From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5CF6C43334 for ; Mon, 6 Jun 2022 23:54:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 68A596B0073; Mon, 6 Jun 2022 19:54:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 63A306B0074; Mon, 6 Jun 2022 19:54:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 501826B0075; Mon, 6 Jun 2022 19:54:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4187B6B0073 for ; Mon, 6 Jun 2022 19:54:12 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 19ECD8014B for ; Mon, 6 Jun 2022 23:54:12 +0000 (UTC) X-FDA: 79549467144.07.71483AB Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf02.hostedemail.com (Postfix) with ESMTP id 9C98280083 for ; Mon, 6 Jun 2022 23:54:04 +0000 (UTC) Received: by mail-pl1-f170.google.com with SMTP id o17so13402057pla.6 for ; Mon, 06 Jun 2022 16:54:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ouxhGugAA2tPJJPRF6OdUkV7XlxQLQlKTv4/wM/LekM=; b=AuQjwOtWn2+Rc03YG3etwzRzTH0CCbgNuv1xffg1Ld3FuL2dEgQgZkkWZN3nyBckkO LwT7Mu0qaQtrcFSwm6Esqg61dowMN/js5n/+If9Dw6hKt17dD4jUnegsk0stShUZ3zqg sh83mYauL8nTLDdBNLxnfNFHmSyCiEWRGfuB28w+j7nboNCmd2O3BjNH+o7Ga07B0s/x DN/83o4TDVl7xcfORtA5ArMvzFQme95f213YIZ3/PEswsLo0Tig6ZPrF5blEbJSk4h8V svJPkhppQV77IGNQvaHZ442rvkm4djydBHBnoNz07xmJ/XXNYzpD42M8yF/3EuZswxnC KFDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ouxhGugAA2tPJJPRF6OdUkV7XlxQLQlKTv4/wM/LekM=; b=yVO1kyryM8aKsDtjyWuzX4R+MfeR0ePnMcLHWxyRB2Ur4f7YPaFXx/pMAFU/tIoiu4 gg0AHsmyNkFQ/Dah+qAeAURqN06DHc6pUVSvlEuWGhkFxxNpRYpmRkqr56Yrr7Axb3zF QuNRq6KmHknWLg4LuG3cPWeRoR1uVxAD/9d30GzohjCqfuNoeTNSZEWB2X7/RF/BhLpc do09FBAXkcFhIJVb1KfLKSNQe7TkpmPkSTtPU3igRPV3Piiyv14kmPayqooK+IyTgLjb rwitTqelc8q6bdSTDybJvfJa0a55o+SXCCm24uzEJHgva5oNhammotZfg7ooa0VcTiu9 Xcpg== X-Gm-Message-State: AOAM532kndEHrY//G/BQI98x6vTsUB4MwErI0xonnwpUTYyFZnf7qwi7 W5/qHxeHwr+B+DbBzcHIAQlqHIUTqAlS9ESMXF0= X-Google-Smtp-Source: ABdhPJz5CS/O12V84rWnyFvRDsQ+mtVXxRXfPfy5eSLBnSvb0sLnKOIPSbKbRFnkAHqKRVfa4evwiiyTbSe8JoB7xjg= X-Received: by 2002:a17:902:c40a:b0:163:d38e:3049 with SMTP id k10-20020a170902c40a00b00163d38e3049mr26344066plk.87.1654559650641; Mon, 06 Jun 2022 16:54:10 -0700 (PDT) MIME-Version: 1.0 References: <20220604004004.954674-4-zokeefe@google.com> <202206060911.I8rRqGwC-lkp@intel.com> <20220606152333.6f06f2e23a1161e444fa0f8d@linux-foundation.org> In-Reply-To: <20220606152333.6f06f2e23a1161e444fa0f8d@linux-foundation.org> From: Yang Shi Date: Mon, 6 Jun 2022 16:53:58 -0700 Message-ID: Subject: Re: [PATCH v6 03/15] mm/khugepaged: add struct collapse_control To: Andrew Morton Cc: "Zach O'Keefe" , kernel test robot , Alex Shi , David Hildenbrand , David Rientjes , Matthew Wilcox , Michal Hocko , Pasha Tatashin , Peter Xu , Rongwei Wang , SeongJae Park , Song Liu , Vlastimil Babka , Zi Yan , Linux MM , kbuild-all@lists.01.org, Andrea Arcangeli , Arnd Bergmann , Axel Rasmussen , Chris Kennelly , Chris Zankel , Helge Deller , Hugh Dickins , Ivan Kokshaysky , "James E.J. Bottomley" , Jens Axboe , "Kirill A. Shutemov" , Matt Turner , Max Filippov , Miaohe Lin Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 9C98280083 X-Stat-Signature: r9dams4qkgwxepy5qftt3uqis7k8s4ke X-Rspam-User: Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=AuQjwOtW; spf=pass (imf02.hostedemail.com: domain of shy828301@gmail.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1654559644-232748 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 6, 2022 at 3:23 PM Andrew Morton wrote: > > On Mon, 6 Jun 2022 09:40:20 -0700 "Zach O'Keefe" wrote: > > > On Sun, Jun 5, 2022 at 7:42 PM kernel test robot wrote: > > > > > > Hi Zach, > > > > > > Thank you for the patch! Perhaps something to improve: > > > > > > [auto build test WARNING on akpm-mm/mm-everything] > > > > > > url: https://github.com/intel-lab-lkp/linux/commits/Zach-O-Keefe/mm-userspace-hugepage-collapse/20220606-012953 > > > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > > > config: x86_64-rhel-8.3 (https://download.01.org/0day-ci/archive/20220606/202206060911.I8rRqGwC-lkp@intel.com/config) > > > compiler: gcc-11 (Debian 11.3.0-1) 11.3.0 > > > reproduce (this is a W=1 build): > > > # https://github.com/intel-lab-lkp/linux/commit/d87b6065d6050b89930cca0814921aca7c269286 > > > git remote add linux-review https://github.com/intel-lab-lkp/linux > > > git fetch --no-tags linux-review Zach-O-Keefe/mm-userspace-hugepage-collapse/20220606-012953 > > > git checkout d87b6065d6050b89930cca0814921aca7c269286 > > > # save the config file > > > mkdir build_dir && cp config build_dir/.config > > > make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash > > > > > > If you fix the issue, kindly add following tag where applicable > > > Reported-by: kernel test robot > > > > > > All warnings (new ones prefixed by >>): > > > > > > mm/khugepaged.c: In function 'khugepaged': > > > >> mm/khugepaged.c:2284:1: warning: the frame size of 4160 bytes is larger than 2048 bytes [-Wframe-larger-than=] > > > 2284 | } > > > | ^ > > > > Thanks lkp@intel.com. > > > > This is due to config with: > > > > CONFIG_FRAME_WARN=2048 > > CONFIG_NODES_SHIFT=10 > > > > Where struct collapse_control has a member int > > node_load[MAX_NUMNODES], and we stack allocate one. > > > > Is this a configuration that needs to be supported? 1024 nodes seems > > like a lot and I'm not sure if these configs are randomly generated or > > are reminiscent of real systems. > > Adding 4k to the stack isn't a good thing to do. It's trivial to > kmalloc the thing, so why not do that? Thanks, Andrew. Yeah, I just suggested that too. > > I'll await some reviewer input (hopefully positive ;)) before merging > this series.