From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35BCDC433DB for ; Wed, 10 Feb 2021 01:52:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 99B8E64E45 for ; Wed, 10 Feb 2021 01:52:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99B8E64E45 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id ED4016B0006; Tue, 9 Feb 2021 20:52:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E5D416B006C; Tue, 9 Feb 2021 20:52:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D24C96B006E; Tue, 9 Feb 2021 20:52:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0249.hostedemail.com [216.40.44.249]) by kanga.kvack.org (Postfix) with ESMTP id B8B4A6B0006 for ; Tue, 9 Feb 2021 20:52:36 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 87382184E4E52 for ; Wed, 10 Feb 2021 01:52:36 +0000 (UTC) X-FDA: 77800683912.02.juice14_110d92d2760c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id 6E5D810097AA1 for ; Wed, 10 Feb 2021 01:52:36 +0000 (UTC) X-HE-Tag: juice14_110d92d2760c X-Filterd-Recvd-Size: 4385 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Wed, 10 Feb 2021 01:52:35 +0000 (UTC) Received: by mail-ej1-f45.google.com with SMTP id jj19so1143234ejc.4 for ; Tue, 09 Feb 2021 17:52:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5Y0hH4puqhVgD9YBJOu4kwdN95fkrF9cI64f+jI4TuI=; b=ZhFfu6fsO73uBpsqktPX6WQp9JLruC/kjVGMUNjZ8/k/51ZGMy2VIHKXk7uEyfVnxh IkH89bJZKTEieB09hSxu2LTNv3b02z/fxV9AglkncOF4uiySmKGOSGN+rRzNI5boce+Z Ll5ao3/eMEI6GI9IE+nofQM9UHtQYAdkvuQo1T0ECcFcqw15cE+f7a6uRAB6utNW0utA dbk/dKsEgxvLbMCMZYEUy8g33tFKXhWCmQ2fvzMVz5cupS7+Ca46ikTXy8IAgXsNcWof xL8BpE4uZdLZ7cvm9r92W6Aa+yBtjkJxuTCj1zLbMl41T/cgcVP9M/82j7PwmbeLkr4v El9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5Y0hH4puqhVgD9YBJOu4kwdN95fkrF9cI64f+jI4TuI=; b=XZ6A81C097meBBsiTApq/YM9HeJJ9HpgA5tomqB6dZE4xO+mGiqFgwlWTjYkUXcEMY FjPUH5m3pFcgbnnWRkmDXqAM3NGCB13+C0C+56J3RjkVlN6fh6MkjEycGbvGJETYvvlj PQWlNP+2Lmi6/gkjVgpn1kyh94szD6hKbnLjM7cW5TRW6MhAFb5ZijQjgc/dIEDCmNSn GGbrDuZp7PDw8n/9i5A0N4x+zcOixgVB32x2qENYU1E6iFrfAnYF6TqdlU1FSuk4/Uk4 98GFMhGW1WVzDd1f6u+cGR2mSX0WXEGbYuTUfQfJ2mCWK/avgH6yeqgKfUER2YSlRCsR 1lQQ== X-Gm-Message-State: AOAM531xIxIirxYJOiG1QH0SbZDsuV4dHp4kSnywRcVF5o0IbVzMmR6n Ybubo4Lx71g2XiCQ2EESVqdLeSdURtmi4vJff8A= X-Google-Smtp-Source: ABdhPJzcLiBGc4YPhx9MdE321/TkRLGewWu8NTRYQyAc3lHaeqGjJf9dolDyIG4S39SrILg3xEX8gRuGkNc7Fwq5H9k= X-Received: by 2002:a17:906:eca5:: with SMTP id qh5mr556226ejb.161.1612921955003; Tue, 09 Feb 2021 17:52:35 -0800 (PST) MIME-Version: 1.0 References: <20210209174646.1310591-1-shy828301@gmail.com> <20210209174646.1310591-10-shy828301@gmail.com> <20210210012726.GO524633@carbon.DHCP.thefacebook.com> In-Reply-To: <20210210012726.GO524633@carbon.DHCP.thefacebook.com> From: Yang Shi Date: Tue, 9 Feb 2021 17:52:23 -0800 Message-ID: Subject: Re: [v7 PATCH 09/12] mm: vmscan: use per memcg nr_deferred of shrinker To: Roman Gushchin Cc: Kirill Tkhai , Vlastimil Babka , Shakeel Butt , Dave Chinner , Johannes Weiner , Michal Hocko , Andrew Morton , Linux MM , Linux FS-devel Mailing List , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 9, 2021 at 5:27 PM Roman Gushchin wrote: > > On Tue, Feb 09, 2021 at 09:46:43AM -0800, Yang Shi wrote: > > Use per memcg's nr_deferred for memcg aware shrinkers. The shrinker's nr_deferred > > will be used in the following cases: > > 1. Non memcg aware shrinkers > > 2. !CONFIG_MEMCG > > 3. memcg is disabled by boot parameter > > > > Signed-off-by: Yang Shi > > --- > > mm/vmscan.c | 78 ++++++++++++++++++++++++++++++++++++++++++++--------- > > 1 file changed, 66 insertions(+), 12 deletions(-) > > > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > index d4b030a0b2a9..748aa6e90f83 100644 > > --- a/mm/vmscan.c > > +++ b/mm/vmscan.c > > @@ -368,6 +368,24 @@ static void unregister_memcg_shrinker(struct shrinker *shrinker) > > up_write(&shrinker_rwsem); > > } > > > > +static long count_nr_deferred_memcg(int nid, struct shrinker *shrinker, > > + struct mem_cgroup *memcg) > > "Count" is not associated with xchg() semantics in my head, but I don't know > what's the better version. Maybe steal or pop? It is used to retrieve the nr_deferred value. I don't think "steal" or "pop" helps understand. Actually "count" is borrowed from count_objects() method of shrinker. > > Otherwise the patch looks good to me. > > Thanks!