From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01C1EC433EF for ; Tue, 12 Jul 2022 17:03:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8FA669400B2; Tue, 12 Jul 2022 13:03:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 882DD940063; Tue, 12 Jul 2022 13:03:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7241A9400B2; Tue, 12 Jul 2022 13:03:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5D01C940063 for ; Tue, 12 Jul 2022 13:03:07 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 30DC460E97 for ; Tue, 12 Jul 2022 17:03:07 +0000 (UTC) X-FDA: 79679068014.12.2EBBFB3 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) by imf19.hostedemail.com (Postfix) with ESMTP id B1BA81A006F for ; Tue, 12 Jul 2022 17:03:06 +0000 (UTC) Received: by mail-pg1-f170.google.com with SMTP id e132so8131715pgc.5 for ; Tue, 12 Jul 2022 10:03:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eu38gMEhlCLDFy6KkUeAsbrjDX67p3SRtgMNjLCMflQ=; b=PJWVB/myr/wcbSmiFH8IWsfipFzM8q+DgJJNf26SDblPjf6i9tww20D44Tp6Auxtnx Wxa6nEPNfng7lVd8cDSG6W/PhUm8WQaqFYbaYWR6PIZESnkjssgadKSq+fZ5BuCBdmtg seE4e6SvrxqHxjhNM0oxPclJRv/tj0B0vlrqAEIds1/uYTkvhiVmSK6LPHjidJutHdWP wAgxpdcI2jB/Ke0eJaxrFHTtivzpZXDmErwobM60POTYTewnlbboJRklJN9zzjGz7zu7 qDwrzxZJbWIoIE/ugSYzPA4eBK61H5Pvuv+YomAy9xNCI8s4GDXU56PmUBOp2jHGugHV IIKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eu38gMEhlCLDFy6KkUeAsbrjDX67p3SRtgMNjLCMflQ=; b=bUMYY2NJZmTZY+gXf76022Rkz6n2/RzZw2HPge4a5kFENNRD17/yPeeJKdBWs0Rndx HHQKQJqHSUyv9zyT8QW8Jtgn1KPwZ1If55yH20bvqct9snZArWfnzb6LD/oPS9HaVwU5 OuOjqVzqHn4htNAlGKh1myDeAJEdps39AjrOrIIemyCoNffeWKmG3fDgFi3BEe0uNrRJ LqmbmkoxHUn0ec8fLlgspg5kPaHLF47UFe5QUZz3Sair/QFJZ+ZosDkZQz7MEENsXlNV afaoMutMVzCxT4F1Q5ca9F8o4JJgbnnGwI9inX6UQq2VZfGg+WUUWYulDtL7V9xvoX0x urog== X-Gm-Message-State: AJIora+PSm5GHJibkfd4Ug4jNe3sdBoclRJTKd5YfEyCQvOH/LZbdMju pPdVMl/17YRApwv7mfqUyc6MxBX3HCi8iWccAcQ= X-Google-Smtp-Source: AGRyM1txobi65oZyr08oYxAWdMJVeMiBiU9GqjYAztqFQDwa+JZ/PqOXEduhDypqtoEZMIz2uoSPlX7LP+O35+uezEw= X-Received: by 2002:a63:9142:0:b0:412:b171:b6ac with SMTP id l63-20020a639142000000b00412b171b6acmr21029214pge.206.1657645385595; Tue, 12 Jul 2022 10:03:05 -0700 (PDT) MIME-Version: 1.0 References: <202207100715.TBIYQ4fc-lkp@intel.com> In-Reply-To: <202207100715.TBIYQ4fc-lkp@intel.com> From: Yang Shi Date: Tue, 12 Jul 2022 10:02:53 -0700 Message-ID: Subject: Re: [akpm-mm:mm-unstable 284/293] mm/khugepaged.c:2409 madvise_collapse() warn: possible memory leak of 'cc' To: Dan Carpenter Cc: kbuild@lists.01.org, "Zach O'Keefe" , kernel test robot , kbuild-all@lists.01.org, Linux Kernel Mailing List , Andrew Morton , Linux Memory Management List Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="PJWVB/my"; spf=pass (imf19.hostedemail.com: domain of shy828301@gmail.com designates 209.85.215.170 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657645386; a=rsa-sha256; cv=none; b=v/0TqV69xhee5XnqtE2vFKrVR1+11doZV65Pm/+zFcBGo9WFAStTWUVbRTlUZFuQnftLem 9phWeLKMgBfMPEJ5CBwPZw0jQEZS34XXvFRy6QYy0OYonwJNJbmFSBVJNXAGsHGgoTnPyK 53HyZ0i+c5H3qibe6t2rtQL6R5IanqA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657645386; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eu38gMEhlCLDFy6KkUeAsbrjDX67p3SRtgMNjLCMflQ=; b=5zHVnXTOITOA6u7g8zFpoSfuqb2KIVd6/lrPgisT8vJ0deaU1gWp0OKt1s11vnsIEH0LFn UkATgabH6CGS2N/V/XDSCFuzkC1IkxVboPnj1ZGhlFC+Hg7LomuYqSQOmmbPnb5/Z/pJ0i VEmAj/oCd27Ftu0Sxvjdw4vDjGT0GTM= Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="PJWVB/my"; spf=pass (imf19.hostedemail.com: domain of shy828301@gmail.com designates 209.85.215.170 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam09 X-Stat-Signature: nwjf1iphmmk1pkqtg1r3cw6rz73xoxe1 X-Rspamd-Queue-Id: B1BA81A006F X-HE-Tag: 1657645386-74701 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 12, 2022 at 5:36 AM Dan Carpenter wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-unstable > head: 0e9f775fb0b4adf1a4ef50ea156ead09a0fc5194 > commit: 9f626ffb1d1c5c26b4a8e0fdffec784a5f773274 [284/293] mm/madvise: introduce MADV_COLLAPSE sync hugepage collapse > config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20220710/202207100715.TBIYQ4fc-lkp@intel.com/config) > compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 > > If you fix the issue, kindly add following tag where applicable > Reported-by: kernel test robot > Reported-by: Dan Carpenter > > smatch warnings: > mm/khugepaged.c:2409 madvise_collapse() warn: possible memory leak of 'cc' > > vim +/cc +2409 mm/khugepaged.c > > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2387 int madvise_collapse(struct vm_area_struct *vma, struct vm_area_struct **prev, > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2388 unsigned long start, unsigned long end) > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2389 { > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2390 struct collapse_control *cc; > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2391 struct mm_struct *mm = vma->vm_mm; > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2392 unsigned long hstart, hend, addr; > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2393 int thps = 0, last_fail = SCAN_FAIL; > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2394 bool mmap_locked = true; > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2395 > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2396 BUG_ON(vma->vm_start > start); > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2397 BUG_ON(vma->vm_end < end); > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2398 > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2399 cc = kmalloc(sizeof(*cc), GFP_KERNEL); > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2400 if (!cc) > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2401 return -ENOMEM; > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2402 cc->is_khugepaged = false; > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2403 cc->last_target_node = NUMA_NO_NODE; > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2404 > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2405 *prev = vma; > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2406 > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2407 /* TODO: Support file/shmem */ > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2408 if (!vma->anon_vma || !vma_is_anonymous(vma)) > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 @2409 return -EINVAL; It seems better to move the cc kmalloc after the anonymous vma check? > > kfree(cc);? > > > -- > 0-DAY CI Kernel Test Service > https://01.org/lkp > >