From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49527C433EF for ; Tue, 12 Oct 2021 17:56:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C5EFF6109E for ; Tue, 12 Oct 2021 17:56:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C5EFF6109E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 153BC940007; Tue, 12 Oct 2021 13:56:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 102D5900002; Tue, 12 Oct 2021 13:56:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F3388940007; Tue, 12 Oct 2021 13:55:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0132.hostedemail.com [216.40.44.132]) by kanga.kvack.org (Postfix) with ESMTP id E4AB7900002 for ; Tue, 12 Oct 2021 13:55:59 -0400 (EDT) Received: from smtpin32.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id A493D18337A18 for ; Tue, 12 Oct 2021 17:55:59 +0000 (UTC) X-FDA: 78688538838.32.41A9D56 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf09.hostedemail.com (Postfix) with ESMTP id 4752F3000100 for ; Tue, 12 Oct 2021 17:55:59 +0000 (UTC) Received: by mail-ed1-f46.google.com with SMTP id i20so2495904edj.10 for ; Tue, 12 Oct 2021 10:55:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=soBzo+qbALf37mSRAz8nmH9lQXp3XIT1ObUNt0qkGj0=; b=hsP4DmTGF3eAqU7bNHruL62nilE9S5zruKtdwfxzdWmwWMd7RaETqY+rY/mKRbl9Da V5a2yUMkbEhqaAdQ13ZyHgnAdrbgLpmT/UpVE7o/RyJa+9MVNOWebEbFUwzBHqsYorNt ChT4f396/OBMkZ5LC6mLfN16v+J9kwqiJZIt9nLufEPwgxZREUELX4snhCLondSFFMWU pPWLC490tDJI2PaA93aPEOywPaSkAE+YTPIzD/qUhMYRi+E8foUVMDwlMv5Ik9Aoi4k8 eFYcM/g7spIA1jjjX0TlJo1FgwytwfB9kH9IDmPuT1Ogu7SZQA3QVjsH3OenNlhAF77i Z0Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=soBzo+qbALf37mSRAz8nmH9lQXp3XIT1ObUNt0qkGj0=; b=yJLmITbhyUjy3gy1WeJbgUeut+ola0QtUH4wpOo9dmeKVikXkxTzaJawEiJ4h9fD1P rnbzjWh5hg0h9o3Gnq92+q8tbvGrAyscz46bJtBaUc3O43Q2H9sLz3BA6FcK15PdP8j8 4idnJXCHJM9vfwe39u2zESYGtgtGpLbtxfcUyNY+3eTd4Px/OSPRUFq8zOclZ9XLRs/u 8QtgKIzbB06wSjhrl4wEy/3pFnLOLFlOhwiFEOzFBo1pOezgqQDmZ3mQHktXJmg1PdVO 3kSoyC29KaKOvVdlncW9ihsKWm9vZgGq4NFmsAtk3wlKflE0q4tyN4fGwaImYgepZlH4 KkeA== X-Gm-Message-State: AOAM531RjJNYJ8xElh709zB+YxBWm1Of7oDhFljxV2b87siDVbDkgz9K 7ZC121yzGSI5Ufp3prTL/yIBj5kd4cd8pFg1eq8= X-Google-Smtp-Source: ABdhPJzqqdCdy3PLxYA0+ffbkkFCnRh9E8V3xG+QVrjXZWe+XLIXJAGAO4KXVstkq4dDF3UcdIuQh2Ozoim+W/SLiXE= X-Received: by 2002:a17:906:c7d0:: with SMTP id dc16mr34668619ejb.555.1634061357851; Tue, 12 Oct 2021 10:55:57 -0700 (PDT) MIME-Version: 1.0 References: <000000000000c6a82505ce284e4c@google.com> In-Reply-To: <000000000000c6a82505ce284e4c@google.com> From: Yang Shi Date: Tue, 12 Oct 2021 10:55:45 -0700 Message-ID: Subject: Re: [syzbot] BUG: sleeping function called from invalid context in copy_huge_page To: syzbot , Hugh Dickins , Matthew Wilcox Cc: Andrew Morton , Linux Kernel Mailing List , Linux MM , syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=hsP4DmTG; spf=pass (imf09.hostedemail.com: domain of shy828301@gmail.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 4752F3000100 X-Stat-Signature: xbao8y6bpesp75nmj1e86pnpprbo5stb X-HE-Tag: 1634061359-174712 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 12, 2021 at 7:03 AM syzbot wrote: > > Hello, > > syzbot found the following issue on: > > HEAD commit: 1da38549dd64 Merge tag 'nfsd-5.15-3' of git://git.kernel.o.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=14379148b00000 > kernel config: https://syzkaller.appspot.com/x/.config?x=76f7496a8217e5ec > dashboard link: https://syzkaller.appspot.com/bug?extid=aae069be1de40fb11825 > compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 > > Unfortunately, I don't have any reproducer for this issue yet. > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > Reported-by: syzbot+aae069be1de40fb11825@syzkaller.appspotmail.com > > BUG: sleeping function called from invalid context at mm/util.c:758 > in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 30700, name: syz-executor.2 > 2 locks held by syz-executor.2/30700: > #0: ffff88806ee498a8 (&mm->mmap_lock#2){++++}-{3:3}, at: mmap_write_lock include/linux/mmap_lock.h:71 [inline] > #0: ffff88806ee498a8 (&mm->mmap_lock#2){++++}-{3:3}, at: do_mbind+0x25d/0xeb0 mm/mempolicy.c:1314 > #1: ffff888145989e18 (&mapping->private_lock){+.+.}-{2:2}, at: spin_lock include/linux/spinlock.h:363 [inline] > #1: ffff888145989e18 (&mapping->private_lock){+.+.}-{2:2}, at: __buffer_migrate_page+0x3af/0xca0 mm/migrate.c:723 > Preemption disabled at: > [<0000000000000000>] 0x0 > CPU: 1 PID: 30700 Comm: syz-executor.2 Not tainted 5.15.0-rc4-syzkaller #0 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 > Call Trace: > __dump_stack lib/dump_stack.c:88 [inline] > dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106 > ___might_sleep.cold+0x1f3/0x239 kernel/sched/core.c:9538 > copy_huge_page+0x126/0x360 mm/util.c:758 > migrate_page_copy+0xfc/0x340 mm/migrate.c:619 > __buffer_migrate_page+0x8cb/0xca0 mm/migrate.c:758 It seems like this one has the similar root cause with https://lore.kernel.org/lkml/CACkBjsYwLYLRmX8GpsDpMthagWOjWWrNxqY6ZLNQVr6yx+f5vA@mail.gmail.com/. The THP is collapsed for page cache from raw block device. Then the THP got migrated by calling buffer_migrate_page_norefs() in this BUG report, which takes mapping->private_lock and is used by raw block device. So skipping the non-regular file in khugepaged (https://lore.kernel.org/linux-mm/a07564a3-b2fc-9ffe-3ace-3f276075ea5c@google.com/) seems like a proper fix. > move_to_new_page+0x339/0xef0 mm/migrate.c:905 > __unmap_and_move mm/migrate.c:1070 [inline] > unmap_and_move mm/migrate.c:1211 [inline] > migrate_pages+0xfc5/0x39e0 mm/migrate.c:1488 > do_mbind+0xbc7/0xeb0 mm/mempolicy.c:1340 > kernel_mbind mm/mempolicy.c:1483 [inline] > __do_sys_mbind mm/mempolicy.c:1490 [inline] > __se_sys_mbind mm/mempolicy.c:1486 [inline] > __x64_sys_mbind+0x233/0x2b0 mm/mempolicy.c:1486 > do_syscall_x64 arch/x86/entry/common.c:50 [inline] > do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 > entry_SYSCALL_64_after_hwframe+0x44/0xae > RIP: 0033:0x7f408623f8d9 > Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48 > RSP: 002b:00007f40837b6188 EFLAGS: 00000246 ORIG_RAX: 00000000000000ed > RAX: ffffffffffffffda RBX: 00007f4086343f60 RCX: 00007f408623f8d9 > RDX: 0000000000000000 RSI: 0000000000c00000 RDI: 0000000020012000 > RBP: 00007f4086299cb4 R08: 0000000000000000 R09: 0000010000000002 > R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 > R13: 00007fff13d3589f R14: 00007f40837b6300 R15: 0000000000022000 > > > --- > This report is generated by a bot. It may contain errors. > See https://goo.gl/tpsmEJ for more information about syzbot. > syzbot engineers can be reached at syzkaller@googlegroups.com. > > syzbot will keep track of this issue. See: > https://goo.gl/tpsmEJ#status for how to communicate with syzbot. >