From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 888D7C77B76 for ; Mon, 24 Apr 2023 21:17:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B6846B0072; Mon, 24 Apr 2023 17:17:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 164C66B0074; Mon, 24 Apr 2023 17:17:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07B726B0075; Mon, 24 Apr 2023 17:17:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EE0FB6B0072 for ; Mon, 24 Apr 2023 17:17:26 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8C296A0366 for ; Mon, 24 Apr 2023 21:17:26 +0000 (UTC) X-FDA: 80717545692.19.4493D7E Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by imf10.hostedemail.com (Postfix) with ESMTP id AF6EFC0014 for ; Mon, 24 Apr 2023 21:17:24 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=h8yqfVmn; spf=pass (imf10.hostedemail.com: domain of shy828301@gmail.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682371044; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1IQmgFRWemEvXJC88T/rDku0y6B5K+c+6E1l1xk0hYI=; b=6jgAHyDBb1U9bdiME87vqskgRcbV+tc2EoQPZdIIRcSq8TWCv3Xp+uNBpMjWPSvgcFvICY 85IfxcCF104J/19rTLMNziAZQ3FV7CfHGbLBtvWXGMRnHw91ncwdPoZkJLvNI2upfppiYp sJ7I7IDxg3eFIFzbuc45PHLe7q+2QQI= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=h8yqfVmn; spf=pass (imf10.hostedemail.com: domain of shy828301@gmail.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682371044; a=rsa-sha256; cv=none; b=cBzDCe9Abm5+qLU4JoCYSvnqEePYeKFGaaH4ATixCbHP/smn4G+aC/MMBgOmjGbvmns6Me SNyz8ctaGFbHwldeHkZ0yH8Bjp01PXye2nlDeGT81yoqjCg7dXvzBi/RCyoZ4x9sE4CLkR y8K7LDIb4NdKrO6xedtD4W/sOoBwAZ4= Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-63b73203e0aso31025536b3a.1 for ; Mon, 24 Apr 2023 14:17:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682371043; x=1684963043; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1IQmgFRWemEvXJC88T/rDku0y6B5K+c+6E1l1xk0hYI=; b=h8yqfVmnsIsaOgvfBMfP0TfIF8rf0Dt0iGWSoJ5hqw0IM/Nes78I2QLmPVreVrQ00b iXv+uSHM4guXlcbktd8ejSXbIVhL27z1tOKY2+jiI5kLCvr/LzFEASO+VDDR9oM8lvjm 3pO3gfXvWCUMYtyOIG0SCXiNIv8mfz22kBS9z3bcOUZetecWnhB/UaCtYzVU5izrOOLf RTGTpDLEvq7OdOMY+HkCejVxtRZF3XnVnMadlmZ0YgpcykE4a/negmZAHhTWyDcrfYdv 9vEykl+NyaYGSpXYpuFV0FH5y5U628FesWSTx3IFrbKl4FfE2z5TNwU6SYMoRl5kqGIx /2XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682371043; x=1684963043; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1IQmgFRWemEvXJC88T/rDku0y6B5K+c+6E1l1xk0hYI=; b=iYLv++Ye4l6tIIa5S3bCO/MElb2F7eA2K2TVTTI9SXiUHfqeHQIc9HaddCo6j7doYm iipcEwe+93YEeIfANs4Bk6ytX0QXORPQFjnVi0cVDs1xlZIw+78Y0RdhVM+qfrdRVsu2 Pixf8HKhSPVSknTc9vPOXHlA6cSypneX6vz00MZ5nNZtsnmnxdq37duu+npC0y4BxxWl GfddAGCOeOIRYSzPEnQeYlF+Z8+TTXqTJSb76RsHvp839y/UCljeHlPxP3EUqZSKCpr1 cCAyOh0BJycAbY1NfQHDeyynab8/UsFsR9miKqtyfhQGGZdCb8tfxdcANT2a9MwcfprZ xpPw== X-Gm-Message-State: AAQBX9eDElgO23F0/5RblQ2wJtJsgterQZKRh7XXvpsKxPF38rBo8hsj HBNv4WMmEEAmmGyhih6fNJBhBrYVhxsipAf2pxg= X-Google-Smtp-Source: AKy350YdosoMK29+Sw0J+vSpOOdKm+Y6k32RQnY43Hcu+sK/jdkLswUFO7t02Rwt6i53F7WTakMbOvGEF6qngQP/Gdc= X-Received: by 2002:a17:90b:1106:b0:247:5c00:10 with SMTP id gi6-20020a17090b110600b002475c000010mr21067746pjb.2.1682371043441; Mon, 24 Apr 2023 14:17:23 -0700 (PDT) MIME-Version: 1.0 References: <20230421214400.2836131-1-mcgrof@kernel.org> <20230421214400.2836131-3-mcgrof@kernel.org> In-Reply-To: From: Yang Shi Date: Mon, 24 Apr 2023 14:17:12 -0700 Message-ID: Subject: Re: [RFC 2/8] shmem: convert to use folio_test_hwpoison() To: Luis Chamberlain Cc: Matthew Wilcox , hughd@google.com, akpm@linux-foundation.org, brauner@kernel.org, djwong@kernel.org, p.raghav@samsung.com, da.gomez@samsung.com, a.manzanares@samsung.com, dave@stgolabs.net, yosryahmed@google.com, keescook@chromium.org, hare@suse.de, kbusch@kernel.org, patches@lists.linux.dev, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: AF6EFC0014 X-Stat-Signature: ozp35ab4x5ptrp1hw89p935smxffx9d9 X-HE-Tag: 1682371044-508450 X-HE-Meta: U2FsdGVkX18QR/IzmlX11ZBFrNn9IrOpyyFfJrcqydkSBaIJA/1LFNYd5/y2TflXZwr5er5aYhlp9uXk4G+qIhRznqtCzbGtETtjsqWYBZls6mk076vLTJAB4xi5bURHdopk60eyZQExtpWNRMiDkOYksQSDwMgHE5oceDsPcnDkusIfl3V8G+gmyg50WFh/Ta76Eb3BGVysAVIl5tTRA6dJlJmXhQV97io3EaFYECCopf4+ozvi1/1DzmnCQ3zTmSP2cxiD8wxD3usMznRhbGQeQmTm/mJN2hvG537QlAgnrRQW6wA0WVTuCPAMHMSUby4ig1xf6gHRxQaFa1KfRTepCCnRFuFOYyOvT7DrW/c3CWizjKmM02uGbzIwvGpnQJPYrjo7yE6ZqY44GxdVPPTr0wnxBi/uAYOjO65escSUStCd5Na/bhJGXcXYKyrFzRLX/2AevT7mfOrvyfAmwoXU0cl3jD9GD11o4UdZ9KwQGbXSvB1G61WH8l8s71J2hSsdXaaG0t1ZTY410NkP9MwrBH9hEliVgQBHSuTr0hIUSXrzqk3CLMRThaCPwPn7IfegOuJcvP1LYGXH1Oc+hwriUKyD7p7kwuWSw4rTkhtoDzIGxlhH8ZTqitLuIt8iuho1lR2EsFp/+Ate/alEouLZm4NUbYtYO0hhmppzL0QVc7q2epq6fszEH7+2RBHH+F69S1unQPUpkQe2Rn+50kCuD7YRhcXCmZSlQrqECCwdVi+d79zxzh6veaSXLvtMDDmtTFgP9QzCye0ka2yTfDc/vM7brH38ewaF/I7+/TcNBXhXiquzBgUB8YmdS/++6B4Fgj8Dq2GTSuzVgCkUWd/gIB9LeIlhHTYds0PWmyzgCYEF0eumxd0ejzqDnlMt/Zs4nEwPCGB0Ns5z2V/bXrjnj9g66VN030q83g2uA+T+TacVSEtiEGPFGoqMBrSDs/DgpU8Q6fk8jqRGyKv Ahg484QH zw+P6UGBVYDBTHVXuaWaq59B7FG/gk17roqqiD0aiOeczkJA8R5bG3htAiuxeG7IkIef2AuhAl31dT34GLdlTU/+h4Inc74ee5nEB0m7Go9XLhn6S46DiSmYJv4up1IF+9LbTUfBJlR90kV/r1lo1vU6oZxU/jYGA2l5N35DJSUh6tfimdVmzlvmr+7RugQDCtrlwjablgl+dZzCMV7GhJZXrekx7bkNAk7tc0e8RzHCbbrA/lsELVEKP04xH9yB18Goy8ns8XGyaWkcmFd1mG+02mIYoNdRIA7JxQY3i3uV6Tf0Vz+fCmgDH1THFnVX0VBpc1KaRC1CGx/WontmzgTENh8PC7lO+2o4CX3lShXhEG3kHttObBLcJdk6BNrkJsuQqY4hse6pxCe8BWB5HwkA0l1VeF0KZOssrGOc7PlVTpqwyIrsIzMtb4T3JTet7CaOhNlY9xfZsmrXvDLs2ZNg9fw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000032, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 21, 2023 at 8:05=E2=80=AFPM Luis Chamberlain wrote: > > On Fri, Apr 21, 2023 at 11:42:53PM +0100, Matthew Wilcox wrote: > > On Fri, Apr 21, 2023 at 02:43:54PM -0700, Luis Chamberlain wrote: > > > The PageHWPoison() call can be converted over to the respective folio= call > > > folio_test_hwpoison(). This introduces no functional changes. > > > > Um, no. Nobody should use folio_test_hwpoison(), it's a nonsense. > > > > Individual pages are hwpoisoned. You're only testing the head page > > if you use folio_test_hwpoison(). There's folio_has_hwpoisoned() to > > test if _any_ page in the folio is poisoned. But blindly converting > > PageHWPoison to folio_test_hwpoison() is wrong. > > Thanks! I don't see folio_has_hwpoisoned() though. We do have PageHasHWPoisoned(), which indicates at least one subpage is hwpoisoned in the huge page. You may need to add a folio variant. > > Luis >