From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D24AC4338F for ; Mon, 16 Aug 2021 20:24:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B3D7B60F35 for ; Mon, 16 Aug 2021 20:24:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B3D7B60F35 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 31A7F6B0088; Mon, 16 Aug 2021 16:24:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A3066B0089; Mon, 16 Aug 2021 16:24:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 16C016B008A; Mon, 16 Aug 2021 16:24:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0179.hostedemail.com [216.40.44.179]) by kanga.kvack.org (Postfix) with ESMTP id EDFD36B0088 for ; Mon, 16 Aug 2021 16:24:39 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id A0EC3824999B for ; Mon, 16 Aug 2021 20:24:39 +0000 (UTC) X-FDA: 78482071878.26.61D1F94 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by imf25.hostedemail.com (Postfix) with ESMTP id 63E5DB000E27 for ; Mon, 16 Aug 2021 20:24:39 +0000 (UTC) Received: by mail-ej1-f44.google.com with SMTP id hs10so34160776ejc.0 for ; Mon, 16 Aug 2021 13:24:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sXYkpEIBbTRqbu2ccbqpOzzUrzgOM/KwayJpCu9iw+g=; b=u6tt21vd6EagJz//PQCD+JbTYKIj7NXVCZZBbObmv2vKKL2DShAV/l4PfBDA93tYcW MD4eWUBKGzxXgFu1eyOlI0phqRckANQiXkkATyAdwoDDH4FY66Exjd9JFbW0v0Jpsnqq 3B1pLf28Tf6qEZtTPMW6IEYwY3AufFSZB5bOrbnDTOp9rXKohthGMYyuDnwQ+GOqmWaH LaqxFbXui4ulJeSWKUAY2dVBQcW4cP7Qmy2jJf4NsQmt/t8kt59nXjCr86d/7L1mqwTQ XsQYSFl2t9cxqnGfdIgCoAkryLV8e/SQw3pvz3/KbIf24lfsjA0pkX4SXyoycrcIDRDr TXlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sXYkpEIBbTRqbu2ccbqpOzzUrzgOM/KwayJpCu9iw+g=; b=C+l/OXSQecPrILa5/RWujzOHFYNoA+RBHrDQIDEhOiew2qZXhXe8NBJq/On6nlfXng Iv4MEobmFsfktGpUNFFxdJjST/18xm1T83/Uv8brYwSmvmk79FvaJfccpWud0FZMOynq sRP+ViMf1wH42Ud6iDCKqlCK3sSxpF7We30cb35fdDe5tMhjxB/IaPq/FXV2xFqursWm yyWnCE/bJ9HwbJazW8mBtRJQD1ll3n7GKWscToKsxiEu4jJudxL0j5z69Tvq07sDU5Lh kbUOwpYrxAIVMHMnBIpDCUo9v0+tyXimLPe9UVFRUy+3TfD/PfYgBh2dfEzhxc7ENwle PJEQ== X-Gm-Message-State: AOAM530oWDOugkp0iiq/od5qv/mlOPJH0Svoe2e4+C+ouNVytOk7X894 hi+mKzxKJ6vGsWToclRPQhQH3+KOWxPYNGw6Voo= X-Google-Smtp-Source: ABdhPJwL4La/Jm+xPr1GT3nSytXa50mjZQ4RhVC7yFc/HZ4dpvqezib3/5Cxzoc2qewwsk/sbs4LQ1+4eSv89GuBV40= X-Received: by 2002:a17:906:ae51:: with SMTP id lf17mr245428ejb.161.1629145478108; Mon, 16 Aug 2021 13:24:38 -0700 (PDT) MIME-Version: 1.0 References: <20210816180909.3603-1-shy828301@gmail.com> In-Reply-To: From: Yang Shi Date: Mon, 16 Aug 2021 13:24:25 -0700 Message-ID: Subject: Re: [PATCH 1/2] mm: hwpoison: don't drop slab caches for offlining non-LRU page To: Matthew Wilcox Cc: =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= , Oscar Salvador , tdmackey@twitter.com, Andrew Morton , Jonathan Corbet , Linux MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 63E5DB000E27 Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=u6tt21vd; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of shy828301@gmail.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=shy828301@gmail.com X-Rspamd-Server: rspam04 X-Stat-Signature: 6pabmodwz1c3kwik77ef88q7aqs4s7dr X-HE-Tag: 1629145479-878007 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 16, 2021 at 12:38 PM Matthew Wilcox wrote: > > On Mon, Aug 16, 2021 at 11:09:08AM -0700, Yang Shi wrote: > > But the most disappointing thing is all the effort doesn't make the page > > offline, it just returns: > > > > soft_offline: 0x1469f2: unknown non LRU page type 5ffff0000000000 () > > It's a shame it doesn't call dump_page(). There might be more > interesting information somewhere in struct page that would help us > figure out what kind of page it was in your environment. For example, > it might be a page table page or a page allocated for vmalloc(), and > in both those cases, there are things we might be able to do (we'd > certainly be able to figure out that it isn't worth shrinking slab!) Yes, dump_page() could provide more information to us. I could add a new patch or just update this patch to call dump_page() if offline is failed if the hwpoison maintainer agrees to this as well.