From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85685C27C4F for ; Wed, 26 Jun 2024 23:43:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A09716B0082; Wed, 26 Jun 2024 19:43:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 991DE6B0083; Wed, 26 Jun 2024 19:43:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80BFD6B0085; Wed, 26 Jun 2024 19:43:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5F59C6B0082 for ; Wed, 26 Jun 2024 19:43:19 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 93B431217E6 for ; Wed, 26 Jun 2024 23:43:18 +0000 (UTC) X-FDA: 82274668476.10.4DCF36C Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by imf13.hostedemail.com (Postfix) with ESMTP id BD07F20018 for ; Wed, 26 Jun 2024 23:43:16 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bzpHgDni; spf=pass (imf13.hostedemail.com: domain of shy828301@gmail.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719445388; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CrLP38uOvZfrbnJR7lsc4EL5zjKiJ8Snmz7L5lGjvE4=; b=nmq+VYBDPhF7B2hfV0jwW5xaKJJ+s9EZSj9nuZ2SgfI3v+VCRigHjK6pSLLuadLU0ERtbS uc2SvBaCTJDjllIp6qxk3JUydS5lvIQ78Xgf/66UW6Hc4hIdGB3BWIovHtftLbC8xUbXc1 pnQd3pn5e/W9DCbyrCm0YoIR2rHWOqE= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bzpHgDni; spf=pass (imf13.hostedemail.com: domain of shy828301@gmail.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719445388; a=rsa-sha256; cv=none; b=Rfpz6GXIo/4R0ORoSKu03bk8f/49ijdvlVX644FWjBCIQei3g4BPksBwv0/p8GjAFvII8L 1gFDiJ4EjwR1ipZy99i84E8IC9uo2i5MqGYzsi45CuNzSgEsqQsROQHdpyOx4UNMVKBk/P C+Mg6tuimLONfnqbOm211I9tjxfu7wE= Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-57d1679ee83so1008814a12.2 for ; Wed, 26 Jun 2024 16:43:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719445395; x=1720050195; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=CrLP38uOvZfrbnJR7lsc4EL5zjKiJ8Snmz7L5lGjvE4=; b=bzpHgDnipR7bfWE3PCFIqksAZaMiW7PETDniZqA/lNvG5LOuYFe30tUZBIxaP6Cnj/ IhLEgwzwhnKWWm8rSblDNNxNc/M3qTNW5dx4i6t/RcrX3aquvMQysGVZdOH2kOanC0AU S/bw6Sxoa4qbNOw3SpQTkURStdfvvIkLVuOMlMbJVM05J29p+ccB45TWGiAunqBUPVkM jJF5m+0V0I49knSAk5OmftysjKKT7OC75wQrT8zbYAgCpVU2xjEtxZ6PEo9IymyEsSsE tZ4A0GbyKlWn+4UgIxu6pa/o+MdjdQ2Hzj0wcSq41pjFZk5va0SXbymiCPWOVheFYe5c LTGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719445395; x=1720050195; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CrLP38uOvZfrbnJR7lsc4EL5zjKiJ8Snmz7L5lGjvE4=; b=TA3O3OgcC/Pz0GlCiy8zk8SR70kGZLlsrw7/umboME7z3FZTPxn6NL+MGMJLIWueNK TRVYlEnkUMGiK+iHrNqP6LxZnAiDZI71NwEfjTzNPd6L6XF0QgReu0pcV9zjW1nsZ3q/ SGWG3X89mH63IDCiYKUoPzsB4fOSCA6OLAZD8fhrHCscZ45GqEXqZvpZVj3EJTE4qB+M LsXPmTs3KQxnedXqZGrHcybka6tdkRctIp+AYhsOzOPnsOfjOk4NbyEtE7sTe4n+c9fL UW+R5rZ3Zn3yDcRJ1n8CUiwmTWuyFkYf7f6OdrbR37fisG7R2lRnaczvv5WAnA+V9OfS ZpBw== X-Forwarded-Encrypted: i=1; AJvYcCXKCOwKogVpTeqsaJ1/CT6OZ7rBmoaST5FlrZJP9/C+EzCeuUZDEmmNFTYgp2koccLSMMAFoDSgmYVAJdGdInhTUw8= X-Gm-Message-State: AOJu0YyAw1CJP0K5yq5MiTUQHrLtg1IqvYzDNUEKpW839RVdQVVdAgiE GxubK8DosjK32g0xBamzA5E/1Qh/qUqTqh8Owt1Svbzlj9FNN4YvCoaV2rt1aQhlkX6P//pBuqd xsO7ZleeIFS+gSG2Aj74U8ekiMTk= X-Google-Smtp-Source: AGHT+IEoO7WqInlry20Zl6ArEMNympSdQMtbH9/JkZYyI2m2W8eeey8fYyMjHy8AqYzrWxdunxJmmGE96/pwffNA/Jc= X-Received: by 2002:a50:ab5c:0:b0:57d:12c3:eca6 with SMTP id 4fb4d7f45d1cf-57d457943bcmr8363110a12.18.1719445394886; Wed, 26 Jun 2024 16:43:14 -0700 (PDT) MIME-Version: 1.0 References: <20240625233717.2769975-1-yang@os.amperecomputing.com> <20240626134040.63fe621bff6a5fe1c0503999@linux-foundation.org> In-Reply-To: From: Yang Shi Date: Wed, 26 Jun 2024 16:43:02 -0700 Message-ID: Subject: Re: [PATCH] hugetlbfs: add MTE support To: Andrew Morton Cc: Yang Shi , muchun.song@linux.dev, catalin.marinas@arm.com, will@kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: BD07F20018 X-Stat-Signature: 94m5atimgyagefbhubzgnsjqnb6dmpzg X-Rspam-User: X-HE-Tag: 1719445396-139370 X-HE-Meta: U2FsdGVkX18CQQSg5HFgfqdsVC055t+4sknLbWAfWAaP3K05Y7rOSI2kyjWXUvWF3Dcqo9oAxboRrVwmeiyQDmtBtpHK/mOSPNMROFXhCwBc5mh2F9eDFYy/LpYG6aZTRBLZ7fzFS5XWs4n+jsb5nc66z8yBZy1MAQBrxV8Ynk60y/nNwxhjxm3FFi+GHGXWea2EhN9UTUnECI3bgguxc5so5Y7pCB9zncWfMu7UZWzbgfuutJaQOL67mn+e+PosqqDiwRbyhZe7+tNi0jjcqjzAexW82RpBraPemKwbCjWg+Bh2aiJGok6ek3A2vAg8IAd26KgnwagnLLv14tf7XTtBza/IkzQbRm5S78fyLdhSWQ/Ek2aQpolaoBUdusoI+ZvznpVwBvZSqywSM4xtLruw2MVS7ugY35ZOm2kbiCS2eMRMQ1pij+kVJqiLI0u6X7X5/bXfN9+o1IFu1MlZdIavwQtZWgz23BzCuGqCuBIx2Vp05oryS0dEoI8mAXBcLJ2uSWhZNa04t0J4sdMniGAWDmjcAY11HnX765+/9kZKkrBLRAvSoefYwbjQ7HwKVcCenWTbMjanFwG0D9dFR4DfRfYfkEptWIN62KHB/UjGnr42VTF3YqThjdRMpj2BTzTdt7chWv+d9vRr1oL9KAUqwqS4NBEhYjsAjVJYNT2VmLJ2c087Snlg9rq10l7S/No26yQmLKSh5fwtjUirZTEj32G2ajlxinIeCQnqK4+ghS6m5+r2EPYgDOIFQPyxj2lFAJdddalvBe1lZchaGK8WSLYuDzaEDzmOss2otfP1c/8koUpuxZYcDvuhposzwKPUVikXoLyU8230aTq6wGXnEtfC4+MmUObwLrZFJRDj+e+Kl22duHKQK3XKRKf76qV4+CuH7JaLJUednxnHOYja6L7+TiBGrwEIcBK67lUdZXcAzfydHIUerfFj6NxT9HRMI7FS+ayuFiFY4k8 QetKlMlm y4KBwgeMZJKK8r9XRHSl6r3y4PK1tPFmXutmxrXSUdJbbkO3g/v96RXgFMNM98aBDf4nmpYoJK0jGUc+IkNWKFQIUVmtMSWEWNRP20/lxrYj0qeL+6UzGU29SMVdF12YA3/l6Sx/l9AbgLm0VGiP4j6sSIA8bf4fQfjrPZQnVq6kj2WmNhzDOFCj6JGqDr20AT8mnP9VhS4c6kaO/XHl7y+auik8oALrVKanMIHv87ia0w03JGYou84WCZ5vrGA7Rp99Hm2yevnGj4vGg46hoZ/ZHL8qwRqhLYZSt7uSm2P5cnN8lz1WU0HdgbyAjw5Eo/IfODPO2bOl62bZ/M0ve6ZjBRky2RF4NDR4MPu64biWtlwrCd+R8EamJxxFqcKHEAgW2M25QezLdKg+FxI3Ii6WGp15FfIKQiJ+sUs28XxRQLvM5A7sBPuIXrw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 26, 2024 at 1:45=E2=80=AFPM Yang Shi wrot= e: > > On Wed, Jun 26, 2024 at 1:40=E2=80=AFPM Andrew Morton wrote: > > > > On Tue, 25 Jun 2024 16:37:17 -0700 Yang Shi wrote: > > > > > MTE can be supported on ram based filesystem. It is supported on tmpf= s. > > > There is use case to use MTE on hugetlbfs as well, adding MTE support= . > > > > > > --- a/fs/hugetlbfs/inode.c > > > +++ b/fs/hugetlbfs/inode.c > > > @@ -110,7 +110,7 @@ static int hugetlbfs_file_mmap(struct file *file,= struct vm_area_struct *vma) > > > * way when do_mmap unwinds (may be important on powerpc > > > * and ia64). > > > */ > > > - vm_flags_set(vma, VM_HUGETLB | VM_DONTEXPAND); > > > + vm_flags_set(vma, VM_HUGETLB | VM_DONTEXPAND | VM_MTE_ALLOWED); > > > vma->vm_ops =3D &hugetlb_vm_ops; > > > > > > ret =3D seal_check_write(info->seals, vma); > > > > How thoroughly has this been tested? > > > > Can we expect normal linux-next testing to exercise this, or must > > testers make special arangements to get the coverage? > > It requires special arrangements. This needs hardware support and > custom-patched QEMU. We did in-house test on AmpereOne platform with > patched QEMU 8.1. To correct, custom-patched QEMU is not required for a minimum test. But a special test program is definitely needed. We used custom-patched QEMU to test VM backed by hugetlbfs with MTE enabled. > > >