From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F528ECAA25 for ; Thu, 25 Aug 2022 18:40:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 075F76B0074; Thu, 25 Aug 2022 14:40:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 024BE6B0075; Thu, 25 Aug 2022 14:40:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2F7A940007; Thu, 25 Aug 2022 14:40:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D2C236B0074 for ; Thu, 25 Aug 2022 14:40:25 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A5CFB160464 for ; Thu, 25 Aug 2022 18:40:25 +0000 (UTC) X-FDA: 79838980410.09.A4B77E2 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by imf27.hostedemail.com (Postfix) with ESMTP id 6216440013 for ; Thu, 25 Aug 2022 18:40:25 +0000 (UTC) Received: by mail-pg1-f169.google.com with SMTP id w13so13548460pgq.7 for ; Thu, 25 Aug 2022 11:40:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc; bh=duXyvjXe4AkIou7dUw5MCWJNp7VHWvIL2t2RC7bb1Cc=; b=iyXK2r58khFK0vwS2Iv02e4ACHkv8ZLY6YG5ZFVdu9Ja9/q/nsXGYXBuysDw4QNEKA NmSuRO0rzXM7YdyI+uSrXLWtVjEggU0kUzx0F7gM7INomwSQ7Hxu3BJWA+9qS/i7czjf 5w5lWMEdokIzn865gUtFDkWYF8OjWQTnYlAeD4gXTUatwdvzi0V24SGNisgFFMDM/Yuo 98+nazowYyntRVSPiCKHArE70rrSOdeAVuhY+DD0l7eMivBZoi+DmybKypSeEIbmiFLP FVivJOV+guSxcyY6hHRc2zAfK2kXJIh1XQ8vCU60Rz/Hxf+TmEPGYXbOBDeRCd9ajFFS LXZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc; bh=duXyvjXe4AkIou7dUw5MCWJNp7VHWvIL2t2RC7bb1Cc=; b=Vh5AvYQUeJtbIBDw9AJWXwIbFXH/eg400cuBr9bn4ycvhUCCmqBsncaRmzbmaGVUvm E61/gByDWo3DAl4N3n/szF9g83ZjcKOnSm3YOl5Y8OmLhdEVZ44hyVw6AgEK6juSDTKQ aNW9WlBMvhBGT+iQ5SHaYKmCbPRPZf7MePuoM988XYxHULc55QmQ2EfvQm/95SdwqiEj bSBlqRG//QRU9WlbMVOlL2AfmmwYwFV4eoTwnnNgre+GqmgC8jcV3kJs7/pE450UjukQ wdR53NZdhfAqL//goAyATfgWtP8UXsyCH9DE5dWeYoWdhjMMWd8zjm/g8YJKFwEOj/Aa tbUA== X-Gm-Message-State: ACgBeo1RDFK/X7HEjgvQIyCJLcCVcadwpZXgjKrhcV80VSiQPUs9/+Az h+e+5lEW6h9zyiQjJP2ixlHZ6SC0tWdw+iT7zPo= X-Google-Smtp-Source: AA6agR6Mx6R7a5A6rU8M2X+JEIFTTLGcM/orAjWf6VO+/vLOKvXS8h2GUmvDiHKRbz/ye0S0uXBXfZBdUbncx+EtdBg= X-Received: by 2002:a63:1604:0:b0:41b:c410:3395 with SMTP id w4-20020a631604000000b0041bc4103395mr343090pgl.75.1661452824383; Thu, 25 Aug 2022 11:40:24 -0700 (PDT) MIME-Version: 1.0 References: <485f8c33.2471b.182d5726afb.Coremail.hantianshuo@iie.ac.cn> In-Reply-To: From: Yang Shi Date: Thu, 25 Aug 2022 11:40:11 -0700 Message-ID: Subject: Re: (resend)WARNING: trying to isolate tail page in isolate_lru_page To: Matthew Wilcox Cc: Yu Zhao , Minchan Kim , Andrew Morton , Linux-MM , =?UTF-8?B?6Z+p5aSp56GV?= , mawupeng Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661452825; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=duXyvjXe4AkIou7dUw5MCWJNp7VHWvIL2t2RC7bb1Cc=; b=gK4+3wH9w1Dr8P/WRxZnpzBYtcqja70z1KXXSnpTiHcYpW9z6bZi9TrlQorMeuqn9k+vdG nECm+b0mSpiAxQD0boU9e2R9OLpSQx1to6dAYMvxFI43cPfHuntpKwCKqa4xtrFD9PfJU5 /Hx2Ck+QtrnHatisq8th25dYRlmcfHc= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=iyXK2r58; spf=pass (imf27.hostedemail.com: domain of shy828301@gmail.com designates 209.85.215.169 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661452825; a=rsa-sha256; cv=none; b=mUOGbe0UPCJJF9OygBXl+bpU5q2NWtLLvmVLyWyqsVYj8CkEuKbhUYjfvd321oVl8bIbyj /NOWVS2YBTWyUrEnJoJKLqhf6nm9lTN5anIGRHs4llCg1qkE37B/RbnqBanwf4Kq5Et1Wl /tu3HK2FhKn3uVYwlcllWkDVQCjRtc0= Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=iyXK2r58; spf=pass (imf27.hostedemail.com: domain of shy828301@gmail.com designates 209.85.215.169 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Stat-Signature: 1wo9b61tju43pqxrxm85eqhs8of9hxiz X-Rspamd-Queue-Id: 6216440013 X-Rspamd-Server: rspam03 X-HE-Tag: 1661452825-562947 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 25, 2022 at 11:23 AM Matthew Wilcox wrote= : > > On Thu, Aug 25, 2022 at 10:50:19AM -0600, Yu Zhao wrote: > > On Thu, Aug 25, 2022 at 8:40 AM =E9=9F=A9=E5=A4=A9=E7=A1=95 wrote: > > > > > > Hello: > > > > > > My Syzkaller reported me the following issue on: > > > > > > > > > HEAD commit: 072e51356cd5a4a1c12c1020bc054c99b98333df Merge tag 'nfs-= for-5.20-2' of git://git.linux-nfs.org/projects/trondmy/linux-nfs > > > > > > git tree: upstream > > > > > > kernel config: defconfig > > > > > > compiler: gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0 > > > > > > > > > ------------[ cut here ]------------ > > > trying to isolate tail page > > > WARNING: CPU: 0 PID: 6175 at mm/folio-compat.c:158 isolate_lru_page+0= x130/0x140 > > > Modules linked in: > > > CPU: 0 PID: 6175 Comm: syz-executor.0 Not tainted 5.18.12 #1 > > > Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.13.0-1u= buntu1.1 04/01/2014 > > > RIP: 0010:isolate_lru_page+0x130/0x140 > > > Code: c3 89 c6 e8 22 4f f2 ff 85 db 75 0d e8 a9 4d f2 ff 44 89 e0 5b = 5d 41 5c c3 e8 9c 4d f2 ff 48 c7 c7 a0 be 6a 93 e8 a9 f5 69 01 <0f> 0b eb d= e 66 66 2e 0f 1f 84 00 00 00 00 00 90 41 54 55 48 89 fd > > > loop3: detected capacity change from 0 to 16383 > > > RSP: 0018:ffff88800844f8b8 EFLAGS: 00010282 > > > RAX: 0000000000000000 RBX: 0000000000000001 RCX: 0000000000000000 > > > RDX: ffffc90000509000 RSI: ffff8880037997c0 RDI: ffffed1001089f09 > > > RBP: ffffea000010b040 R08: ffffffff8117b3f8 R09: 0000000000000000 > > > R10: 0000000000000005 R11: ffffed100d2c4ead R12: 00000000fffffff0 > > > R13: ffff88800185aff0 R14: ffffea000010b048 R15: 0000000021000000 > > > FS: 00007f8acbd46700(0000) GS:ffff888069600000(0000) knlGS:000000000= 0000000 > > > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > > CR2: 0000001b2c821000 CR3: 0000000005028005 CR4: 0000000000770ef0 > > > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > > > nfs4: Unknown parameter 'vfat' > > > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > > > PKRU: 55555554 > > > Call Trace: > > > > > > madvise_cold_or_pageout_pte_range+0x43b/0x8f0 > > > __walk_page_range+0xa48/0x1310 > > > walk_page_range+0x14b/0x280 > > > madvise_pageout+0x184/0x260 > > > madvise_vma_behavior+0x843/0x13f0 > > > do_madvise+0x310/0x5b0 > > > __x64_sys_madvise+0x5f/0x70 > > > do_syscall_64+0x38/0x90 > > > entry_SYSCALL_64_after_hwframe+0x44/0xae > > > RIP: 0033:0x7f8acc5d38bd > > > Code: 02 b8 ff ff ff ff c3 66 0f 1f 44 00 00 f3 0f 1e fa 48 89 f8 48 = 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f= 0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 > > > RSP: 002b:00007f8acbd45bf8 EFLAGS: 00000246 ORIG_RAX: 000000000000001= c > > > RAX: ffffffffffffffda RBX: 00007f8acc6f2f60 RCX: 00007f8acc5d38bd > > > RDX: 0000000000000015 RSI: 0000000000004000 RDI: 0000000020ffc000 > > > RBP: 00007f8acc6400a9 R08: 0000000000000000 R09: 0000000000000000 > > > R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 > > > R13: 00007ffec656fb0f R14: 00007ffec656fcb0 R15: 00007f8acbd45d80 > > > > > > > The above is from 5.18. Another report from 5.10: > > https://lore.kernel.org/r/d927a335-a70b-48d3-9645-1d33cc88bd9c@huawei.c= om/ > > > > We also hit it on 5.4, 5.10 and 5.15: > > trying to isolate tail page > > WARNING: CPU: 1 PID: 4608 at mm/vmscan.c:2096 > > isolate_lru_page+0xb4/0x527 mm/vmscan.c:2096 > > Modules linked in: > > Looks like my analysis from yesterday was dropped: > > : This all seems quite plausible. The reproducer seems to (correct me > : if I'm wrong) create an AF_PACKET socket and mmap it. af_packet.c > : seems to create compound pages and mmap them. This isn't folio-related > : at all; I just moved the code that warns about it from mm/vmscan.c to > : folio-compat.c. > : > : Looks like a long-standing bug in MADV_PAGEOUT to me. Such page should never be on lru, right? We could test lru before calling isolate_lru_page() for this case? I know isolate_lru_page() does the check, but the tail page warning is raised before the check. Could the tail page warning be moved under the lru flag test? Seems possible, but it should need extra handling (re-set lru flag). Seems a little bit overkilling. > >