From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FEAFC433F5 for ; Thu, 7 Oct 2021 02:50:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CA32361175 for ; Thu, 7 Oct 2021 02:50:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CA32361175 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 3A2E76B006C; Wed, 6 Oct 2021 22:50:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 32B12900002; Wed, 6 Oct 2021 22:50:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A3C56B0073; Wed, 6 Oct 2021 22:50:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0192.hostedemail.com [216.40.44.192]) by kanga.kvack.org (Postfix) with ESMTP id 07A476B006C for ; Wed, 6 Oct 2021 22:50:05 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id BEB1C1837CD8E for ; Thu, 7 Oct 2021 02:50:04 +0000 (UTC) X-FDA: 78668111928.38.8E1C820 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf14.hostedemail.com (Postfix) with ESMTP id 743D76003971 for ; Thu, 7 Oct 2021 02:50:04 +0000 (UTC) Received: by mail-ed1-f46.google.com with SMTP id l7so17468064edq.3 for ; Wed, 06 Oct 2021 19:50:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=C3IDDYZFaUFLO/w9rYUwlHxNDVqOHTPNwMNOfkBaNKU=; b=prKH8LCl8QEsGEgecOpvC/Q38loRFsRmCFbzq7zkpKsydHQxRZKatmqH6Acjuk20K5 p3TEM19UvZdW4HzzgJkJykXQB0374MrlZA/NnOp43kE8iy0tn+uDx5d3OqfBWY9yw9LR y1LeQihcSgnzSBP0u+Mr/mRHHIR9gpUzgTjKTVFGkQe7t5KG2Coxbz9MMK6SXaHLZzbH Ar90CVLBZ/jWF3kb0Wll5fiT6aFEAw8W4rd0TeWtXmJ4MMcBlXDDw0+A+bZe4k6JGu6h fqwzq4Lq4jSzijNdX4eGftHD8cSLUBHTicvCX5NXKyfs89/DJE4CVzrwsAXscb/zwKgE BOcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=C3IDDYZFaUFLO/w9rYUwlHxNDVqOHTPNwMNOfkBaNKU=; b=yXUfpVYHO+VDRTFEil3DyZyTsxWSG/H/ZMQsT95HBuEu9retNc2Cf55xy2gvNPuk2l raBFy5+A8sF21NobgdrN1cjKM81iE+6KjKjcM9M+vfkzb69OPiRKsIaawywUL5cV7UKW hUuUxInzIhmHK0s3YUTJD00ljVRAwUA4iBfNG+Z2hT8mN2ieTTMDssL8keydB2rGJpYx yKXAisagDFIxu8l+BmKwdrFS/l/TyCaXHedufbzWgets9+ttbSCSMzPOzn0GWWdAOF2r WhAQaizJ4eVv2ynLwb9/DjwLbnmcSpiiLWv7vpCk/zYe39baEKR2nP6aOKdp5qVh5eYw 7zmA== X-Gm-Message-State: AOAM5310VBlRHPajIlDTL2/65Mu/239J06e76izen92VGaMASZT/FhOj hd+/8Nj4d9yJQUrZ+Vonas64V2BkI0hGfK+5IFE= X-Google-Smtp-Source: ABdhPJzYUn+UTefsCrkM5ibhhX/EsK1QfZ6WToWZbVncVman2b38jSdBgYdkgUMBnBIPrTwIQvL2lqYQqSwyvZwidzU= X-Received: by 2002:a05:6402:16d2:: with SMTP id r18mr2568038edx.363.1633575003380; Wed, 06 Oct 2021 19:50:03 -0700 (PDT) MIME-Version: 1.0 References: <20210930215311.240774-1-shy828301@gmail.com> <20210930215311.240774-3-shy828301@gmail.com> In-Reply-To: From: Yang Shi Date: Wed, 6 Oct 2021 19:49:51 -0700 Message-ID: Subject: Re: [v3 PATCH 2/5] mm: filemap: check if THP has hwpoisoned subpage for PMD page fault To: Peter Xu Cc: =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= , Hugh Dickins , "Kirill A. Shutemov" , Matthew Wilcox , Oscar Salvador , Andrew Morton , Linux MM , Linux FS-devel Mailing List , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=prKH8LCl; spf=pass (imf14.hostedemail.com: domain of shy828301@gmail.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 743D76003971 X-Stat-Signature: txbm8mqxfpo7ywqb8pgozqywqzhfe5wt X-HE-Tag: 1633575004-296196 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 6, 2021 at 1:18 PM Peter Xu wrote: > > On Thu, Sep 30, 2021 at 02:53:08PM -0700, Yang Shi wrote: > > +#ifdef CONFIG_MEMORY_FAILURE > > + /* Compound pages. Stored in first tail page's flags */ > > + PG_has_hwpoisoned = PG_mappedtodisk, > > +#endif > > Sorry one more comment I missed: would PG_hwpoisoned_subpage better? It's just > that "has_hwpoison" can be directly read as "this page has been hwpoisoned", > which sounds too close to PG_hwpoisoned. No strong opinion either. Thanks, TBH, I don't see too much difference IMHO. Someone may interpret it to "this" subpage is hwpoisoned rather than at least one subpage of THP is hwpoisoned. > > -- > Peter Xu >