From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60788C433F5 for ; Wed, 13 Oct 2021 03:29:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0D1A560551 for ; Wed, 13 Oct 2021 03:29:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0D1A560551 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 7ACED900002; Tue, 12 Oct 2021 23:29:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 75CF26B0071; Tue, 12 Oct 2021 23:29:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 64BA4900002; Tue, 12 Oct 2021 23:29:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0162.hostedemail.com [216.40.44.162]) by kanga.kvack.org (Postfix) with ESMTP id 56AEE6B006C for ; Tue, 12 Oct 2021 23:29:14 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 1B28E30C67 for ; Wed, 13 Oct 2021 03:29:14 +0000 (UTC) X-FDA: 78689983428.09.D682229 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by imf25.hostedemail.com (Postfix) with ESMTP id 20552B000180 for ; Wed, 13 Oct 2021 03:29:12 +0000 (UTC) Received: by mail-ed1-f42.google.com with SMTP id i20so4071919edj.10 for ; Tue, 12 Oct 2021 20:29:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QQNzKhmWO0HGdKOXS89qG3A9ZaAzZaeuitB9xg0P9Ao=; b=f6qT0uRPXcqOGtMmEVof+51Xl5cKE7prSFUJeMauW7N+C6L3sOqFGwT1ekFZJhEd70 vPMywWIudQiUiWUNOVO+yNZVwEQlW4GoGW4O+vqMQTrALs/WY3S45JSTlVEdKOIB/VYQ h40sKy7usu9bba4pLDqe2E6E8CHUZpCu1h1hoUbny22Z/B3p5EugiLiZ4+Fi2zeb8nz1 HeeDLamf+P9B/350ATB4/JzLBEWcB6+ET8QxSQ+GQCe2DhIvyeD9vHUfxgdDxMnZ8abz HDfsV+HjTFt9WhpqUOe8LvuF+ez5Qj3fuVOw8eiKpL1xPAApMg9h4zWETOa6NNRUY9V4 jFVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QQNzKhmWO0HGdKOXS89qG3A9ZaAzZaeuitB9xg0P9Ao=; b=0mSTHwDVaTSJ9DDlrnfHS6NUrlJIGeM0iqmHqampavmZRSsd2Vbkb0cHgN03tTLr4U LQgsj3S176/R59EuxQC/MdHjdw+tHgtIB9z44LKDpGik1aN8hbDdTU3j5VqGvoDEowVP DSeup7LysND2loh7IcGjQK/pLVwmeK1VkRUd1rigxh0nowpWhj53/RcMNcYfcIO34Slp Ps9lECKki7gfY6F6waKqUws+h9j3YN53bBp8B9lIAduPugi4rWi+U2/Y4CtpI3mCsI70 vXA0lswOBrIF48fO24Y0C+p1gMNaPUjBL6e1iqJOrdcT9MqxfoVVaQC9iVEXIdem+kEn BsSA== X-Gm-Message-State: AOAM5308E37+TFAj8gz7qMDw4zsvwC6k2ymONz0nHwcEw2KDouZssQAa P+6nRgbMIlN4g2t17YNqI09cePlciJfsaT1dZK8= X-Google-Smtp-Source: ABdhPJxvk0vJYLQJ1vV4YH05l7GLiZPOWUjnKHqMswz4TzPRmLJueLbEJU0nSPkZJevYe2sl2IKfRHRcOVTIpDwYWKo= X-Received: by 2002:a17:907:2bdf:: with SMTP id gv31mr38358350ejc.521.1634095752792; Tue, 12 Oct 2021 20:29:12 -0700 (PDT) MIME-Version: 1.0 References: <20210930215311.240774-1-shy828301@gmail.com> <20210930215311.240774-5-shy828301@gmail.com> In-Reply-To: From: Yang Shi Date: Tue, 12 Oct 2021 20:29:01 -0700 Message-ID: Subject: Re: [v3 PATCH 4/5] mm: shmem: don't truncate page if memory failure happens To: Peter Xu Cc: =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= , Hugh Dickins , "Kirill A. Shutemov" , Matthew Wilcox , Oscar Salvador , Andrew Morton , Linux MM , Linux FS-devel Mailing List , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 20552B000180 X-Stat-Signature: 9ftkdfxyfueskmi8mzuorps766mgi3dp Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=f6qT0uRP; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of shy828301@gmail.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=shy828301@gmail.com X-HE-Tag: 1634095752-650090 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 12, 2021 at 8:07 PM Peter Xu wrote: > > On Tue, Oct 12, 2021 at 08:00:31PM -0700, Yang Shi wrote: > > The page refcount could stop collapsing hwpoison page. One could argue > > khugepaged could bail out earlier by checking hwpoison flag, but it is > > definitely not a must do. So it relies on refcount now. > > I suppose you mean the page_ref_freeze() in collapse_file()? Yeah that seems > to work too. Thanks, Yes, exactly. > > -- > Peter Xu >