From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3A1BC4332F for ; Thu, 20 Oct 2022 18:47:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B2978E0002; Thu, 20 Oct 2022 14:47:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 663078E0001; Thu, 20 Oct 2022 14:47:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 503BB8E0002; Thu, 20 Oct 2022 14:47:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3E9888E0001 for ; Thu, 20 Oct 2022 14:47:56 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D2A421608F5 for ; Thu, 20 Oct 2022 18:47:55 +0000 (UTC) X-FDA: 80042212110.07.F62BEDA Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by imf23.hostedemail.com (Postfix) with ESMTP id 42965140038 for ; Thu, 20 Oct 2022 18:47:55 +0000 (UTC) Received: by mail-pf1-f181.google.com with SMTP id 67so355328pfz.12 for ; Thu, 20 Oct 2022 11:47:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=XES49IrsE/SNg2Wiu5FQcJL1HnVmIEJ2XPODG9d1kGs=; b=TGOPgfy40MWjEd7IhcI1/ZW6PxJ+EOtNf6zzdZbHKPpf+3R7WFtDhCDtLiFdmN9REE D7EiKdWDaucHF/mgXN/rznmUkhCewUtED5WBFM1MYa3eUevu75Fb5U0uigdkyRsb9vKZ fAAAYkbVrEQhWKWPp+6hvS6ttYZZZI9IbrHulloOQxkYnB5uKnfgekkeTsl3oDqKlHpu otcVRlTtkB0slFRegMp1ezvKn6Edzw4/aPc228rKocalKthJOy/MgEFXKw7vj3yZbsJn LS9zdfvUX1Y0DQ+jjQvOrCHAiy5/YfaIJEHZRW/hvApi8kPTZgNC2zQRw/J2A9EXtelD cs8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XES49IrsE/SNg2Wiu5FQcJL1HnVmIEJ2XPODG9d1kGs=; b=tRdlj3dy5t3gEkBfQ4Oc8RdvRcj0AFhakuoOKFSwXHzTg1utc2myI8bJNws5G8ZyhD +JE29xhmDWG5FU+pPfuHFWeDAHIcihz7fptAWiMj1XN074Fdc3F8ptxIcsSquG/D1wIv HTVqXbzEsjLFtA8sO8LA0NPOtAO79b+BLGil76GU++SBRny7CQNyIIrXiRqHjxlKfFj3 byNO22Au0qXygw0fvHyV22LqYz6USHjRpxLX1f54tOQvsy2njXEHo5WA8dF/nooV5w2w YPaf2NH4O1mE8i2/NNilAb3EUCa0tE0RRIMcVNqC5wCsaFVTMEnoD9uv/llxha8YJvZ0 YngQ== X-Gm-Message-State: ACrzQf1nXx1GVdhMEzRhKRHLCZ0mjewnYUtssHIpwiDuHVa4Ewk8kLFf Wrp6D0SgFZfMoyxjCE7E5jXok699q7Bp9EA5zxc= X-Google-Smtp-Source: AMsMyM5ebdgIUi5uCKboyyRksMvDQjr91KEFedSkJbNcScR1hzEnwJL775AUWPR+H9D9E6Ry/4kaqDau0rrS8pOuzsc= X-Received: by 2002:aa7:9dcb:0:b0:565:89a8:c708 with SMTP id g11-20020aa79dcb000000b0056589a8c708mr15595214pfq.4.1666291674290; Thu, 20 Oct 2022 11:47:54 -0700 (PDT) MIME-Version: 1.0 References: <20221020015122.290097-1-ying.huang@intel.com> In-Reply-To: <20221020015122.290097-1-ying.huang@intel.com> From: Yang Shi Date: Thu, 20 Oct 2022 11:47:41 -0700 Message-ID: Subject: Re: [PATCH] memory tier, sysfs: rename attribute "nodes" to "nodelist" To: Huang Ying Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , "Aneesh Kumar K . V" , Alistair Popple , Bharata B Rao , Dan Williams , Dave Hansen , Davidlohr Bueso , Hesham Almatary , Jagdish Gediya , Johannes Weiner , Jonathan Cameron , Michal Hocko , Tim Chen , Wei Xu Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666291675; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XES49IrsE/SNg2Wiu5FQcJL1HnVmIEJ2XPODG9d1kGs=; b=Oqidt7Zdglv8hFB/ge2BUidD/IB64BU/FsIsqeoN1hrIZ7nxEGoKuKBTELE0G6DEn/+j7Q VYW5d6LSzEB6+3lscOoRKAxcX0MhMExoym59xF55Sla9KIfj/PDRlsYgqesYfo/h7iA3Ih COSe/t/XR/RdmXe54L5KjwquJV2rvjU= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=TGOPgfy4; spf=pass (imf23.hostedemail.com: domain of shy828301@gmail.com designates 209.85.210.181 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666291675; a=rsa-sha256; cv=none; b=rKYpkziSPG2LmzWoBek+hveEfIIb5lqqm+HWox6Z6MInnsKB+cWaJ3+tXum+V5LUPxmRtG 3KPogpDqiLaYu7PtrCLTTzyBZUBbdJ5oNXKLAeNQghRqcy5dlNpdWUQm4p9ATrEWZnMHPA xmoghP0iSv/H8c9qvUF7iN6P+t+ppxU= Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=TGOPgfy4; spf=pass (imf23.hostedemail.com: domain of shy828301@gmail.com designates 209.85.210.181 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 42965140038 X-Stat-Signature: ezpfgx5de3qre744uha7d91y4dt5yxxj X-Rspam-User: X-HE-Tag: 1666291675-376885 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 19, 2022 at 6:51 PM Huang Ying wrote: > > In sysfs, we use attribute name "cpumap" or "cpus" for cpu mask and > "cpulist" or "cpus_list" for cpu list. For example, in my system, > > $ cat /sys/devices/system/node/node0/cpumap > f,ffffffff > $ cat /sys/devices/system/cpu/cpu2/topology/core_cpus > 0,00100004 > $ cat cat /sys/devices/system/node/node0/cpulist > 0-35 > $ cat /sys/devices/system/cpu/cpu2/topology/core_cpus_list > 2,20 > > It looks reasonable to use "nodemap" for node mask and "nodelist" for > node list. So, rename the attribute to follow the naming convention. > > Signed-off-by: "Huang, Ying" > Cc: Aneesh Kumar K.V > Cc: Alistair Popple > Cc: Bharata B Rao > Cc: Dan Williams > Cc: Dave Hansen > Cc: Davidlohr Bueso > Cc: Hesham Almatary > Cc: Jagdish Gediya > Cc: Johannes Weiner > Cc: Jonathan Cameron > Cc: Michal Hocko > Cc: Tim Chen > Cc: Wei Xu > Cc: Yang Shi > --- > Documentation/ABI/testing/sysfs-kernel-mm-memory-tiers | 4 ++-- > mm/memory-tiers.c | 8 ++++---- > 2 files changed, 6 insertions(+), 6 deletions(-) Reviewed-by: Yang Shi > > diff --git a/Documentation/ABI/testing/sysfs-kernel-mm-memory-tiers b/Documentation/ABI/testing/sysfs-kernel-mm-memory-tiers > index 45985e411f13..721a05b90109 100644 > --- a/Documentation/ABI/testing/sysfs-kernel-mm-memory-tiers > +++ b/Documentation/ABI/testing/sysfs-kernel-mm-memory-tiers > @@ -10,7 +10,7 @@ Description: A collection of all the memory tiers allocated. > > > What: /sys/devices/virtual/memory_tiering/memory_tierN/ > - /sys/devices/virtual/memory_tiering/memory_tierN/nodes > + /sys/devices/virtual/memory_tiering/memory_tierN/nodelist > Date: August 2022 > Contact: Linux memory management mailing list > Description: Directory with details of a specific memory tier > @@ -21,5 +21,5 @@ Description: Directory with details of a specific memory tier > A smaller value of N implies a higher (faster) memory tier in the > hierarchy. > > - nodes: NUMA nodes that are part of this memory tier. > + nodelist: NUMA nodes that are part of this memory tier. > > diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c > index f116b7b6333e..fa8c9d07f9ce 100644 > --- a/mm/memory-tiers.c > +++ b/mm/memory-tiers.c > @@ -131,8 +131,8 @@ static void memory_tier_device_release(struct device *dev) > kfree(tier); > } > > -static ssize_t nodes_show(struct device *dev, > - struct device_attribute *attr, char *buf) > +static ssize_t nodelist_show(struct device *dev, > + struct device_attribute *attr, char *buf) > { > int ret; > nodemask_t nmask; > @@ -143,10 +143,10 @@ static ssize_t nodes_show(struct device *dev, > mutex_unlock(&memory_tier_lock); > return ret; > } > -static DEVICE_ATTR_RO(nodes); > +static DEVICE_ATTR_RO(nodelist); > > static struct attribute *memtier_dev_attrs[] = { > - &dev_attr_nodes.attr, > + &dev_attr_nodelist.attr, > NULL > }; > > -- > 2.35.1 >