From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1835C433EF for ; Tue, 8 Mar 2022 03:12:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 04AE48D0002; Mon, 7 Mar 2022 22:12:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F3BAD8D0001; Mon, 7 Mar 2022 22:12:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E04A28D0002; Mon, 7 Mar 2022 22:12:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id D23018D0001 for ; Mon, 7 Mar 2022 22:12:13 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id A14D1601A5 for ; Tue, 8 Mar 2022 03:12:13 +0000 (UTC) X-FDA: 79219745346.11.931A5E4 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by imf01.hostedemail.com (Postfix) with ESMTP id 292A640008 for ; Tue, 8 Mar 2022 03:12:13 +0000 (UTC) Received: by mail-pf1-f173.google.com with SMTP id a5so4588736pfv.2 for ; Mon, 07 Mar 2022 19:12:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DSL+CJ30QrNNiMtvQAliZTSjOgz5ibG4HT8HISEqYVw=; b=enIgMCftvwgGBl1IncTfFPpjWznJL5qOknJvHD/wBZJXmsv3Wv4QmwayLtrZ+zuS07 d81C5bvx7boL+GzT394rKVRZ4JEaHLbJvnDpJCRi1lrOvTY5UBe0LAFZuDX515iy2br+ 7jnDJCki9KavViUAUuAyN4LTN2zbEHxS1lwxuM9cKkjVFSPtFdY6Fh0ko3cSag7/KJE5 aYdshI7z68wm3TA1d2GD83NR0wwze00yL+cXLLhB3GwIh20lenTE+f4vyshK6/VFdsef EKsaaVmavyt3YttJlz8NwtEdqK7IkbOlZX31WjYcKET/3HCd9SzJeXUGIFQJvlE3B6dx nisg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DSL+CJ30QrNNiMtvQAliZTSjOgz5ibG4HT8HISEqYVw=; b=J3BsT2we3a8LBy6OItdFBmlY1pWyR9CocA5lWEjQuq8e1g6ClFMzRh14IVWIZ8hZ7b P9r2THOUe6f2NDR4TerjSJZqR0AT9fXh8RKox+CsWBXqlbm9yQH/hoz03b2axoUKS7tN PvWUaWesMAnBKy860vvxO3oYz3iINS2fi1rT8SL7dU4xPuRZlsWPE2pDou5u0BmTfa93 3Jp26GotpODjMERtZ1J5cvLC5D62CErXzZjTm9x3eRBMEhX0siy/arUPcWA+ACDpiKj+ 8vBGoGZBNfzulDJU8Uxg2NKtTMp9iXAp3OgHhdr1c9nSltlwhU3WqbT7SynT3DgyTh60 dqIw== X-Gm-Message-State: AOAM532nz2w1DkVGLi2HSwvBx/jdokK9zOLYF2GOdqpme14Osco/+YTx ngkwBSYmMTptjf5mlxwoU7mGsMVDLt8uXQ2Stms= X-Google-Smtp-Source: ABdhPJwtoNx6F2DnCx+OyV0HaX2RHwYKcgUBJsc6OpAydX/rAAPDRRmjID2wQgJXWbBnsxmS7FYdeoDpJzJYZEhrD1k= X-Received: by 2002:a63:cd49:0:b0:373:5fbb:c790 with SMTP id a9-20020a63cd49000000b003735fbbc790mr12247352pgj.206.1646709132146; Mon, 07 Mar 2022 19:12:12 -0800 (PST) MIME-Version: 1.0 References: <20220303222014.517033-1-shy828301@gmail.com> <13ad4ba1-2a88-9459-3995-70af36aba33e@redhat.com> <20220306180718.6d4e6233130b94fdad98df88@linux-foundation.org> <84a6c9c1-d18f-6955-2666-0a2d7bce6094@redhat.com> <20220307154326.6494f7fca7def491a23e5df1@linux-foundation.org> <20220307165015.77fbcbe9e1fa2fe15f3eb239@linux-foundation.org> <8f419d19-c83d-bbcd-8936-2d64ced7464c@google.com> In-Reply-To: <8f419d19-c83d-bbcd-8936-2d64ced7464c@google.com> From: Yang Shi Date: Mon, 7 Mar 2022 19:12:00 -0800 Message-ID: Subject: Re: [PATCH] mm: thp: don't have to lock page anymore when splitting PMD To: Hugh Dickins Cc: Andrew Morton , David Hildenbrand , Andrea Arcangeli , "Kirill A. Shutemov" , Linux Kernel Mailing List , Linux MM , Matthew Wilcox , Naresh Kamboju Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 292A640008 X-Rspam-User: Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=enIgMCft; spf=pass (imf01.hostedemail.com: domain of shy828301@gmail.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: 9ipathorrjm8jedajftaijgyftrduo6s X-HE-Tag: 1646709133-987570 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 7, 2022 at 6:36 PM Hugh Dickins wrote: > > On Mon, 7 Mar 2022, Andrew Morton wrote: > > > > OK, looks sane. Can someone please test all this? > > Only the briefest of testing, but > > mmotm 2022-03-06-20-33 > minus mm-thp-dont-have-to-lock-page-anymore-when-splitting-pmd.patch > plus mm-huge_memory-remove-stale-locking-logic-from-__split_huge_pmd.patch > plus mm-huge_memory-remove-stale-locking-logic-from-__split_huge_pmd-fix.patch > > is infinitely better than mmotm 2022-03-06-20-33. > > I could just about reach a login on yesterday's mmotm, but graphics no. > Couldn't spend time to investigate, but Naresh's mail today that LTP > thp04 timeouted (hey, I'm English, we say timed out!) inspired me to > try booting with transparent_hugepage=never on cmdline, and that worked. I think it was because of mm-thp-dont-have-to-lock-page-anymore-when-splitting-pmd.patch. It was buggy (missed pmd_trans_huge(*pmd) check) and was dropped by Andrew. > > Again, no time to investigate, but the combination above has booted > and is running load, including transparent hugepages. And before > setting that load going, I did try LTP thp04, which passed. > > (There is an unrelated console printk lockdep spew, and am I the only > one to see these mm/workingset.c:567 shadow_lru_isolate warnings that > started up a week or three ago?) > > Must dash, > Hugh