From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5F31CE7AAE for ; Fri, 6 Sep 2024 03:35:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5CB106B0088; Thu, 5 Sep 2024 23:35:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 57A936B008A; Thu, 5 Sep 2024 23:35:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 41AF36B008C; Thu, 5 Sep 2024 23:35:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 243656B0088 for ; Thu, 5 Sep 2024 23:35:31 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 52CE680E2E for ; Fri, 6 Sep 2024 03:35:30 +0000 (UTC) X-FDA: 82532898420.17.484C91E Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by imf18.hostedemail.com (Postfix) with ESMTP id 8AAF21C0008 for ; Fri, 6 Sep 2024 03:35:27 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="GcpjICc/"; spf=pass (imf18.hostedemail.com: domain of lcnwed@gmail.com designates 209.85.216.45 as permitted sender) smtp.mailfrom=lcnwed@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725593629; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IhuYj790wDLfRfrUaika0uMYzKXg4fII2xntIbGsGSs=; b=vOLJrU4goFuD8gXvPfy4sLDiwn8DqcztFrLXQXZVEnzT1Xxl/DbHn7RHFuoTTBk/yjqSDI BODJA0RgAuPbYKAfQkATS1h+TPndxZDzDYmLXl9HkxKex0qYzPgX9+j2sYUMQfsaT3Nhl1 fo3LM8jE0cQpTyMbDDdZRb/brqBxcN4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725593629; a=rsa-sha256; cv=none; b=m9zUI+nagiInXa5Q+mH9vz0r71jeg/AlFKRak+s+vJ+qzDeBkqESAQWntjE89H0l1bctFK Imwce+lRFD/N6LKptuopv8USiSfy5a8TBkGU06PAZXOoCHIELOQRqBMjPKp2aV2kpFeYSy F5FixLYgqg61qQdFhVo9WlJPsJOH/Qw= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="GcpjICc/"; spf=pass (imf18.hostedemail.com: domain of lcnwed@gmail.com designates 209.85.216.45 as permitted sender) smtp.mailfrom=lcnwed@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-2d89dbb60bdso1122624a91.1 for ; Thu, 05 Sep 2024 20:35:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725593726; x=1726198526; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=IhuYj790wDLfRfrUaika0uMYzKXg4fII2xntIbGsGSs=; b=GcpjICc/iZnekjmgGiP1+JxKQS+/mClDJZ9e47sLVIJOmxjRMn0qbi6dWKzbKTE7Ei 0YhPHWQ7/8vlI4F+cZRWwMtuu8gPIdwjJu3nXjzNNqfu1mU6/F5rvPxrH4QqUtoV+Q7O 6FmOtZ9BYph0+Vya0PX5ViBGPoqG3QhHnkH1es5vVALd4/7FYXHbkhx8vhl3mPyUcZXD uQf/BjfKY4GvRi8059GqlQ+prRgOvoHYLn1sYpy+4OprEtoKrVz6RsBgNDVBdz58oEb2 wEYEDYW8pXZgYnKxAjAHSDDoPMZ9pphtTUmNJoCjbly9PQdpLNJbmwlE1mxsXoUopvIQ DA1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725593726; x=1726198526; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IhuYj790wDLfRfrUaika0uMYzKXg4fII2xntIbGsGSs=; b=lhuTt3TAQsA2+qlY3Tw7DWM+XFvDMG527dxu8043lIQF10EqgX2ymmANWVaPl4fmau vm3p5UjYmpvyaIJxuyJFDdMec3Us1id35KGXgRagXzq7o5u0CkEsw2ulmpwaI0OPsskw GVX2+Ld0BNHeCMuleEd7LZahaxh2Dgsx2UFF6gYG4jYvbkAAfMsEQEuouusBHR6CaoLG rsLe4zF4XNOJ/ikDZEwZcDb303+3aJHM1a/7RUBQayjBnynT+Xwxy0PsLGiIjttkMl4j kejjSkKk606/xeSQAJcOkOi0Tl+iGOt7J2MU0YhgZdRJaC29WOkLu0HFXwIDWV4yj3/9 7oPA== X-Forwarded-Encrypted: i=1; AJvYcCW3vYwZPPijUE+wqTaVkmT9SH0wIK0qS96GNRbL7+ogQIHdP31KJe9ICe/pHopmfb2EbhF6n0DXhQ==@kvack.org X-Gm-Message-State: AOJu0YwyYbClI/qxUylR7OTB7W8/uqKYbnhecC5jhI74gJ6Lq4CeIcxC FUiuYf2YiTgbfwr9dP5RQObiROJkpNQ+q/zTTU76L3+qk5zhD1PI9CKHcwiEqwBUSqVOFCWdBCu Asw25XomyNL/zQe64ybwHsQB84gc= X-Google-Smtp-Source: AGHT+IFdboao3qNZkxuDUbHVJ4PM6zjbRZc22bL5X5Tp6/gOTzAoRIWcICCop5130io2oNLVIWOxQyb8NP8EamXmsj0= X-Received: by 2002:a17:90b:384a:b0:2d8:b6a6:bc2b with SMTP id 98e67ed59e1d1-2d8b6a6bffamr19518963a91.21.1725593725981; Thu, 05 Sep 2024 20:35:25 -0700 (PDT) MIME-Version: 1.0 References: <20240905095216.7888-1-wangyibo@uniontech.com> <50595531-87b0-4420-9624-948810066a6e@redhat.com> In-Reply-To: <50595531-87b0-4420-9624-948810066a6e@redhat.com> From: Lucien Wang Date: Fri, 6 Sep 2024 11:35:15 +0800 Message-ID: Subject: Re: [PATCH] mm: move bad zone checking before getting it To: David Hildenbrand Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, trivial@kernel.org, Wang Yibo Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8AAF21C0008 X-Stat-Signature: zc3cacrp6831izgof5qatwoa38ri4ucz X-HE-Tag: 1725593727-95643 X-HE-Meta: U2FsdGVkX1/oqjmXYAC0QX5iZPC3I7a8MmhNlZucjgIS8yB27LpwjbtigSEp7EQ3FaK2+cKH8zFmerBgu3Goyn3tZd8wmj5+baoIYWcmMPc1MJe4HZqUxZ1/HjPPO+QwLk5BscPIoWHVL6+h0KtaIxcwHTSXbD7NpCBqRta00dyyJuIbhsNvL4IQ/1AZruM+Ry4LEr2/zRrqgkEc/IZw96OBC+FfjCX/+nZB4z4SazWw/7Nl3WouDgPMPLrNP7mU8y7OLdBUzYGfV1ecI4pZ0Ju+WIDdQTyWrRicLsof5QeJyjaLL5jbrKm6frl5TF3FL9TUxhHqXTESbc4ja/6MhJyLixB4yGabW04otEUQ/4JI2Ta7dH4+0KisMYw7d63v0pgWnSeiEV13w70geLxucRmMIGGGBHSb+xM26Tc5cos9WsZ7K1U6CULTkh/51Q8tV7BGs2Uzlz5VvkOLizzz8b/oavR8EI3cDK6us6B4SYK7PFLWOeGPlaJYviEVKzl3xKSKMQ6qAE9pPUAVGNJw50/xj0unZ32u7uzAjgYm4LhBWG7L0fCM1I/BoAceMHmpJos1w2UvR9pgLpWjvHk98dWlt3bh5guGWQe5y8Vv7G1cr7VKhJSLBCKcPVf8vt5t70vItgTeHy9ViqhvsvoXNkt7e4CwRgv0ZQxPvJi1WFjvufz4iT5DFiz71k57QGgEVwxcS3TGXOz4a5VkwKPsZk/oG/wkRA4ibaUgLAVw3FbcQ0q761vDgznd/riEXZHWC8CwPgpPvrujHl9F4mynKBtm5d7snZQYRFblZ6wNYZrQvdF/RhgnrYitpnvnC1iqXuRQ9bTZUFXSNzfoVn8WdutaH1gKEL5BQ2oCluDjkn6xWybcnU+bVCm11LFaFjxGgAJrVigcssrtxVAQzOHBpuWGGLBnjcQyVaXbslF0sjNak4dq85VqzRmNbpVNjkOhh099a/lZDDUs7M4yzmQ 8eFGqvqf tZma5KX6f/fRRnAZATPeAwYurztgRJZQb5HT7aUv9msT3peECBXNiDtmwudDjSDKoLVoCOXJhMFgafgeZg7VlF4rCTxD/RVluT9RJGYIcgJwEShgV1O3Jmf5XLGIGBFobpzoKVT+hoOZ5NRCdZr1J4MS9ovacGMHYqy1OZ3kElosZZxgb1N7x1GFPr8xWmBemWrf9dPCxR+5J01nXp8X2SgEFjeBAgQfubvZnfknBUUVntU8ivN9YGC5hWgZHEiHiq8WRU42YR+AuStB/exJGAlX9vQmWA87Cwo7SJdwCIyUY+2KY5NRY6yfuLgYch5xyvi9zR52m8jcTpPLnvt7Bf7cYeMWcTj2KM1ezKnk0z+1l86yB1uB1bNu3608RqJpPaNc5Y3Ilb2luo+SAW2K+1uZmhg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000012, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Sep 5, 2024 at 6:22=E2=80=AFPM David Hildenbrand = wrote: > > On 05.09.24 11:52, Wang Yibo wrote: > > When flags from gfp_zone() has an error combination, VM_BUG_ON() should= firt know it before use it. > > s/firt/first/ > > Please break long lines. (checkpatch.pl should have warned you) > > > > > Signed-off-by: Wang Yibo > > --- > > include/linux/gfp.h | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/include/linux/gfp.h b/include/linux/gfp.h > > index f53f76e0b17e..ca61b2440ab3 100644 > > --- a/include/linux/gfp.h > > +++ b/include/linux/gfp.h > > @@ -133,10 +133,11 @@ static inline enum zone_type gfp_zone(gfp_t flags= ) > > { > > enum zone_type z; > > int bit =3D (__force int) (flags & GFP_ZONEMASK); > > + VM_BUG_ON((GFP_ZONE_BAD >> bit) & 1); > > Better use VM_WARN_ON_ONCE() instead while at it. > > > > > z =3D (GFP_ZONE_TABLE >> (bit * GFP_ZONES_SHIFT)) & > > ((1 << GFP_ZONES_SHIFT) - 1); > > - VM_BUG_ON((GFP_ZONE_BAD >> bit) & 1); > > + > > Unrelated whitespace change. > > > return z; > > } > > > > But I don't see why we would want this change? It's not like the kernel > would crash when calculating z. > > Or is there some change in behavior I am missing? On Thu, Sep 5, 2024 at 9:13=E2=80=AFPM David Hildenbrand = wrote: > > On 05.09.24 12:48, Wang Yibo wrote: > > When flags in gfp_zone() has an error combination, > > VM_BUG_ON() should first know it before use it. > > > > Signed-off-by: Wang Yibo > > --- > > include/linux/gfp.h | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/include/linux/gfp.h b/include/linux/gfp.h > > index f53f76e0b17e..ca61b2440ab3 100644 > > --- a/include/linux/gfp.h > > +++ b/include/linux/gfp.h > > @@ -133,10 +133,11 @@ static inline enum zone_type gfp_zone(gfp_t flags= ) > > { > > enum zone_type z; > > int bit =3D (__force int) (flags & GFP_ZONEMASK); > > + VM_BUG_ON((GFP_ZONE_BAD >> bit) & 1); > > > > z =3D (GFP_ZONE_TABLE >> (bit * GFP_ZONES_SHIFT)) & > > ((1 << GFP_ZONES_SHIFT) - 1); > > - VM_BUG_ON((GFP_ZONE_BAD >> bit) & 1); > > + > > I'm afraid you either missed half my review comments or your answer to > my mail did not make it to my inbox. I did not read your first email carefully,Sorry for that. I will reply to your comments based on your last email. > > -- > Cheers, > > David / dhildenb > > > -- > Cheers, > > David / dhildenb >