From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5BD3C4828E for ; Fri, 2 Feb 2024 22:06:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 32E0F6B00A7; Fri, 2 Feb 2024 17:06:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2DD296B00A8; Fri, 2 Feb 2024 17:06:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A5D66B00A9; Fri, 2 Feb 2024 17:06:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 078446B00A7 for ; Fri, 2 Feb 2024 17:06:01 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4B217A1D5C for ; Fri, 2 Feb 2024 22:06:00 +0000 (UTC) X-FDA: 81748247280.14.221DEBA Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) by imf27.hostedemail.com (Postfix) with ESMTP id 57CBF4001E for ; Fri, 2 Feb 2024 22:05:57 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=TMqP3rja; dmarc=none; spf=pass (imf27.hostedemail.com: domain of alexghiti@rivosinc.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=alexghiti@rivosinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706911557; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=88hcq8XgkrpsBeyZheiHmTOtZGbbdlYCkf6URsqgIp4=; b=F/SPUeMomBMMy9ijlj57GA9tVZem2QYAJvFfBQl2MWUIuJpTp10MDdj14EAtJ/D+dDbx/A D1CDNB7XKA27oltcu4R2TeV6brmApnlTQhlUwRJJhkcNRpaBTWGkQJgqbW9X3Dz4zadELV v9pkQs/TCG6bLmdECD8FQsidGLIfOMw= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=TMqP3rja; dmarc=none; spf=pass (imf27.hostedemail.com: domain of alexghiti@rivosinc.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=alexghiti@rivosinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706911557; a=rsa-sha256; cv=none; b=UhSmi+p05G/G3IZ84NP9NHfSp8tpXdnFmljUCjM09fIVrogjvaQg9pAMwkWRDUhEu+e3Yw 5eZWubAgvYwjwg1K//GQ997UYObnhF83+KPoMGnNxex4ClLtVLTxCy43q14VecmHa/jKme hbLOlUKIt5QUqPT4ftHZArL+UrXnWVE= Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-56010d9aab4so355889a12.3 for ; Fri, 02 Feb 2024 14:05:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1706911555; x=1707516355; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=88hcq8XgkrpsBeyZheiHmTOtZGbbdlYCkf6URsqgIp4=; b=TMqP3rja7p2mgkKBm9GSoC2e7G258zoXeiMhtksGuGpezPhPhaqYBnBQOYkJnKwgo5 ljTslLTqNJEi3GK4/L0R+a8QbQzROJoU/kszpqf5QsksNysp94ECKfuGuXdsHhKQajFy 16jcWK6Th4qm+98prTBwZO026+Mqgy+hyesgsRpcDs9s0AScyB3UstJx9VeJL6TrqUvf uoD8Rg54G4iQRTjoEK6IR5fv9XdK1GWw7d35PXWLJulb60G6HCXaImd1Cf6R7Cs77bzN Po9A2ALWuGYaBVMmIr548ytm8kzhXOwYE/j1smygWAwGgpYR5koFuBcgQyEcriepdM2l G2FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706911555; x=1707516355; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=88hcq8XgkrpsBeyZheiHmTOtZGbbdlYCkf6URsqgIp4=; b=FxuwNG6oO/4M2A6BvwqTzI/UYYhzIMUrVTntBcnkQ3vEo/VdFZ8vlbSCmeQ02QbCqi Jm9bV2SC9t43PqT7FPI5nnhOJz6q9V7ky6xONbVnYTJOdYrYPBtwvMMsTQTih9C0YyXt L6OzHauiwwlwv4e6TrPOdMjEubbYzWzLXHxJZE8wONuyYPmW6IIOQ3y1S/cVVq7sLvZs +aD3B75BPvhcs8uTQvt2Z62zKC9cjzFVwcCZlQjzHDe/AGpHT0aOBSi34Mj541ReRX4I 7JvOpltCEp484M1SUlHk+Ck3owggadMZiP28AfR8ABjr7v+lprk/M5frgdQvzxbrgk8r kBkA== X-Gm-Message-State: AOJu0Yy7yyXXGN0N7ALl/nGWm2ob3FxCEGZCM7O1u+UwYEsQHGYqmzB0 zjX5lCs390FMQiuBXZL99j8exRcgcZlbM7C/3t9ijHaSvgA0k+mBgxs/olaYOjLQ7wBJ41UjZNh YZmJ8UlTQd+2fFkaFdnyQ33ntCKZSfMcDmxnGEA== X-Google-Smtp-Source: AGHT+IEdra/txPxsHeiEZSIqeLcoax0q8b5/TdMlKdrQpsLC9Bhy0DO41JjMt0QszL6IyZw4hoGkwwrYDp1u0lZqAvA= X-Received: by 2002:a17:906:2455:b0:a2e:94a0:93b4 with SMTP id a21-20020a170906245500b00a2e94a093b4mr4841883ejb.61.1706911555736; Fri, 02 Feb 2024 14:05:55 -0800 (PST) MIME-Version: 1.0 References: <20240131155929.169961-1-alexghiti@rivosinc.com> <20240131155929.169961-5-alexghiti@rivosinc.com> In-Reply-To: From: Alexandre Ghiti Date: Fri, 2 Feb 2024 23:05:44 +0100 Message-ID: Subject: Re: [PATCH RFC/RFT v2 4/4] riscv: Stop emitting preventive sfence.vma for new userspace mappings with Svvptc To: Andrea Parri Cc: Catalin Marinas , Will Deacon , Thomas Bogendoerfer , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrew Morton , Ved Shanbhogue , Matt Evans , Dylan Jhong , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 57CBF4001E X-Stat-Signature: 4tax3hjw8et3sewacfpx858uaasa1sx6 X-HE-Tag: 1706911557-263860 X-HE-Meta: U2FsdGVkX1+Rfh36HxkW3lWgR8hy8Am1v3+O1cysBO3mcW6NRG5CQEwBzF1XS4wKo+UcAAfrdBNJFObFYtnFFFe+581TxgdaxiSjnpJqR9OGFmV6YzZBbqqHNe71wXbnRhWaTibzOkNUTXMA25ehGEbfOnpVfHQVryqNO4n2AYTLCY2aSJa23tbJAE0Q8Bc8L0u80EcZCmJP5dpOfOqv076AfcX6/tH88pRQiqaPxMwzn+Y7onii9oDh59kLuv0dcVfKoBYUsiEvFJYVgKE7nTXE14CtNexTGvqAv/pdNifx0gSgwzSCMOHR4Rey2K7IYMtZxfXF8bD1P+KhujfkQpo2+nQJBVgcZ+R2ddHakmwHcrB1sBAvtk2Uvi0R47oh5K723j0lwF0tJt7Rcj3q1pdsR4drzQS1RHWVwYUJCGzs3OjyJC8ZCpX3Noga4QiQi4moy5I5TsGl5jSo/spOnwYmb2hvpFQykPnISphbvYEP47hApUKbX1KzqGoaivF8tZdVe3y4igco6nbCQYeKEjOZXhOMlOpQilwz8bTUcWG0y04N6u92OJHGFuJUDdmwu//by+I0RiBGxNq/tv6kTLafHXH4Jlvhzd4Ru8WrJZCZcy7ndJLA6bFTif1GO+Wy6R3hjsWbanozSh4vtxfjEo/Y+bh0M89fwHVymsgbeMzEjfYGI5nM6IsLL/hqYQT+2WQiIkaxECgkPdvIO1g1eXyOZEpRx+R/86fE+2nCTCIu6DJJcgR47bd/W+BOubZ7NKwhQWgvk6DZcnYNhJIz0VWif5N6KtATRQpTP9TUajV+7weHxXgjmu0mefTs5YAFq6gZV0lQUANr7EurdEDf1tbvyXhhKzgIs5lYVYVj8W5nFlTfltcfDZFtgpF2QFxnFxDYBqFHWxufPKknn7hwRON0r+oLPCrFD735QumHGqXbslHq+L9rIJ8LC5rLbgZbD9HZkPre/DmZeTgKBPD cEgqEsBU OQlwB2pctJgoEW7q2ybxx7JyUkvGoiKirnLk8CjgMGEGWn5kUPEqacHfX2Hq0y2jqgqS+b5N430qgzk1xZRCdrM4REJLTyaOCxQ7RK5K+bMpLDYpCOIzgklbMZcSSJhrEZwpuMoBn2i5lPnXvTKWqidU1k5ZTrS/TMj45cNo1NGt+yym7m5fAiHWL8ILAEBiy+Zg5X4JNu826gnJgKe2T5jPyD9XPntlBxj7zw9wt5c1NyBLEF4MOlUi8id02+ZNPyxvS63JXhaxmXtvIIt+/+/rgfu7yWsHwJTMrsAtSe+Dn39+Bcoc1UebJRdhKk9gwRL93OBkHy31TdsMkAEGjzR8+na707FPmvpQb843DJ6mh0LvX3oH47GsMCzz39I7H7cwsj6C0zXnBWSmNEuo//eWgdTaKpb7dCjzvxwCyfsm9BdA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 2, 2024 at 4:42=E2=80=AFPM Alexandre Ghiti wrote: > > Hi Andrea, > > On Thu, Feb 1, 2024 at 4:03=E2=80=AFPM Andrea Parri wrote: > > > > On Wed, Jan 31, 2024 at 04:59:29PM +0100, Alexandre Ghiti wrote: > > > The preventive sfence.vma were emitted because new mappings must be m= ade > > > visible to the page table walker but Svvptc guarantees that xRET act = as > > > a fence, so no need to sfence.vma for the uarchs that implement this > > > extension. > > > > AFAIU, your first submission shows that you don't need that xRET proper= ty. > > Similarly for other archs. What was rationale behind this Svvptc chang= e? > > Actually, the ARC has just changed its mind and removed this new The wording was incorrect here, the ARC did not state anything, the author of Svvptc proposed an amended version of the spec that removes this behaviour and that's under discussion. > behaviour from the Svvptc extension, so we will take some gratuitous > page faults (but that should be outliners), which makes riscv similar > to x86 and arm64. > > > > > > > > This allows to drastically reduce the number of sfence.vma emitted: > > > > > > * Ubuntu boot to login: > > > Before: ~630k sfence.vma > > > After: ~200k sfence.vma > > > > > > * ltp - mmapstress01 > > > Before: ~45k > > > After: ~6.3k > > > > > > * lmbench - lat_pagefault > > > Before: ~665k > > > After: 832 (!) > > > > > > * lmbench - lat_mmap > > > Before: ~546k > > > After: 718 (!) > > > > This Svvptc seems to move/add the "burden" of the synchronization to xR= ET: > > Perhaps integrate the above counts w/ the perf gains in the cover lette= r? > > Yes, I'll copy that to the cover letter. > > Thanks for your interest! > > Alex > > > > > Andrea