From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBD76C021A4 for ; Mon, 24 Feb 2025 10:49:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5B3AA6B008C; Mon, 24 Feb 2025 05:49:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5682D6B0092; Mon, 24 Feb 2025 05:49:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3DBEA6B0093; Mon, 24 Feb 2025 05:49:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1E1366B008C for ; Mon, 24 Feb 2025 05:49:25 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 973DA1C94CE for ; Mon, 24 Feb 2025 10:49:24 +0000 (UTC) X-FDA: 83154516648.04.0395BDD Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by imf10.hostedemail.com (Postfix) with ESMTP id 6F0E1C0006 for ; Mon, 24 Feb 2025 10:49:22 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=YAAiORwf; spf=pass (imf10.hostedemail.com: domain of alexghiti@rivosinc.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=alexghiti@rivosinc.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740394162; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=O+3hc2uspzUuGySeq35PHHzR5JH/rChsfvYHdlzz6CY=; b=utNJR7bjqWBfJ19mwAJPWmiSgKNMhOvo7HfUP7DgNxgc7mL7txrxrfFF+iKVKQaI3/8VuE Ap2ZScXjbi09BzXpZx8hixjEBCCZqnNRNQyJO/LlGBi77UkFVhoxIYKxiha8y79BhwPRH/ 0BxcpMemt4zD4v7QjL3jR6v6X7a0UT0= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=YAAiORwf; spf=pass (imf10.hostedemail.com: domain of alexghiti@rivosinc.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=alexghiti@rivosinc.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740394162; a=rsa-sha256; cv=none; b=AhbOVTxf6zi9jhCbE6amp28LSkMblAE7wL8SlBwFoGpVY5PeZb+dB0v5Prj4Ku9nlXKyHd eh4XNqZnpuRGQaTRWBxdRAVfzC5y2hI45xEdo/wbtdNNyG+/J7z4mFn4DJ0G7oYusikdTT nrdEZXp3WMfogI7yXtN7VYVd9vN6xGs= Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-abbae92be71so484458766b.2 for ; Mon, 24 Feb 2025 02:49:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1740394161; x=1740998961; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=O+3hc2uspzUuGySeq35PHHzR5JH/rChsfvYHdlzz6CY=; b=YAAiORwf/Q6yottcPO/yDRoSL235Cf6QpMBriuMTBn76HBsJzLXBUqF/wKa0EYtf2x 5qHtaPit7BmNLXqISXhMep8+6cbXuoTFfVdK7SYM4ok9/w/pGaSp2isCdqhVoQsg1Meg Vj/JTnCt9g+zXKovMo0/IP3QkvZsb0v5JX6yoLJPhM6jsd9M8c2EZa3NzJbhicLiunsn Bob1Sei5XINVXnJwHyNVOP32F/rPEZ1bgkj0Xs5z8cABAkX9LyN0SlYJlwXHbSeTqjXU xH5qKpNH8mmNy+yt1++l3QPGSFbLV084ZJFPouRw0JcLM0RuJsMUsMZvafUD4U9Ro2CY e9ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740394161; x=1740998961; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O+3hc2uspzUuGySeq35PHHzR5JH/rChsfvYHdlzz6CY=; b=vxJ5K+yt0xGUxof5TRbetVsiqWQwSGyLIzG/vHrvPMW4JiJjOb01MJXhziDk2wXCGA jQmZWQriBjBI4bIpdAv9IFj//MdHaFF3Ny3L1GtblfKvxKh0oqrCPUYSHc4RrZZ3nuo5 jsRwIvrlg4KYTyi1ao7aC8ooPny+xwBwVJ8GJSljJuNjKk3X38U/8DnJxQ4luSYQAH2R SObC4teZfVoabs6p53UFEwSrDkX/r0VvgeAP9v2ThMEZSuO14V+eNKIUnbxfn++dm1NN OJVE77mzP0syfXgnjIXWuTvWis9tljvG4IFKIfzaCwPlavdwr0mLQFEpIFNIxBHRgBF+ 52wg== X-Forwarded-Encrypted: i=1; AJvYcCVSZcxaQWKJS+bqq9jxGj2H68baECYdVPZZAcj9/t2A6wFdh67WNYCzL0ZpYtk/Q2dufea9H3g/Og==@kvack.org X-Gm-Message-State: AOJu0YwGEq4Op05wRXN9ECsx+6DbRulyEj18rA3ikP2waMtzB+A/uPrR GPbAyTLjx7Inl7p2e/DMHdI0vYJPwJr+Hbim3LRkvxQui2QEfk5Nv8f7ZsnlwrquVCouJu8ji8f rxEDIa5OkF7WJXgiQnH/imag/1f3ns+SuUwm7fA== X-Gm-Gg: ASbGnctkMSA9t/jAvSxYp1kfP9foudUKrgx4n0LqxfYlREXUQsjLBMkhizzWPn8o+W7 +Fh6q0OzDTWnclEVTr9snsgitXe2bkubs8Lbnwe3l7eBaBgeg8JQfnvyIJl3Nace3BHprqRaObO O5WxliG8s= X-Google-Smtp-Source: AGHT+IHHpKWXIm/v2k+338UkHDIVLeb79WjMIsWoo/8r7lA3uc+V3rq9HglSj1eZuVQogWlVvckU5UsUcnUd6gUjF0M= X-Received: by 2002:a05:6402:388c:b0:5e0:7cc4:ec57 with SMTP id 4fb4d7f45d1cf-5e0b7266ba5mr26764777a12.31.1740394160578; Mon, 24 Feb 2025 02:49:20 -0800 (PST) MIME-Version: 1.0 References: <20250217140419.1702389-1-ryan.roberts@arm.com> <20250217140419.1702389-2-ryan.roberts@arm.com> In-Reply-To: From: Alexandre Ghiti Date: Mon, 24 Feb 2025 11:49:09 +0100 X-Gm-Features: AWEUYZlGjIT4eI7eKQbJ3SHrGN78CEaD_5h64M0X3Xtov-A0DdsnodalQc20rYI Message-ID: Subject: Re: [PATCH v2 1/4] mm: hugetlb: Add huge page size param to huge_ptep_get_and_clear() To: David Hildenbrand Cc: Ryan Roberts , Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Gerald Schaefer , "David S. Miller" , Andreas Larsson , Arnd Bergmann , Muchun Song , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , "Matthew Wilcox (Oracle)" , Mark Rutland , Anshuman Khandual , Dev Jain , Kevin Brodsky , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 6F0E1C0006 X-Stat-Signature: 9c8rg7pgu7nzrnncr1arx4zujxicu3kd X-Rspamd-Server: rspam03 X-HE-Tag: 1740394162-640898 X-HE-Meta: U2FsdGVkX1+u6yJwr4qMjAoScjkjd6GX8wMAFUIP1WnvUEHS0NeteM3ZO3OH8HA5IRX3UCbq2/AjjEQfWVcyw6z1j3LaNQv11Qtjk4wggu8rTvRSnqQqDrOcPrAMBTrnQ7XG+oMtLV+RLy1XSVYE4U/YuS2b0qDQNUV2WXuSM0FF68FoXU6K0rSrGlkX+lMYT+XHKqYs3tosEBoIjIX/TkQHh5XJw+a/aGqpIZt7Vo9ySmtUITFTC4/4EFqDLkmVJPQazaO6coA3TIMT0P559QDLe51zC0zn3K7L8iuTYJT09vX3beoijdzUz9k2K30CrVDBSW7USoOyNTJYH3P5T/6m4DY7tRitkm5udrvKXwdmWyTH394kty960nbAc+8Xq/wzI6phtqScjHwfkh5jVD8q86e8rUy60RHIiRzgwXekYA3V1k7Fhu5zG6tIP2AQGKLqTRCgZ5K99DBQ7tD8+IxMBLWnUa1bkhz1pUQrE+mH4MkPkL5GfjBMXS0Qn0pB6gRDa9wxwe4kmD1BXENbvkNsXJdk2d0oCnUBUE6dTatbhRVXtr+5F00J/a1EycyBDGL727icaGV6eDY/7jV6LJNMZwMnE8zONeKh3cHpWYT0M5s7PFNrbi4oh5r/aO6ayHjPxpFrKupTY09IBfQilK0eHlFJbub1PbQT2FVMPjT8wSH6LHKURbGhr0hn8SCqd9xF4407N6IOFQyg/EjFECilyOaqljVfhuQYKajNGk3qD69YLSY8qV5R89LaqYQV6Xj5PJKnDR9k6nGSy9Ze7X5RjE+pGFYMvcPeTCjyssLF4u4c659IEt7DkyzZDrSYOBPocXBjo/hr2fPDkREKLONdTvvK1HB1HXw5eu9EL/K0423gmZoABpu83Ryyr632EeSjdPd9+OzhpJ8rXTo787rABtLRxfokhUFq/eF5vDTsN82w1eyupuSXa5fxwApuKHQM+RpykVB1CMNpR44 dmcGqEdD vqsOoRcx31jfOaigflydXmM+ZH4oGG5oPodAtjm7j6GSrA3W6NBHV3S1A4sS6hCUoIr5c2cotvUY2xKDEFMOK58IWEoLC4me3IAgFDURn8FuwpD/DBSDiFfA0J2nO08QfQcJq9N42r3Jn9LsHFkh9L0wCRfEaQSkPpesMHtIoUfJlbQ9TdrNPJSH/gbgygB4BFSQ0Ytssijy9Y/fewZHa34q63no1hsb/W9w+4nWQXmNwC2rQgbtMVnp9jDnErb+6U/buXjDUmmFei0P56+PsSneCNlx3QpP5g2aq9XNo7drmsYMHAD7xg7wNFGrC6WuWGyBCFhJ3aK/Jo0syqdqIMrTK9NcsBI+uqi5bTbaM9UDPIh8LbYm4zkO3kj6mIPjOSED2iqFusn1aXYMzdZdS+IYdY4ygX1CkVxCcELWArBF8FVcj4aFcy1YjyKXjOizmgdbIoahNotNA9lvlws8jOKnYvmMqBR8P9yis1z3mQkSNkpdUQVTpMBJozw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000016, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Ryan, On Thu, Feb 20, 2025 at 10:46=E2=80=AFAM David Hildenbrand wrote: > > On 17.02.25 15:04, Ryan Roberts wrote: > > In order to fix a bug, arm64 needs to be told the size of the huge page > > for which the huge_pte is being set in huge_ptep_get_and_clear(). > > s/set/cleared/ ? > > > Provide for this by adding an `unsigned long sz` parameter to the > > function. This follows the same pattern as huge_pte_clear() and > > set_huge_pte_at(). > > > > This commit makes the required interface modifications to the core mm a= s > > well as all arches that implement this function (arm64, loongarch, mips= , > > parisc, powerpc, riscv, s390, sparc). The actual arm64 bug will be fixe= d > > in a separate commit. > > > > Cc: stable@vger.kernel.org > > Fixes: 66b3923a1a0f ("arm64: hugetlb: add support for PTE contiguous bi= t") > > Signed-off-by: Ryan Roberts Reviewed-by: Alexandre Ghiti # riscv Thanks, Alex > > --- > > Acked-by: David Hildenbrand > > -- > Cheers, > > David / dhildenb >