From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB97CEB8FBC for ; Wed, 6 Sep 2023 12:44:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 05EC0440165; Wed, 6 Sep 2023 08:44:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 00F70440151; Wed, 6 Sep 2023 08:44:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E187B440165; Wed, 6 Sep 2023 08:44:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D0356440151 for ; Wed, 6 Sep 2023 08:44:00 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8E3B0160AB9 for ; Wed, 6 Sep 2023 12:44:00 +0000 (UTC) X-FDA: 81206139840.26.054ED4E Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by imf13.hostedemail.com (Postfix) with ESMTP id A4C602002D for ; Wed, 6 Sep 2023 12:43:58 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=Gddr0nti; spf=pass (imf13.hostedemail.com: domain of alexghiti@rivosinc.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=alexghiti@rivosinc.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694004238; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=97T82DaWND1ic3tMqCxU8VDEgFQSQlyfp7fMNRtDH0U=; b=TRfcRqDtaOKbL4pIQsiClAoCAnaeWmkfNJrlsMHaF4f9MRh17b2IgANbYI3/QmkHmQSquT lKtlKCbiECCM5PJZr3Yk6ApVU1hgCN9MnF4cPfu8Uyy4lhSnvaw6opFbcnP83VZw83Ur5+ IFsBgAawKZJHjXEDjX3XkOZWFI0f7F8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694004238; a=rsa-sha256; cv=none; b=j1Kc6pZI2CfCi+VNVH7INUZXrVdjN2M0A0NLxVe+RO+M8WNsCrVC0c26jZESUQtm9SZ9dp ATbS1HABi62bFVrxS0J3zcFUHXGiTP3cmmthEkcQXvef2IBgYPT55DOi6Ds9ysrDgoz73r 7eabv/GPsrKFs1mwmv/d1cM6nyX3tTw= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=Gddr0nti; spf=pass (imf13.hostedemail.com: domain of alexghiti@rivosinc.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=alexghiti@rivosinc.com; dmarc=none Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-401d6f6b2e0so5797295e9.1 for ; Wed, 06 Sep 2023 05:43:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1694004237; x=1694609037; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=97T82DaWND1ic3tMqCxU8VDEgFQSQlyfp7fMNRtDH0U=; b=Gddr0ntiUr0sNRE7R9XAZxPJQgFRzuPw63yonM57hAHMud4qN9v9iBNJyQdNIBhG4F IwbDDCYqFlKmpQ1ajj4Mp8Dcl9oY/M1MhSGZWjjfjaSz4xc4cqSjEnAWStFsDdDmXA6r RlarxFdijcAxM77/Jv1YORQKNJeuiSeYNwGFE2/Y4/qzlHgKa3PouOCNerjNbBrtG15j oFvAelCQBoFqEurNjtdlJks77qGgK7z1JuJmyYgbn82zyX26mtJKsLZEWkflZmdHsoGM HlUfYiU8mzgIhvpkxYM16N2Yw/fRPh/OUhXrgIpUMlGiR8CmIMeouVgx8DA5nyRYRLC5 ixKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694004237; x=1694609037; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=97T82DaWND1ic3tMqCxU8VDEgFQSQlyfp7fMNRtDH0U=; b=PuxKK2/Ydcs99CJhs7UrJaA6v1uhAeQRGcOR6ydW0MDZ3ietvyAQwcjWPUKymszrrg ruJgUx691qHTsZrpHHsSz0EAuhkkZdJd4TZDVM7uervOI1aDXnwevoYL0IjGO9dkWzsb 50TEeljnkm589pGp/GbTmlZ41OfPv1Lk2Bxdr0NAVzUuANQdKu68AElzCeErG+T80pUL QuEibJBjymFHGCDe+ENjhvLon0l1uFb7UUQKLbT2qsPPWzj/No0wgAItklRq0NI6A0b6 BfdJ1mM7iH3LDKVaCCTEyH7TVx5SxJDC989YX9hVuQvAyIttqKuND13cEKZde3jDeDG9 gMAg== X-Gm-Message-State: AOJu0Yzfj2/qLQSahPcnWL+eM0NpswyDzLC+GiU6iL0WNSfysvAkm2d0 mDk4NGdJ98cGkYX31tclIrNMtHnQIkca3/vVwmQROQ== X-Google-Smtp-Source: AGHT+IE5EzPlYpM04M+Q/aJihvrqk89xvt00ppxx1QLaRQWeDL07/bJeynyeRYAenM4+M4c30V7uH8C5wCvl72MrsjQ= X-Received: by 2002:a05:6000:5c9:b0:30f:c1fa:7901 with SMTP id bh9-20020a05600005c900b0030fc1fa7901mr2582820wrb.5.1694004237054; Wed, 06 Sep 2023 05:43:57 -0700 (PDT) MIME-Version: 1.0 References: <20230801085402.1168351-1-alexghiti@rivosinc.com> <20230801085402.1168351-5-alexghiti@rivosinc.com> In-Reply-To: From: Alexandre Ghiti Date: Wed, 6 Sep 2023 14:43:46 +0200 Message-ID: Subject: Re: [PATCH v3 4/4] riscv: Improve flush_tlb_kernel_range() To: "Lad, Prabhakar" Cc: Geert Uytterhoeven , Will Deacon , "Aneesh Kumar K . V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Mayuresh Chitale , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Andrew Jones Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: A4C602002D X-Rspam-User: X-Stat-Signature: 4bzh643wshfgbs4qwn733ntn3u6mzjsn X-Rspamd-Server: rspam03 X-HE-Tag: 1694004238-282634 X-HE-Meta: U2FsdGVkX1/r5ZPPucSJ5qayAL16O74nsv7fr7VWxVtiujy5GzfwlEqitXfNLSrgCS3P7KTtHmi+hyudzZZZu8pv9k/iYqd9CjKmhxULz1pYf8zPouzh8EHAbU8Gkd3Kw73kEC3pH4z5L8Kvgq3Hz2xBjYsndSoGUf/TCXK88xRGKmVnHdlenRnXaSxEw39EX7U0Gi/6U2m/Zqt5svtoPiDPubn9bGM3J84GZloyO+v8LCQg4AUF+/F/uGdpUNny3EPlWXfa4EShrgFdrpOLs0dfzz6SdqAhfV1eLbflS0ku67MdB9gaEwqVeUIWZiiDJ2QwM+MK1ir41q92IMe2sBBAvbjbZOIBRn66+3fgxet1soVH3qnYCAXIWt1gl8JmIiEHWz2K4FTuD/so84oAHp+9FwXPGwL0dGrFCnfe2sjcE1Wajr6fiv6/O5xe8m6uydNObj9ItVlhtTjLVTQQm8KwhtrgixbqXSghtvlQvRcnA5Z5HOLxpDvjdv14B4hECgHIIUGpj6/luDilzUaG8mIJCqs5DkakyC0QkZfHxED0ohLrF5NLh3CcjeGkVtNC7F4zm2K9wgYIj43YQY5g98HkbzkE+7RIDG8bHyD/f/YyAIuy7aQNyBFEwaGij6GQncHZsAE+cEiz5Gso6PjWGk3ZmrjFIrtOZlC0Lj+VHHaKES8qepozhRQjNuP0el9DzcghXN2/uH1Ufxj4Rh+gAwDHtVtOkTAX7fCSI+qtLSFTmyv8IV2PsKERo28bL5nyHWmN+2vOwjuGGNNRos0v4Yay+imqMKi5P/bii2ENNmXVkDJEz0QGJFvK5dkTwJVkKO7V+k2ywY3AOJndY5D2Y/Wgqs+AsoWP7HhVt/lpm8MihfQ7CHbUGcLZ/mQAJNSCGr1ip6wwhWe9hlSGjYt3lOPupn0Hcf4ANg7bUsHQNMtv15a6MGYlSidI9LX/r6kBVzAxwo3w1kJy8/mtedo cnm/9KQs S+cy/8HOxJiN72pNBTtMm3jjOV7c7gdVorGNlMI1DNRh/4Lfo+SLtHtAYNdyuobJsBP1ywNcEsUCtE8o/v9VYBKwwneYdwUckyk09W3C2zY79LgtcldtAs5Hw+4ZiHA4gXR6c4M8xNft+RALb2BvAulIF9qbfHj2aEx+IcdBLAYBpXfXwEcrr6FFVZCEK3wIVDIbHaC+QE6yOgS7vLbsHoSmzca5IHjHK6CUgBMxZPNEjd4IOY/asWfhcRqHcT+VtoaiiRgmFyJkQKTSG+oW9vdjm4aXSnZIj8IYmQiGgsWD7uoVa3EK9cPN2eqfqHstXDHHvZMtwMLch5CeDprHefMM/B/v9YXz8QmID+SnfyNnb1tYL6g0Y4YBevYuoxF7dJgKxRoh80bCfoS5pUPU4LrZe7MMQ1V6P1XWFYeoWVAPL/41oc17mh2Qe1eUyXTeExSIzwCP6o4nw9u9XDU/bmavnPriKKxP/A/XMyYbFfynS9M/4LeZZIyBakpPmBb5A+ZF+d85Rn/mcgAHbActj+dk7OsN4/xla0PzWN0/KCDc1jlFXZnVGkvZkWqv5Pe/D92Yt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 6, 2023 at 2:24=E2=80=AFPM Lad, Prabhakar wrote: > > Hi Alexandre, > > On Wed, Sep 6, 2023 at 1:18=E2=80=AFPM Alexandre Ghiti wrote: > > > > On Wed, Sep 6, 2023 at 2:09=E2=80=AFPM Lad, Prabhakar > > wrote: > > > > > > Hi Alexandre, > > > > > > On Wed, Sep 6, 2023 at 1:01=E2=80=AFPM Alexandre Ghiti wrote: > > > > > > > > Hi Prabhakar, > > > > > > > > On Wed, Sep 6, 2023 at 1:49=E2=80=AFPM Lad, Prabhakar > > > > wrote: > > > > > > > > > > Hi Alexandre, > > > > > > > > > > On Tue, Aug 1, 2023 at 9:58=E2=80=AFAM Alexandre Ghiti wrote: > > > > > > > > > > > > This function used to simply flush the whole tlb of all harts, = be more > > > > > > subtile and try to only flush the range. > > > > > > > > > > > > The problem is that we can only use PAGE_SIZE as stride since w= e don't know > > > > > > the size of the underlying mapping and then this function will = be improved > > > > > > only if the size of the region to flush is < threshold * PAGE_S= IZE. > > > > > > > > > > > > Signed-off-by: Alexandre Ghiti > > > > > > Reviewed-by: Andrew Jones > > > > > > --- > > > > > > arch/riscv/include/asm/tlbflush.h | 11 +++++----- > > > > > > arch/riscv/mm/tlbflush.c | 34 +++++++++++++++++++++++= -------- > > > > > > 2 files changed, 31 insertions(+), 14 deletions(-) > > > > > > > > > > > After applying this patch, I am seeing module load issues on RZ/F= ive > > > > > (complete log [0]). I am testing defconfig + [1] (rz/five related > > > > > configs). > > > > > > > > > > Any pointers on what could be an issue here? > > > > > > > > Can you give me the exact version of the kernel you use? The trap > > > > addresses are vmalloc addresses, and a fix for those landed very la= te > > > > in the release cycle. > > > > > > > I am using next-20230906, Ive pushed a branch [1] for you to have a l= ook. > > > > > > [0] https://github.com/prabhakarlad/linux/tree/rzfive-debug > > > > Great, thanks, I had to get rid of this possibility :) > > > > As-is, I have no idea, can you try to "bisect" the problem? I mean > > which patch in the series leads to those traps? > > > Oops sorry for not mentioning earlier, this is the offending patch > which leads to the issues seen on rz/five. Ok, so at least I found the following problem, but I don't see how that could fix your issue: can you give a try anyway? I keep looking into this, thanks diff --git a/arch/riscv/mm/tlbflush.c b/arch/riscv/mm/tlbflush.c index df2a0838c3a1..b5692bc6c76a 100644 --- a/arch/riscv/mm/tlbflush.c +++ b/arch/riscv/mm/tlbflush.c @@ -239,7 +239,7 @@ void flush_tlb_range(struct vm_area_struct *vma, unsigned long start, void flush_tlb_kernel_range(unsigned long start, unsigned long end) { - __flush_tlb_range(NULL, start, end, PAGE_SIZE); + __flush_tlb_range(NULL, start, end - start, PAGE_SIZE); } #ifdef CONFIG_TRANSPARENT_HUGEPAGE > > Cheers, > Prabhakar