From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C4A2C4345F for ; Thu, 25 Apr 2024 10:22:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 90B786B008C; Thu, 25 Apr 2024 06:22:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 893C76B0092; Thu, 25 Apr 2024 06:22:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E7BC6B0093; Thu, 25 Apr 2024 06:22:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 46B066B008C for ; Thu, 25 Apr 2024 06:22:49 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B2765160C2E for ; Thu, 25 Apr 2024 10:22:48 +0000 (UTC) X-FDA: 82047665616.29.FC6BF8E Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) by imf14.hostedemail.com (Postfix) with ESMTP id 871C8100017 for ; Thu, 25 Apr 2024 10:22:46 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=iXbTbQPh; dmarc=none; spf=pass (imf14.hostedemail.com: domain of alexghiti@rivosinc.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=alexghiti@rivosinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714040566; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Tb0RWXYcOUdwAJ2aC7C5cjwImSQlTgJoiKwx4zZtUTU=; b=uHCPKvflQSpr9nn+Xe3vaWm+k01M6TtDysvgUu1s4u/dxuEZwBJkDp77oNjBqqQ9lWgVpx 2DEdp0WDbQszID7/IqbFhP7fWv4zYGIAP3A9Z4VxFJtaXEQvpeG/FZRwCTdZpIR8K875x9 F6urEwY8jjljxwpSpAPjGBMl+7iuuA0= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=iXbTbQPh; dmarc=none; spf=pass (imf14.hostedemail.com: domain of alexghiti@rivosinc.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=alexghiti@rivosinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714040566; a=rsa-sha256; cv=none; b=iobVFGkOYWAqboa6p307AmlLpBkEVSgsLCrvWtAjC81cwGEa125MAll0I3ZqU/VuIPa2jy 3GDCGU7sSXmQ7leHwjNprrBh0YGcmDHl748ea4uWPhG/NxjbcY9BxkpJ5VqJkD8hXnAy6X pE+MYtfhqlZidYO8yPx7T7qch/T47Mk= Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-572347c2c16so955809a12.2 for ; Thu, 25 Apr 2024 03:22:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1714040565; x=1714645365; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Tb0RWXYcOUdwAJ2aC7C5cjwImSQlTgJoiKwx4zZtUTU=; b=iXbTbQPhVs+wro+qwZ2Uia1RvHJLcSaL9pBwXNCRkSUwxpD3Y8bAm7oZmSqJYaI6ss hLq3fiMW2My2W4dirqBugG8XBd3LLXU1bcTevKTSQhx24N0R2MOWm9NI7EmW+00bh6ll 51m0N70oTcROFpZu6TFFRKuR92fJQKjnyIZ7gOk1RI8rnu70ieeJWbDqSaqsj8/YzhjV 0F5HRjy+ir5G/b1zaEyde9ayIcRYCu50kvNkNJZ5Ct0DU+IxwaVVW1od5XIl9IcUixyM XyJt/62HuztYuAKfoQfzcID4w6at5JXmqOXc42mvW0BAU4fqPqabLhnKo1qPbXr80+DL Xg3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714040565; x=1714645365; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Tb0RWXYcOUdwAJ2aC7C5cjwImSQlTgJoiKwx4zZtUTU=; b=sboHYM/HBudV0Jx1XHobhVA51hXwwTaXNnlgeOJ0/PITXMODhjgI8WaJcbOt47zc2y y65EMDRUTazqNo1FzfCKHlUeTEklVhz0UqHUtM1+KO4pCUS9iGTCqP0vCutM6vn6YHaF VACJE0Dc+bysyO3tibf+JmbdEL1FqOdEYVK14R+yfv4iGnCETlMxXqMa4dugeGzf8jlh f0LCzLCr2BoxmvdyyAqpXsUSZUzGjou9nycXLuWkQHV1aFLj8osYUaJuyRV4ePePkbEj rkO7nvLPBR98BxtXoJ/Znja4O/HzHkSCE6Y/8lXAEw02oLL2PCA9nZGVmMg47CqGCRD5 3X0A== X-Forwarded-Encrypted: i=1; AJvYcCVl3a2K63rABpb8MNXcs3mzlKfYkuCRrexzjZmilC/Fr7i6SOkqET2/d22DFiDNsglr0t2PsvJ19g5QtJQB4JSSfgw= X-Gm-Message-State: AOJu0YxByRDxhqPPOmgM7/1RCXoykrE5N3MMC3cyz2cUIHHeAiLeK9Ne /HIzmL55sFMQ/1IRiO6gQE79KrdFXn6YXxea+ClV5m55nqeLvbGwV9SXVpqp0BIg2V9UP1LSxSx CGqlA4wOx/cTdr93ufnHI+kFCIL6VOI7Qx6N50w== X-Google-Smtp-Source: AGHT+IG8hw9GemhS0Y2zrqPlg61weeOaKBTk8AKOgSpxSoiunT0f7Msptuqm/wIphoBkX2od0EVzqsFkRHMXAD8JMOk= X-Received: by 2002:a17:906:7ac6:b0:a55:bfe7:3e62 with SMTP id k6-20020a1709067ac600b00a55bfe73e62mr3060024ejo.11.1714040564519; Thu, 25 Apr 2024 03:22:44 -0700 (PDT) MIME-Version: 1.0 References: <20240423142307.495726312-1-mbland@motorola.com> In-Reply-To: <20240423142307.495726312-1-mbland@motorola.com> From: Alexandre Ghiti Date: Thu, 25 Apr 2024 12:22:33 +0200 Message-ID: Subject: Re: [PATCH v2] ptdump: add non-leaf descriptor support To: 20240423110435.c84aa2a0e4cb5a17fb1ab18d@linux-foundation.org Cc: Andrew Morton , "Maxwell Bland Jonathan Corbet" , Catalin Marinas , Christophe Leroy , Will Deacon , Maxwell Bland , Ard Biesheuvel , Mark Rutland , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 871C8100017 X-Rspam-User: X-Stat-Signature: gy5s7dfq9dsfe9e3gu71415agca59p18 X-HE-Tag: 1714040566-833994 X-HE-Meta: U2FsdGVkX19YgljYfZDYDxAn6rbM0MbwpzKku79fOGLZou4oVpZ2BiDgHkIN1rAVAexMLsc/9N5cPCF8U66H8+C8FRF/O5eeD/CGAkL8lnEeQcOG0Smlce+rRv48r+W1yY8l2Y17inmQRnjg+JUowg/0zbjeZKEeZzDsybH1spH9Dg/8jFtW39oltnIbmOGxzuHxYGy6KJ54jk6lmScZMzRAFOvnf1eauruCGJ7TlhFFvrgaLvqJFGE+hFu4hR5zlSH30xm4DcZ+m8KlGl0WD/C0Wrgubna/6CQ61QR+5FI0UYtBcusymsviZdUtfPhpnAl1h2Gm5B3U3jJ6w0IlhnhdP7eeUqaqFPpfXbcuvShE5gzvCBbXHVnNGRkqKdOfunxzD+YS+XOyQe8jpKGMxqX202V3WZ8ZuTgrs2b7JHizspoKPBFm6EoyfFUTy7efnfdumEPffFLVURmQjO2oBw6snERaQy8qnkEKvLGXDNGF6CBtd+3/vThUupq8J9TYBLlJFqvg0utNn3GC9SObRlp8zifh7TITGSeBqVHYFxsE6/3+0HgfkrPA60jFnrQK0rc9/pCbTY8lNVcKb6xOQ6jY8V28Re2uaf7SiMdPHWqUIyE8FaMUPaW6LjZCsYD7r83WrAlwpH/LAzZQSYOsW8LCQNvBSlH3Uhia6CUd6ovNlf7+lRCpjWERNr9YxOqdhqWQno5upSAWSIHNq1Dj2+JlNt83EPSpViAE9zFnciMxj4efvTLz5hE9Pxm9U6PuzxULm8wZ0fWh1qO5kN0HJrM0fNYTQ89FPKu5fdRX2bPaD+HvKh5mvMT9PA5vdeJbVB+FmAn9khM4nRnVNXPCBUHDgw6FKWI/b0w/AcjsNGK2/XOZtDHczZoDtB5hyUTLne5iM7jlC76soowvd0DHYpdvLWx5dZRxkTSoTFFSthv0KDub1rj230YQQeeW0NFhj4yxcdhxuvL112InHoq qLPrrdnW L7kf/Ngs0uV3+yH8gR2WEZdOMS1rDH9vhFUHzOwZH3NOG8QKMuSxEkiarXns9qM3WFy6P947EV60n2Yy9KgOjneJQ0aIXs8OYSlXKhR0Q8UBbuv8o8n/FaxRbWFdcv3ZbNCz4aeoWZ6hg0vUVekBEAoumBcMXBk3ddoQ58LeqmKOToDbVgEKFPKgmlUrxHYTqa+0sdNN8BWJmmlSdCm9zaZhLzEygCd4J55ufwHs0d1/CnJVljK4WWkxm1CpV7AY1U4JeNbfZxVBL+xJWEd1jXyeif9C8sNgf64khKc5oLflWhVuiOJStcLoy7HUx7FreyxEEkaONbm61HkSejIM7oVNIihqIH/29UWVmdyHhXFAhNU0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Maxwell, On Tue, Apr 23, 2024 at 9:26=E2=80=AFPM Maxwell Bland = wrote: > > Add an optional note_non_leaf parameter to ptdump, causing note_page to > be called on non-leaf descriptors. Implement this functionality on arm64 > by printing table descriptors along with table-specific permission sets. > > For arm64, break (1) the uniform number of columns for each descriptor, > and (2) the coalescing of large PTE regions, which are now split up by > PMD. This is a "good" thing since it makes the behavior and protection > bits set on page tables, such as PXNTable, more explicit. > > Examples (spaces and last attribute condensed) > Before: > 0xffff008440210000-0xffff008440400000 1984K PTE ro NX SHD AF NG UXN M... > 0xffff008440400000-0xffff008441c00000 24M PMD ro NX SHD AF NG BLK UXN M..= . > 0xffff008441c00000-0xffff008441dc0000 1792K PTE ro NX SHD AF NG UXN M... > 0xffff008441dc0000-0xffff00844317b000 20204K PTE RW NX SHD AF NG UXN M... > > After: > 0xffff0fb640200000-0xffff0fb640400000 2M PMD TBL RW x NXTbl UXNTbl M... > 0xffff0fb640200000-0xffff0fb640210000 64K PTE RW NX SHD AF NG UXN M... > 0xffff0fb640210000-0xffff0fb640400000 1984K PTE ro NX SHD AF NG UXN M... > 0xffff0fb640400000-0xffff0fb641c00000 24M PMD BLK ro SHD AF NG NX UXN ... > 0xffff0fb641c00000-0xffff0fb641e00000 2M PMD TBL RW x NXTbl UXNTbl M... > 0xffff0fb641c00000-0xffff0fb641dc0000 1792K PTE ro NX SHD AF NG UXN M... > 0xffff0fb641dc0000-0xffff0fb641e00000 256K PTE RW NX SHD AF NG UXN ME... I think it would be easier to read if the lower levels were tabulated, so that we can quickly see the page table structure. I'll implement this on riscv once merged, I'm a big user of this dump :) Thanks, Alex > > Full dumps available at > github.com/maxwell-bland/linux-patch-data/tree/main/ptdump-non-leaf > > Signed-off-by: Maxwell Bland > --- > > Dear Andrew, > > > I was going to queue this while awaiting acks from arm people, but > > there's a large reject in Documentation/arch/arm64/ptdump.rst. > > Ack, thank you and apologies, if I understand correctly, you are seeing > this issue on linux-next/akpm, I was not familiar with the submission > process. I was not able to reproduce on mm-unstable, linux-next/master, > mm/master, ... This reply (v2 commit) is cherry-picked to > linux-next/akpm. > > A diff with linux-next/master for my original submission only returns: > > 611c611 > < base-commit: a59668a9397e7245b26e9be85d23f242ff757ae8 > > base-commit: 7d4768ae56014b3db93423e84f8794f173ec5c91 > > Regards, > Maxwell Bland > > Documentation/arch/arm64/ptdump.rst | 125 ++++++++++++++++ > arch/arm64/mm/ptdump.c | 224 +++++++++++++++++++++++++--- > include/linux/ptdump.h | 1 + > mm/ptdump.c | 13 ++ > 4 files changed, 343 insertions(+), 20 deletions(-) > create mode 100644 Documentation/arch/arm64/ptdump.rst > > diff --git a/Documentation/arch/arm64/ptdump.rst b/Documentation/arch/arm= 64/ptdump.rst > new file mode 100644 > index 000000000000..0f38b92fd839 > --- /dev/null > +++ b/Documentation/arch/arm64/ptdump.rst > @@ -0,0 +1,125 @@ > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > +Kernel page table dump > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > + > +ptdump is a debugfs interface that provides a detailed dump of the kerne= l page > +tables. It offers a comprehensive overview of the kernel virtual memory = layout > +as well as the attributes associated with the various regions in a > +human-readable format. It is useful to dump the kernel page tables to ve= rify > +permissions and memory types. Examining the page table entries and permi= ssions > +helps identify potential security vulnerabilities such as mappings with = overly > +permissive access rights or improper memory protections. > + > +Memory hotplug allows dynamic expansion or contraction of available memo= ry > +without requiring a system reboot. To maintain the consistency and integ= rity of > +the memory management data structures, arm64 makes use of the > +mem_hotplug_lock semaphore in write mode. Additionally, in read mode, > +mem_hotplug_lock supports an efficient implementation of > +get_online_mems() and put_online_mems(). These protect the offlining of > +memory being accessed by the ptdump code. > + > +In order to dump the kernel page tables, enable the following configurat= ions > +and mount debugfs:: > + > + CONFIG_GENERIC_PTDUMP=3Dy > + CONFIG_PTDUMP_CORE=3Dy > + CONFIG_PTDUMP_DEBUGFS=3Dy > + > + mount -t debugfs nodev /sys/kernel/debug > + cat /sys/kernel/debug/kernel_page_tables > + > +On analysing the output of cat /sys/kernel/debug/kernel_page_tables one = can > +derive information about the virtual address range of a contiguous group= of > +page table entries, followed by size of the memory region covered by thi= s > +group, the hierarchical structure of the page tables and finally the att= ributes > +associated with each page in the group. Groups are broken up either acco= rding > +to a change in attributes or by parent descriptor, such as a PMD. Note t= hat the > +set of attributes, and therefore formatting, is not equivalent between e= ntry > +types. For example, PMD entries have a separate set of attributes from l= eaf > +level PTE entries, because they support both the UXNTable and PXNTable > +permission bits. > + > +The page attributes provide information about access permissions, execut= ion > +capability, type of mapping such as leaf level PTE or block level PGD, P= MD and > +PUD, and access status of a page within the kernel memory. Non-PTE block= or > +page level entries are denoted with either "BLK" or "TBL", respectively. > +Assessing these attributes can assist in understanding the memory layout= , > +access patterns and security characteristics of the kernel pages. > + > +Kernel virtual memory layout example:: > + > + start address end address size type leaf attributes > + +----------------------------------------------------------------------= -------------------------------------------+ > + | ---[ Linear Mapping start ]--- = | > + | ... = | > + | 0xffff0d02c3200000-0xffff0d02c3400000 2M PMD TBL RW = x NXTbl UXNTbl MEM/NORMAL | > + | 0xffff0d02c3200000-0xffff0d02c3218000 96K PTE ro NX SHD A= F NG UXN MEM/NORMAL-TAGGED | > + | 0xffff0d02c3218000-0xffff0d02c3250000 224K PTE RW NX SHD A= F NG UXN MEM/NORMAL-TAGGED | > + | 0xffff0d02c3250000-0xffff0d02c33b3000 1420K PTE ro NX SHD A= F NG UXN MEM/NORMAL-TAGGED | > + | 0xffff0d02c33b3000-0xffff0d02c3400000 308K PTE RW NX SHD A= F NG UXN MEM/NORMAL-TAGGED | > + | 0xffff0d02c3400000-0xffff0d02c3600000 2M PMD TBL RW = x NXTbl UXNTbl MEM/NORMAL | > + | 0xffff0d02c3400000-0xffff0d02c3600000 2M PTE RW NX SHD A= F NG UXN MEM/NORMAL-TAGGED | > + | ... = | > + | 0xffff0d02c3200000-0xffff0d02c3400000 2M PMD TBL RW = x NXTbl UXNTbl MEM/NORMAL | > + | ... = | > + | ---[ Linear Mapping end ]--- = | > + +----------------------------------------------------------------------= -------------------------------------------+ > + | ---[ Modules start ]--- = | > + | ... = | > + | 0xffff800000000000-0xffff800000000080 128B PGD TBL RW = x UXNTbl MEM/NORMAL | > + | 0xffff800000000000-0xffff800080000000 2G PUD F BLK RW = x MEM/NORMAL | > + | ... = | > + | ---[ Modules end ]--- = | > + +----------------------------------------------------------------------= -------------------------------------------+ > + | ---[ vmalloc() area ]--- = | > + | ... = | > + | 0xffff800080000000-0xffff8000c0000000 1G PUD TBL RW = x UXNTbl MEM/NORMAL | > + | ... = | > + | 0xffff800080200000-0xffff800080400000 2M PMD TBL RW = x NXTbl UXNTbl MEM/NORMAL | > + | 0xffff800080200000-0xffff80008022f000 188K PTE RW NX SHD AF= NG UXN MEM/NORMAL | > + | 0xffff80008022f000-0xffff800080230000 4K PTE F BLK RW x = MEM/NORMAL | > + | 0xffff800080230000-0xffff800080233000 12K PTE RW NX SHD AF= NG UXN MEM/NORMAL | > + | 0xffff800080233000-0xffff800080234000 4K PTE F BLK RW x = MEM/NORMAL | > + | 0xffff800080234000-0xffff800080237000 12K PTE RW NX SHD AF= NG UXN MEM/NORMAL | > + | ... = | > + | 0xffff800080400000-0xffff800084000000 60M PMD F BLK RW = x x x MEM/NORMAL | > + | ... = | > + | ---[ vmalloc() end ]--- = | > + +----------------------------------------------------------------------= -------------------------------------------+ > + | ---[ vmemmap start ]--- = | > + | ... = | > + | 0xfffffe33cb000000-0xfffffe33cc000000 16M PMD BLK RW SHD AF NG= NX UXN x x MEM/NORMAL | > + | 0xfffffe33cc000000-0xfffffe3400000000 832M PMD F BLK RW = x x x MEM/NORMAL | > + | ... = | > + | ---[ vmemmap end ]--- = | > + +----------------------------------------------------------------------= -------------------------------------------+ > + | ---[ PCI I/O start ]--- = | > + | ... = | > + | 0xffffffffc0800000-0xffffffffc0810000 64K PTE RW NX SHD AF = NG UXN DEVICE/nGnRE | > + | ... = | > + | ---[ PCI I/O end ]--- = | > + +----------------------------------------------------------------------= -------------------------------------------+ > + | ---[ Fixmap start ]--- = | > + | ... = | > + | 0xffffffffff5f6000-0xffffffffff5f9000 12K PTE ro x SHD AF = UXN MEM/NORMAL | > + | 0xffffffffff5f9000-0xffffffffff5fa000 4K PTE ro NX SHD AF = NG UXN MEM/NORMAL | > + | ... = | > + | ---[ Fixmap end ]--- = | > + +----------------------------------------------------------------------= -------------------------------------------+ > + > +cat /sys/kernel/debug/kernel_page_tables output:: > + > + 0xffff000000000000-0xffff0d0000000000 13T PGD F BLK RW = x MEM/NORMAL > + 0xffff0d0000000000-0xffff0d0000000080 128B PGD TBL RW = NXTbl UXNTbl MEM/NORMAL > + 0xffff0d0000000000-0xffff0d02c0000000 11G PUD F BLK RW = x MEM/NORMAL > + 0xffff0d02c0000000-0xffff0d0300000000 1G PUD TBL RW = NXTbl UXNTbl MEM/NORMAL > + 0xffff0d02c0000000-0xffff0d02c0200000 2M PMD TBL RW = x NXTbl UXNTbl MEM/NORMAL > + 0xffff0d02c0000000-0xffff0d02c0200000 2M PTE RW NX SHD AF = NG UXN MEM/NORMAL-TAGGED > + 0xffff0d02c0200000-0xffff0d02c0400000 2M PMD TBL RW = x NXTbl UXNTbl MEM/NORMAL > + 0xffff0d02c0200000-0xffff0d02c0210000 64K PTE RW NX SHD AF = NG UXN MEM/NORMAL-TAGGED > + 0xffff0d02c0210000-0xffff0d02c0400000 1984K PTE ro NX SHD AF = NG UXN MEM/NORMAL > + 0xffff0d02c0400000-0xffff0d02c1c00000 24M PMD BLK ro SHD AF NG = NX UXN x x MEM/NORMAL > + 0xffff0d02c1c00000-0xffff0d02c1e00000 2M PMD TBL RW = x NXTbl UXNTbl MEM/NORMAL > + 0xffff0d02c1c00000-0xffff0d02c1dc0000 1792K PTE ro NX SHD AF = NG UXN MEM/NORMAL > + 0xffff0d02c1dc0000-0xffff0d02c1e00000 256K PTE RW NX SHD AF = NG UXN MEM/NORMAL-TAGGED > + > diff --git a/arch/arm64/mm/ptdump.c b/arch/arm64/mm/ptdump.c > index 9bc4066c5bf3..6a8b2bcc9ac7 100644 > --- a/arch/arm64/mm/ptdump.c > +++ b/arch/arm64/mm/ptdump.c > @@ -24,6 +24,7 @@ > #include > #include > #include > +#include > > > enum address_markers_idx { > @@ -97,6 +98,11 @@ static const struct prot_bits pte_bits[] =3D { > .val =3D PTE_VALID, > .set =3D " ", > .clear =3D "F", > + }, { > + .mask =3D PTE_TABLE_BIT, > + .val =3D PTE_TABLE_BIT, > + .set =3D " ", > + .clear =3D "BLK", > }, { > .mask =3D PTE_USER, > .val =3D PTE_USER, > @@ -132,11 +138,6 @@ static const struct prot_bits pte_bits[] =3D { > .val =3D PTE_CONT, > .set =3D "CON", > .clear =3D " ", > - }, { > - .mask =3D PTE_TABLE_BIT, > - .val =3D PTE_TABLE_BIT, > - .set =3D " ", > - .clear =3D "BLK", > }, { > .mask =3D PTE_UXN, > .val =3D PTE_UXN, > @@ -170,34 +171,206 @@ static const struct prot_bits pte_bits[] =3D { > } > }; > > +static const struct prot_bits pmd_bits[] =3D { > + { > + .mask =3D PMD_SECT_VALID, > + .val =3D PMD_SECT_VALID, > + .set =3D " ", > + .clear =3D "F", > + }, { > + .mask =3D PMD_TABLE_BIT, > + .val =3D PMD_TABLE_BIT, > + .set =3D "TBL", > + .clear =3D "BLK", > + }, { > + .mask =3D PMD_SECT_USER, > + .val =3D PMD_SECT_USER, > + .set =3D "USR", > + .clear =3D " ", > + }, { > + .mask =3D PMD_SECT_RDONLY, > + .val =3D PMD_SECT_RDONLY, > + .set =3D "ro", > + .clear =3D "RW", > + }, { > + .mask =3D PMD_SECT_S, > + .val =3D PMD_SECT_S, > + .set =3D "SHD", > + .clear =3D " ", > + }, { > + .mask =3D PMD_SECT_AF, > + .val =3D PMD_SECT_AF, > + .set =3D "AF", > + .clear =3D " ", > + }, { > + .mask =3D PMD_SECT_NG, > + .val =3D PMD_SECT_NG, > + .set =3D "NG", > + .clear =3D " ", > + }, { > + .mask =3D PMD_SECT_CONT, > + .val =3D PMD_SECT_CONT, > + .set =3D "CON", > + .clear =3D " ", > + }, { > + .mask =3D PMD_SECT_PXN, > + .val =3D PMD_SECT_PXN, > + .set =3D "NX", > + .clear =3D "x ", > + }, { > + .mask =3D PMD_SECT_UXN, > + .val =3D PMD_SECT_UXN, > + .set =3D "UXN", > + .clear =3D " ", > + }, { > + .mask =3D PMD_TABLE_PXN, > + .val =3D PMD_TABLE_PXN, > + .set =3D "NXTbl", > + .clear =3D "x ", > + }, { > + .mask =3D PMD_TABLE_UXN, > + .val =3D PMD_TABLE_UXN, > + .set =3D "UXNTbl", > + .clear =3D "x ", > + }, { > + .mask =3D PTE_GP, > + .val =3D PTE_GP, > + .set =3D "GP", > + .clear =3D " ", > + }, { > + .mask =3D PMD_ATTRINDX_MASK, > + .val =3D PMD_ATTRINDX(MT_DEVICE_nGnRnE), > + .set =3D "DEVICE/nGnRnE", > + }, { > + .mask =3D PMD_ATTRINDX_MASK, > + .val =3D PMD_ATTRINDX(MT_DEVICE_nGnRE), > + .set =3D "DEVICE/nGnRE", > + }, { > + .mask =3D PMD_ATTRINDX_MASK, > + .val =3D PMD_ATTRINDX(MT_NORMAL_NC), > + .set =3D "MEM/NORMAL-NC", > + }, { > + .mask =3D PMD_ATTRINDX_MASK, > + .val =3D PMD_ATTRINDX(MT_NORMAL), > + .set =3D "MEM/NORMAL", > + }, { > + .mask =3D PMD_ATTRINDX_MASK, > + .val =3D PMD_ATTRINDX(MT_NORMAL_TAGGED), > + .set =3D "MEM/NORMAL-TAGGED", > + } > +}; > + > +static const struct prot_bits pud_bits[] =3D { > + { > + .mask =3D PUD_TYPE_SECT, > + .val =3D PUD_TYPE_SECT, > + .set =3D " ", > + .clear =3D "F", > + }, { > + .mask =3D PUD_TABLE_BIT, > + .val =3D PUD_TABLE_BIT, > + .set =3D "TBL", > + .clear =3D "BLK", > + }, { > + .mask =3D PTE_USER, > + .val =3D PTE_USER, > + .set =3D "USR", > + .clear =3D " ", > + }, { > + .mask =3D PUD_SECT_RDONLY, > + .val =3D PUD_SECT_RDONLY, > + .set =3D "ro", > + .clear =3D "RW", > + }, { > + .mask =3D PTE_SHARED, > + .val =3D PTE_SHARED, > + .set =3D "SHD", > + .clear =3D " ", > + }, { > + .mask =3D PTE_AF, > + .val =3D PTE_AF, > + .set =3D "AF", > + .clear =3D " ", > + }, { > + .mask =3D PTE_NG, > + .val =3D PTE_NG, > + .set =3D "NG", > + .clear =3D " ", > + }, { > + .mask =3D PTE_CONT, > + .val =3D PTE_CONT, > + .set =3D "CON", > + .clear =3D " ", > + }, { > + .mask =3D PUD_TABLE_PXN, > + .val =3D PUD_TABLE_PXN, > + .set =3D "NXTbl", > + .clear =3D "x ", > + }, { > + .mask =3D PUD_TABLE_UXN, > + .val =3D PUD_TABLE_UXN, > + .set =3D "UXNTbl", > + .clear =3D " ", > + }, { > + .mask =3D PTE_GP, > + .val =3D PTE_GP, > + .set =3D "GP", > + .clear =3D " ", > + }, { > + .mask =3D PMD_ATTRINDX_MASK, > + .val =3D PMD_ATTRINDX(MT_DEVICE_nGnRnE), > + .set =3D "DEVICE/nGnRnE", > + }, { > + .mask =3D PMD_ATTRINDX_MASK, > + .val =3D PMD_ATTRINDX(MT_DEVICE_nGnRE), > + .set =3D "DEVICE/nGnRE", > + }, { > + .mask =3D PMD_ATTRINDX_MASK, > + .val =3D PMD_ATTRINDX(MT_NORMAL_NC), > + .set =3D "MEM/NORMAL-NC", > + }, { > + .mask =3D PMD_ATTRINDX_MASK, > + .val =3D PMD_ATTRINDX(MT_NORMAL), > + .set =3D "MEM/NORMAL", > + }, { > + .mask =3D PMD_ATTRINDX_MASK, > + .val =3D PMD_ATTRINDX(MT_NORMAL_TAGGED), > + .set =3D "MEM/NORMAL-TAGGED", > + } > +}; > + > struct pg_level { > const struct prot_bits *bits; > const char *name; > size_t num; > u64 mask; > + unsigned long size; > }; > > static struct pg_level pg_level[] =3D { > { /* pgd */ > .name =3D "PGD", > - .bits =3D pte_bits, > - .num =3D ARRAY_SIZE(pte_bits), > + .bits =3D pud_bits, > + .num =3D ARRAY_SIZE(pud_bits), > + .size =3D PGD_SIZE > }, { /* p4d */ > .name =3D "P4D", > - .bits =3D pte_bits, > - .num =3D ARRAY_SIZE(pte_bits), > + .bits =3D pud_bits, > + .num =3D ARRAY_SIZE(pud_bits), > + .size =3D P4D_SIZE > }, { /* pud */ > .name =3D (CONFIG_PGTABLE_LEVELS > 3) ? "PUD" : "PGD", > - .bits =3D pte_bits, > - .num =3D ARRAY_SIZE(pte_bits), > + .bits =3D pud_bits, > + .num =3D ARRAY_SIZE(pud_bits), > }, { /* pmd */ > .name =3D (CONFIG_PGTABLE_LEVELS > 2) ? "PMD" : "PGD", > - .bits =3D pte_bits, > - .num =3D ARRAY_SIZE(pte_bits), > + .bits =3D pmd_bits, > + .num =3D ARRAY_SIZE(pmd_bits), > }, { /* pte */ > .name =3D "PTE", > .bits =3D pte_bits, > .num =3D ARRAY_SIZE(pte_bits), > + .size =3D PAGE_SIZE > }, > }; > > @@ -252,7 +425,7 @@ static void note_page(struct ptdump_state *pt_st, uns= igned long addr, int level, > u64 val) > { > struct pg_state *st =3D container_of(pt_st, struct pg_state, ptdu= mp); > - static const char units[] =3D "KMGTPE"; > + static const char units[] =3D "BKMGTPE"; > u64 prot =3D 0; > > if (level >=3D 0) > @@ -263,8 +436,8 @@ static void note_page(struct ptdump_state *pt_st, uns= igned long addr, int level, > st->current_prot =3D prot; > st->start_address =3D addr; > pt_dump_seq_printf(st->seq, "---[ %s ]---\n", st->marker-= >name); > - } else if (prot !=3D st->current_prot || level !=3D st->level || > - addr >=3D st->marker[1].start_address) { > + } else if ((prot !=3D st->current_prot || level !=3D st->level || > + addr >=3D st->marker[1].start_address)) { > const char *unit =3D units; > unsigned long delta; > > @@ -273,10 +446,20 @@ static void note_page(struct ptdump_state *pt_st, u= nsigned long addr, int level, > note_prot_wx(st, addr); > } > > - pt_dump_seq_printf(st->seq, "0x%016lx-0x%016lx ", > - st->start_address, addr); > + /* > + * Entries are coalesced into a single line, so non-leaf > + * entries have no size relative to start_address > + */ > + if (st->start_address !=3D addr) { > + pt_dump_seq_printf(st->seq, "0x%016lx-0x%016lx = ", > + st->start_address, addr); > + delta =3D (addr - st->start_address); > + } else { > + pt_dump_seq_printf(st->seq, "0x%016lx-0x%016lx = ", addr, > + addr + pg_level[st->level].siz= e); > + delta =3D (pg_level[st->level].size); > + } > > - delta =3D (addr - st->start_address) >> 10; > while (!(delta & 1023) && unit[1]) { > delta >>=3D 10; > unit++; > @@ -322,7 +505,8 @@ void ptdump_walk(struct seq_file *s, struct ptdump_in= fo *info) > .range =3D (struct ptdump_range[]){ > {info->base_addr, end}, > {0, 0} > - } > + }, > + .note_non_leaf =3D true > } > }; > > diff --git a/include/linux/ptdump.h b/include/linux/ptdump.h > index 2a3a95586425..d32fa8515182 100644 > --- a/include/linux/ptdump.h > +++ b/include/linux/ptdump.h > @@ -16,6 +16,7 @@ struct ptdump_state { > int level, u64 val); > void (*effective_prot)(struct ptdump_state *st, int level, u64 va= l); > const struct ptdump_range *range; > + bool note_non_leaf; > }; > > void ptdump_walk_pgd(struct ptdump_state *st, struct mm_struct *mm, pgd_= t *pgd); > diff --git a/mm/ptdump.c b/mm/ptdump.c > index eea3d28d173c..aacbd499ffcd 100644 > --- a/mm/ptdump.c > +++ b/mm/ptdump.c > @@ -40,6 +40,9 @@ static int ptdump_pgd_entry(pgd_t *pgd, unsigned long a= ddr, > if (st->effective_prot) > st->effective_prot(st, 0, pgd_val(val)); > > + if (st->note_non_leaf && !pgd_leaf(val)) > + st->note_page(st, addr, 0, pgd_val(val)); > + > if (pgd_leaf(val)) { > st->note_page(st, addr, 0, pgd_val(val)); > walk->action =3D ACTION_CONTINUE; > @@ -63,6 +66,9 @@ static int ptdump_p4d_entry(p4d_t *p4d, unsigned long a= ddr, > if (st->effective_prot) > st->effective_prot(st, 1, p4d_val(val)); > > + if (st->note_non_leaf && !p4d_leaf(val)) > + st->note_page(st, addr, 1, p4d_val(val)); > + > if (p4d_leaf(val)) { > st->note_page(st, addr, 1, p4d_val(val)); > walk->action =3D ACTION_CONTINUE; > @@ -86,6 +92,9 @@ static int ptdump_pud_entry(pud_t *pud, unsigned long a= ddr, > if (st->effective_prot) > st->effective_prot(st, 2, pud_val(val)); > > + if (st->note_non_leaf && !pud_leaf(val)) > + st->note_page(st, addr, 2, pud_val(val)); > + > if (pud_leaf(val)) { > st->note_page(st, addr, 2, pud_val(val)); > walk->action =3D ACTION_CONTINUE; > @@ -107,6 +116,10 @@ static int ptdump_pmd_entry(pmd_t *pmd, unsigned lon= g addr, > > if (st->effective_prot) > st->effective_prot(st, 3, pmd_val(val)); > + > + if (st->note_non_leaf && !pmd_leaf(val)) > + st->note_page(st, addr, 3, pmd_val(val)); > + > if (pmd_leaf(val)) { > st->note_page(st, addr, 3, pmd_val(val)); > walk->action =3D ACTION_CONTINUE; > > base-commit: 5f9df76887bf8170e8844f1907c13fbbb30e9c36 > -- > 2.34.1 >