From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C2F6C04FFE for ; Tue, 14 May 2024 17:24:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 831108D0034; Tue, 14 May 2024 13:24:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7DFB28D000D; Tue, 14 May 2024 13:24:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6CE8B8D0034; Tue, 14 May 2024 13:24:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4E2CD8D000D for ; Tue, 14 May 2024 13:24:23 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id BBDD0121355 for ; Tue, 14 May 2024 17:24:22 +0000 (UTC) X-FDA: 82117675164.28.86A4789 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf20.hostedemail.com (Postfix) with ESMTP id CD5281C001D for ; Tue, 14 May 2024 17:24:20 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=A77sO4Zg; dmarc=none; spf=pass (imf20.hostedemail.com: domain of alexghiti@rivosinc.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=alexghiti@rivosinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715707460; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Zm6je9rht4BjYmGJ1IuR6KKMw8nH5QLaou4Ka+z1F+s=; b=RlWW/urmH037QiEMUwYln7T5onO7rm2iuGx+slmINjq9laYuMlYfXwqOvoyvobyVQYdaql o8cwv39vIEjJnpXXAfC1THbQNtAiDuPftb0c/dAKnEdppFrlR2EW5nhIlm7+LoR6CW5Tm8 QMCKiogF5zYTVYtVj0dYrexb0WgS0DA= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=A77sO4Zg; dmarc=none; spf=pass (imf20.hostedemail.com: domain of alexghiti@rivosinc.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=alexghiti@rivosinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715707460; a=rsa-sha256; cv=none; b=a72LvaCFd6s9DjKkLMT0JRtnbPsqSIUXFmeFb1y703cFjEht8EQpWdHBtACnLw3gGcgATQ 1HxDGDt8Fprgi3ySMcoQGJpQ9XJ8fuJS3AToMu8QyUyKkSo4sJ2giQvZgqRvK/ypnRKT6L PGPvYlT/t/lLSz4lid3nxwc5RsVhtd8= Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-572baf393ddso1701636a12.1 for ; Tue, 14 May 2024 10:24:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1715707459; x=1716312259; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Zm6je9rht4BjYmGJ1IuR6KKMw8nH5QLaou4Ka+z1F+s=; b=A77sO4ZguLgwDRNFslyet0SO4UMa+MBmEVFGV+mrOz0RE9VEHRR4wPeh9FUiYlEoCJ JNM3tOoBwhwFMyd8LV9yZVZjvQRLmmrJsbZdLvfz6GVgirsyc4icPVqh4UP5jFwL1EVO gSHY7018B2BKYM0BGjTUWVExYVUyeASjmB26074ERCJ8cZ8rUIrcB0OXKyw7H88cclOY jx1YKFjZIi1ORiMmWKlZmNYlS9UOis4IqhNn4Rn99rhPcn2cJNhLdJHa+j2DfFc3yc6C 5uQKsgqu/fo9UontiDDzXS7XULt66cHSft3F2enByxAJgUAIn9Po/8ZigsR2ON7mp3+B LEJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715707459; x=1716312259; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Zm6je9rht4BjYmGJ1IuR6KKMw8nH5QLaou4Ka+z1F+s=; b=dYxl02KqA83ECrxS2VIhmyc0aZsoYvpe3QjqaEEnWqqzPjL4oAbj3wNVGHqcEyZc6d t5P2GCwZPLU0jgic7mtruR1alGOp7hiQ2fopBDpyZFCNhEiG03YKRCxZo9JTGVQddyTy pV6EaVEBi/a9LCX6Ipe8Pcshfix5SCk0shxO5fmnZDiAg9J95pVe2Ab2boAZ1lgq2AM0 AKaHYBZIeE7gWaPQojigtNN75yxO+Gsd7MD2jTieG2GcqaNy6tlncNsxSqUnZMIrjxW8 b/I/bVs5kh2XWuYo6P/nuIYSCSmHe75Oh+FZACzCde+skGAAnVHsknRHBXXsATE1ICFp Ddmg== X-Forwarded-Encrypted: i=1; AJvYcCUfTKlru8lIbXDuUwAJCDNZa5ZhCft5Olx2aapgnAhGdAAIAVjDJiqkqaeydAHn8jIbHpI2M3PoCM0B1TW+5vYD5cA= X-Gm-Message-State: AOJu0YyQhOjKjb02K+MMicFK/UiK30IlviyNXEu9yUh1IOsZjnhcEB2G EW+Z1cOApEnb4Mai4fzfaip2E4KdrV0SC9X5QJTklNwJ65YpLnwdflfJcKjTyG6EOvgnG4NDCs1 kcfnd8zIZIvnExyy7XXFb4EFpZNghGJyQ7ZfqUg== X-Google-Smtp-Source: AGHT+IF56JWIpkZ2/AL2ubyZfgA/2Uc3aQFZ5Ej57ui6rLBhQ10e6OWlyGWRPN5l4ez0BlwqzQ5aMzCSBobUR5m/tfc= X-Received: by 2002:a05:6402:26cd:b0:572:3fac:e085 with SMTP id 4fb4d7f45d1cf-573328e276amr15922880a12.13.1715707459179; Tue, 14 May 2024 10:24:19 -0700 (PDT) MIME-Version: 1.0 References: <20240514140446.538622-1-bjorn@kernel.org> <20240514140446.538622-4-bjorn@kernel.org> In-Reply-To: <20240514140446.538622-4-bjorn@kernel.org> From: Alexandre Ghiti Date: Tue, 14 May 2024 19:24:08 +0200 Message-ID: Subject: Re: [PATCH v2 3/8] riscv: mm: Refactor create_linear_mapping_range() for memory hot add To: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= Cc: Albert Ou , David Hildenbrand , Palmer Dabbelt , Paul Walmsley , linux-riscv@lists.infradead.org, =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Andrew Bresticker , Chethan Seshadri , Lorenzo Stoakes , Oscar Salvador , Santosh Mamila , Sivakumar Munnangi , Sunil V L , linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtualization@lists.linux-foundation.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: CD5281C001D X-Stat-Signature: 79zeubizyyr4nwurhea4wuoggzy1apra X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1715707460-610596 X-HE-Meta: U2FsdGVkX18tW2vmhfUSD5U+CpRYV1sk2alQHVzeRd0rDcZDrG5oxnQnTD7cT8JTAZzTg4lPRoTeKKwTS7C39bsSPmQjO9JCR5ZfvNUaPjOjTkb2+sdPXjZh8yjUsnE5qnjj+R6/z/G+7vXFD34LB7gJTUylickFd0WKI9SPQnGge1k9tUQQ5l1y/fEa8ugjWppmu+5hnCjjGjt6t8mLq+5hhm6Cu8XJ2hDZq/ZtdOYz77+j1uJJSqD5N8Jt37m2u2JfmYePQYtR/PwOVY1GiK+6/d7H5fr/pgwG9Krvqc5YWvrrmxOHsYEo0070ynxMMYI9m9mIzTiBzlF0eP+YoD+vjnoK0jxVzo+3bjr6qqtZBz7L1opoas3v5PzCm0Llm+PwXRL8pKBKr6ny6bUva3RjufgeOUSUkfqMRE7JRtL9w59iPbfmxmJ2X5XrVtuXFYy8JBiHD0sNeNEtfkUOeUdL82SEKuynB8p4NCZ1wvaK9Abb9K0EP5LdBuDsZgb4A3QvlVcC/GiNA7VL2ZQoniGwlY6Sb+hkNcfp98D8eDQLg8taxk5q/7VUVggOt6lTMS+tdBcB5QaSLpbWdb5Lo3/93t3NJMeuhNjsgOBlvqwLhzfbd+Laz0Yx7KpqNhojHV8iGBHozBWE7OReF1g23ZmhLxZkHDC0OcoQq3fmrzUN5hytAi5VuWzirMSVw6XJ9XH8lig6kDRGawnuZ8vJ/0hLoEwN0fR+MKKQ5tHFCfb94QKDTxmUZLls9HcK+aIy3MkGVK/eOItrov4S8YiFG4Fk9Qbo+tZMtOUxe1uLdVDmoRGQ8NAyfMn6VWmIspYFBvF/dxRuxq5ND07IoMnF+AXqznvhL8ebmH84PoCXSBC06hJimu85kdmdOzGCPUMyKsE8MN8k6vAuWbslB98S03iajwfatvYkZcU+koYZydJZXRNbuVGF5U1YRwLto6kLRO151GfI34vRY+c5IxR HX5SXKc8 XYneUMWTwc5ZeWIBYSiL2cWkawwH2JzxAxe8UYxQ0GR02feH62m+tiiQc7USUSn4gmMuq7RUTFQR5ZmO0D+awo4wUi+V/zzL4uIdCSqc1HgT36mlPX3AJAfIP8K6+wbZr7F9ypNUeYAJ0ViMz941Ghlrhuu5vZPdQFxrpIzjqRJdege533HHLpVAdjskKYAB6E2FsCXFSuKL1qJEExKf9h0454yCJCIkVWDnDdZ1gTt/wkXpG6D9eMefEj+0BakBUfCrY8wxh44+gh6hViqAMQLRH4Pep6ATCz9xuG+Iq6UHQOIS7pCQTil9+/+h1W9coDtfdGVAiORQLsbk6hOmN6GVVfWwt1gxNEwfmGTs8wlZEs27DYpiNMvbhOvCOKVGbX6a5F2XtiKjrPtJi8/AUgU7xHlV66W7QVo2L/VXLQciuSPK+/HmnOik95A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 14, 2024 at 4:05=E2=80=AFPM Bj=C3=B6rn T=C3=B6pel wrote: > > From: Bj=C3=B6rn T=C3=B6pel > > Add a parameter to the direct map setup function, so it can be used in > arch_add_memory() later. > > Signed-off-by: Bj=C3=B6rn T=C3=B6pel > --- > arch/riscv/mm/init.c | 15 ++++++--------- > 1 file changed, 6 insertions(+), 9 deletions(-) > > diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c > index c969427eab88..6f72b0b2b854 100644 > --- a/arch/riscv/mm/init.c > +++ b/arch/riscv/mm/init.c > @@ -1227,7 +1227,7 @@ asmlinkage void __init setup_vm(uintptr_t dtb_pa) > } > > static void __meminit create_linear_mapping_range(phys_addr_t start, phy= s_addr_t end, > - uintptr_t fixed_map_siz= e) > + uintptr_t fixed_map_siz= e, const pgprot_t *pgprot) > { > phys_addr_t pa; > uintptr_t va, map_size; > @@ -1238,7 +1238,7 @@ static void __meminit create_linear_mapping_range(p= hys_addr_t start, phys_addr_t > best_map_size(pa, va, end - p= a); > > create_pgd_mapping(swapper_pg_dir, va, pa, map_size, > - pgprot_from_va(va)); > + pgprot ? *pgprot : pgprot_from_va(va))= ; > } > } > > @@ -1282,22 +1282,19 @@ static void __init create_linear_mapping_page_tab= le(void) > if (end >=3D __pa(PAGE_OFFSET) + memory_limit) > end =3D __pa(PAGE_OFFSET) + memory_limit; > > - create_linear_mapping_range(start, end, 0); > + create_linear_mapping_range(start, end, 0, NULL); > } > > #ifdef CONFIG_STRICT_KERNEL_RWX > - create_linear_mapping_range(ktext_start, ktext_start + ktext_size= , 0); > - create_linear_mapping_range(krodata_start, > - krodata_start + krodata_size, 0); > + create_linear_mapping_range(ktext_start, ktext_start + ktext_size= , 0, NULL); > + create_linear_mapping_range(krodata_start, krodata_start + krodat= a_size, 0, NULL); > > memblock_clear_nomap(ktext_start, ktext_size); > memblock_clear_nomap(krodata_start, krodata_size); > #endif > > #ifdef CONFIG_KFENCE > - create_linear_mapping_range(kfence_pool, > - kfence_pool + KFENCE_POOL_SIZE, > - PAGE_SIZE); > + create_linear_mapping_range(kfence_pool, kfence_pool + KFENCE_POO= L_SIZE, PAGE_SIZE, NULL); > > memblock_clear_nomap(kfence_pool, KFENCE_POOL_SIZE); > #endif > -- > 2.40.1 > You can add: Reviewed-by: Alexandre Ghiti Thanks, Alex