From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19BD4C47073 for ; Thu, 4 Jan 2024 13:01:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 920846B0322; Thu, 4 Jan 2024 08:01:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A88F6B0325; Thu, 4 Jan 2024 08:01:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 748DC6B0328; Thu, 4 Jan 2024 08:01:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6092E6B0322 for ; Thu, 4 Jan 2024 08:01:55 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1D85A408D5 for ; Thu, 4 Jan 2024 13:01:55 +0000 (UTC) X-FDA: 81641640990.10.0F0337B Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by imf25.hostedemail.com (Postfix) with ESMTP id 1FF04A0022 for ; Thu, 4 Jan 2024 13:01:52 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=ss8xW3FX; dmarc=none; spf=pass (imf25.hostedemail.com: domain of alexghiti@rivosinc.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=alexghiti@rivosinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704373313; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/9OiB6Zr2X3JWx8/EcNzOysEraumuG0RSKA4yvIy1vs=; b=NwdosTvtIgHhvojoJvmcIlx4NxpkEmdt7boa3JxDTvNduGlGOWG52THiG8hWZEDOCX5PeD svAPBEu7bCvGidhE81ML6BiCprul90L7F1Gqry23GE9RFuYaiC5n8KfOrgt2inDq2PJQeA H+BfGnwGKbonjiVOxyHnpBIqzcliX3s= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=ss8xW3FX; dmarc=none; spf=pass (imf25.hostedemail.com: domain of alexghiti@rivosinc.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=alexghiti@rivosinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704373313; a=rsa-sha256; cv=none; b=vJXSMyNd7W1KCeLqlSz97gAny+8Q3kPfTRkvmHBnk5QtLCuIqpzzWwE+elD64zqBiaOYzd Hl4eThBidIjCdYpvPyG3DoMJA9fbSCm6MrVAV7WeAII6rtJkEFEtc+D8vNqPT4jVYePmLm +FQ7pmBnpUIjQK1xONTOtCKGNtTZ+EE= Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a277339dcf4so53111866b.2 for ; Thu, 04 Jan 2024 05:01:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1704373311; x=1704978111; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/9OiB6Zr2X3JWx8/EcNzOysEraumuG0RSKA4yvIy1vs=; b=ss8xW3FXv7ow+gtJeq1Nnx2/ff/m7wYG6/ZzHwFFpu7CSNRxVpq3aLXzv5BIeZNigM 8VGT8PCMQM+Wnbi9IiPLzPCzGev4lPZ1FW3CeyNKwbXx+caGkW6NDV2Sj+71DHlJucBi RJSD+TLKX9CLlG+BqJL/aUTMbNURmTBE6QJ9M3RuM68woYV2kdwWAMID31IEznX80Cuf 0kFugEpFUCwUpwR6Zm3vRGMXPAMFfmAPpHf1/5Bnslvoue2owVpFOhQtmiehDRdpJKmY /Gjyx/eCKuGbJxE37UhmmZ6mnvHSx79dMjpRBHg7j+BWhPy3MjA2Wj2uS9DsRPMVoNRu lUvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704373311; x=1704978111; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/9OiB6Zr2X3JWx8/EcNzOysEraumuG0RSKA4yvIy1vs=; b=wTUn/kLw6Xwjeo5pbgE01+MmB7fTtmD/u9ZIUFikc9svESqD9SWZfZfLxZ1yqOrBD5 AfuTEftFJRMJngS9patoocr7v8vT5lehVPyzbtxDFPxOe+67h4nvRdzPhlUwLBf+OaIm LpEi+bTAHQ/SOJmahkrNbe8cP/HYRxG2EaqbzzWnLS57OZMQXjYKLU+bNCuzf3QcMZQa ISBzCnPYlZKg8ysc0uOVw1V7TkPJ0nCuwm7ENtoLwEyUCFSjSm3vcmAUm9FOVfTBmC24 bxr1vnyZ3MHyENoJ1aWl4wA5/93rtBdTVkeUF8tjmBqzB4dEtx6okQujp909HSqq66xl 7qLA== X-Gm-Message-State: AOJu0YwhJxYnuIf4ISk/n4Z1vya4wkW/tqIRRWht9WZwFarXa1cKu8xi BpX1wEWh5suMvI8RilQuep1C5BeC22hxN7Cz1E7tsHj4VKCgIA== X-Google-Smtp-Source: AGHT+IGv4Nd1O7QiBVZ3icJngtwYGoUCGkSaR0BhUpZqYDOqHIhgeGA1hyWSfztxKwIkK4DFZEIwm3bDuFwwIzHa8xc= X-Received: by 2002:a17:907:76ac:b0:a28:b9b8:2f8c with SMTP id jw12-20020a17090776ac00b00a28b9b82f8cmr268278ejc.152.1704373311541; Thu, 04 Jan 2024 05:01:51 -0800 (PST) MIME-Version: 1.0 References: <20240102220134.3229156-1-samuel.holland@sifive.com> <20240102220134.3229156-13-samuel.holland@sifive.com> In-Reply-To: <20240102220134.3229156-13-samuel.holland@sifive.com> From: Alexandre Ghiti Date: Thu, 4 Jan 2024 14:01:40 +0100 Message-ID: Subject: Re: [PATCH v4 12/12] riscv: mm: Always use an ASID to flush mm contexts To: Samuel Holland Cc: Palmer Dabbelt , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 1FF04A0022 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: aukt7nt1pps14pyo94t4syjxb9fzadu8 X-HE-Tag: 1704373312-126437 X-HE-Meta: U2FsdGVkX18IQ9IofYs7bLcEnlLQ+pKBExsApnFFOVj24ZtSE/GBdLIkuHA91yHfDBpjnIQn4c0oixi8P8G27wVUCDh3Nlt1VPNeP3pkzeS2GjMY+mR+VApvBQOP+m0V1WGww2ZYQ4popZ46OUV21skLp4O3j6QFf7FzchotuuFmS1kaOtWWae6zfW2FDUNhGLpsRvVfZ942K1+c8Q9lsJMFKzLVAFDlvFTru1R/xXO3Vyyq9ykjw7ZQYrI5TuD8dTRq5M3LgQbeBQdUPtz8Xgv/6GdVyQrDYzGxgEixe+plkX9r5ieEZx3xg52ucX0McsaI/KhUnA1nB/ytRDT5Wajpp/1h4A0PYpggNvtEZGk42879r+tid+pICF1tAVPJAIIO1JwWrWZn+jEDNo0TlguapXZx7xg6smMTghOBUMrSbdwuzPZDjPX+3AMscHRbqWnvBMApU9Y/BjM/C+3MZUnzpJ9+a5RaS3O7v/sHG1aNfOuFwoocFcmdr5BlEqGwupSR9xNRVut4GXjCJ/0WVIZBAkMcOzAJ0arFz2vJqkXJ6berHE4YkBElaqwFQEQRK+fzx2SiR5+dvqaZkKMTxjZ4NWlFaJxd9y3t3NYbFVHoVa/jK8nlJ5cDQx98snudgIZcMeLic61KMOrkiZddDE65Yjm/Eh8FnNUPxtk4Ejz1brx5toJWP3ST82LnTDQWG6/1sxKHCadOQxlNOAvPWX/YjmfTH0CU/wnQ/vh8cgU3HyY5aCZ0LwpzmoSjudRjHRmCpXgF02uEDOicwtiHltNFzJd9mYCRXWm3O9wCvyipPZR8KErM2bZVVdjpok4rG011h9YTqyUjcrIIR+LbbqlfFrYlWjzV//yzKMmKxCW3eikzLQuVPCsdjAd4+ZrpAt9n2lmutTDN7vWWq5C4eifOgHIa0ch7YsLvk+f3p+QT2k9/DzyCNVtk03opMR3qiVJ7ZRVFifDlpbdZqkH BMxxX685 wN0uOBHux+TAnMUdNH16Zcsqdo7VXvxyDGnJF7B92PKs5cafrdHqJ02U2fLfwduKlhOI/feulfXTMJlLflV4MYtekDtYkGx3GiWeAvEm48bAihqgS8saigXa5okxv9V9M558534C3dcfZOyCQgPuPgRkC5hwMAmazbtVHs8ut5TcEyEf8tLVA3hNDx60WC6WCwi/HpybCqhePAwIcVYqVZ7Gbu9eN5JyRq3P+7dTLicFj+2iO4eVeOsOor5FYEETTkyTJiQ/smi3ogF3cmlg/oYYafOidkX543JJPWSx5dDK6MBuBj1JEHmlmULed/6IcturYb1PIimNwQTJXF57ehzaSSmmcnT8qkkGHnrbs6lXmHtIbgc/jP/Gjyr7wTb3InzwcFZDeH0p35GyQ77+UHHMfZFNUELnLyidxNq/Km+5tbPNK4gjzgmx+Qg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000031, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 2, 2024 at 11:01=E2=80=AFPM Samuel Holland wrote: > > Even if multiple ASIDs are not supported, using the single-ASID variant > of the sfence.vma instruction preserves TLB entries for global (kernel) > pages. So it is always more efficient to use the single-ASID code path. > > Signed-off-by: Samuel Holland > --- > > Changes in v4: > - There is now only one copy of __flush_tlb_range() > > Changes in v2: > - Update both copies of __flush_tlb_range() > > arch/riscv/include/asm/mmu_context.h | 2 -- > arch/riscv/mm/context.c | 3 +-- > arch/riscv/mm/tlbflush.c | 3 +-- > 3 files changed, 2 insertions(+), 6 deletions(-) > > diff --git a/arch/riscv/include/asm/mmu_context.h b/arch/riscv/include/as= m/mmu_context.h > index 7030837adc1a..b0659413a080 100644 > --- a/arch/riscv/include/asm/mmu_context.h > +++ b/arch/riscv/include/asm/mmu_context.h > @@ -33,8 +33,6 @@ static inline int init_new_context(struct task_struct *= tsk, > return 0; > } > > -DECLARE_STATIC_KEY_FALSE(use_asid_allocator); > - > #include > > #endif /* _ASM_RISCV_MMU_CONTEXT_H */ > diff --git a/arch/riscv/mm/context.c b/arch/riscv/mm/context.c > index 3ca9b653df7d..20057085ab8a 100644 > --- a/arch/riscv/mm/context.c > +++ b/arch/riscv/mm/context.c > @@ -18,8 +18,7 @@ > > #ifdef CONFIG_MMU > > -DEFINE_STATIC_KEY_FALSE(use_asid_allocator); > - > +static DEFINE_STATIC_KEY_FALSE(use_asid_allocator); > static unsigned long num_asids; > > static atomic_long_t current_version; > diff --git a/arch/riscv/mm/tlbflush.c b/arch/riscv/mm/tlbflush.c > index 5ec621545c69..39d80f56d292 100644 > --- a/arch/riscv/mm/tlbflush.c > +++ b/arch/riscv/mm/tlbflush.c > @@ -84,8 +84,7 @@ static void __flush_tlb_range(struct mm_struct *mm, uns= igned long start, > if (cpumask_empty(cmask)) > return; > > - if (static_branch_unlikely(&use_asid_allocator)) > - asid =3D cntx2asid(atomic_long_read(&mm->context.= id)); > + asid =3D cntx2asid(atomic_long_read(&mm->context.id)); > } else { > cmask =3D cpu_online_mask; > } > -- > 2.42.0 > You can add: Reviewed-by: Alexandre Ghiti Thanks! Alex