From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D487EC25B7A for ; Tue, 21 May 2024 13:41:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 503616B009E; Tue, 21 May 2024 09:41:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 48CC16B009F; Tue, 21 May 2024 09:41:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 305796B00A1; Tue, 21 May 2024 09:41:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0FD886B009E for ; Tue, 21 May 2024 09:41:28 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BB531161240 for ; Tue, 21 May 2024 13:41:27 +0000 (UTC) X-FDA: 82142515014.09.A714598 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by imf26.hostedemail.com (Postfix) with ESMTP id DF60814000F for ; Tue, 21 May 2024 13:41:25 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=OgxXABR1; dmarc=none; spf=pass (imf26.hostedemail.com: domain of alexghiti@rivosinc.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=alexghiti@rivosinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716298886; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U+1xsVOenBqGRXV+vq+cVu4jiCpn+H/2Flnt09jmSX0=; b=nrf6kTj5p5TJUGoO51UX40p1iNF0VSiqCmMTrjCuVQDWIYKi+d5jAchGo9kCLCuOP9Fipw P4lWaB9cEod+YB09hYcF/f4swfI6QVNlXUWsUP6fuWVzvAyPp6/rpqmB9o/h5uazhi/Zdd VE0OeWwcAdGtlZMx1vKPfWUg92hHVtY= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=OgxXABR1; dmarc=none; spf=pass (imf26.hostedemail.com: domain of alexghiti@rivosinc.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=alexghiti@rivosinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716298886; a=rsa-sha256; cv=none; b=q6dmdAHg/igD3ML8DcW6bqNQ/bDjDEX+IfYLiRFC6rdqyDXrZxOsR+h8bxnguiZh0K4tb/ C96F74qWQk7kEuifoS1v41EGk59wbkB3yCMvE8C/L6lz8sRwt506Wvo5vi+xjd6+GEYeAd XCsYXJds/y53TI6wqqbU+VqftJtpIbs= Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-41f9ce16ed8so43217965e9.0 for ; Tue, 21 May 2024 06:41:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1716298884; x=1716903684; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=U+1xsVOenBqGRXV+vq+cVu4jiCpn+H/2Flnt09jmSX0=; b=OgxXABR1ezAQP6Pk7TOLuDY/2B5Bp7GmBSyUeIlKriz4s2tj73HEBkmrkruyqLqpDh t05ALQmpqE3tUo+bYF58YFxnyFcEAWJHZyYio8IQK2/1ld+A5BtzXU3wMtCqcKCE7tw5 D7eoL0Zwu8xxXliSTmy7WJl0AaY70R16aQdDTwrgEYizJBGaEHsLpCYhFI51kr7E73Mz biUP6sMO9zVaEJH7ajhALAcqnfDVg1A4Z+eBt62L+1aC4fkPcX5+P71NdWQpM4UmNynn yk8FHpDMDOy8026G7Dc9LUtIkHKBIuPq2hIIgqzWl7dOEWwOM05/XFgfBX/Mh0KHHPgF SN9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716298884; x=1716903684; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U+1xsVOenBqGRXV+vq+cVu4jiCpn+H/2Flnt09jmSX0=; b=mggtBt0PZOfB0nboxJBsVOGS+shzelWcCtGs71e+tDLgxkwYBihrn9UE/pIZXkHvWu exyLHj90H0s2ZVBa0Wfqma/mddNBt0r4hLeGvmFQ4kOLfsTgdslluRX3f2S/ydD/YCd0 6HfNlmYxCCoL+lPi7lzb8vza6/k/qWRYE8vz7VnhAZI+xkZI7ybMUMW+/VdKLRnKGB9Y 2e6pB/mYJgUW3ZZi0rpOgcISGeyi8NXK8L50HVAo1qGpsgj1UU0DT0D5DvtOapQTCAJa vfV1zHGruwR/Q+YuTCSE7zmlzmpOp1LhtL+FjLNnRK7T1G+9YRaJrNzX6MCnKHWcF78A SklA== X-Forwarded-Encrypted: i=1; AJvYcCXh9VBfC+Yi2blvUi7suToPobYpQUzDP1EoMUMvDshOJMe0Qjl2VH44eC69eL5FziXC+0Pi5DlD0uI/N7eq+xn1+HQ= X-Gm-Message-State: AOJu0YwiUWHGrlTWOZy2GUm8htQua80uQWuYru4VKVHNnYhjghUSq1KT QTOwDiuX/qEtEtusk12ye+h4+Cb58vq86kCYlUnyPSqzaIYXCKuKnLAtQAGQ9bE5yi2YXPlkjOd 3m3/WD5YtHJucBfZ649ru0i/BnZQxq5FIZo7apQ== X-Google-Smtp-Source: AGHT+IEHsbdyc9+JywKTd0t0PpMsBEzeUY13uoyr7VftCkfS7u3Z4jvNXqxJorAsuGUNCeaWmG6E1b/MXJC0vpgD+7A= X-Received: by 2002:a05:600c:5601:b0:41a:adc3:f777 with SMTP id 5b1f17b1804b1-41feaa38ec7mr320385465e9.16.1716298884332; Tue, 21 May 2024 06:41:24 -0700 (PDT) MIME-Version: 1.0 References: <20240521114830.841660-1-bjorn@kernel.org> <20240521114830.841660-10-bjorn@kernel.org> In-Reply-To: <20240521114830.841660-10-bjorn@kernel.org> From: Alexandre Ghiti Date: Tue, 21 May 2024 15:41:13 +0200 Message-ID: Subject: Re: [PATCH v3 9/9] riscv: mm: Add support for ZONE_DEVICE To: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= Cc: Albert Ou , David Hildenbrand , Palmer Dabbelt , Paul Walmsley , linux-riscv@lists.infradead.org, Oscar Salvador , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Andrew Bresticker , Chethan Seshadri , Lorenzo Stoakes , Santosh Mamila , Sivakumar Munnangi , Sunil V L , linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtualization@lists.linux-foundation.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: DF60814000F X-Stat-Signature: mndcsmdp41tpoyfitxecehscs74unt3e X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1716298885-283339 X-HE-Meta: U2FsdGVkX1+6LpFgKKkh+Iz8CTViO0ufsDggfiGzEOBkhS9bBSYPP/PttPrZRaUyeM/gXkmIRgG5MNrmAjn+6tBbsP2qRVHSgsx+y4CSEiqNLOZqgkR9X3GvfYIKY+860qwWkLG0K7XXwQHaZWg0zAHdiCEQBH7tK/tTg03MXwdpjyw0rPRS6tu1vgSjc5d+y3eenwAc9J9NFnXMWAgdClYaUhhW1wI5vjgt7ktnZ7z3MdQaTJ99XkbsSicBsLIXvkpcVZus9Ud8174Etq4fIHzq7s3l9iwTkCcey3HiLJsZqFlK8xLnXpE2OyMLb2Da+wkuvllmxFTYcOYE4ladOW0sG+WSUVeDt6vr+aJ78CrVM4hWTIXIKCYIYmW4k7vEuzpgL0zOktT5iqjgOWCBfnnb3MsjrMZgYm9JiQ/p+C1BE4/sYDI74ENcKULGwtiP5toX9LeW+zGj6oJxJp3uGJ0gJbEZ5ac+4frs/PWOHWexMHEksYl2LSMua50LLcyXkvA8cYYUhlbSg99kpdTBi7xeyHp+9dlosPQMxs2NWH1cNVAeTakiTHbFiwyRzURlnVFOpTQKSlsVO8/kEHkupb94wECXg+Fyh18+qAlcyuTXgVRTB3420pgdt18FJgSE5Y5StyKK2yt1z0qEFMogt8WYNHvsYmQuBwnRCHgzANARV6J6jb9fXTW8OtDl7flDldaczSCTpVmo4AGyCVowq9Vl4xLIF+3pCvDBV5EoIQ9ykjvj7H9QKZaPDz+BClCpb6o/nbk/LK12yXV03KdfrJARm/xz4p2Lmof1FxFHnQAZqTNhS8rIMqUyz0NF0VrFsvzsiOy3NimuSPVFjBYmz0ejquX5aSWKC1+Lw3uO7QEPDpU8CZODPwhbERxaH4ZCmIUJr/3dWnAaipNp9D7XX80bW2izEEB8eVR5neJpP6JqhneDdPBM8oN1G9m2AJjDKgZTHUd0USAJELSZwbS WDJsm5w9 TsjrjeI3DwJyyixMQ/R/3+pqjYpg/mYz0ELPd/VveQ2OaGfM3x22EaZ+asTP5KOG9Fef+L2Yvj7euv1P/4cnGTfVPdUghi/KMU8Fe6CFNusZeS3ydjliP0z6fclJXnfF+cKYiMMixsjFvyTXWOpKcTUGG1gQNDiN23+yZ96sxJKUGC0QK92cyuY5NFMHLHp3BdVYjtJMHGVGinMsul7OnUEY93K64qQ66yGnWepJeAITzdBnrk0FR8JyI/I1/Rr11LndrTnEcKRucSfluuYptfiXw/oN1UTb0wt1YGhXy7kZ0KIkShX8Rb1y9s+eAfIyGw2AXWzTMdr2TsHSL5qYOyEzCwpyEjzhAuBQEVo/XeW/QyZdrKK78+U0ijJ7/63b7wds3GlKibyWKV9eNNNp0u1BhomcZqEMHGJoJSZ25G2xiXo0SjblfqwSs1Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 21, 2024 at 1:49=E2=80=AFPM Bj=C3=B6rn T=C3=B6pel wrote: > > From: Bj=C3=B6rn T=C3=B6pel > > ZONE_DEVICE pages need DEVMAP PTEs support to function > (ARCH_HAS_PTE_DEVMAP). Claim another RSW (reserved for software) bit > in the PTE for DEVMAP mark, add the corresponding helpers, and enable > ARCH_HAS_PTE_DEVMAP for riscv64. > > Signed-off-by: Bj=C3=B6rn T=C3=B6pel > --- > arch/riscv/Kconfig | 1 + > arch/riscv/include/asm/pgtable-64.h | 20 ++++++++++++++++++++ > arch/riscv/include/asm/pgtable-bits.h | 1 + > arch/riscv/include/asm/pgtable.h | 17 +++++++++++++++++ > 4 files changed, 39 insertions(+) > > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > index 2724dc2af29f..0b74698c63c7 100644 > --- a/arch/riscv/Kconfig > +++ b/arch/riscv/Kconfig > @@ -36,6 +36,7 @@ config RISCV > select ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE > select ARCH_HAS_PMEM_API > select ARCH_HAS_PREPARE_SYNC_CORE_CMD > + select ARCH_HAS_PTE_DEVMAP if 64BIT && MMU > select ARCH_HAS_PTE_SPECIAL > select ARCH_HAS_SET_DIRECT_MAP if MMU > select ARCH_HAS_SET_MEMORY if MMU > diff --git a/arch/riscv/include/asm/pgtable-64.h b/arch/riscv/include/asm= /pgtable-64.h > index 221a5c1ee287..c67a9bbfd010 100644 > --- a/arch/riscv/include/asm/pgtable-64.h > +++ b/arch/riscv/include/asm/pgtable-64.h > @@ -400,4 +400,24 @@ static inline struct page *pgd_page(pgd_t pgd) > #define p4d_offset p4d_offset > p4d_t *p4d_offset(pgd_t *pgd, unsigned long address); > > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE > +static inline int pte_devmap(pte_t pte); > +static inline pte_t pmd_pte(pmd_t pmd); > + > +static inline int pmd_devmap(pmd_t pmd) > +{ > + return pte_devmap(pmd_pte(pmd)); > +} > + > +static inline int pud_devmap(pud_t pud) > +{ > + return 0; > +} > + > +static inline int pgd_devmap(pgd_t pgd) > +{ > + return 0; > +} > +#endif > + > #endif /* _ASM_RISCV_PGTABLE_64_H */ > diff --git a/arch/riscv/include/asm/pgtable-bits.h b/arch/riscv/include/a= sm/pgtable-bits.h > index 179bd4afece4..a8f5205cea54 100644 > --- a/arch/riscv/include/asm/pgtable-bits.h > +++ b/arch/riscv/include/asm/pgtable-bits.h > @@ -19,6 +19,7 @@ > #define _PAGE_SOFT (3 << 8) /* Reserved for software */ > > #define _PAGE_SPECIAL (1 << 8) /* RSW: 0x1 */ > +#define _PAGE_DEVMAP (1 << 9) /* RSW, devmap */ > #define _PAGE_TABLE _PAGE_PRESENT > > /* > diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pg= table.h > index 7933f493db71..02fadc276064 100644 > --- a/arch/riscv/include/asm/pgtable.h > +++ b/arch/riscv/include/asm/pgtable.h > @@ -387,6 +387,13 @@ static inline int pte_special(pte_t pte) > return pte_val(pte) & _PAGE_SPECIAL; > } > > +#ifdef CONFIG_ARCH_HAS_PTE_DEVMAP > +static inline int pte_devmap(pte_t pte) > +{ > + return pte_val(pte) & _PAGE_DEVMAP; > +} > +#endif Not sure you need the #ifdef here. > + > /* static inline pte_t pte_rdprotect(pte_t pte) */ > > static inline pte_t pte_wrprotect(pte_t pte) > @@ -428,6 +435,11 @@ static inline pte_t pte_mkspecial(pte_t pte) > return __pte(pte_val(pte) | _PAGE_SPECIAL); > } > > +static inline pte_t pte_mkdevmap(pte_t pte) > +{ > + return __pte(pte_val(pte) | _PAGE_DEVMAP); > +} > + > static inline pte_t pte_mkhuge(pte_t pte) > { > return pte; > @@ -711,6 +723,11 @@ static inline pmd_t pmd_mkdirty(pmd_t pmd) > return pte_pmd(pte_mkdirty(pmd_pte(pmd))); > } > > +static inline pmd_t pmd_mkdevmap(pmd_t pmd) > +{ > + return pte_pmd(pte_mkdevmap(pmd_pte(pmd))); > +} > + > static inline void set_pmd_at(struct mm_struct *mm, unsigned long addr, > pmd_t *pmdp, pmd_t pmd) > { > -- > 2.40.1 > Otherwise, you can add: Reviewed-by: Alexandre Ghiti Thanks, Alex