From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40F08C25B10 for ; Mon, 13 May 2024 13:09:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C67156B0297; Mon, 13 May 2024 09:09:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C0CDC6B0298; Mon, 13 May 2024 09:09:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFAD66B0299; Mon, 13 May 2024 09:09:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 913CF6B0297 for ; Mon, 13 May 2024 09:09:30 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3E00880E7F for ; Mon, 13 May 2024 13:09:30 +0000 (UTC) X-FDA: 82113404100.03.BF25530 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by imf01.hostedemail.com (Postfix) with ESMTP id 5CC9B40005 for ; Mon, 13 May 2024 13:09:28 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=HT7Yf6Ao; spf=pass (imf01.hostedemail.com: domain of alexghiti@rivosinc.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=alexghiti@rivosinc.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715605768; a=rsa-sha256; cv=none; b=QHMIQAVtmmmw3HnW2ruxFpZTWY+arJcURV2blsA9sW9+CTMS9NgmnG+gcp2H+c9ImLSOJr PotwcdXMegzzqq8lg5TDaFCB7eQSk0XQDtlDUvYbjWoyumKgYbkucuUg7h2vj8fSn0Hvad RRGcrlKk9AC818v3oeYJbsNgJRWC5m4= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=HT7Yf6Ao; spf=pass (imf01.hostedemail.com: domain of alexghiti@rivosinc.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=alexghiti@rivosinc.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715605768; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5MKXjMChMNLDQEAHfT5KxNeT5FU7Py9gH+YOnRbraDE=; b=b5l1ujWLwAZrN/t2ECPmbzzjsQilmpaFdqdXxdgPV+LsmBlf+y8l/vev6ucp7ciU623G2L E4iz0e7pK93Woz2wMt+2MNex5bfc11kkYf3KBSww94w+xGcP3BCw/PzqCCtTVN9K9dOSdX +E8krQybv1IpaO8pbP/3X+nm4OBpdY8= Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-a59a609dd3fso745156866b.0 for ; Mon, 13 May 2024 06:09:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1715605767; x=1716210567; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5MKXjMChMNLDQEAHfT5KxNeT5FU7Py9gH+YOnRbraDE=; b=HT7Yf6Aomxcge6csASYBa4xj9tZuL1bJ+Q6v4K+mmxvTQ/tLhdMRMk7QjrnEzGXoyD pOHpxXS6t5Z8N1erTUgoPSVJ/NfglIg0aVtKwzLcZgAqpSRKdLL4isq1lrLVDu5vosD7 gJCpUfXI6OSBfc+bFKtnxj5WaU+vK9JRt1bxIF3ncTvIpoyE89F+ksCRunM0IQIizNia 8QiyMbh9tgX8UVRCzhnPWjOijRjjHx1tFg0gjNPrI3pn22kQBAvbllN9eVBejgDSLc2N ZX+FHEIaXuIQRYEo5bzvSsMyp5VAgF8r4skNArVh36NWXFNwhhQc2S63HDsnRhMprJM9 ez8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715605767; x=1716210567; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5MKXjMChMNLDQEAHfT5KxNeT5FU7Py9gH+YOnRbraDE=; b=bjEc250pzf091CPP8jV1fv+dLpL0zi/dSLjY4vWrwymWzsCjvU/7zNOGQ2cidPKSAP wlB7Asm3xb/9s65NSRAs6DeblIxZqcRHNakjK1mGvr50w0dGeC7nDqfBAK8PNZHkjRs3 eCulsK4bMIvSo0mH8YbbtSvVnQyA11EfY5jlHKec/yPxREnQ5MlgOhYaVBZzwh+Geiha XNP2LoR5AON8JhwSmnf5LGbdQQQVKqI2nCjPsILhEUHmSoLeZgTTqz1R7szWf1Cjm7Mu mSnGRjpN7HD/fGbdfTqEBZYqwLI3c9vReLLu3KSqoGaSxUOFabX7lJKuVrIpH9t9/gbI 7/8A== X-Forwarded-Encrypted: i=1; AJvYcCWjksgmMBkVntWV/H6jjZ+8/OfTOOP0B7FImemx1Wy5YuXEHbPYZxbfXaQugydM4eyvSLoH5VBJogC3ZYC1dqXq7iQ= X-Gm-Message-State: AOJu0Yy0AhXToxlm6UE+RMH/F2+nu6eM4XZ7I5SVq32/fJL4UneQWS5v mL58SyNc/oT5BLM+6tqK1i3gBUBvXrM7wrWP8RzNE19n8o3SOpWtOOUx7akFUx+mK4Ea40gIdAf xV+q8qtzOJ0LpxkZAg4qC5DZePM7nWaAukLSvUg== X-Google-Smtp-Source: AGHT+IE2QlkBf1B/qIqHvwWeBSEoU1R5RwhfvNE59sMHl2qimtxCkyusw1APubthP2zoyId5MUd15f47oIJVMuD1t0A= X-Received: by 2002:a17:906:ca8e:b0:a5a:7b88:8672 with SMTP id a640c23a62f3a-a5a7b888747mr3863166b.16.1715605766892; Mon, 13 May 2024 06:09:26 -0700 (PDT) MIME-Version: 1.0 References: <20240508191931.46060-1-alexghiti@rivosinc.com> <20240508191931.46060-2-alexghiti@rivosinc.com> In-Reply-To: From: Alexandre Ghiti Date: Mon, 13 May 2024 15:09:15 +0200 Message-ID: Subject: Re: [PATCH 01/12] mm, arm64: Rename ARM64_CONTPTE to THP_CONTPTE To: Barry Song <21cnbao@gmail.com> Cc: Ryan Roberts , Catalin Marinas , Will Deacon , Alexander Potapenko , Marco Elver , Dmitry Vyukov , Paul Walmsley , Palmer Dabbelt , Albert Ou , Ard Biesheuvel , Anup Patel , Atish Patra , Andrey Ryabinin , Andrey Konovalov , Vincenzo Frascino , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-riscv@lists.infradead.org, linux-efi@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 5CC9B40005 X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: o6mztpk3o5ocjoiec7ozr6bkigfwirae X-HE-Tag: 1715605768-584389 X-HE-Meta: U2FsdGVkX18sqGUmJ8rkLMnTAVIBZgUHr3vx8Nl5Mra0a7iZEEFPQ9Jc+v6MJwpIPvrwFSYVwnEKRS3vGI7eF/o+SUvrrvTwWCQkB49eU5oryK/cYqYgEubcJksjmoCXOjcgn1CVMVmeXU/vTK1w1oyhk7lko7tyVkbvBneSomgbjcOcaMo6lBDWscKkCjm3Q21m9jB2ut31V6Pj8Ym61EmsVvxqljYeuaiFlWNRZAcqGy651N3GKqcudMgHL1sqo6cwu1noQwiCNEJlbdCChyM5kA7+2JHvSadcgpT4jJnuoDvzoB3Op5NErzrHon3tHG0i5oAGwDsqcCfDCok9W7wf+smbAiI+RsDyNzo3TZgL2N1gp1m3RrI1YrkfqvT1hXHfKJF9kd1ms048gzvFAFRRrWz0aO/syGCgIwnebe6sR82HtNHTffl+wq0l8EbM4xfguB6glqthsnoOn93fTdwkdp7eKfxO1F0QFmUQ7rQXxOWyoAIDsMJMECt90wDV7wqpYwACrXQFkRqjMxzdMylADJkgfvwZe8UEFAJ8ObDl4p/3eMN2QS1mzG/JeTjugIjiWgf785zleX4EEnQlVfuvwLQdtKzl/fBeO5zmUTGtfuUZTmtcFGiIhzO6CqKXrPMBiyGwEKGzCQ4xWJ3DMMdgrWalfqzNQiHwWKvCeJdAnaWZ0/REXqe+HWHapuM3r2diGvA7kr2zUbi15mMV1TeamK5w+rCwh3BOLwogmu571OG1yTYVB0DHsyPXP8/ykpDMi8RApnEOzc6CLqOa1dfaoGiSS50Xpav5jKsG/Cy2K8nvUGLNkSOqZ0Af8nFtl/CZEDbGWzREZDvjE4UwnSFs3iFTci+TIAAz6/QeUgjVigXNcgiQicJ1OAUTFHhn7SBT0hwrYaR14qQ0avfr8rFrZKlGEItpS0+7hDgEdhFOO4A0WhJne/WvhAabpcxl1lDx8MxSePi/yAtzCnA vvh6JFV8 sMzJmrR3ZyY3G7N6+Rd7fLSpk6HagY93f3ZUt17iQXeYpVE77RBfUFtBFoKkCH10yhF1xME/HYQ4WYsw2OBgujYy8Nft1EGNgevOV+TjTz73Fejlr+PzNIPKv9q5yyXYAdO/vN39ITzMNDr4E0xwYm4NCeKRKZqU/JtHQEYC7K9Wvs2wqAX03WwFw08wBlu5xzpEfLcYVTyHR8SeIdmeAaUISJXSaz/gMFF+lfuMFXiTAFUDPUu98cEK4QpFah6nKt54TmO7/lcbGZWCoIDnugzCSTePJGxmS+HfeFofsgEX10mmA2lJI4uff8z6KRQIJuyQ4gSxhl3DkUR9IRapf2SSfMC3xzA5icESlv9dNKAQ1OgL7P0AlIEmwjmtetQALyZMJ/nhQ0D174xJWp0uC1QK9dGsvvC7iINwniXXrkkm9R/6jXS7N9bNWx7p6n29KcdHXf1evI4Sdb0ouJxXerH7xFOedS7jHNsfKsyM+D8zO9VD7KVOS9adedmjAv25/8E+PFVTBoeoB1W1Sgw1+AzLUax9OYrJ33z/rpYWrH3hfeU6hY+K9RjwxRXB/DyRE+mhFsDRNz2vPby9oqH28cylHBg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Barry, On Thu, May 9, 2024 at 2:46=E2=80=AFAM Barry Song <21cnbao@gmail.com> wrote= : > > On Thu, May 9, 2024 at 7:20=E2=80=AFAM Alexandre Ghiti wrote: > > > > The ARM64_CONTPTE config represents the capability to transparently use > > contpte mappings for THP userspace mappings, which will be implemented > > in the next commits for riscv, so make this config more generic and mov= e > > it to mm. > > > > Signed-off-by: Alexandre Ghiti > > --- > > arch/arm64/Kconfig | 9 --------- > > arch/arm64/include/asm/pgtable.h | 6 +++--- > > arch/arm64/mm/Makefile | 2 +- > > mm/Kconfig | 9 +++++++++ > > 4 files changed, 13 insertions(+), 13 deletions(-) > > > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > > index ac2f6d906cc3..9d823015b4e5 100644 > > --- a/arch/arm64/Kconfig > > +++ b/arch/arm64/Kconfig > > @@ -2227,15 +2227,6 @@ config UNWIND_PATCH_PAC_INTO_SCS > > select UNWIND_TABLES > > select DYNAMIC_SCS > > > > -config ARM64_CONTPTE > > - bool "Contiguous PTE mappings for user memory" if EXPERT > > - depends on TRANSPARENT_HUGEPAGE > > - default y > > - help > > - When enabled, user mappings are configured using the PTE cont= iguous > > - bit, for any mappings that meet the size and alignment requir= ements. > > - This reduces TLB pressure and improves performance. > > - > > endmenu # "Kernel Features" > > > > menu "Boot options" > > diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/= pgtable.h > > index 7c2938cb70b9..1758ce71fae9 100644 > > --- a/arch/arm64/include/asm/pgtable.h > > +++ b/arch/arm64/include/asm/pgtable.h > > @@ -1369,7 +1369,7 @@ extern void ptep_modify_prot_commit(struct vm_are= a_struct *vma, > > unsigned long addr, pte_t *ptep, > > pte_t old_pte, pte_t new_pte); > > > > -#ifdef CONFIG_ARM64_CONTPTE > > +#ifdef CONFIG_THP_CONTPTE > > Is it necessarily THP? can't be hugetlb or others? I feel THP_CONTPTE > isn't a good name. This does not target hugetlbfs (see my other patchset for that here https://lore.kernel.org/linux-riscv/7504a525-8211-48b3-becb-a6e838c1b42e@ar= m.com/T/#m57d273d680fc531b3aa1074e6f8558a52ba5badc). What could be "others" here? Thanks for your comment, Alex > > > > > /* > > * The contpte APIs are used to transparently manage the contiguous bi= t in ptes > > @@ -1622,7 +1622,7 @@ static inline int ptep_set_access_flags(struct vm= _area_struct *vma, > > return contpte_ptep_set_access_flags(vma, addr, ptep, entry, di= rty); > > } > > > > -#else /* CONFIG_ARM64_CONTPTE */ > > +#else /* CONFIG_THP_CONTPTE */ > > > > #define ptep_get __ptep_get > > #define set_pte __set_pte > > @@ -1642,7 +1642,7 @@ static inline int ptep_set_access_flags(struct vm= _area_struct *vma, > > #define __HAVE_ARCH_PTEP_SET_ACCESS_FLAGS > > #define ptep_set_access_flags __ptep_set_access_flags > > > > -#endif /* CONFIG_ARM64_CONTPTE */ > > +#endif /* CONFIG_THP_CONTPTE */ > > > > int find_num_contig(struct mm_struct *mm, unsigned long addr, > > pte_t *ptep, size_t *pgsize); > > diff --git a/arch/arm64/mm/Makefile b/arch/arm64/mm/Makefile > > index 60454256945b..52a1b2082627 100644 > > --- a/arch/arm64/mm/Makefile > > +++ b/arch/arm64/mm/Makefile > > @@ -3,7 +3,7 @@ obj-y :=3D dma-mapping.o exta= ble.o fault.o init.o \ > > cache.o copypage.o flush.o \ > > ioremap.o mmap.o pgd.o mmu.o \ > > context.o proc.o pageattr.o fixmap.o > > -obj-$(CONFIG_ARM64_CONTPTE) +=3D contpte.o > > +obj-$(CONFIG_THP_CONTPTE) +=3D contpte.o > > obj-$(CONFIG_HUGETLB_PAGE) +=3D hugetlbpage.o > > obj-$(CONFIG_PTDUMP_CORE) +=3D ptdump.o > > obj-$(CONFIG_PTDUMP_DEBUGFS) +=3D ptdump_debugfs.o > > diff --git a/mm/Kconfig b/mm/Kconfig > > index c325003d6552..fd4de221a1c6 100644 > > --- a/mm/Kconfig > > +++ b/mm/Kconfig > > @@ -984,6 +984,15 @@ config ARCH_HAS_CACHE_LINE_SIZE > > config ARCH_HAS_CONTPTE > > bool > > > > +config THP_CONTPTE > > + bool "Contiguous PTE mappings for user memory" if EXPERT > > + depends on ARCH_HAS_CONTPTE && TRANSPARENT_HUGEPAGE > > + default y > > + help > > + When enabled, user mappings are configured using the PTE cont= iguous > > + bit, for any mappings that meet the size and alignment requir= ements. > > + This reduces TLB pressure and improves performance. > > + > > config ARCH_HAS_CURRENT_STACK_POINTER > > bool > > help > > -- > > 2.39.2 > > Thanks > Barry