From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4602BEB64DA for ; Thu, 20 Jul 2023 07:01:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A557C2800BA; Thu, 20 Jul 2023 03:01:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A05F928004C; Thu, 20 Jul 2023 03:01:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8808C2800BA; Thu, 20 Jul 2023 03:01:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 74D8228004C for ; Thu, 20 Jul 2023 03:01:01 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 32D80B0A1F for ; Thu, 20 Jul 2023 07:01:01 +0000 (UTC) X-FDA: 81031093122.27.DB26ACF Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by imf10.hostedemail.com (Postfix) with ESMTP id 1C8B5C0010 for ; Thu, 20 Jul 2023 07:00:58 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=rivosinc-com.20221208.gappssmtp.com header.s=20221208 header.b=1MfTo46H; spf=pass (imf10.hostedemail.com: domain of alexghiti@rivosinc.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=alexghiti@rivosinc.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689836459; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3ZEjFz7LOZdmaaeUrHv50TFnsXpX5R1v3ht7TZZ808M=; b=SlXNjBhTQPUGBO0ZsRbv2mqlv6apCEjR1PbEAJiG3IXBXD4hWXPIrryFztpfPrnVrCwJCF o1QD+C8R9GPbhhxVA3xBopJRdLGoosJqGkcsPyum+xj3vVbEbQRwFJL7zzaUjb4IK8gdwQ jAPMxSei8fJB70LD1DQZGe4akEk0MPw= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=rivosinc-com.20221208.gappssmtp.com header.s=20221208 header.b=1MfTo46H; spf=pass (imf10.hostedemail.com: domain of alexghiti@rivosinc.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=alexghiti@rivosinc.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689836459; a=rsa-sha256; cv=none; b=RWSMrkwVCkfSNtPCS+g6MlojPbs8r6GHls987mptyJg5F1R7aTDe3c30uPHQ83Zv20a6uC 8Ld0yYU1MmPdJT10QOkEEJRTxbIlMnl7ceUnUlHImaw0P9HHIbJT22r0cU+QxHqhiu/fCn CZpU2T+QYgBWf0nXeEjUoi17Hpu+UaI= Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-314417861b9so319151f8f.0 for ; Thu, 20 Jul 2023 00:00:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20221208.gappssmtp.com; s=20221208; t=1689836458; x=1690441258; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=3ZEjFz7LOZdmaaeUrHv50TFnsXpX5R1v3ht7TZZ808M=; b=1MfTo46HP0GNpJ9cJoyU1w/4UKVOAFz6QpJ4q70QXZNvjfL/YVfMgjHYqRYUSAxHDc jTtWwxIaJkGms8cWTugFcMm3Mz/kMh171waQTUmVGUrnhWRdSZZAnopxNT52sGyk4Vhr JccuRh1ReQQymlnZdjxbyC4YAll5dWm92TQo+/lCGQexj5cQvGKHZ8hgObMHOvGcBNKc O5YUKLp3tsmyVHte9MmjUkozGnbFeFs6ggXSUOdv86CnBPa+ITw35RBr4dJ9ncycHteI yoBB4mBa6g7bQWRNx+/Wq4Kah+D6A8vPku4/YRJO5RvDvi7ldgcJ20Ijhjk2fCg6Vb/c pjSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689836458; x=1690441258; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3ZEjFz7LOZdmaaeUrHv50TFnsXpX5R1v3ht7TZZ808M=; b=RN6H1NRdzwi1VAr9DJLyNwkWjVlrFo0e6l2dDtth9cnDJ15FHmHECIJXdUXm55Za2l ryuuFygEJCuuHPOJnvBthI5U1h7uqwsZler71MekkEqM3BfofceIy7zigQmXe1y++RPz IXGt96fei400He8zDuM+/9G7iYu3BMFT2VGNhXxXpiQk74wRDV0gcOxkS72L+wDv5Wxf nRp4Kq1oo14Kk1LtQId39/3AqDeS8UOEJOrsg0ex4fb/+4ooN9jno0pt43RdkvFnqqyf 9jsVSzJ5Cns1h39R3cFavdxT5kIfkXK4ZkFqaz+nDvk8ReXl5zfutfuNPap2p3JeUhhb Uiuw== X-Gm-Message-State: ABy/qLZlYeoKvOJXWTqt5SXR82wSeZGFTA2hkN0KOj+QZGIGf5vpbbjW JFCuPU+lpdrColXak6Ro9CyeNmgjkcjuZRHBgTC0BQ== X-Google-Smtp-Source: APBJJlFTDTlY08cieS+z3W0RyAq1pip8zIDcg55w3AOM8lXoEXjLTyl+gVgmTMjFP8mz/ktC3zk5jdu+9sPkK0WnKYA= X-Received: by 2002:adf:e903:0:b0:30e:3da5:46e5 with SMTP id f3-20020adfe903000000b0030e3da546e5mr1830181wrm.59.1689836457755; Thu, 20 Jul 2023 00:00:57 -0700 (PDT) MIME-Version: 1.0 References: <20230714165508.94561-1-charlie@rivosinc.com> <20230714165508.94561-4-charlie@rivosinc.com> In-Reply-To: <20230714165508.94561-4-charlie@rivosinc.com> From: Alexandre Ghiti Date: Thu, 20 Jul 2023 09:00:46 +0200 Message-ID: Subject: Re: [PATCH v6 3/4] RISC-V: mm: Update pgtable comment documentation To: Charlie Jenkins Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, conor@kernel.org, paul.walmsley@sifive.com, palmer@rivosinc.com, aou@eecs.berkeley.edu, anup@brainfault.org, konstantin@linuxfoundation.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, mick@ics.forth.gr, jrtc27@jrtc27.com, rdunlap@infradead.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 1C8B5C0010 X-Rspam-User: X-Stat-Signature: 7bsyiq94zde3dowb8idfuy3qp4jpk74k X-Rspamd-Server: rspam01 X-HE-Tag: 1689836458-931348 X-HE-Meta: U2FsdGVkX1+L/D7BAT7OxEaD2H3p9hxm7GGD+7dHdH5y+45M58kx+2Sc9kaYF0BNHmJYVHYobyvjMFxyV/IOvo5OMkQYWbIcog5I6ex5cRcQOn6PWS3sojcib/aV4mY/Lc6c51P8ascQsiebxP5eukRcA/O1JMHbNV6x0vN+Up4Z29oYfixW386Jb0GBvUQU/icJH2Kg0zqM8J2iQyar0IMHollP+LLf50cWyuX95tp2ngg4QwsEV3OsiaLJWJhe0O6GWWQHLD3gB71a158h2BidheBDuV9OaMP82k30NMcEVw5o96oPwDczYVsWk4S08av0weDEnhIw68p/gEvlk9LugiGMPIax8dX0+AWOlVYuMwLIDcqued8H4mBW4SPI80IjPD78w5IRhlqgksCUe8GLB0yRpoqrORrXzLSByvShb1e/z2d4CWkJJ3rI7FfxKrHX8TronwqtKEe3fMxZzBTIfqoS+Z9XVvVLRgybqWRur32BK2XtHRQCSDhLxhTn4NL8KAMKci5akAwNFxPd6XszfsKJdB5+JRb/tVXwnMMa5/Bn2a1t3wQbYLnXhNVwOsSjbcXegdGymcD4yFrtKjSQejD8iL10i9oSkrGzqpHZvVzpv/HdQ9H9cskwGJeQW4I6iJGy35glHFPNbAVFhvbmMkmZGsSyo+HIbhQOxTEClXMxhN11oyuB0Tqc0vMbhwbtfHhWmF8raIWvPMfUS0+TuHcURGO7t43JWVXuPwfU3Y0LBPm4JCFNFfySVhacGff1pW0NXOs9nuqzB2UqczcPoTuAnbXLpC4/aBwKM25rG9KwSJRbrZBLAJaTF4b0eQ30MzcS4PDt4EP3cdkn90W8Kz6aV/nTEN+hVhwZayGhxSs++x+fDwvV9mdxxUtlu1uliFks6z6mQclcDBOZFI3RarVqkXzwF2zHNw+zEDt1jt+wQGnYqbn6Et9ik0XVapeLD2IZ9grrh7nMaJg wDqsfREY UdGb23+IilttlJVLH+6ukY9SANirmLSymuS2znZc4/8G/PWHvteMKFTSs+6lmGO54dc/E1PtuW73pQeczA6UD71qxFPNy/pk3Y4Z3mbjPlh+nIG4v4QPuseLT5Oon+KjrBd0nXWIHGxIHrNcvM2rq1Iq5h37joEhKu0uQ+dKssCdLlmXloIVtm1DrLPNBkGZx76EL1iSlXeot2b8LNko8dReld0Fo0KJcFVkQRevjWvVSC4SBEC9lU4iuHiaWsz6YvpAP0H4hghm6lVfKNZsl8bkRZAMzgJpugr42xgxndYo/xmrLhR0i7OfEf4J6hNpVwDitPXyAq1a4jzM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.019248, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 14, 2023 at 6:56=E2=80=AFPM Charlie Jenkins wrote: > > sv57 is supported in the kernel so pgtable.h should reflect that. > > Signed-off-by: Charlie Jenkins > --- > arch/riscv/include/asm/pgtable.h | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pg= table.h > index e13f5872bfe9..28660bab754c 100644 > --- a/arch/riscv/include/asm/pgtable.h > +++ b/arch/riscv/include/asm/pgtable.h > @@ -840,14 +840,16 @@ static inline pte_t pte_swp_clear_exclusive(pte_t p= te) > * Task size is 0x4000000000 for RV64 or 0x9fc00000 for RV32. > * Note that PGDIR_SIZE must evenly divide TASK_SIZE. > * Task size is: > - * - 0x9fc00000 (~2.5GB) for RV32. > - * - 0x4000000000 ( 256GB) for RV64 using SV39 mmu > - * - 0x800000000000 ( 128TB) for RV64 using SV48 mmu > + * - 0x9fc00000 (~2.5GB) for RV32. > + * - 0x4000000000 ( 256GB) for RV64 using SV39 mmu > + * - 0x800000000000 ( 128TB) for RV64 using SV48 mmu > + * - 0x100000000000000 ( 64PB) for RV64 using SV57 mmu > * > * Note that PGDIR_SIZE must evenly divide TASK_SIZE since "RISC-V > * Instruction Set Manual Volume II: Privileged Architecture" states tha= t > * "load and store effective addresses, which are 64bits, must have bits > * 63=E2=80=9348 all equal to bit 47, or else a page-fault exception wil= l occur." > + * Similarly for SV57, bits 63=E2=80=9357 must be equal to bit 56. > */ > #ifdef CONFIG_64BIT > #define TASK_SIZE_64 (PGDIR_SIZE * PTRS_PER_PGD / 2) > -- > 2.41.0 > You can add: Reviewed-by: Alexandre Ghiti Thanks, Alex