From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3303DEB8FAF for ; Wed, 6 Sep 2023 12:18:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC0B144015F; Wed, 6 Sep 2023 08:18:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B707844015C; Wed, 6 Sep 2023 08:18:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A37DA44015F; Wed, 6 Sep 2023 08:18:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 90DA444015C for ; Wed, 6 Sep 2023 08:18:50 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5708DC0B69 for ; Wed, 6 Sep 2023 12:18:50 +0000 (UTC) X-FDA: 81206076420.06.F848D5A Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by imf15.hostedemail.com (Postfix) with ESMTP id 7AB19A0037 for ; Wed, 6 Sep 2023 12:18:48 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=eleljsHp; dmarc=none; spf=pass (imf15.hostedemail.com: domain of alexghiti@rivosinc.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=alexghiti@rivosinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694002728; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uCatPaNtALkNNK4KsoXQ8WAXqz9RrcLBBDmwLPI3Vw0=; b=4DmySutkFyNtpLUjhmyzc12W8350dt/Y0G1LvQfEI4WymDTgnJiOUugL+T43WKYzFUZLoR rs20XUz5hp7+AnxRYfUtZGmSGCjblEpEE+d0oqs1YCKh7o7Er2J9OBe3YhEBsFg75cRI5s +bExPu/2Hekdkt8oW1Qe8hfZmE6en14= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=eleljsHp; dmarc=none; spf=pass (imf15.hostedemail.com: domain of alexghiti@rivosinc.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=alexghiti@rivosinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694002728; a=rsa-sha256; cv=none; b=L3eGfRMrnINZ8iVy9chR7f0NKo20zSI8ZKr6RsYWivGwYZnmpNa+jVcL4N+KkuMF0kLyV9 b8uwnhdlweGg8dRuzRHS5uluamh5i/j4sDn3E0C3ikL2QtY5aPR5PdWyOdjWD35uQ1u/xo 1wuUFFB0VbfTKmD2qL2Pbn+zkvAFM74= Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-31427ddd3fbso3000114f8f.0 for ; Wed, 06 Sep 2023 05:18:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1694002727; x=1694607527; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=uCatPaNtALkNNK4KsoXQ8WAXqz9RrcLBBDmwLPI3Vw0=; b=eleljsHpcdhXf/vP5TZMYYdTV/LduQ7DdNQq5Epcp0SIyBAHVijudCXhiUZcA41V7K KAzS5UOhWjQkQojyuLdrSxFb+tgvQINgTItjwP0myQNTmq5shWW03kM2NyVME9pnYxiL X+OrJjAKfXnLDFzSF46/0wNj3WKyahz0NL73Yq2dbIlPOW7F/paJGEL8Ir2RpxCwFa2x M+NWIHrrubP++zum90RiIsUgE1l6VRaMmVHb9oFFKYVNFENG5jf/6fjPV1AbBby7QPZq wqxXTyVomzUVdpmTwV0+nhtt7bOqFmDukrqi/B25GNbmzajVeUUS7R7tFZQHXx+D2FFd uhQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694002727; x=1694607527; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uCatPaNtALkNNK4KsoXQ8WAXqz9RrcLBBDmwLPI3Vw0=; b=UyPXgZ8cjqZc7yEJ0KdY6WLMMbNf8OF7W+joxatcGDSQ+SJp5glTrx0RoORdI3bqLs a2QprqC2ZNo49UOSaFxmC5p1jjSjWSyRx4HcAJk69QuNEAObpah5CfDhPij3SYQdlAFz O2eGECiWKrB4GnWFx0t6aVvVsStWeTA6h3mjNZroLBFlGNfAKTRg/gaLeJVp8KrsfDkG jhLF//99O8iB70ri8/J6pf79b74wX/DXfSNeU+1aw1qH5HOaCSx+h1CSTbsGahvfzKk5 ErMkI43oDUIvqs9/ODnyQ4L9HQ745N1ptzwsauSuh1AmrKMapaGpa+ldQVCN7QbQTKmx /82A== X-Gm-Message-State: AOJu0Yy81hv9bRxnMbW0o6T/pBxCGl4MM+gz1u3VYHQPp7b6ZhXVkXxB 6HfYQ8gwa1qce81nubmnvNpy5fxjGpkonUrXPUEOVQ== X-Google-Smtp-Source: AGHT+IHr5EDmAZjNEiPKlcvR7awkoi1CNbTcJGcicRFsNZbpcWizj4wm9k/5LZIJTpywY2sKGNbDzYOdptyCzoRBUHk= X-Received: by 2002:adf:f011:0:b0:31c:8257:2c78 with SMTP id j17-20020adff011000000b0031c82572c78mr2105408wro.52.1694002726940; Wed, 06 Sep 2023 05:18:46 -0700 (PDT) MIME-Version: 1.0 References: <20230801085402.1168351-1-alexghiti@rivosinc.com> <20230801085402.1168351-5-alexghiti@rivosinc.com> In-Reply-To: From: Alexandre Ghiti Date: Wed, 6 Sep 2023 14:18:35 +0200 Message-ID: Subject: Re: [PATCH v3 4/4] riscv: Improve flush_tlb_kernel_range() To: "Lad, Prabhakar" Cc: Geert Uytterhoeven , Will Deacon , "Aneesh Kumar K . V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Mayuresh Chitale , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Andrew Jones Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 7AB19A0037 X-Stat-Signature: cxqw9igko91u4tca9iyxy7bbtwimntku X-HE-Tag: 1694002728-665545 X-HE-Meta: U2FsdGVkX19rAi7/DV5Dna3vyCgSvywnr/APVgKbxLqHkDFQ/1tIKpRHmHFyCuAZJ2sfhE6lVHPnMxJHqJ20j+XtWInzSPVmO3BinU3zJMxlLoedBzDuLLbSJSooS2t9O03AiP7mvnwKBysOYZ3St27Div9GAh5VWWK4ykQdETxteuh3YzzKwTIR/flxGy2M8u/WXPhz8pclnmmOll/QD6jHwIwew8ErmIzqB2GGmtRrKtw1h2QxYkzFIDOs0wsz77ZaqWinw3b7M0ljUp8u/Dkam27cTRjNBmY9zmD83Zkz6GIGGQmCMz9MexsMMjrH1krSFU+qK98sRrgya9cv8ngGCXcjmzc9KR7TXzsMzxSkwsUul6aQMVOXyfN7YZAAWcvpAz8PBQwjuAThfmv5tn3ir92TZFfp/Lm/fRu6b0R/vMcHWYIsOAuys8AuBjH2lOrZZcR6c0/ulBjmMoijCx/KH+r7GMr5JpuCT9WdiL5UQUb+4OtexrlH+le1yKvT03UVVwNF0eBR9nfdcYn0UOdOEDYXefaynzZNq9MUBinUtSqel1kRtod+acs+53faz4Tph5RZf+6k0R4KEv6zhuOeEo1EPbyuMvHsw/aN2TJ5nZaaMGxUdHyv54XvuzL++1DsKdMcstmMLqMuKT7SbWNhn8xyRMVsuzI4Vu8mgT/SYY9VsFSMPRDmd0A8eq8AlZwcZiAjQA3G2SYeMKHKGS+375gVE4eXs4VKDfki7wcqcIUz+MgSp3VYlXz42wuuY1Yzz91gE/tKlkG/QetPZ69eOWjJQpIccyFkfIVbFqWlx2bdQtRrqkb/qC4C7nacJ4egXeHmam6gdSpcQ6m/xHmEZiuQ2CazYdZbBCP2T8RYva7bY7sDWkTHVgZmmZyuEs6DgEE+MbvMvjhbMK7misMdD/PdLX8Q25RaRxdC2xdLRs8JLwkvDmBvXaEB3zPNROdBN+1TvN/vXNzPa1v 9mY+R+nu hc4EIs0j5GbQGaAavyf3D5+fNpQGTTXbsl6u06SHvLQA2imWLvtnyFVWr7BRxth2gEVubCZQ5fdwTjaoJHu3krVN3iUeTzfCWAMEkyL6mMQEhvyW9LYM6HABzkuqveNvYq0Ux+uGSg/G2hpSi3QRfhOb4fp/FOvx/jk+niZYN2M96oXN9neFYCsKwhe/aKZweBEcfZjwfia2IUCHDozTQX0fbhGb3qlPdat5hoxXw9UyCi2w9Xf/af6JnkzSe2D/+a3a4ynxjc3SfpR1titSGUh/zv71hQxRC+RKkngasm5I8itMQoZX6eFjw/d1gaOuYQslI1GtbANgKwxMabG2NeLeFfPbDmyOnUUhSq7y/mx/2EbIQPETGoxjts+hnX0EIhm0IRccCBZCZCjFCqdRsShh8CK/9V8Qjl5dt9L6PtUGWF1hTj5Tssw7/CUKn5bIM11eKDyEcivuPFN5biZHagA9T4SkFnVBvqk81kY+XlIYoEjdzEA9jHjXE4nMcFSwHWC2RBIl22Bi//coWtF5iN0VccSpRlB1b5UEDY3be3ITTxLkAPnnjy/fsvQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 6, 2023 at 2:09=E2=80=AFPM Lad, Prabhakar wrote: > > Hi Alexandre, > > On Wed, Sep 6, 2023 at 1:01=E2=80=AFPM Alexandre Ghiti wrote: > > > > Hi Prabhakar, > > > > On Wed, Sep 6, 2023 at 1:49=E2=80=AFPM Lad, Prabhakar > > wrote: > > > > > > Hi Alexandre, > > > > > > On Tue, Aug 1, 2023 at 9:58=E2=80=AFAM Alexandre Ghiti wrote: > > > > > > > > This function used to simply flush the whole tlb of all harts, be m= ore > > > > subtile and try to only flush the range. > > > > > > > > The problem is that we can only use PAGE_SIZE as stride since we do= n't know > > > > the size of the underlying mapping and then this function will be i= mproved > > > > only if the size of the region to flush is < threshold * PAGE_SIZE. > > > > > > > > Signed-off-by: Alexandre Ghiti > > > > Reviewed-by: Andrew Jones > > > > --- > > > > arch/riscv/include/asm/tlbflush.h | 11 +++++----- > > > > arch/riscv/mm/tlbflush.c | 34 +++++++++++++++++++++++----= ---- > > > > 2 files changed, 31 insertions(+), 14 deletions(-) > > > > > > > After applying this patch, I am seeing module load issues on RZ/Five > > > (complete log [0]). I am testing defconfig + [1] (rz/five related > > > configs). > > > > > > Any pointers on what could be an issue here? > > > > Can you give me the exact version of the kernel you use? The trap > > addresses are vmalloc addresses, and a fix for those landed very late > > in the release cycle. > > > I am using next-20230906, Ive pushed a branch [1] for you to have a look. > > [0] https://github.com/prabhakarlad/linux/tree/rzfive-debug Great, thanks, I had to get rid of this possibility :) As-is, I have no idea, can you try to "bisect" the problem? I mean which patch in the series leads to those traps? Thanks! Alex > > Cheers, > Prabhakar