From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE1D2CDB483 for ; Thu, 19 Oct 2023 09:06:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 512638D0196; Thu, 19 Oct 2023 05:06:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 49AF18D0019; Thu, 19 Oct 2023 05:06:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33B4E8D0196; Thu, 19 Oct 2023 05:06:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 203108D0019 for ; Thu, 19 Oct 2023 05:06:58 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C5464A0619 for ; Thu, 19 Oct 2023 09:06:57 +0000 (UTC) X-FDA: 81361631274.07.062923F Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by imf16.hostedemail.com (Postfix) with ESMTP id E724418000D for ; Thu, 19 Oct 2023 09:06:54 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=n+2xBB0h; dmarc=none; spf=pass (imf16.hostedemail.com: domain of alexghiti@rivosinc.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=alexghiti@rivosinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697706415; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yTzH6q/KHuyR0ZINbw+hcjZ5+0x6X/p2cjmFJ06sw1g=; b=AOoJoDZTlfKBUz0M0KmM1vfQZ/zH9VKpfHpkWqjZbW9Bjx2m4aZm2ke/YobYL9n/9m6ixc 2VHTOMOF7L3pNg7fHGBl3BBjaTQn3u0MicjK1najxSKbefNpx46i8qRMLxr0/Xe7Ss1fKV 8x8lHm72pQFFR/4RlWbFg6zEmbF/zMc= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=n+2xBB0h; dmarc=none; spf=pass (imf16.hostedemail.com: domain of alexghiti@rivosinc.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=alexghiti@rivosinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697706415; a=rsa-sha256; cv=none; b=O++9Z6g2TWcpZmEP7j4QqLZvvhLvAib5f1rpFM+u7uRQu7wnu3Yb762GMSZ/37bEQ5bGn8 N4MwlHqhtnfaTIDseZI9lE5fu4XYKIy0wNYmdoBTLktdsX/5dZJwY2NDqM7pKxgK+SQDoF Oec5cbiz6tT0JCMm3gwEW3OING3tTdI= Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-32d885e97e2so6922534f8f.0 for ; Thu, 19 Oct 2023 02:06:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1697706413; x=1698311213; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yTzH6q/KHuyR0ZINbw+hcjZ5+0x6X/p2cjmFJ06sw1g=; b=n+2xBB0hZlW0wh6q2WBwL/drTpoFfzXitwIuWBvr7JcPw2uDiPO4JKh/erv0Uu7RDY GfKFPFh0PSgYXzA1KpW9j12FKO8NAUyEO0soX/kjQvy9FwRHfi9SPuQt/AkP1azfmano KIQp2dcKSjGId8euS66jxUz69wOgjJ3sBk65nV/3n7w3/4gWNKjXuSkK27YIDvLO4QxK GtKNsmyS5ZnUrgxVYhNE+kh02wvMS2AavAtZMqZ+pbDhdwOheTBCWj2+mK+BjUNdaAGg wt1NWn9ixU6iW5p2jsCv4VlocZwpwPgvjYVHSpsLiIvv43G5HVmIzjvPF7HBSqmKc6jl jG8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697706413; x=1698311213; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yTzH6q/KHuyR0ZINbw+hcjZ5+0x6X/p2cjmFJ06sw1g=; b=EtEhjSbStYvzpMZbVaL1/TA3x8CG+UVNH1ldPLrVxwhYY0410oPez1H2l/QHKi4stP xvHYZ4ha9o2J+Q1ct3ISsXFkYWgk3HBUmqa1mlt9/WXgr4dqlHbUuQeXLHh5XaFKFOYo rzDinqx953/3d9Ald+QB/pco5tgOAWFM8D0cUuEE0SQougGQb3gSqlE7YIqRFnpW/PPK NjkfBOtx67YX+7LQqnqw8YTFSXVxT/HudLQ2Q5re2gdLMSAlW3I3pO/XEv5hiMaW+ml1 HIlMnuf96NeBiW1m4IX6iYiylpxoHEkJgrTgLEoty+mJGfiSc9K+CVSkPY6c3UUIJm2u TEig== X-Gm-Message-State: AOJu0YznEg3UCbrO/cKoMjyCgdofBfxziZBBuekhnIDUPx22yUVX8TZD MbudqBdPprpAcFdpfEYdnTquCP8vtkwqyXRwktGFzg== X-Google-Smtp-Source: AGHT+IHSkQS9qNtpAIEMi6sxLaFTkgi+j6Rf7WXRtDe59N4GEvIdt/PZ1MtRQGPplsiQPNtP0AvAANDdTsTJLGZENEE= X-Received: by 2002:adf:db4b:0:b0:32d:b06c:80b5 with SMTP id f11-20020adfdb4b000000b0032db06c80b5mr1127928wrj.2.1697706413344; Thu, 19 Oct 2023 02:06:53 -0700 (PDT) MIME-Version: 1.0 References: <20231002151031.110551-1-alexghiti@rivosinc.com> <20231002151031.110551-5-alexghiti@rivosinc.com> <20231012-envision-grooving-e6e0461099f1@spud> <20231012-exclusion-moaner-d26780f9eb00@spud> <20231013-19d487ddc6b6efd6d6f62f88@orel> In-Reply-To: <20231013-19d487ddc6b6efd6d6f62f88@orel> From: Alexandre Ghiti Date: Thu, 19 Oct 2023 11:06:42 +0200 Message-ID: Subject: Re: [PATCH 4/5] riscv: Suffix all page table entry pointers with 'p' To: Andrew Jones Cc: Conor Dooley , Ryan Roberts , Alexander Potapenko , Marco Elver , Dmitry Vyukov , Paul Walmsley , Palmer Dabbelt , Albert Ou , Anup Patel , Atish Patra , Ard Biesheuvel , Andrey Ryabinin , Andrey Konovalov , Vincenzo Frascino , kasan-dev@googlegroups.com, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-efi@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: E724418000D X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: r5xbujhsnys5b8sxpmkjggshftb9qkaf X-HE-Tag: 1697706414-881777 X-HE-Meta: U2FsdGVkX1/GweO9bmF/SJeW/5JT2gwGUp2np3DOYywo0u/G5jmx8FRj7SPFsOWxpridNbpLl5/+WzcHMAucrPMKuySVQxW6UsYg1O7pw/M5rFnRjs35hvs3EEkVafuzoAE1PpHTlxtCGY/j4CV+qi9wI5Eo7YnRDgRUwpLVkfZUtF9ScRi/BPpWLZAb/aiE0q9IQq7VK4jrSmHYXv8j1eoFxDVlnV/WCiVVlj38Wq6KriMiDXa7GIxUrcPE9SwRljtUd44S2wfwpzJCUhDferh9MpkgkacJNa5EsMeL7kptQ/Q+o8EmTqVRBnsjEqXItUUyBzrKbBf6YEDYfC3OGBEf7Kl6ZJpKpB35KdPpA5opPozNj2nONoVM8hefLEMAgwGtCndkGsDJejVwOdBSLr1aS7MaZrZ20zu8ncAY0wbeLsf2sjaVTqBDPz8aTDLZL0ATpqs5/PYoSwGVTkQiRXOYMvJo+VXy6H5VW4j4FANrSMJCFRxBWh9GFarxsfgpa4CHjkEvp6srgtOD5Inku4DJJTIRZYfyRA8hw9kumoebB0WlLKlpGkosJVMn3NfkObdj4wtesr0IXJWQ1vQSMw35979U+dLConAn6reX87OVbG2pSPfxyYKdmNoNbK6mKaeGiyjxQeka9061ktjg0qtaZKSQyFzi6yeanb0yqvjbz554VR5n2xbZshu1E6kt6wtgIJ5XuIlzJrUI0VNqTnroSUM+8reT2cvfV4EpFxP9lL9B+1UPCTylQObzSi6yfhXextX/rWnQhadUJahft13ef0zUnCYLAfrBrRWVLbMasKQ4c7ORDgmZlJ+SsKNe0ejluGiHCOpSqDbSGQp0anqevqrODUh67DVSkm6/dKmfzeNWSXbJ0+R2UKlVzdKbF+2DXgJN2+VZawKiIhvbWMWg5JC9r5Ib0QL1XIs7hu6G8XRc9jC+F2Ec9Jn+CpRgp//SY6+pF91VnV3coHt YP2JZdaF bSepc4UHD1JEauTefmg4n1iwi7iMXUK1G6MaAOvSBBZz0CLn/Ne5e47THWhELfl9xFeufBrkL6zQibwFtCeGxIHAsBSdiJ0sBzl293R4v1eZnufdHBLNAraCU4LOtg2LvzG26BL4OF853ABV89GTgwdqTbCMulbm8/CfwcVlvOVmjSJnK0m2e4w6m4R3pDKpoDUXtH0UxQcESDDz6mWeFj/fQ9VjANe/Wp9Z7/+7bHd75b1ZpUT+VjabPlwbb088+sRb1nxHR5lf3rcvaK/pORw9tOA73Em3x/c3pfsBxAdInax/sasQiHmCpynJ5XQu4T07D8Vt9S2D18l8LxFNKaHU/U5JmG7IUBS69sPR5TQmD6ZujZmb6qRw73bsFGytKULf4xxKQrPFS8UHvaIjadJfTFQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000043, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Conor, Marco, Andrew, On Fri, Oct 13, 2023 at 11:58=E2=80=AFAM Andrew Jones wrote: > > On Thu, Oct 12, 2023 at 12:35:00PM +0100, Conor Dooley wrote: > > On Thu, Oct 12, 2023 at 12:33:15PM +0100, Conor Dooley wrote: > > > Hey Alex, > > > > > > On Mon, Oct 02, 2023 at 05:10:30PM +0200, Alexandre Ghiti wrote: > > > > That makes it more clear what the underlying type is, no functional > > > > changes intended. > > > > > > Scanning through stuff on patchwork, this really doesn't seem worth t= he > > > churn. I thought this sort of Hungarian notation-esque stuff was a > > > relic of a time before I could read & our docs even go as far as to > > > > s/go/went/, I see the language got changed in more recent releases of > > the kernel! > > The documentation seems to still be against it, but, despite that and > the two very valid points raised by Marco (backporting and git-blame), > I think ptep is special and I'm mostly in favor of this change. We may > not need to s/r every instance, but certainly functions which need to > refer to both the pte and the ptep representations of entries becomes > more clear when using the 'p' convention (and then it's nice to have > ptep used everywhere else too for consistency...) > > Anyway, just my 2 cents. I started changing that in one function and another one, and another one...etc up to every instance. I still think that it makes things clearer, but that's subjective, you raised valid points and I'd really like to see this land in 6.7 so I'll revert this patch and send a v2. Thanks for your feedbacks, Alex > > Thanks, > drew