From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24F4BC47073 for ; Thu, 4 Jan 2024 12:47:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A9AD08D0072; Thu, 4 Jan 2024 07:47:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A4B538D006C; Thu, 4 Jan 2024 07:47:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 912448D0072; Thu, 4 Jan 2024 07:47:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 818B28D006C for ; Thu, 4 Jan 2024 07:47:31 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4F24F1C11B8 for ; Thu, 4 Jan 2024 12:47:31 +0000 (UTC) X-FDA: 81641604702.19.1D3826E Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) by imf15.hostedemail.com (Postfix) with ESMTP id 83BBCA0017 for ; Thu, 4 Jan 2024 12:47:29 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=Qm5XJAYt; spf=pass (imf15.hostedemail.com: domain of alexghiti@rivosinc.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=alexghiti@rivosinc.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704372449; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T4/T6LM2cR9BhRuyec6i7dIzoBYTu6Jc/wC4bPpGSrs=; b=T2Gbf/8cf4zvO9GqTIga6oiXSB6R+WcoCMQ3/CDHtvUALt7tktS32VOSpf/UG8KcFFkU7r Fi/uL9oMucXSHS8RDXHigJkEeTtOJz7F/+46tXb+UIvj9nze/ZT+p/2hIZ5vzt3iJ6GSj4 GuFX1Ai1Kgx1BdqFnOJPMVirK2NcRWU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704372449; a=rsa-sha256; cv=none; b=tz5M1La26fUZOKqYunUnf/wSYlK8tlWeQpqFxoJpPTd1LVZ4Rcm4OTaG7tuIX37KJm2wB8 DAo1mLSOilX8HNkAYhm8YNE0UK5ZjTY70xKFZfBTbtBCxsaarqlCqSlHk+9V4nCxOYHZZ5 GdJhtK/ztuwe7UJBzg9+h+8jXOnJXO4= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=Qm5XJAYt; spf=pass (imf15.hostedemail.com: domain of alexghiti@rivosinc.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=alexghiti@rivosinc.com; dmarc=none Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-555e07761acso611915a12.0 for ; Thu, 04 Jan 2024 04:47:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1704372448; x=1704977248; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=T4/T6LM2cR9BhRuyec6i7dIzoBYTu6Jc/wC4bPpGSrs=; b=Qm5XJAYtQ1Wg7uNiY/8vT9+//K649mL4iivLqaCAuHRg3/Azfn/TA8RW/FIHSQu28K N/MaRF5+WkwM0qkUDnGhhWWr4i1CWJUrrDIF6BsSMccHBV7FZY5uy7PElXAlwVxMlAKt oWeXdVCouJDsj0cd8OAtNBe2X6OJYebblOx/6492ZUF3WmJ9SogF7ibk0pSk2kXxjpgx t/qoNXVrA7RLX+0YVqfEMi4NrDrkdqEiw3FMSTwJ+pN2EjJ6Nte+L9bEs5ZQSpmiO723 ODbh/b5aodBJwNP/iDw+fuENun3Y7Eppz753fJ68RpyoOpShjQ5217kBvKlzh8Shkq/6 b1ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704372448; x=1704977248; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=T4/T6LM2cR9BhRuyec6i7dIzoBYTu6Jc/wC4bPpGSrs=; b=VbAeZ+PA41yjNy67IS+UXbABY0q9lTr08mmsjmE5ieWE/0LDkwD8lJc0eFKlDE+Fhn +MSVQgw9K+U5HbiPCyqXF6p9xXitlL8j/vBDEGSW2iNRzWexPUdM2TgDBrJJpSu/eQCN c/Kf9825XwjM251b1HcURMpXXBckXi9xvaTfkCgELwjUE8h8tTTqgLCm1Jnob7cfM8Cd ll0fP8ucdbS0h43udWHR7V+K/Dhjtwd8kGHE4rDYLcLhgvLzDa3F2qwsyjT2TgPeVQdw XiC0P+mtTgsgKFxajU4yn773xfncso1lQs9hqYE4g6jZ8m8Y5O8AWcS/Q/RZCc1a8dJ/ jk7Q== X-Gm-Message-State: AOJu0YxsKpmlHYsZ6+ECK2kkzhkkJ+Z7j9vYt4f061YbiEk7fM6vWsUW HJOJzGdsXtbijajBT5Jcu8NXCOPFeRT6lZQYUqq1lF1eLdwxjMny89IhVgZy61g= X-Google-Smtp-Source: AGHT+IHUQ3YoVaFmv46BhHeLVQ5EJ1NE0eAcs7J5rojOmYSHjoP6iLNHAvk7t77NJdQ/bytQn9xnJQcuGL/1iBdPOgY= X-Received: by 2002:a17:906:f34c:b0:a28:b7e1:e24b with SMTP id hg12-20020a170906f34c00b00a28b7e1e24bmr195383ejb.162.1704372448064; Thu, 04 Jan 2024 04:47:28 -0800 (PST) MIME-Version: 1.0 References: <20240102220134.3229156-1-samuel.holland@sifive.com> <20240102220134.3229156-11-samuel.holland@sifive.com> In-Reply-To: <20240102220134.3229156-11-samuel.holland@sifive.com> From: Alexandre Ghiti Date: Thu, 4 Jan 2024 13:47:17 +0100 Message-ID: Subject: Re: [PATCH v4 10/12] riscv: mm: Make asid_bits a local variable To: Samuel Holland Cc: Palmer Dabbelt , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: g4bd8sntgcjztt6o44oatyrf4xiypahc X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 83BBCA0017 X-Rspam-User: X-HE-Tag: 1704372449-830545 X-HE-Meta: U2FsdGVkX1/fDKaN7iq9QSZelJCp0Jk3hK6JF/PtWXT2peItQE+vQgHtfA70wfj040rh5DG+YfdnqkipuxT3nvSDAM6o9zA4U56h+f3O5xmgLmDOrkAQF0H1vYcFB2V/S7aGcQkx6McN4Oma2Z/8kd8V4/6VQv5+1iuCcJDXe3ptjfCBVpX5625MJ0O76+WA+yLD3VWH8KHrOcB5Y3tBq+yc5L3+D/pUUCNpxLo7RwZz8+PnYX8s6c26xpfYXr5V17GBJXPgXvzKWnGzTxBDSk2GO3mCKMpbg/nmLbYDIDGxCSnuVhsWnXUUGf96YN/Q/qqKwkfjqUidlD7ABpsHv4Q+P3kym4z9PJdV5woNtRuBW+zA3GqoCPRJT24AGsXbdxrb5OTfq7puIxZVJTVWBUgpxXkkaOi+/48rx6J927ooDszgpVhIAd6oGJkSgLRNvgYiwpyMR+5KJ2XDjpGBgVjeU2vxSt0726rIb4O5tqg2FowKY+B2CgZNK1UK/MNPDHPjRuBezeDIw3Zn4oOMT08HTg/5fwW2cIyyys5FJBp/+JqGjND2bQllekkwEXh2a0aSaX+uSl5reK7isjs+kteoC9mckFe0aE21sLGf/WwwSfhRu3vEgcvX9/MHZ76bmaZqqjVw6jA5BmDjmO6QADAehq/ZGQEBUvMjUdfIF+8Jrfg6dZsnKThx9lDtEkyuDJrXy65+SGiJkm00YqrpAsAkIjb/kjdnqViTA9apmhZCoyR+HVS5SrmnDLO7kPTPlxFJahDQt8xmYvyqzV8AJGs94WvY0JoMI+xYv6IGxLwA7pyueWwos8iSnXm2dqQY0rtgNF3ol//Cp0X5eJT269x+zkZAKv+SiblUzBr1XM8wuJCJ+xFDuF6zJqQugo1wYZ8UxEAsZkr0GdTv6EgOlPN+FsXa9F6KlV/CbWqrkbCtdAR2ItM2+aXah4aNINB4gHqyYRMrNnU18V69Beb 5AIoaPkD JYPui6L1BIbOPh8kZlHgoI1caQlsH+cqm1+grYvcvyHGfiTkTGl36aZAHCC8tjWA4ImWCpUKCHfvdSiAPXioOs1Xq2Uudo9mkrDcSUQYqU1auXKQ6Sv8PlTxDpZinnZhEtA44OcZ2N+67orDMLoy0tofGSXWQiIV2lKHpt7rsBTZr4a5iwci1oFebYlhnAelOFal8/W8mUVKItk0AjlStZRS9I+8zKAp9SRJsASt8l3+MqpHsyN9mnX9EXWJjOdzCdfsvnz8bHPoMyFQLtFe4tJy5JfX6GYU8Iqt6JoByQF1t8zP0X/Ukt2lwmOdDjv6Mn7C16D0JG1P8Esrxr9xevplJXmmrEvK/7QoRK6MM6YDf7Tle675G1ftzcYeA0hPalekAr/UsxWM8PJg0FEp5TDCjD9hdfxlWYhhJRTp863WoPSZz3Vhyp4atLKSYykObZeUgfI2ffCHY6uX0905iJWmVe/ojsCjt1Kh2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 2, 2024 at 11:01=E2=80=AFPM Samuel Holland wrote: > > This variable is only used inside asids_init(). > > Signed-off-by: Samuel Holland > --- > > (no changes since v1) > > arch/riscv/mm/context.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/riscv/mm/context.c b/arch/riscv/mm/context.c > index b5170ac1b742..43a8bc2d5af4 100644 > --- a/arch/riscv/mm/context.c > +++ b/arch/riscv/mm/context.c > @@ -20,7 +20,6 @@ > > DEFINE_STATIC_KEY_FALSE(use_asid_allocator); > > -static unsigned long asid_bits; > static unsigned long num_asids; > > static atomic_long_t current_version; > @@ -226,7 +225,7 @@ static inline void set_mm(struct mm_struct *prev, > > static int __init asids_init(void) > { > - unsigned long old; > + unsigned long asid_bits, old; > > /* Figure-out number of ASID bits in HW */ > old =3D csr_read(CSR_SATP); > -- > 2.42.0 > You can add: Reviewed-by: Alexandre Ghiti Thanks, Alex