From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98CA3C432C0 for ; Tue, 26 Nov 2019 19:41:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4631E2075C for ; Tue, 26 Nov 2019 19:41:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="cD48sxrR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4631E2075C Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B43F46B033D; Tue, 26 Nov 2019 14:41:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AF49D6B033E; Tue, 26 Nov 2019 14:41:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BC6D6B033F; Tue, 26 Nov 2019 14:41:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0082.hostedemail.com [216.40.44.82]) by kanga.kvack.org (Postfix) with ESMTP id 80CD06B033D for ; Tue, 26 Nov 2019 14:41:14 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 30CDD180AD806 for ; Tue, 26 Nov 2019 19:41:14 +0000 (UTC) X-FDA: 76199447268.19.music16_27d1f35127f57 X-HE-Tag: music16_27d1f35127f57 X-Filterd-Recvd-Size: 4109 Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Tue, 26 Nov 2019 19:41:13 +0000 (UTC) Received: by mail-ot1-f65.google.com with SMTP id m15so16981123otq.7 for ; Tue, 26 Nov 2019 11:41:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dsKgJ5qFUgopMwvxZ4JDss58rF+rfZraBDg650+0Z0Y=; b=cD48sxrRbKVlxTAah5kCzM2yI7ff2DNlrMEWuGGZnBU8q+RiOKqgBtEh8xGcZInqwP Mz24ezGC4SLLRM+Qc0MQjE/pe4SitwcZLSg7TBXw8NiDMC8u1uySoNkVIhjWBhqsxaIJ zEa/EHupUKo7CpdUaJtLcTm5A9g5GmFcDeVVi6iBuvCchC60HAKvMpSxs5LLmP9rXMtg 34Dou4f2XbYa2NXWVz1VBPwJf7Ge5UmLMI0ILuIn4udXYq+B8GpT5UbHf1BsvDJ7MKMg 8VKSpzzoTp5fOQ//mEiATTmtUDdk6hy7u/hAOG3NdFJSa3u0X33LQpCRPnjcW64DPtLe eISw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dsKgJ5qFUgopMwvxZ4JDss58rF+rfZraBDg650+0Z0Y=; b=hbNby+TTnOc8isOvBbQKcaaHGUPo/O2PNufxeGS/JY6Il3+tsNWsX8f9dk/VJT8KSf 7MnApPyYP7WAV0RU7LQlJ+zs7StSHMIMMgzX+dYV/PAtYph/HVFITWAcC+mRsIwY0zX7 uttFgZJQuZ6rQoymiFqeD2Q1YeKxWwbc8RQsRi6OWObV1VYEhpuVE1Vn1Z4ue7IYAent Lyws6CcxvHPVDi7EfSTNwbEjK8ZVqCQYkO9Bv8shCthQ8+8t/hBILaZa5aE2hkrcHrJz xy998ZqwjkIKEh2dvRmOKgXiV7tTd11Ebhv5i42d19xjL1daHbunzibgH55Yve4PWotu CR+Q== X-Gm-Message-State: APjAAAVaOlvB0lNzRHrNz8MVHCAbcSqk6TbDogqF0r5zchgPEaKprnvM Xx0JqBBiMHZArjAYu4pY9aGYR/jI8XX4JHHbE3gjXQ== X-Google-Smtp-Source: APXvYqwbkhqIofEOqkKbby5QEzvf0MywPslDzhs8RQTrL1thmB2MW98GdBPgEDIlEnhuS97UTMDdNg8PAGZkvEIz54g= X-Received: by 2002:a9d:6649:: with SMTP id q9mr513560otm.313.1574797272502; Tue, 26 Nov 2019 11:41:12 -0800 (PST) MIME-Version: 1.0 References: <20191121211424.263622-1-gscrivan@redhat.com> <87tv6wmgv3.fsf@redhat.com> In-Reply-To: <87tv6wmgv3.fsf@redhat.com> From: Mina Almasry Date: Tue, 26 Nov 2019 11:41:01 -0800 Message-ID: Subject: Re: [PATCH] mm: hugetlb controller for cgroups v2 To: Giuseppe Scrivano Cc: cgroups@vger.kernel.org, Mike Kravetz , Tejun Heo , Li Zefan , Johannes Weiner , linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 22, 2019 at 12:54 AM Giuseppe Scrivano wrote: > > Hi Mina, > > Mina Almasry writes: > > > On Thu, Nov 21, 2019 at 1:14 PM Giuseppe Scrivano wrote: > >> > >> In the effort of supporting cgroups v2 into Kubernetes, I stumped on > >> the lack of the hugetlb controller. > >> > >> When the controller is enabled, it exposes three new files for each > >> hugetlb size on non-root cgroups: > >> > >> - hugetlb..current > >> - hugetlb..max > >> - hugetlb..stat > >> > >> The differences with the legacy hierarchy are in the file names and > >> using the value "max" instead of "-1" to disable a limit. > >> > >> The file .limit_in_bytes is renamed to .max. > >> > >> The file .usage_in_bytes is renamed to .usage. > >> > > > > I could be wrong here but I think the memcg files are not renamed, so > > the same file names exist in v1 and v2. Can we follow that example? > > I've enabled all the controllers, but I don't see files under > /sys/fs/cgroup that have the .limit_in_bytes or .usage_in_bytes suffix. > > To what files are you referring to? Never mind, I was wrong. The limit_in_bytes and usage_in_bytes are indeed renamed in the memcg in v2. Please ignore :) > > Thanks, > Giuseppe >