From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85413C3ABCB for ; Mon, 12 May 2025 19:14:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C75716B0088; Mon, 12 May 2025 15:14:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C244D6B0089; Mon, 12 May 2025 15:14:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B12C36B008A; Mon, 12 May 2025 15:14:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 90E516B0088 for ; Mon, 12 May 2025 15:14:37 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6C9581407D4 for ; Mon, 12 May 2025 19:14:38 +0000 (UTC) X-FDA: 83435207436.18.A6E72FE Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by imf02.hostedemail.com (Postfix) with ESMTP id 8239F8000D for ; Mon, 12 May 2025 19:14:36 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=TyKJOtSK; spf=pass (imf02.hostedemail.com: domain of almasrymina@google.com designates 209.85.208.51 as permitted sender) smtp.mailfrom=almasrymina@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747077276; a=rsa-sha256; cv=none; b=nitCOtr20PWFRxkJ3jNfisfLQSHYu2V6uuRJpOMb3QlffYa+lRgdeBqHy88KGUY1n9gYR3 YVqK5UIMS1OooSsSOcC5Cnl94NOrT6s+aa1AvHBZ/AEO6JIc5HtNQX3fjCj48phQntI/2Y bgqm1uNmy0rlUlGuTWuyr/ws8Pw/RWk= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=TyKJOtSK; spf=pass (imf02.hostedemail.com: domain of almasrymina@google.com designates 209.85.208.51 as permitted sender) smtp.mailfrom=almasrymina@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747077276; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6grkvz4IGQ6h1k6YUz5SWGU/3xxG7rgL4ytaAoxrVus=; b=yNCviBteHkN7dOZkrZhkb6p++RuUa43fxo1Xlm9Hf7nZ1rw1VOQ0VQ0UdhiADqwuuvgXSx y64y87s2X3pYYnhV8Jn93/JtJxm4ZjYNd+6igyWQ60OnvSHK7huV4WlqPGjvhAVIA0XiQl cCjOhzQpCrZxYgim1XHSAa5w3l2Oyho= Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-5f438523d6fso2298a12.1 for ; Mon, 12 May 2025 12:14:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1747077275; x=1747682075; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=6grkvz4IGQ6h1k6YUz5SWGU/3xxG7rgL4ytaAoxrVus=; b=TyKJOtSKXkjzFr6XpvHGQ7mc0kDacrfiDNk6zHxaA5Q59yZrwxFjqiETdXFhOIASCz 7tyvuwEWprUd+XjkzoxdGy/F3JsGPGuLhKFxJyTWC+7/fOnVrfISAmlwY/WGYA54IGUM qiEKoeWR2EwOMjJOq5FqBrmlCxQY8LluXNabGDJQbz1sb9ULqNddV2RYPgpOTQxLYBtg bGhtf8SO4r6IZ1oNFbchz5v/+QOYVaD+KtiWn5C47d466g3ymZOmg3fSYrZDSmCQc77j QlHvgdQVqnWzZbQZAL3y3yRHcT/OdHj0TVSOt/UXP1jldbDdlgqf2oGRK5MM0lMGnp39 9I9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747077275; x=1747682075; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6grkvz4IGQ6h1k6YUz5SWGU/3xxG7rgL4ytaAoxrVus=; b=xN3vZo4iIhPYkT3eJk8hAOgp/+nTUbrxdAEZBQ4MKsfFshzLuJPCNzm0IpnVYRUJuX C/OyRlpwp/qMq8AC4ygHsV9lGzNhYjsthARy2ex+/BoSSHImpqjWhygVhjNHCWGsgz1Y /fJIZjxjEi8SQb3nMwaaJjNrpEVgzfF+vUN0KZl6YZXhnfRQxF9AQt2brZSM8kaui2ak ZGh1hYFL7VEqA3Qt++Do65J4Gn84xr0NL3stXRQk+S6nmnUxq88JP2BCFU+EoX61TdZn nbtAOdsMIY8MdaYa0QRObBqDP/CcoPFb6+t+M9SAAQY+nqG5lVBc2nykzkw7UOuNJfnr w8ig== X-Forwarded-Encrypted: i=1; AJvYcCUuii9EyGwvFzzhh+7Ug4zH/KFo0o+bXMKOo/wjDrM5XZDK/qpV3e0myv43PL2rRNNakVuIyCH6XQ==@kvack.org X-Gm-Message-State: AOJu0YxOEjM0C97mPRhhigGGdGZaeIL7fUKOw9a6+AjzKuGM6SICt0Zk 3U/Jt4opxSrAAEXY+7FGCEchg4EMnYcjPCOM8HLqa3EDffA34+je/DmrB2OgBHhklTWXTvb/Um/ m4nq4vCJ5/OeihQvifHsys8hYuatJDN7zYe8cNb7m X-Gm-Gg: ASbGncvgk5sGSPhkutA37rWzLnpArEHKsYiBufkWNrwS3/weAs1a59168b4hBIlz2QM iZQUJrWtCpr2XZXl8JKoQc/l804E8x8PjrmVgZEaZpF+PbGxRzrQ9jK4xNBxXlptHOFKzy+QhWA iZBVbDrHvRbpuwXXbmGorPNDDUQTRNGH0ZGdQnuQXHJLSc7s6hZCr0PCwJaMxirTU= X-Google-Smtp-Source: AGHT+IFtZat3CxYkRrxuf4LayeSFUTjMOU/UUK6s3flry2QVc1ThfDr5aYHBrgSXAdeNzDz8w9DKO2TrEjr/VQ451Qs= X-Received: by 2002:a05:6402:b2e:b0:5fd:2041:88f7 with SMTP id 4fb4d7f45d1cf-5ff2a33cf76mr16530a12.2.1747077274857; Mon, 12 May 2025 12:14:34 -0700 (PDT) MIME-Version: 1.0 References: <20250509115126.63190-1-byungchul@sk.com> <20250509115126.63190-2-byungchul@sk.com> <20250512132939.GF45370@system.software.com> In-Reply-To: <20250512132939.GF45370@system.software.com> From: Mina Almasry Date: Mon, 12 May 2025 12:14:13 -0700 X-Gm-Features: AX0GCFuWCsCZDfmhnWSbDcL7YWTV_J17ret_1dOAsScEvpk7dr4EAmn0tHdJSi4 Message-ID: Subject: Re: [RFC 01/19] netmem: rename struct net_iov to struct netmem_desc To: Byungchul Park Cc: Pavel Begunkov , willy@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, ast@kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, edumazet@google.com, pabeni@redhat.com, vishal.moola@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 8239F8000D X-Stat-Signature: ykrtfnpyaq84aph4mppuy6ekby7fe74i X-HE-Tag: 1747077276-38271 X-HE-Meta: U2FsdGVkX1/mwbM3BbW8PDK39QBVLX/C/2ubzzjjmH2MTvWEfQLZhM+30xPpmUQSvAhy3mFjga9aWNFiWjQG7+tQDBEaPyUIWtP4WzL3t9pVfRKxoozsbjrUScDjJ+t1Ixuvdnt+pQqokzOMtuCjawhyS9acXBBglnb9+DnxpF34VsGCSjT1nqefu8wSGpC+Ft2uVS0NrqcOIbk5MAqD+bvrGNyq1E0pa4BW0TQs9cRsLIlFFZ81dFS99pww3oSRCjk83JbnveL0kMQ9tk2bAJ3sIeM8fhQP6taQ8+B6k9pPBP2PtIWmr9YrKm1mWNemrNtaqAq/o/Z2fd8MBlZJrj0TZ3SSSLCVlZkt93oOazst7Tn9gHpd7JDYz2c1+L87QUPjaWZFqDU/bSl/5jOYs1HHhWygwEf2rNetRUDNlRcSkV0nKtavOaq0CfTuSACTVvMsAN2tYz83HgN9v6+bbBgnPE+5Opqmb98TKGj7hK0LRk0U7YmAuEk4LRVQh+FReVpTTS4elbn5kIPbosLUfLZG6MYLwlrxOMIAdHrKHp3QV/dE+lAZhgr3gyFwFk/GqTOwwG1F9JBdVZssk/6EckVfhvF7D8RwGXQVKHeOpj5ML4i/m1TgIhOoiGy83EalJEQUWquLTgmdxN+y+9tbc6RLrnTsi9vWKRIKyn4kMCK4uk1kT9gSRb7NVOoME9K0QOcyvgIrXzB/eiKYkZPzzskuVoIQF2cyj35w4V7TE3jhcVepW6SGbOzH1JTDadHd1+NAitjJd1vsc24AfmO924mGOn5K65c/scklD1Eej3SjjUwCTXh7YVFtZZU/zfeItTOYKAsUyOxtQPe5QETQ/Fpecwx6fstYnF5N9jfs9RlLYseLzm6AlhCWWREPsZZQWRmW1J9mbKRPo6XdDR06wG4UkjMEm/lExeKufkQh/u0FUty61ubfWMjUXYRX0HlXfJxDWegigaHNjSknxcU WB3GbxmL 3EUtZPtUtQ74OP/QcVsGTttOa8l24+TsUTLuHVXHgtNrCzsiWwd98UXnwwQR9j2lx0yanXmYZiO42J1fCIBxSbMq02Tp2Hf009FlxW/aRqIJR5QXeFoWUEKRUyEil85Avs0ncMxGIg+yo1ZNXgVhbj1iG/t9RAdrxmypkr3mAKhdmKeRHVbugOqDYHMtiEe0O0AAhbL6yjy9cnpYwBjam93o6IV8f6VdKxi1NAn2pwjCxtcAkhfQHElXApNAJaZ9ftatBasdyFA6QkEou/3f8vM6hJSaO/QA9VPCWr1mUM1hDMDGtgR0LWQaThoEzx93ZyeIwZbqqzh44XIGeXfR4rFG9H5g57nAez6Vh1BeVkBJ2uqDUc78Q6gAnBeNKbyRiJltc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 12, 2025 at 6:29=E2=80=AFAM Byungchul Park w= rote: > > On Mon, May 12, 2025 at 02:11:13PM +0100, Pavel Begunkov wrote: > > On 5/9/25 12:51, Byungchul Park wrote: > > > To simplify struct page, the page pool members of struct page should = be > > > moved to other, allowing these members to be removed from struct page= . > > > > > > Reuse struct net_iov for also system memory, that already mirrored th= e > > > page pool members. > > > > > > Signed-off-by: Byungchul Park > > > --- > > > include/linux/skbuff.h | 4 +-- > > > include/net/netmem.h | 20 ++++++------ > > > include/net/page_pool/memory_provider.h | 6 ++-- > > > io_uring/zcrx.c | 42 ++++++++++++----------= --- > > > > You're unnecessarily complicating it for yourself. It'll certainly > > conflict with changes in the io_uring tree, and hence it can't > > be taken normally through the net tree. > > > > Why are you renaming it in the first place? If there are good > > It's because the struct should be used for not only io vetor things but > also system memory. Current network code uses struct page as system > memory descriptor but struct page fields for page pool will be gone. > > So I had to reuse struct net_iov and I thought renaming it made more > sense. It'd be welcome if you have better idea. > As I said in another thread, struct page should not embed struct net_iov as-is. struct net_iov already has fields that are unrelated to page (like net_iov_owner) and more will be added in the future. I think what Matthew seems to agree with AFAIU in the other thread is creating a new struct, struct netmem_desc, and having struct net_iov embed netmem_desc. --=20 Thanks, Mina