From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 802D3C3DA47 for ; Wed, 10 Jul 2024 23:42:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E70026B0083; Wed, 10 Jul 2024 19:42:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DFA126B0088; Wed, 10 Jul 2024 19:42:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C72916B0089; Wed, 10 Jul 2024 19:42:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A34506B0083 for ; Wed, 10 Jul 2024 19:42:19 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4F2721A02DB for ; Wed, 10 Jul 2024 23:42:19 +0000 (UTC) X-FDA: 82325469198.06.04E58AF Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) by imf18.hostedemail.com (Postfix) with ESMTP id 7F57E1C0009 for ; Wed, 10 Jul 2024 23:42:17 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=zsMvaWcq; spf=pass (imf18.hostedemail.com: domain of almasrymina@google.com designates 209.85.219.46 as permitted sender) smtp.mailfrom=almasrymina@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720654906; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xw22ZH4c8gyTKnFajh7vcYEJsOdrHlsxvg9OLt0kZtA=; b=SARGtCRYPI8DOFQVnP9X8ZFhs3/mIN+lOpavpRR2IHysTmYpla4MfkhWVFWAwFGioEG+3L iTDrHMA48K+uX9f0Srrk5YkUhal4jCt6uq1WFWM5RbO9zypWvDB8hA/Lo0g5TCBVh4hKR2 YUO0xXBVYFChIy7csyBV3r+axPEBXXE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720654906; a=rsa-sha256; cv=none; b=jED9nnzwlWp3bLFrVYoBuN/2ZQIRip7HV2zvr2FCpf6BNe38zMIuhc4mDm2XGI/nB5a4JE Fcpk5zzmz4ADjuL1/Qn4xauu3Qg66/HCZDlVmyyyHDI4JejcwkwiwX105OkHWWRp0ulPUq SWAraI+PDtqNrAacvXVjz2e5xtT4y0A= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=zsMvaWcq; spf=pass (imf18.hostedemail.com: domain of almasrymina@google.com designates 209.85.219.46 as permitted sender) smtp.mailfrom=almasrymina@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-qv1-f46.google.com with SMTP id 6a1803df08f44-6b613921035so2081466d6.1 for ; Wed, 10 Jul 2024 16:42:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1720654936; x=1721259736; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xw22ZH4c8gyTKnFajh7vcYEJsOdrHlsxvg9OLt0kZtA=; b=zsMvaWcqMyUKQiJ11qpmf9wp5fv2FQCgUgeHlouHi+KMhgwfj1xHLhxfx1pu9dZ1Qk GCXEZZ8JEAB/GUpfEO+6it8L8a4WcJKXaVRn/Wh0x3XPYqtDGY4fSic0ubVN5W66NKjV 9P612b5r/YFnJjLp60dU1n3l7EemXp16SZVv/bdHcsBtY7EG737k8Vg6UCCNbfcItpe6 HTYoZntyr4X7EiNbbPlHMEzgKea+bW4XFAgxv+/a7W9Z4C2cg3K2bOjo7FUBKZNzb4/l tAxnNperd8ljsHgC18gsO+vuZmuGELvuT2LtJqm7ffLarXG+2v0SOBec32C6s7Lnj42R +SJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720654936; x=1721259736; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xw22ZH4c8gyTKnFajh7vcYEJsOdrHlsxvg9OLt0kZtA=; b=KmUsbcj81GcM4dMfMAc4ks16bClrcECJBZwZIyMcnHqYmCJ5S1RQWjBMPNQYCuIrAb +5pRY0Omm8QyfY5mTwUGvjlyOd6Jlk8rmWUmqM9KJQnNldY9h44X1gRrC/E9dLn8Imou QDJWXm/3R5R585xCTNpSawqCQFR3NjnwWlB5izbWWxilwEyJzeaUmmXGZWaN1wJOEiM9 41CrG+O7zb+ut0R1N26G5lmntVYJnIYz4HokmTgL2DZ+BYf5tYk57VBXYZ8I7KFz7FmY MOAJzkHTSqT0S3vd2Npk1Q+kKcWQ5sxhjs1DWd5p1WIdPbe65eijjjIQnipfCWeysMnP 7dxg== X-Forwarded-Encrypted: i=1; AJvYcCU1ND5x15v5uePiDTi8hI/31U4V7lqEq3ASXno461eCNQgc/e8+OO5i3PrbTugxzLqe/b5qqDWgoVqYAGa9balgKeQ= X-Gm-Message-State: AOJu0YwwnZbjFCCo4TMjiHfNDUDKksDwwGvqNyjBD+JWvxr5z4GAJSZX NMJGVN3bQJFEaqiCTP5q78O0hIS8MS3yTi+iZnNinfZwrUC2ESMtud4ay6A8F2AxZx4R73dsYLK cBejifC/Wau4jNxSWsb2NpnXwsCZFqlygtjmf X-Google-Smtp-Source: AGHT+IGOLOQ6K3/3da49V2eHyCz+KQjRCyIEiAYnB4b8F1iCu2D4bkJxhlzGFfxvSjmRGC6gzv7EI1OWCLflWXtCr4A= X-Received: by 2002:a05:6214:20e2:b0:6b5:9c9c:7baf with SMTP id 6a1803df08f44-6b61bca896amr97392016d6.23.1720654936406; Wed, 10 Jul 2024 16:42:16 -0700 (PDT) MIME-Version: 1.0 References: <20240710001749.1388631-1-almasrymina@google.com> <20240710001749.1388631-6-almasrymina@google.com> <20240710094900.0f808684@kernel.org> In-Reply-To: <20240710094900.0f808684@kernel.org> From: Mina Almasry Date: Wed, 10 Jul 2024 16:42:04 -0700 Message-ID: Subject: Re: [PATCH net-next v16 05/13] page_pool: devmem support To: Jakub Kicinski Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-alpha@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-kselftest@vger.kernel.org, bpf@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, Donald Hunter , "David S. Miller" , Eric Dumazet , Paolo Abeni , Jonathan Corbet , Richard Henderson , Ivan Kokshaysky , Matt Turner , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Andreas Larsson , Jesper Dangaard Brouer , Ilias Apalodimas , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Arnd Bergmann , Steffen Klassert , Herbert Xu , David Ahern , Willem de Bruijn , Shuah Khan , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , Bagas Sanjaya , Christoph Hellwig , Nikolay Aleksandrov , Taehee Yoo , Pavel Begunkov , David Wei , Jason Gunthorpe , Yunsheng Lin , Shailend Chand , Harshitha Ramamurthy , Shakeel Butt , Jeroen de Borst , Praveen Kaligineedi , linux-mm@kvack.org, Matthew Wilcox Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 7F57E1C0009 X-Stat-Signature: bzsndbwbhoigt5zubbb3u8xt9bo8odgc X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1720654937-448693 X-HE-Meta: U2FsdGVkX1+vk8lBNjKfwIFbIkpgW6y2V30pTYVt1zhYS5TvCdWMy51FfoKiZC950r4K2MNdCOpc7NyKjQO8DZ5VotMV2t+X0r4RN22sCE1yqyAVIvaeFtykIl7P7ZbIE+8lr4veKswsQKcVag82UprW4cG5tK8UiJnEEJ/f2KC9GpfLBMYKdPC3Od4lcuvwewgHjZ4LgPlOxEiz29Jcse+aCFBJA7cSYaOYIXHIFKxhzG8S9+Zsog5C3axRtAOQMUtxPX4A2aVFYHJxYYrw9A3Nut1PhvUuID0tInqXD3VHFq6yqfG7BSmu7uY9E3Hogv/arSQOJonIV9WusZY1Jrn3k+waKQC8JpF8Xis1WrYPJn5K4Qm7c6kD5+JzSeXiQSbwF4OgZ2eJ6boGBfmhDD/wExM31JKQzenltPROUr2PEbUZZDmU/g+vnzcJoMQZGGR7I+VTt7A/H6T5jDRXznVCWxJTf7Q7Rz6tVE/FQVJSgY8ylWSg3tN8WkTmNkprBP0qN45Z2TTx6c3HIL3BJlvy0Bzl7EcINElxcQMP/aY2Aezl0jcQh6fvesTZuEoGDBD1S4eIRr+Pdvkyy4HDF+jw/KzLkEF8I9ZZZK6XtcHWQFihtowGjGJllyIuZ1pZe4bz7Y52WeSYO2601K/de5cu3sUBCeK7goUjebyyJ9TDI4Hp3TicKbgJZvOM/3jnLzhumu3vglQ/9Pqs1ncaEdrUnyejmjdxhI9uJzbBsmua2Hrp3cOrUFRJvzw8lcco+6RhbMN9eNXyQt9IqjahqRJlvQ8UPGFiWzT6z4mW1ihnkMfB/EBQlK58JibrvNw4ELVQhci6xMHMGrpDBuyRH42AkI6eO7Ar5ASruQta+JIjyBN72cRGgiQd1Qv5NIzUG8VJf5Nr5YR9IbeKepfINMVXHs6+S0k98VNv/Uza4wItuYFa19OchWPV+wjVQx/czyIwR5B2V+uqUcMdZXH zgYXOfn8 m5xzXYC3DGRaRIilxNWABfxLQ+WwNx4p/vRxAcY9Asp8ymSYXE1+v/stWpKJw49516+0/nDvXBZ8AEeRgH8cgq+B4hG2/l5CHXVqZ0eMdNfNkggFXFNUnk4qnhEoYBekL8LO4bSrwXOX1X/fkm2ma+Rmu0YBiyCyxzq4+D/h0A/EEnGMeXzG2njcd3nf2gesjcrjvErqCVzUukks32YQUs5QBCJ8Nnx8EPlaolJ7NPjeTlm/73bt4k8E09s+Jy1HqGIe8dj9E2ke9bjnwQ82O4xfsALL+HU8MDVPhfaQs8Y1grjVCOUUBwiRtQrZ2ewJWqh5Jq20HZWJAW2WxGEpC5CZC/yp7uL770PPN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 10, 2024 at 9:49=E2=80=AFAM Jakub Kicinski wr= ote: > > On Wed, 10 Jul 2024 00:17:38 +0000 Mina Almasry wrote: > > +static inline struct net_iov *__netmem_clear_lsb(netmem_ref netmem) > > +{ > > + return (struct net_iov *)((__force unsigned long)netmem & ~NET_IO= V); > > +} > > + > > +static inline unsigned long netmem_get_pp_magic(netmem_ref netmem) > > +{ > > + return __netmem_clear_lsb(netmem)->pp_magic; > > +} > > + > > +static inline void netmem_or_pp_magic(netmem_ref netmem, unsigned long= pp_magic) > > +{ > > + __netmem_clear_lsb(netmem)->pp_magic |=3D pp_magic; > > +} > > + > > +static inline void netmem_clear_pp_magic(netmem_ref netmem) > > +{ > > + __netmem_clear_lsb(netmem)->pp_magic =3D 0; > > +} > > + > > +static inline struct page_pool *netmem_get_pp(netmem_ref netmem) > > +{ > > + return __netmem_clear_lsb(netmem)->pp; > > +} > > + > > +static inline void netmem_set_pp(netmem_ref netmem, struct page_pool *= pool) > > +{ > > + __netmem_clear_lsb(netmem)->pp =3D pool; > > +} > > Why is all this stuff in the main header? It's really low level. > Please put helpers which are only used by the core in a header > under net/core/, like net/core/dev.h Sorry none of those are only used by net/core/*. Pretty much all of these are used by include/net/page_pool/helpers.h, and some have callers in net/core/devmem.c or net/core/skbuff.c Would you like me to move these pp specific looking ones to include/net/page_pool/netmem.h or something similar? --=20 Thanks, Mina