From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C6EFC5AE59 for ; Thu, 5 Jun 2025 19:55:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F1A36B00CD; Thu, 5 Jun 2025 15:55:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A7D06B00CF; Thu, 5 Jun 2025 15:55:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8435F6B00D0; Thu, 5 Jun 2025 15:55:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5E6FB6B00CD for ; Thu, 5 Jun 2025 15:55:47 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0761C1D81E9 for ; Thu, 5 Jun 2025 19:55:47 +0000 (UTC) X-FDA: 83522402334.17.795E716 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf24.hostedemail.com (Postfix) with ESMTP id 18F18180011 for ; Thu, 5 Jun 2025 19:55:44 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=0eJVXJas; spf=pass (imf24.hostedemail.com: domain of almasrymina@google.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=almasrymina@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749153345; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aaGimUCU1zGGvfY9Mn8mz26Pj9z4GAUe4JLOgwbUwZQ=; b=M7T33ql+/InWjT2V0sCpTHZyfGri4IJB65lrV9SCHB+uOu3npVuzqge6XYxG4+x9YxA3fr KcY+6ye4Z584szXX1B6h2redbgz4JO4IIghFpUOii16p87wC/rTu0ZU9ttA5iCpkBVym1O 5TNYPV+IsMsoycleRuvoFQXk4u82qX4= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=0eJVXJas; spf=pass (imf24.hostedemail.com: domain of almasrymina@google.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=almasrymina@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749153345; a=rsa-sha256; cv=none; b=z+qjRrfrKqiqlLV9BKGJo9uBHkYe5DLxzMMzVz4AfWlSFPJYbG5bt6I4/Tl3HnG80q2oFj EkDXLdIbLhOdi2P+kew08aciuYWTo7bdBYALhAb+s2qNSXmi3eqpom4deLjh6perZioRVf wgSPCNndRBeGOaTVqbnlQFxLe6WZSBE= Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-235ca5eba8cso39545ad.0 for ; Thu, 05 Jun 2025 12:55:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1749153344; x=1749758144; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=aaGimUCU1zGGvfY9Mn8mz26Pj9z4GAUe4JLOgwbUwZQ=; b=0eJVXJas6xyJAa9GSDmQWjqkyrPYjeRSMAKK5clJrvG0jXnQ3xgkXP7z75NVFN+l+a jrATkOpGsVitGsNSb5RczPQMt3e/hrcmmIIKjcYg4E+JlyMd2c97/S1wM2nC4ZRVQRH8 m9sIop2jDIlUWWm4yeV6Y9kq8LNjVlMXVnKmVuOvDijV2aNAiPyDpIwmjgwRd/seSSIv cK2q6e8txklhfZn2Qe8yej5dKhHY7y5a0ouJbDyZqt8RIjDwWR0y90fqIsA83xV7mvnX C7g5FicH9vXziABZKuwFtE6YBi5a5XQkSLBAHMf4FVGJm/CauB8tgiHBvw9Oe977hzWT 2YOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749153344; x=1749758144; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aaGimUCU1zGGvfY9Mn8mz26Pj9z4GAUe4JLOgwbUwZQ=; b=PtJ9YBybwc5aZMO+OM8Lv13OZ9BUJm5VVPDsO7z5r489e7OFn5mSE4cVvosfRFFHmx 8Pr2eGPtghLxL/KxH0e7ZHdrY6E2JL0J16abTs2e+2yyaDA1OtZctMvnDttk04MUHWZm rtbaeBurdS+XVfndWeYxwXEj3yFgL2qFObQpxVspFevTo+/s3rz7GtKY58aYlhNyjqD3 0tGVNmeL0gOYk4cNI5unRW2IuUzEy+lK03mmGN8VlcD4CYGj45e7cL0aLvBf/rPMAdmA XdRK6U+7Yzn//H4LiFz/uIq+hODDoMWemeKmTFADQim3iL/KaDJ1RTdVPZGVxSkwayCx eIzw== X-Forwarded-Encrypted: i=1; AJvYcCXm0V22fcMoYlpeZX0KknfUEnmlUDTzNBMucM6cQ9RMJJqjd0IRSjfFP0VmV4KKgXF5eR6grpwVCA==@kvack.org X-Gm-Message-State: AOJu0Yx3+2wV+oAvpYIZ8m2Z+EG3F7i0nzkWNE02Z/USdMcWACzVSJ4v Zm39omISwK71HNJya8R79jghMsLS3H32Sbg7JaIbsfbXoiVHNxGde7DgwCalDTqJlR9QOfnJiMJ vCw2ZUuDBjLYJ8ldDKuiqBSm1L+gVUaizv69cvmDM X-Gm-Gg: ASbGncvLjapHrdnCEqTquP0gWTbz84pVqMaej2uAh++SRVRyJKDqL/GxdxYf4xIAxjb /L+Y8w9z2NS/j9hSqh8k33unqNku8MrqVWLcGJtpldbd0Bq9F47CCFduQIbpIzCzUoJs216YmFc KiQwynI+pguv2qFh9jcsiMjv227gxRrcpkZdLNF6mVSa1Iyi0xoQlQA8E= X-Google-Smtp-Source: AGHT+IEbDYUxJCrIU5Brh7cnuMJfzIWyAE8NR3PlzWoOLOAmknLGWMiWPBhbHrXSP1lOx8L1UkuKv0q/wSg0HLr5qIM= X-Received: by 2002:a17:902:bd01:b0:235:e1d6:5343 with SMTP id d9443c01a7336-23602368069mr421065ad.20.1749153343599; Thu, 05 Jun 2025 12:55:43 -0700 (PDT) MIME-Version: 1.0 References: <20250604025246.61616-1-byungchul@sk.com> <20250604032319.GA69870@system.software.com> In-Reply-To: <20250604032319.GA69870@system.software.com> From: Mina Almasry Date: Thu, 5 Jun 2025 12:55:30 -0700 X-Gm-Features: AX0GCFuuQ92ndxwEnSpPABdXmG7bIUeEpcPA_xt_UklLH28k3XHKW3c6yOYdwC4 Message-ID: Subject: Re: [RFC v4 00/18] Split netmem from struct page To: Byungchul Park Cc: willy@infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, asml.silence@gmail.com, toke@redhat.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com, netdev@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 18F18180011 X-Stat-Signature: cpyzufsexawi5s1hbp9juu94r9sxzu4i X-Rspam-User: X-HE-Tag: 1749153344-44385 X-HE-Meta: U2FsdGVkX1/QHdfinK9n6ewpt9CpLFCzxONgRGrva4l4zbgjzG61yDpTT5lRDeJrw0FKohmbAT3hsmlzOS+loIVrDIcEeOZKe0ae2eJDMEspJryKFD8Kv8+aYKZAED8lh+EPKu7+8zusoA9GNb6VPjPAJF10XGw8jSO1Z0BNhFPvUHYGtMCTg0OUBfdEK9IxFVmUuP1H+HGcO9THVtQNZ1P3yHlfq2oIf4yjCIyddUPpO9wYecM7mYlv/jjBOvMz1s2iUC3W5CJyRxHPPbbko+93ift+8yrS4R8S1aYtQTvI6CUDqO9sqQqPUeGuI/ecG14wDPwzVhvpODUdVpJH7dZIiL8AC+L4SqoDKPOn8WC3/TLbF0Lhdn37NgElVO3VnWWEBatLIYsrHLMxlLxCwrP8EzGKcOCrT2YXeP9XC6WNCBWuI3EUJJs1U51NvFCZDWEp6nPOfGueEM2ohphqSD1bu+KEelcRX5JWgtCWudnNFEMQZUy6/q3dDEIZx3LTv7LaqLTU2It4jmUxD5HYAmU19sCk1tibDrl+kSx8pPFPssjwmviO0gAdpqJyoMaKuLd6rC2ASQHNEiiMYOG++9A/x2vP+fBEOSdrNE5drepgb/Qzt/NDTVaY+AMxlNWPTFESEig1o3JLbgowwEZ5afmQa61gvoz59OIHUlJDbu6WLqc9gtsQU5zXrNidQSbvjE28Kgr5sdWo6HiSqa1QLB0UIuQJVSxwLuAalGfieu6EtKcblejN1E87fmmquHj9YCLIuB+5hQPYcfIAu7vVkMyNCzerSsEHLgEqklqFySuQw5Orj1HBk2w2ljPqnVu11szn3jjBDO1Sd/jg9gu8M5LUJYGFQlGri9UmACFhmVTyggPifGCJ3hQMgxRxhV5VXRjXRe1fslAdBf+SQz+82CeAibtW+qToAWwfSwdyuUP2UcslOE2bDSYZCA5gyfcmE0EiePkSjDDFzE0bBFa DrylE8eJ jgJNSfTH492s1d3KNR8gOvmVsRqKmIgTzM6/yGbHjX5FwfOiOVqg5N5OO3N59Ptx7QovqDfEM54an7wya56YXLEz9Pr8AH6preNeT8LM+dGe4AuxAfM3IVkZLp/vEgaluOyJPxH2LWtqHItk/QM5HNaVgUhR8n03FEwNyY9etNt+DB4I/tM/D8EomNi4VtWOTm7S4MrNLqqmkBPpC7LC6Il7Y1hcZ/a50V/ovS7b25Hfpz56YdXkF3D8iUnRof0fDwrOA6SPDJpCvPSmC+4W7Y0WfuQ6M2JriySg5utAAtah0Xakv9IK1TCgjflC2mV740hMkAoSEFVRDRrgmFh0R2jeVYKkLrhayRrnOO/mYdQOKS5h+AZMr0mVEQ+iQOqztl2GxARttWl+txAdRfMvuccu2lxac4XjijzwfpsmqYP5aeOtMDRWG4xZ/tw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 3, 2025 at 8:23=E2=80=AFPM Byungchul Park wr= ote: > > On Wed, Jun 04, 2025 at 11:52:28AM +0900, Byungchul Park wrote: > > The MM subsystem is trying to reduce struct page to a single pointer. > > The first step towards that is splitting struct page by its individual > > users, as has already been done with folio and slab. This patchset doe= s > > that for netmem which is used for page pools. > > > > Matthew Wilcox tried and stopped the same work, you can see in: > > > > https://lore.kernel.org/linux-mm/20230111042214.907030-1-willy@infra= dead.org/ > > > > Mina Almasry already has done a lot fo prerequisite works by luck. I > > stacked my patches on the top of his work e.i. netmem. > > > > I focused on removing the page pool members in struct page this time, > > not moving the allocation code of page pool from net to mm. It can be > > done later if needed. > > > > The final patch removing the page pool fields will be submitted once > > all the converting work of page to netmem are done: > > > > 1. converting of libeth_fqe by Tony Nguyen. > > 2. converting of mlx5 by Tariq Toukan. > > 3. converting of prueth_swdata (on me). > > 4. converting of freescale driver (on me). > > > > For our discussion, I'm sharing what the final patch looks like the > > following. > > To Willy and Mina, > > I believe this version might be the final version. Please check the > direction if it's going as you meant so as to go ahead convinced. > > As I mentioned above, the final patch should be submitted later once all > the required works on drivers are done, but you can check what it looks > like, in the following embedded patch in this cover letter. > We need this tested with at least 1 of devmem TCP and io_uring zc to make sure the net_iov stuff isn't broken (I'll get to that when I have time). And we need page_pool benchmark numbers before/after this series, please run those yourself, if at all possible: https://lore.kernel.org/netdev/20250525034354.258247-1-almasrymina@google.c= om/ This series adds a bunch of netmem/page casts. I expect them not to affect fast-path perf, but making sure would be nice. --=20 Thanks, Mina