From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65464C3ABC3 for ; Fri, 9 May 2025 14:09:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D38F428003F; Fri, 9 May 2025 10:09:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CE6BB280031; Fri, 9 May 2025 10:09:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD65428003F; Fri, 9 May 2025 10:09:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9F1A9280031 for ; Fri, 9 May 2025 10:09:30 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1C649120494 for ; Fri, 9 May 2025 14:09:32 +0000 (UTC) X-FDA: 83423552184.02.AF1B3EF Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf05.hostedemail.com (Postfix) with ESMTP id 273A810001B for ; Fri, 9 May 2025 14:09:29 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ZeXfHkIc; spf=pass (imf05.hostedemail.com: domain of almasrymina@google.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=almasrymina@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746799770; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jCiKxL6LvoeyY9W6b3RA5blUeHU2Mmy1DhVz0FZzVWc=; b=RaRqjajYOPPhRhXVbAkKDCEl96VkzgJTYNcyAAUWZgkzzC1b4uMrK940J/5C6bXioroz7S S6jG7bllVSzpjMcDZYVMsHmDq7xkoa9eOTNS5LXiAtXs0hJv0T4jWxWnnOZ/xJcavlXpYf D5Upnx+ROKHrOolIE058bPUn7vcTeQY= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ZeXfHkIc; spf=pass (imf05.hostedemail.com: domain of almasrymina@google.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=almasrymina@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746799770; a=rsa-sha256; cv=none; b=SyfUcWFZJGPujih/9ge1oeCo+c7EvNJvCq98pIraM+2iDoRB9ldOpTrH4UuaxY3mvqGHFP R4L3B78+/qrg+IkscRmrXJlRf3h+JJtySrXui/ByRHeVIJkgg1srdtc0lk0275Dilshbxw KLQlPfigOXSV1MWWJoprPW4ZuKcS21U= Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-22fa47f295dso148165ad.1 for ; Fri, 09 May 2025 07:09:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1746799769; x=1747404569; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jCiKxL6LvoeyY9W6b3RA5blUeHU2Mmy1DhVz0FZzVWc=; b=ZeXfHkIcyhnw36JfFh/ztMLP/HlQlaBS9pg6HoBkEOGnJ7OkDvXRJaZ0g5yCMYwO0v fGiPCRKa+YmOIVwryEHqN2dWeWyUqxsXwCLpcnYROYSCcS3eZn4NKXrHN8TywkRkxkjo TWhQJlJpDwiWTCM56ikR20EcXM+FzxqjaIhEXgASmZ8bRyVlly/e8SrfXAKzVyEuYnz4 XX1+eET0ccHKWkh0gTwAd5B3ns5se3oZj5dfW4a/K0cBth8k5BpmZPNbn7yUInE3U1Il Laq37cpCINHWYOg9vdjo0lr0EEo2d3hqc+yWzoY7rPxUHhiNdZPiS4UTNUCISE78QRAV hKJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746799769; x=1747404569; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jCiKxL6LvoeyY9W6b3RA5blUeHU2Mmy1DhVz0FZzVWc=; b=O6Sw4Q/yIVfEO3DuBbSqeSWWg6KVv5FEmDSmIK06VKI2nf969n17EckgieWsGkAFRB UYmz+mRfaaihCkWx5Gc8uVENCy0bMy0910PatDOps6M7oHqzmsNKDFBowPTNeYRv3xmZ vjkHnlL56r+sCYdlFob1JvxZKOBNTnsMOcthKM2RqdcNgI5Key0r/5pYLa5/KfF0SnoU PBU8HUvklI0uNWUfRheqpdh9zGk3J5TgiJWEKlvQOeKMjRqnoOF5cj9y9fgqqA02yB56 Iu3iAKstsVnCXI54ZbHE3hBK+c/Y37Mr+Xz1Na7EzkeiLJTp7tw+Jc/MtsmRb+lULW0w lSQA== X-Forwarded-Encrypted: i=1; AJvYcCWX/+sDXRBxgfgmoeYD1cSZ804C4IYGlfg5443DLG6GUFvOvlS0HPdA0bWYfJrfHucZcucO85dF6A==@kvack.org X-Gm-Message-State: AOJu0Yw56XdkasAtLjBQZrtuskqjprtTB43N0tvKegr8hyj7FRfg7kAK KvxiIrf8ZluacHMvAd5GItUPcy3Uvqrba4R/NrivhmN9lcv1ZOmammL19/sIzsu2WHvFYXEfbCV C4B2iHLzR4Yuziq7QjD3PIhyp/EMSIlu7X7+D X-Gm-Gg: ASbGncsEnNrws8qmd7RE+eEMSh3kGoGSL2skD0FmyIfVTPNuqxxf/JUD4QgLijEB33C 1HhvQQCIcmXCmk832TpX6cCW86FtF0pAv1vYinIDFmYk8Yn8yfHUE1/Zqxpctw4hF7NZKCwVKBa sizod3FDD8G+EF9nKHL1fZW7k= X-Google-Smtp-Source: AGHT+IGMI/XDr8dUmvgSvSl1rg1l31oGTBGmNKBdui7zTK+cXuKqPn5F0+EqTjHwmKRPbjb5nSBKLROp6YQHQ8mm83g= X-Received: by 2002:a17:903:1c3:b0:224:a93:704d with SMTP id d9443c01a7336-22fca87efcdmr3648795ad.2.1746799768696; Fri, 09 May 2025 07:09:28 -0700 (PDT) MIME-Version: 1.0 References: <20250509115126.63190-1-byungchul@sk.com> In-Reply-To: <20250509115126.63190-1-byungchul@sk.com> From: Mina Almasry Date: Fri, 9 May 2025 07:09:16 -0700 X-Gm-Features: ATxdqUEcD0TRlngE7OhKXE4b1mDY8XLhym2WmzKEPsqCbaP_I_Y7Ra0p4qdhPME Message-ID: Subject: Re: [RFC 00/19] Split netmem from struct page To: Byungchul Park , Pavel Begunkov Cc: willy@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, ast@kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, edumazet@google.com, pabeni@redhat.com, vishal.moola@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: w7oecpk53cbosmxur9p5gfod3x33qiow X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 273A810001B X-Rspam-User: X-HE-Tag: 1746799769-134116 X-HE-Meta: U2FsdGVkX1+eEcVog7hl6ahFkyIGCDh6ToOF5UR86Ub6V6pbOjIf/cvEjRypsrAjYi2gfnHs9X+3bRcfwLt1wvbW0/2gDSJdlgmIYj1dymWi8CzIKDDuZ7r8ubLCu4WpjQniCEE+tJvhHmk1duLHe1w1OANTyr/3UDE6YrKV4bZzL9jZUBhxi0A6eVE57YMbYkz0caRNdpPjuitUBJ3m5e9ag1MT0UslC+auOb4Ic79gyFRFSW7mALZB7SAzLYRtqJEi2ecEEvfNzybECyiTG/h/7SmuYMknv7bcx5o93bXlYAaBGnaVQf8dn/xlkG8JqBLJ1QvF4u/+B7wIlM7eYc6j/WDwcFAT+e6hcmtwbWufA2DciaFItgS3fKPIlDD63tIAmWIAcUgwoe587QJLN/QA/OrPe5WW7sIJ1U6Ld2AKO0oV/tVSdK8gEjHZbGYrgGWo1OcYkNVPteuu9bySLYnroe65XXKBoN8Yl82CVRogDTkawCCcUAEo/429/h/RJPQulqvTXAIBb64JE0fatwvk1WU1jpmwtUUtIfvoUsET0B51KxgYiXFZ4ib+79b+4i5bzn6iS1pf10L3Nb4SXZAHNnRWfej7YRp7oAfA7tcFlOidd4svcZ2C9oF5av3IaKIdZW17Tuegw5rjZnw651R/WOOfr5iPdxMA02sRTPYDcBu30g4VOg2l7vFVzwPBD2iUkM+4xPaA6dnWmWgGa/WiCNsNkzhmv/b9IQXVu2LpWKQMpIhlzCg/7SXTmyhV8DMPIoY8aIFkkKO7lsHW7Vpa95zI1qPti2sJUTs3bQAGfUSZQhPD1V8xXFIXvF1sqI46ewvCGLwl3I52zJOzi550USST+29FnJiQDnedxAowJoykgD/lGSGvwMpAmWgBno0MuKrSR1bsErAFT7iYK54CB2tGh0G28r1hgt3GkRPLMS9IQbLN5g1WuAQYGsvVWsAMfu9p5/wU+YgTv3o S5qC8b/q pVDeoEAtKsF8c98kOEYvhFHrxXAX5UemKeiccqLe1170LB4Dlh/pDQ2yVLNE1oio7S9NdelzWft2bZ8B/cCum826iASioYOMhl2G8aVKimM8aToxeIGj6X/vOqDBYAAtk2LunMOYRZRtPLRSA1cwkKGDgd5p33n3JOBPG4gSKnmzqzUxLc54yOvfeyTXbO1/xLPFr/Ovwbcp/hwyz1iVu3kw3wmuEaHG2y6/84XAoYiZvxTbWHWJzzprZSjpDeglVYJphqvldqAw2Ls8aSodYU8teuZvqsCBle8sxMY8SXbzoM1BlDE3uWL8o3WozM3wX2BWSvcJHTFwcfKId7IDmPEoLyETkNBhqTndkwIabZCqxVXtFKpggzjYOvZe1s6siNt1LVD6gQy4I141qg3cAIjSDxqHf4f3b3XePu2T5FyJa1F/YyFYe02RzLA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 9, 2025 at 4:51=E2=80=AFAM Byungchul Park wr= ote: > > The MM subsystem is trying to reduce struct page to a single pointer. > The first step towards that is splitting struct page by its individual > users, as has already been done with folio and slab. This patchset does > that for netmem which is used for page pools. > > Matthew Wilcox tried and stopped the same work, you can see in: > > https://lore.kernel.org/linux-mm/20230111042214.907030-1-willy@infrade= ad.org/ > > Mina Almasry already has done a lot fo prerequisite works by luck, he > said :). I stacked my patches on the top of his work e.i. netmem. > > I focused on removing the page pool members in struct page this time, > not moving the allocation code of page pool from net to mm. It can be > done later if needed. > > There are still a lot of works to do, to remove the dependency on struct > page in the network subsystem. I will continue to work on this after > this base patchset is merged. > > This patchset is based on mm tree's mm-unstable branch. > This series largely looks good to me, but a couple of things: - For deep changes like this to the page_pool, I think we need a before/after run to Jesper's currently out-of-tree benchmark to see any regressions: https://lore.kernel.org/netdev/20250309084118.3080950-1-almasrymina@google.= com/ - Also please CC Pavel on iterations related to netmem/net_iov, they are reusing that in io_uring code for iouring rx rc as well. -- Thanks, Mina