From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45C60C433F5 for ; Wed, 10 Nov 2021 17:50:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E123C61213 for ; Wed, 10 Nov 2021 17:50:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E123C61213 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 732A86B0071; Wed, 10 Nov 2021 12:50:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E2FE6B0072; Wed, 10 Nov 2021 12:50:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 582A76B0073; Wed, 10 Nov 2021 12:50:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0054.hostedemail.com [216.40.44.54]) by kanga.kvack.org (Postfix) with ESMTP id 493DB6B0071 for ; Wed, 10 Nov 2021 12:50:27 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id D702D81773 for ; Wed, 10 Nov 2021 17:50:26 +0000 (UTC) X-FDA: 78793760052.23.CAD3334 Received: from mail-io1-f50.google.com (mail-io1-f50.google.com [209.85.166.50]) by imf19.hostedemail.com (Postfix) with ESMTP id B28D0B0000B0 for ; Wed, 10 Nov 2021 17:50:17 +0000 (UTC) Received: by mail-io1-f50.google.com with SMTP id 14so3774888ioe.2 for ; Wed, 10 Nov 2021 09:50:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0S9sZv9rv1MLrkq7aAvaZJLfChB0QbHa6Bap7OCVON4=; b=Mpj3q9y8P8tXTskEXoJ+jEkJNmYg08YiZzsMCwx006007UkWib0VzvWz+XRgkwol5g Cq2E/j2ydmsTRrr6KctSBpI480yI3FutqwVcqwb2VlKHUwJWTSsJTCzxJGnIs6kVN/3O DGBhPSDpOxGfegmMhpOX5LX4qoDI1mjiVhMW60IwBCuqrEqdpCvWOXNc2veK2u35aN08 9ckXcJZs87m5QlP77fFFqpf/4jYJaI9QF6U+YIzxX/8Yk9uT+ZKlfuBEgd4y9TQUghkw qaMwa1ayBoLvEKFMLOFsRyir02bszFEdJx/Mmy+VsMnvsU7c1SxsVicijg0LX8EzhIH2 MSxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0S9sZv9rv1MLrkq7aAvaZJLfChB0QbHa6Bap7OCVON4=; b=cS4g4wr1ir0GvwWjNwaRAUv1Pe5BSbXFdxKUfF+3dhkaad6KAmTlXKeijGUJ/SZqiA MwLF6HatLrUsxybU0h5vfyA3enHyjzVTqo2GitimE8ZqUUaycNqVQt4rdMdRXxRMAPcR WPqMuRDdWPoWuOzT9pii4BLdUrZDoPMSwqmtgS8MaDBNB+VYT/OGkP8hUdrFnyWSb0iq fdAQWa0ULg3vn/blOX6VyJeHoUOJ7yF+V/p7m4OqRH4fvnfeYKjpHBTtL2/iso/yt/zo gOlrxRwz6GH143EkeoC40rs8mjjONcNGDIBQ7ny7lWxJBePwCNVd4UGs/WxJvmwCP/l4 RBkw== X-Gm-Message-State: AOAM5305aHA4II8p5V526PcP/KfZxwOvbxoChlwF2p5bdrUDBOxo1dN3 5Ky8AcSsbUuF+zVxXZg/nSEuA00vhxT6lnsWHwLYtQ== X-Google-Smtp-Source: ABdhPJx8SVMZqY/M+G/wfHByt0Gdg7mcZQx8twUBaM2wGi8juiZIcAzzBUsezhqV/JnXuzMhcKYRZ7I6PzZJKf5g7kI= X-Received: by 2002:a02:c559:: with SMTP id g25mr489184jaj.123.1636566625557; Wed, 10 Nov 2021 09:50:25 -0800 (PST) MIME-Version: 1.0 References: <20211107235754.1395488-1-almasrymina@google.com> In-Reply-To: From: Mina Almasry Date: Wed, 10 Nov 2021 09:50:13 -0800 Message-ID: Subject: Re: [PATCH v4] mm: Add PM_HUGE_THP_MAPPING to /proc/pid/pagemap To: Peter Xu Cc: David Hildenbrand , Matthew Wilcox , "Paul E . McKenney" , Yu Zhao , Jonathan Corbet , Andrew Morton , Ivan Teterevkov , Florian Schmidt , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: B28D0B0000B0 X-Stat-Signature: cn3kii15bm9wsmiuwqmu9b4ghtpxqtgd Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Mpj3q9y8; spf=pass (imf19.hostedemail.com: domain of almasrymina@google.com designates 209.85.166.50 as permitted sender) smtp.mailfrom=almasrymina@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1636566617-216272 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 9, 2021 at 11:03 PM Peter Xu wrote: > > The ending "_MAPPING" seems redundant to me, how about just call it "PM_THP" or > "PM_HUGE" (as THP also means HUGE already)? > So I want to make it clear that the flag is set only when the page is PMD mappend and is a THP (not hugetlbfs or some other PMD device mapping). PM_THP would imply the flag is set only if the underlying page is THP without regard to whether it's actually PMD mapped or not.