From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35DE5C61DA4 for ; Wed, 22 Feb 2023 21:18:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E7896B0071; Wed, 22 Feb 2023 16:18:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 970E96B0072; Wed, 22 Feb 2023 16:18:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7ED8C6B0073; Wed, 22 Feb 2023 16:18:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6F0BD6B0071 for ; Wed, 22 Feb 2023 16:18:11 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 37CA08077E for ; Wed, 22 Feb 2023 21:18:11 +0000 (UTC) X-FDA: 80496190782.08.E27215B Received: from mail-vs1-f54.google.com (mail-vs1-f54.google.com [209.85.217.54]) by imf06.hostedemail.com (Postfix) with ESMTP id 79002180018 for ; Wed, 22 Feb 2023 21:18:09 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=eXV1cQ6J; spf=pass (imf06.hostedemail.com: domain of almasrymina@google.com designates 209.85.217.54 as permitted sender) smtp.mailfrom=almasrymina@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677100689; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=otM8qhqUgaC56OL8G3qlw4NF5AhDokREGtXy6YgiFWA=; b=Jc3YufuPNYs8oy3sd2DPm5C1IkdplEJD2VZ4n+v5ty3J77mAVsCfyEDCQMI1JPDoc4Y3ic JHour4t9Xn/Wyo05lnmGM1GRf1lyxRj6fC3CmWgnVyypkqztHdfbMvpajV/f94hHYWW29c 9KkNdqsyN8M+zDtltb1JTMrNH/tzUx0= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=eXV1cQ6J; spf=pass (imf06.hostedemail.com: domain of almasrymina@google.com designates 209.85.217.54 as permitted sender) smtp.mailfrom=almasrymina@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677100689; a=rsa-sha256; cv=none; b=cDgKYk77LkZWpFwm86JjJBn9lhwwypYYXDprqR25uXAhjW2JW5CCXYxGZRCyieTgQLhMvb 2078BJdLenzI8+HWC8Rey+pTqznA2590Y6tlRIAah+3xNK892bIMHmJkrLcf35QOnKBLNQ F6zq8iSbcXoIc3gV9X2d/fMbniirPrc= Received: by mail-vs1-f54.google.com with SMTP id f31so11478050vsv.1 for ; Wed, 22 Feb 2023 13:18:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=otM8qhqUgaC56OL8G3qlw4NF5AhDokREGtXy6YgiFWA=; b=eXV1cQ6JwcBmeQSYFlVACqwetVMSOPxE6Jd2p8DN0Zt4wzQ+k5F4nq5EKJmGG7k+y1 2M+CMNn2TEHBOgYstQYyVi+O9HEeEjbTWUKuJOJGDvt/22beOj089cowScL9hMBd71QC PVNClTGqmvZwYMqPCi0biRPCZqXfMM6bZDEd0sPO/+uP8I9HHzBvh2nZQge+Odf1sxoB CNpQM1JFyKXWHx156KATBlzKC/7mJcI2Ub8AxYq46xGR6wPoIky+K0akrh7zaSlYKZFY 6o2FftsSRZggVQkYrihHo8gcbD3ULni0gy/CxtKhpV3uDIHLrkB2pDf0mcFNnwic2J32 L6+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=otM8qhqUgaC56OL8G3qlw4NF5AhDokREGtXy6YgiFWA=; b=zJdabzRGQlKkqEFDrds82WjzC5rIJIdXyF9MaySzB2qFUq8Vpdyc33Ui+2XqELmJZ3 zGULiTCcK0TgV4z/yS4AOzFlqSQ6Ctk8psic/s0mABgvBP2lBbY2xaV3R59m3xjiuDxL g3qZdpSXWL/4RJFk/ACjuT1gUPPct68tKoh2Br9DhcKMQAvRZLI+tPOJ5eQUKrXeAMby CH3BYj4XXIentMliG2A/30ZSibXNHUIdgO5kEmnKy8/a8ldHQAvnoc3hOAr/u0fhVjWG HaAZphf5FWYH4t2Qy2z2Uu0YSwUCs/Q4XPXV4MoDQnqMnmzO3Q+y19dEdJvmSZTgx2jS Rmzg== X-Gm-Message-State: AO0yUKUDOTY3KuxwKUaKDCBfB81l16g/w6vsWLSpiJ1jtvkwr98z4u9o 8pC5Bs3jmlosMy9XHxcfKLFlU6sxM3THiwf1jRlbLA== X-Google-Smtp-Source: AK7set9M9yI5gWDrVIc5jaubLhHZ9pdVfZZsdKXZRAudRRYOLYEDgOXrEunt4gpCSfAJkyWSsa2rJruKDiLt8GQXYs8= X-Received: by 2002:ab0:38d3:0:b0:67a:2833:5ceb with SMTP id l19-20020ab038d3000000b0067a28335cebmr2737124uaw.0.1677100688403; Wed, 22 Feb 2023 13:18:08 -0800 (PST) MIME-Version: 1.0 References: <20230218002819.1486479-1-jthoughton@google.com> <20230218002819.1486479-17-jthoughton@google.com> In-Reply-To: <20230218002819.1486479-17-jthoughton@google.com> From: Mina Almasry Date: Wed, 22 Feb 2023 13:17:57 -0800 Message-ID: Subject: Re: [PATCH v2 16/46] hugetlb: make default arch_make_huge_pte understand small mappings To: James Houghton Cc: Mike Kravetz , Muchun Song , Peter Xu , Andrew Morton , David Hildenbrand , David Rientjes , Axel Rasmussen , "Zach O'Keefe" , Manish Mishra , Naoya Horiguchi , "Dr . David Alan Gilbert" , "Matthew Wilcox (Oracle)" , Vlastimil Babka , Baolin Wang , Miaohe Lin , Yang Shi , Frank van der Linden , Jiaqi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 79002180018 X-Stat-Signature: 5mm4uujaeu4o7nxt3ip1nd5yyjpnqrpk X-HE-Tag: 1677100689-295762 X-HE-Meta: U2FsdGVkX1/HldGxcL+KpG+Me3wS5g5qml+G1nPsnt7sVEhYiTVPKTqdXj2y+8LnsoAvBGKFtZbIkXNe+22CWbvA1CsMqlu99shRpElP/NLcQ0/pVSQXrs/obYdbXEoNwjQ7/1aAugI6QqjKh69+SU5cr/GZJp7lUFNUIpBp3St6hEOdUFht2NvoxH9pOzkdPPvfwScGDoGkNIJ1GL3utq8jG9oyMZLtKrDjaXB0qeBiKG9JotFWqWmMffWOJKvv9YUcSJI9TT9bimyRhgc8bNemuJdHXmytpy7v1YDzrm+GEK0HydtbKrYJckjq9DEG23Vkf+xq2448EkpE8CYFFqjHO+2FWAHfU2DZ3fsMcriJroZmNQ/FVzP4n01AQscJhHw05gDn9WXXWpT84OLTOGCypGiFHW9cbrs1eBqu/rHMu1yw+vRBfotbybkVV4v4m5ROW3qaPuWN+/nmFEeecQxVfEn6tI+tdcGF9N/pegpmZYBZgtl5Fj6cLoKs16+FJr/LWnxC7kcCRMb8O/ZK9kjnQeCZroWqizZnKlrNUbRF1QNrl/bpRmitAGY5NG8CPCfS4UW9+nJs2LG3sV3cIzybo86bEUQjcSc7ZBN1Ei32qJ4/GXbRqgmx62XgDXiQT4BJ7BBzkSmVDKpbGccZN1iHVRdyRRwn4uQh1wInYPutu6o7wair1qvQOvklmDcuceELV7bPV92lMYJq295vupQib3NRYAB9Q0iE2b+naDcKnZwDRcm3tMkkyDkntXZKQ3QgH30UV5f5YdXcvZ1EcqWCtXFc1hwbOS+qAU+uxZg4UTPkp+q+XZXt+PVTjrUMfiHwAeyPgJKtHwfObRzPPvhZ3PvjkbQEDaN45cFDUx2c5rXEiorqE1IUJaMHdsy4FWJohm8FcACrerlWQgbUKjU1VxncJkTIaGXFtxKZz+Fc19HXcOoIxUve6NB3cmKJMwFBVQMWbJGc0XZ4xPZ fWZkdbzL d2ux1hJUACK0eh6tSRx66xo4HDDh9uiScnip01vy3kMZWD07lxYn1gKvttHeMA1u5HjZ4zBFXIGq1LzvN0zqq/HdQj0ssjaRcfACd6mqy/xSWfQ+TEMm1og7LZFX/L1rAajgL5pNiEwtSrYZKU1PYfmCS8uXFpoP1dxDZkbMxQj+UuE7Jkki6Uh9RyOAOEDWhwg/FpEE7gD5pc2l2IUhITs6b1BCylemBrqmzoj4clm/MrpspPr3ngeWjt8GZH4Byz/CrOu1fvLVdrs3Bs06E6qAFHwsxjZiQcOj4itoNx2Ascj+m3UyOOpearg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 17, 2023 at 4:28 PM James Houghton wrote: > > This is a simple change: don't create a "huge" PTE if we are making a > regular, PAGE_SIZE PTE. All architectures that want to implement HGM > likely need to be changed in a similar way if they implement their own > version of arch_make_huge_pte. > > Signed-off-by: James Houghton > > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > index 726d581158b1..b767b6889dea 100644 > --- a/include/linux/hugetlb.h > +++ b/include/linux/hugetlb.h > @@ -899,7 +899,7 @@ static inline void arch_clear_hugepage_flags(struct page *page) { } > static inline pte_t arch_make_huge_pte(pte_t entry, unsigned int shift, > vm_flags_t flags) > { > - return pte_mkhuge(entry); > + return shift > PAGE_SHIFT ? pte_mkhuge(entry) : entry; > } > #endif > How are contig_pte's handled here? Will shift show that it's actually a contig_pte and not just PAGE_SHIFT? Or is that arm64 specific so it exists only in the arm64 version of this function? Do we need to worry about it here? > -- > 2.39.2.637.g21b0678d19-goog >