From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4B45C04A68 for ; Thu, 28 Jul 2022 18:00:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C3168E0002; Thu, 28 Jul 2022 14:00:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1734F8E0001; Thu, 28 Jul 2022 14:00:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03AF38E0002; Thu, 28 Jul 2022 14:00:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E97768E0001 for ; Thu, 28 Jul 2022 14:00:37 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B3D3C8156B for ; Thu, 28 Jul 2022 18:00:37 +0000 (UTC) X-FDA: 79737273714.06.CEE92E7 Received: from mail-io1-f50.google.com (mail-io1-f50.google.com [209.85.166.50]) by imf16.hostedemail.com (Postfix) with ESMTP id 4B4341800D9 for ; Thu, 28 Jul 2022 18:00:36 +0000 (UTC) Received: by mail-io1-f50.google.com with SMTP id z132so1984630iof.0 for ; Thu, 28 Jul 2022 11:00:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=nCov8FRHa/Y3WlCrgO3ByBndA0cH8Dsr76Rv0iqZvhk=; b=MFXTorzN9HfVbCWJvb8LnqZJt18x3Jre8H0O+MmqTYbWRYedlH3VQJFqv+fdcQ1J3J IIhHqv9gbF7usEeMubH/xq3+4IQZbgPUZ2Do1ZNH57WByFBV2qqVUyoOFRUdAuTNIHwl fEtBJ+s+GC02PMzH2/4TG99jBqetQFhS/neRqLn7wM7I/4vhssmTXY9ju5z1sbolK1jL DVr8sgdvDvFJbyKdF298oGsNnHJ38ExfMibWh+3rz2GqdFWTBn7P/Hn1MOmFYM3E82Ug cbD4zfNz+/1xAVHMcgS4evVpKm8iG+bj7+wn5tOP95RDOq+T3x7HVV0V5d5ggalIsW+h NpBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=nCov8FRHa/Y3WlCrgO3ByBndA0cH8Dsr76Rv0iqZvhk=; b=yz/51CYPV+f9q5fS94X18si24RLnBRsjtN0kLBdU2kOIy27OuOKOr9icfBb2QG3bxG 80GcvDJOQUtU/jAQhNLUFG/pbUdfDgd23xQ3ZXbEzZn3DxF7JOxDPkKcreWRKwpVjd8D OkgG0RzgInGpN6nQR05jqprTeNcSgYSkPPeVi5hTYvtcyG0xQPjwwcwNZsBPZL+am7mT XXMqfMBwjA8FQnPDoIjdDSNI17tGvtAbue4iNdFePYbFT6w/a6koF86fqx0cFfiL2QAf yT59jBx1EKAQorRUXSNSheFxh/iSG6M0v7d38bnLT+NRJPrxUNzvSr1LHht+mi0iAwQm gcbg== X-Gm-Message-State: AJIora8LoTODHjZ0YCh7Nfvm20hpdPgyAop2EkXGhAcsZgxAXjhqTfKH MM5GFWsq9Vcrp5CDw7ye+ROd7OyWTqrR17gqLJkUbw== X-Google-Smtp-Source: AGRyM1sPIe+RIV+y/3FLq45Y8+1JDmnIKY3tNadQz5QP+aZxYEPXsrlHwk/ygeTsRfDASjnqcNiyO5wLNgqQqlrPqiM= X-Received: by 2002:a05:6638:2391:b0:341:48b3:29c5 with SMTP id q17-20020a056638239100b0034148b329c5mr10970147jat.293.1659031235477; Thu, 28 Jul 2022 11:00:35 -0700 (PDT) MIME-Version: 1.0 References: <20220728121949.20985-1-linmiaohe@huawei.com> <20220728121949.20985-6-linmiaohe@huawei.com> In-Reply-To: <20220728121949.20985-6-linmiaohe@huawei.com> From: Mina Almasry Date: Thu, 28 Jul 2022 11:00:24 -0700 Message-ID: Subject: Re: [PATCH 5/6] hugetlb_cgroup: use helper macro NUMA_NO_NODE To: Miaohe Lin Cc: akpm@linux-foundation.org, mike.kravetz@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659031236; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nCov8FRHa/Y3WlCrgO3ByBndA0cH8Dsr76Rv0iqZvhk=; b=4QMcR7t7AotVGJwT4yUmWstGWVKpQ4z4IGMDEupNtmy68kkKMJnu+dG1jnqWsd0cI3mfPy O34sM/WdJfuAP/5Mlc6wRSQi6eAoPI06YuAWuiSGAQ2/rk0ebjHBDWLP+5Wrg868roxEfd BHnCRz/GorzXbdUwUOmXANTOJHWSY/U= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=MFXTorzN; spf=pass (imf16.hostedemail.com: domain of almasrymina@google.com designates 209.85.166.50 as permitted sender) smtp.mailfrom=almasrymina@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659031236; a=rsa-sha256; cv=none; b=ybcyRqTaWbuK+PtYT4GUQuHgyPKx0C5kFp9XW+8qKbF3NxQh5vQtn/7so2jUSEEy+OZOh/ Zt/5TOgdmJhVY+OToN0n9dIaBfrHRSvYxh/3L+z9nlvGheCpvpVm/4B69tl8sYBqMoSW8E vJ15R8JnEeU6gEZvH4YE3Q51jvxEen8= X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 4B4341800D9 X-Rspam-User: Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=MFXTorzN; spf=pass (imf16.hostedemail.com: domain of almasrymina@google.com designates 209.85.166.50 as permitted sender) smtp.mailfrom=almasrymina@google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: uhsh8nfkcyfwuha9sq7chgwidn8na378 X-HE-Tag: 1659031236-937040 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 28, 2022 at 5:20 AM Miaohe Lin wrote: > > It's better to use NUMA_NO_NODE instead of magic number -1. Minor > readability improvement. > > Signed-off-by: Miaohe Lin Reviewed-by: Mina Almasry > --- > mm/hugetlb_cgroup.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c > index 7e0bca52c40f..13ec091385af 100644 > --- a/mm/hugetlb_cgroup.c > +++ b/mm/hugetlb_cgroup.c > @@ -153,9 +153,9 @@ hugetlb_cgroup_css_alloc(struct cgroup_subsys_state *parent_css) > * function. > */ > for_each_node(node) { > - /* Set node_to_alloc to -1 for offline nodes. */ > + /* Set node_to_alloc to NUMA_NO_NODE for offline nodes. */ > int node_to_alloc = > - node_state(node, N_NORMAL_MEMORY) ? node : -1; > + node_state(node, N_NORMAL_MEMORY) ? node : NUMA_NO_NODE; > h_cgroup->nodeinfo[node] = > kzalloc_node(sizeof(struct hugetlb_cgroup_per_node), > GFP_KERNEL, node_to_alloc); > -- > 2.23.0 >