From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42E8FC433F5 for ; Mon, 15 Nov 2021 22:39:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C569E61C32 for ; Mon, 15 Nov 2021 22:39:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C569E61C32 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id C94966B007B; Mon, 15 Nov 2021 17:39:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C43066B007D; Mon, 15 Nov 2021 17:39:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B31C66B007E; Mon, 15 Nov 2021 17:39:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0042.hostedemail.com [216.40.44.42]) by kanga.kvack.org (Postfix) with ESMTP id A2FDD6B007B for ; Mon, 15 Nov 2021 17:39:20 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 61FD78249980 for ; Mon, 15 Nov 2021 22:39:20 +0000 (UTC) X-FDA: 78812632080.13.625BAB1 Received: from mail-il1-f182.google.com (mail-il1-f182.google.com [209.85.166.182]) by imf14.hostedemail.com (Postfix) with ESMTP id A1905600198D for ; Mon, 15 Nov 2021 22:39:20 +0000 (UTC) Received: by mail-il1-f182.google.com with SMTP id l19so18354297ilk.0 for ; Mon, 15 Nov 2021 14:39:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yUwYNrMRiIW2ymDJW4VJI2eBOXEvnHxjYgLtMFL5dtU=; b=Mo/no1eO3vUwMxvosgyzBvyvml0KAnKn/aMS3fSt247ikjoAu4SCRvsIfJlkpuh+9B tG//C1fmSb74+p6D17IuHCFggu0q3Qzh+L6Jb5N5Fsj0gGT0MEK5G7Ib+USRXDKR0ed2 NDX1ksAU2ZxMRsfrBtwXwHJ+/Irzw+yiGRyM3YWngxcstF0+cEw6V50qtli576exi6+2 zbCjdAXUAXWfIKDZxSepAsTyF0Oa8pGle7gJyIyv5Eq/1Y31zklmfsDdXdqCgXclhRVO R9nUxATXHCKISlMsT9vOtnYnPMTEmXJO/wiT6ib2Z9Oqyo7AtyvpuQMy/pHQHoPCrmAE qRAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yUwYNrMRiIW2ymDJW4VJI2eBOXEvnHxjYgLtMFL5dtU=; b=nFZ18uALQNLxpImT+r1W9uJzcSOOLi1Tm0Fdsz/CGdzP5ia1z2/t7+TgjSL5wXLuc1 jTDJIEEpqNZegCeXsr9zMMnEB3kR1MHkhHUl260Te0Ubctox/hHrVxHY/Syv88bAPccH GHYmgCNMq4kCrZ+C508jM8DSViCjr3qFOUspRo+G2f+WVl50j2g+Up+jtqcfE0pKDmb6 oDOHLaW8ecujBqfTVzGAAupnsbgunder3zgQOeex0BUSorsYBjwHfUXkW0binFk+JhUk nHhg6o7S27UgT+YRmeyyo0qPsWxkALYiBqWa+MLCEOz/c2bHDqCWYzBMjKQ3nKCw9gik VoJQ== X-Gm-Message-State: AOAM532CC12cSBFxyXIU8VuO+AZgcv3WXmWIoYDgnvSuemaZNnxFy5xj 9Dqz9S/mWfW82Td/iVyCKiNtOikIfxOD42VeTPZbKQ== X-Google-Smtp-Source: ABdhPJxa2fag4jC2rjJuDGd7c5qYustjXIyKp92upm3FPQdlPFxwFtSLX6D9aLUQpOE0tQ99ZytDTyAFtZtQWiNAhbA= X-Received: by 2002:a92:6b0b:: with SMTP id g11mr1585697ilc.146.1637015959237; Mon, 15 Nov 2021 14:39:19 -0800 (PST) MIME-Version: 1.0 References: <20211113154412.91134-1-minhquangbui99@gmail.com> <20211115131633.81e1879e36aed4a0290e6f0c@linux-foundation.org> In-Reply-To: <20211115131633.81e1879e36aed4a0290e6f0c@linux-foundation.org> From: Mina Almasry Date: Mon, 15 Nov 2021 14:39:08 -0800 Message-ID: Subject: Re: [PATCH] hugetlb: fix hugetlb cgroup refcounting during mremap To: Andrew Morton Cc: Bui Quang Minh , Mike Kravetz , Miaohe Lin , Michal Hocko , Muchun Song , linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: A1905600198D X-Stat-Signature: 19b7gkt1smq7d9c3pkpx7zq1936fhdq7 Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="Mo/no1eO"; spf=pass (imf14.hostedemail.com: domain of almasrymina@google.com designates 209.85.166.182 as permitted sender) smtp.mailfrom=almasrymina@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1637015960-467240 X-Bogosity: Ham, tests=bogofilter, spamicity=0.022070, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 15, 2021 at 1:16 PM Andrew Morton wrote: > > On Sat, 13 Nov 2021 22:44:10 +0700 Bui Quang Minh wrote: > > > When hugetlb_vm_op_open() is called during copy_vma(), we may take the > > reference to resv_map->css. Later, when clearing the reservation pointer > > of old_vma after transferring it to new_vma, we forget to drop the > > reference to resv_map->css. This leads to a reference leak of css. > > > > Fixes this by adding a check to drop reservation css reference in > > clear_vma_resv_huge_pages() > > Thanks. I added cc:stable to this (550a7d60bd5e35a was merged a year > ago) and I've queued it for 5.16-rc2, pending suitable reviewer feedback. > Thanks, Reviewed-by: Mina Almasry