From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA02BC4332F for ; Thu, 1 Dec 2022 22:10:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2DE096B0071; Thu, 1 Dec 2022 17:10:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 28D6D6B0073; Thu, 1 Dec 2022 17:10:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 12E5F6B0074; Thu, 1 Dec 2022 17:10:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 00FDF6B0071 for ; Thu, 1 Dec 2022 17:10:50 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id AAB42ABAFC for ; Thu, 1 Dec 2022 22:10:50 +0000 (UTC) X-FDA: 80195133060.11.918668F Received: from mail-vs1-f53.google.com (mail-vs1-f53.google.com [209.85.217.53]) by imf24.hostedemail.com (Postfix) with ESMTP id 52976180014 for ; Thu, 1 Dec 2022 22:10:50 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="C5A/tE+O"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf24.hostedemail.com: domain of almasrymina@google.com designates 209.85.217.53 as permitted sender) smtp.mailfrom=almasrymina@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669932650; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Rf84obAKN/8ruolDjM0pM28OtudVnfPduob08XaAHeM=; b=p5yFoedc4bNBWVa369fmED7ObZ8PCOwXAGE5WIwP2HPw//CuXs9E71sK0+wCiBGwU/sweb mQgTeVl4Ch+uN8Xh2R8ZnSnKC3uSRxjgUnlhDy7x/nIagiS7Hcz9t0855p0Rj0MqgEsrXU vG8bGwQAehyIqeFqZWD38Bc+kpauyfk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669932650; a=rsa-sha256; cv=none; b=NezoYyjUrSo6IRfGDMFgsWrAMWMrmKfbUEv+mq3EVvd1MSXsgfzfcralwOat0BhhyqBO2f Qv1bWgrDN0shgwME/kkCllRD/jNRaX2SI3tR0whRkyjT6dfsKOminnlk6fYSj26SRywKfs /hSz7mxsum1Q4GzwWn/YlddW1jzE78g= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="C5A/tE+O"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf24.hostedemail.com: domain of almasrymina@google.com designates 209.85.217.53 as permitted sender) smtp.mailfrom=almasrymina@google.com Received: by mail-vs1-f53.google.com with SMTP id 3so2150550vsq.7 for ; Thu, 01 Dec 2022 14:10:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Rf84obAKN/8ruolDjM0pM28OtudVnfPduob08XaAHeM=; b=C5A/tE+OvI+/icvXdhe39VigA0TTbTY4PJd9mnXEXbnfkr0SrvZc1sS0BhKGJ9tFbH VrlF6IzPg1aqf/aWu55hvBF9KZc12XIGaiyBaaWM8tzg9pEnKuCYLKsOWIO9iIRoq6fN h+9U6WOdvTl4++/BjtWYxzFMTOs+g5fd6qJ/zeLOaxZ5HqfmU3EFndAxTDwLIhOvufRg lz9HYLOosZUavj+NWHAmwUBmjsPobyVqbSeR7xoIPkhsfX+u6FQFeFXf4lUXDXHETkX+ aOg84lpe1797MkZHvW3Z/yK8LBKC0vRON342vgsQ0hEFEvXwFpzRCnmNE0JkU96V1fXe hHqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Rf84obAKN/8ruolDjM0pM28OtudVnfPduob08XaAHeM=; b=R9YxzC08KqnHRgo88ea6fP9AcTP9sQ/qeBIX01HiDfYLqO+PkdkFBcDt1D+78cMEqJ YfnfeqbZdl4KmC0tW+aIOrd4opcizywnxN1TTtgCUiivFwQ6KOMBpXN8EAUoFMxWA/J8 f4uL6b7G48kHJiv5c6lQkSzFTXKkd2sV/uRsKN7tqq6Ut4S+HvmUhVpAebl28mQ7+a1V CPyW6T0EXBzs0HkcmkkBqvBi2qEZe4t6/QRc2q1d/zsCzPQus0ee4dhEpcaY1PKDJ6Jy F7p3jU+eBbEUZpENU3BbHqfnlKuoulVB6umFsZ3BJy2KXe7rZNZOoZ4IIRvTi8Me74+L 4vhA== X-Gm-Message-State: ANoB5plU3BZYnAwxCVKap2pOs0BVb4FsJ6df8W8fUbf1rqdO4eQpxt1y ZJNCv9teVTiECISRMMuK8zhJY7Upujw+9PZaW9iPag== X-Google-Smtp-Source: AA0mqf7+zcrz2gPmzIkscfmr5SMSSgOcjkv+7kg2SOfHpFg5FBWFgEZt95ZGmuZG032Oshqx0NMxe3bwoGr4Onh742g= X-Received: by 2002:a05:6102:cd1:b0:3aa:1bff:a8a5 with SMTP id g17-20020a0561020cd100b003aa1bffa8a5mr39103278vst.67.1669932649473; Thu, 01 Dec 2022 14:10:49 -0800 (PST) MIME-Version: 1.0 References: <20221130020328.1009347-1-almasrymina@google.com> <20221201213202.ycdaymwojd5plyrk@google.com> In-Reply-To: <20221201213202.ycdaymwojd5plyrk@google.com> From: Mina Almasry Date: Thu, 1 Dec 2022 14:10:37 -0800 Message-ID: Subject: Re: [RFC PATCH v2] mm: Add nodes= arg to memory.reclaim To: Shakeel Butt Cc: Huang Ying , Yang Shi , Yosry Ahmed , Tim Chen , weixugc@google.com, gthelen@google.com, fvdl@google.com, Tejun Heo , Zefan Li , Johannes Weiner , Jonathan Corbet , Michal Hocko , Roman Gushchin , Muchun Song , Andrew Morton , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: f18z41zn6npfpy467sb4jifebcf131x6 X-Spamd-Result: default: False [2.65 / 9.00]; SORBS_IRL_BL(3.00)[209.85.217.53:from]; BAYES_HAM(-0.45)[78.88%]; BAD_REP_POLICIES(0.10)[]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; DMARC_POLICY_ALLOW(0.00)[google.com,reject]; RCPT_COUNT_TWELVE(0.00)[20]; DKIM_TRACE(0.00)[google.com:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[linux-mm@kvack.org]; R_DKIM_ALLOW(0.00)[google.com:s=20210112]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(0.00)[+ip4:209.85.128.0/17]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[] X-Rspamd-Queue-Id: 52976180014 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1669932650-212051 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 1, 2022 at 1:32 PM Shakeel Butt wrote: > > On Tue, Nov 29, 2022 at 06:03:27PM -0800, Mina Almasry wrote: > [...] > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > index 7b8e8e43806b..23fc5b523764 100644 > > --- a/mm/vmscan.c > > +++ b/mm/vmscan.c > > @@ -6735,7 +6735,8 @@ unsigned long mem_cgroup_shrink_node(struct mem_cgroup *memcg, > > unsigned long try_to_free_mem_cgroup_pages(struct mem_cgroup *memcg, > > unsigned long nr_pages, > > gfp_t gfp_mask, > > - unsigned int reclaim_options) > > + unsigned int reclaim_options, > > + nodemask_t nodemask) > > Can you please make this parameter a nodemask_t* and pass NULL instead > of NODE_MASK_ALL? Thank you very much for the review. I sure can in the next version. To be honest I thought about that and made the parameter nodemask_t because I thought the call sites would be more readable. I.e. this: try_to_free_mem_cgroup_pages(memcg, 1, GFP_KERNEL, MEMCG_RECLAIM_MAY_SWAP, NODE_MASK_ALL); Would be more readable than this: try_to_free_mem_cgroup_pages(memcg, 1, GFP_KERNEL, MEMCG_RECLAIM_MAY_SWAP, NULL); But the tradeoff is that the callers need include/linux/nodemask.h. But yes I can fix in the next version.