From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FC9FC4332F for ; Wed, 13 Dec 2023 01:51:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA8A26B042E; Tue, 12 Dec 2023 20:51:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B58636B042F; Tue, 12 Dec 2023 20:51:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9F9E06B0430; Tue, 12 Dec 2023 20:51:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8DAA06B042E for ; Tue, 12 Dec 2023 20:51:06 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 62B78A0AD7 for ; Wed, 13 Dec 2023 01:51:06 +0000 (UTC) X-FDA: 81560116932.13.DD4FED5 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by imf03.hostedemail.com (Postfix) with ESMTP id 8A0D420002 for ; Wed, 13 Dec 2023 01:51:04 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=DVdowIjG; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf03.hostedemail.com: domain of almasrymina@google.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=almasrymina@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702432264; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rVTd+wP+FI3iBMvI4P15hw8Ct9Bf0aO9fRFezq4rPu4=; b=MGZFDZddAvzvPmDy3loJerW4cuyAzTaVsXCmT7xAKNCQqGg7lrpYGicInYelinG7DAC87T jwRYMrIq/wsC+hLaAWOzwM5WaccKSvGfZy+ksPfuXacMXBxxEAaOgeCAI84QCcrdR5LXpo RPs8HHXDqzFSrvVJdbRt19XI9hYBxr0= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=DVdowIjG; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf03.hostedemail.com: domain of almasrymina@google.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=almasrymina@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702432264; a=rsa-sha256; cv=none; b=DxU9Lx+xageX7T13mwRKLQEc8OFVLhU3uLF1Vqym/WZuCu8CHUJQ2xNnS3UDVAgN1A25yo sDp19f+kH6VVxDnlqhKZ4PQswnFPOcv3v6S0K1Hvza9mtmXewZB5id3yL4gyZyKqar8xw3 i34+uD11Jv8cUg3N3rTxgc2ZD+U394E= Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-54f5469c211so6345318a12.0 for ; Tue, 12 Dec 2023 17:51:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1702432263; x=1703037063; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rVTd+wP+FI3iBMvI4P15hw8Ct9Bf0aO9fRFezq4rPu4=; b=DVdowIjGlkZRPRwPSpqYShO20xsM2Af9YOo6p/r2biZtmml3Qyu9UHLFbQX2t8/VsL ZM+yAjP8RGhAf/qIhK5I+DNudQ7+NupU/YzyfOGmhPLpTkdQxJmOmRA4mu2A/4IgyP+B IGkQQtPmtjhfVJ1+wbBVsR4QKTQReH6BkIhHJnt+el4ZyeJf86qyBitAAHML1nT6XeGf f5r42hxvFwu4Mtz4ifNYZkDp63e8P0tz98c6s5Et6FHGmem6Dl/1KyFXaYUgPViER3dt PqG+wBT4fNmYxymUCcCU8mRx4c0lXqGqRpsElPFxob8XlxyZVgkYt47Efji/2RO6sHrz oaBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702432263; x=1703037063; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rVTd+wP+FI3iBMvI4P15hw8Ct9Bf0aO9fRFezq4rPu4=; b=UUS+hKobQltmGkPP+7RLNZnxNRDdcab01LkZHl7oZ10bFMOw7FrQ2+EhJgizgVzEPQ bPn0kqlxZaRxcrNQR9lDAHjdM7zIgU6hJpKMABtx+Nlu1qDlYF2NPdp4V5lVIzRDUFj6 CP9uHs5q+8Vdkiud4609UTxCTccfpCBDHmmWjrtDhQLcerinrU2Sf9WlEIr6uxoV5cUl zeX7+ze2iNNt93hAUB/HGRDZC86pQxooXxddcatKiQMJLWp8IDEcFUeKTMXKZPo8IxjS XSgD52+9DDMWIaQ+5oLEGBlVyQVCkZolH6pCWMvLqZSSxW4bSERaksdkNAn3cdsRWc3m KTkw== X-Gm-Message-State: AOJu0Yx8hjT238yp7Wrg+NRjEaNlVSBwFhwoy8C3mw/3p+wZ59MmZTQB roIoWsEmYuJnPurqEt6A/I1DjJPndjmacf25nX7QmQ== X-Google-Smtp-Source: AGHT+IEN+Uc+XpoJwj0S1c7u40M8URzpVc7rJ5edSvTUAtl+/7HDPUMDIk3KFXTM4rg+eqk/Gqh9a8Lx8xlysqXEfTI= X-Received: by 2002:a17:906:a8b:b0:9bd:9bfe:e40b with SMTP id y11-20020a1709060a8b00b009bd9bfee40bmr3933345ejf.75.1702432262757; Tue, 12 Dec 2023 17:51:02 -0800 (PST) MIME-Version: 1.0 References: <20231212044614.42733-1-liangchen.linux@gmail.com> <20231212044614.42733-4-liangchen.linux@gmail.com> In-Reply-To: <20231212044614.42733-4-liangchen.linux@gmail.com> From: Mina Almasry Date: Tue, 12 Dec 2023 17:50:51 -0800 Message-ID: Subject: Re: [PATCH net-next v9 3/4] skbuff: Add a function to check if a page belongs to page_pool To: Liang Chen Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, hawk@kernel.org, ilias.apalodimas@linaro.org, linyunsheng@huawei.com, netdev@vger.kernel.org, linux-mm@kvack.org, jasowang@redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: zdcotrzjmpd8em6gzxa5sz96gawbfmqd X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8A0D420002 X-HE-Tag: 1702432264-253882 X-HE-Meta: U2FsdGVkX1+CkGmZD6vKOFwH4myr3HO1Zg1Ac2QfAmFeaSZlm7JIIkSFbhnan9gL6lSLlrGTy9uZZMsN8C5xH6xrAuTySZxS0ZE2L6wOdbMfGRbZiqUB1rophORKHb9f+g08Fdi/maJvwbaXv7oRPTKYXlL9qyYYU23IttJUKpnUw2Y6c+HvqdIaVy96jDtWkF6sFAJlnoWktP0ieuBKhsVbD2yKdoKwGoNMRFYQeM9EyL9YGtdc4n7CWxhnPJSkHSf38DunC0aEqtMr/AWyGVNYeM+NW9i3SOh/xdeCdTbscn6F0IA5kS7/mRNxat21GIpj9tdg0Q+1GzjmmehtB8F0PBMn9/Fna6p4jepUhxOoCnWfHFXUdCx9j7x2TZGcXtt78qnK4SiE0a1cg7WHQCcw417T4TXT67ThvIkkoC0wRFpRCCO+POCqR0qKCF8h6KSxeLy1zjt/1rjPREiD8vHoRUWIxCkdoDit62RFGYF0CoIbWmdiS/X+ca8Nt9PEQOS8iYfVTt9aUm9TN5vQcoN1CSHkz4AbWc976Le6yoCP1JKb2yjNb9zqT9OotVXUaV4er3b7b9e31eS3Z+rz/SZEmMJ7/SnjaA57IkXYOWDVsdyvnpGtXeh56LfZPoN2wATuj5Rr9o4rTeWHdIHSnWTy9hgI5W6g/e8805+Ok1ZldwtXT/L9Y1lKrEp2q2x4NzTEGe6ooJn7/TM7ByBBY5bRC6wA24IJk3OwPd1vkpiQPCc67yPHILJ3A4rKzEQoVxTPOemWK1rOfojJJq/IAw9Ztpz1mVprJoZ2GE4Fdk4rH8Fi3NKYPPY7yyCG0xiKN586azCdgzXB95ASmMLix/YWf7VmmZMiEIwNpGAjRR1/sjc1rzUFUyj4q6WEHVaE1RV2ymEfDsqtpbNKP22kQBICQuxycKFv/s7LKzdZfd4kbKO+t1f0vD091I65xG4LFwXBZY+InpYkfTr7x1M TLjBtzk0 draEF1++lwMd9b+w29RHXlV6rqrrDjmAcolb+lekUDNX5i8g4L9yxOJMHKSWhmzmVdiMyac5kXBnaxN/K7KLKp5Qj8JD7sxnqpr0eohuSUCA1S52g3Icdfo037Fd2LiJRqU1jRHKjMavOds67HRbtHhBGIPXCWIhAeia9Z04oC0WKSnj4rjVx6QIieki05N2EtLt+6HhgRcpcp9d0le/1XRhT1sIN3O2P/5hlLz5IlRKIFXgzCzh+HNA8b1WAusUfxzBPGOcMWHDrzGaZJyZs45LWkH8Sc/rXHfrvvxTyB3UBVx8IiVKdBjDgOgPUvDyCeo4Ows7pHuwpGdOYt+wjVljT++gSb5sb3HpZOxPJFe9kfwh819yvDy5iePmv2ehitsPDt2NEN57uRmzQw5lwhldYMjC9xwm47JzlCfwazi+mXFKS++lzJxjPai5VPdaYiDMyZe2kP0NFwBZlfFSEOlGEqz2OrhzW+bM2/cfowW25u71NpmG3L7IJb9v3Avhi/D8YoRnoRoeJWpMohp7vXamRbbMF/33zOVEV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 11, 2023 at 8:47=E2=80=AFPM Liang Chen wrote: > > Wrap code for checking if a page is a page_pool page into a > function for better readability and ease of reuse. > > Signed-off-by: Liang Chen > Reviewed-by: Yunsheng Lin > Reviewed-by: Ilias Apalodimas Only 1 nit, feel free to ignore since especially if Jakub wants to merge the patch asap. Reviewed-by: Mina Almasry > --- > net/core/skbuff.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/net/core/skbuff.c b/net/core/skbuff.c > index b157efea5dea..7e26b56cda38 100644 > --- a/net/core/skbuff.c > +++ b/net/core/skbuff.c > @@ -890,6 +890,11 @@ static void skb_clone_fraglist(struct sk_buff *skb) > skb_get(list); > } > > +static bool is_pp_page(struct page *page) > +{ > + return (page->pp_magic & ~0x3UL) =3D=3D PP_SIGNATURE; > +} > + > #if IS_ENABLED(CONFIG_PAGE_POOL) > bool napi_pp_put_page(struct page *page, bool napi_safe) > { > @@ -905,7 +910,7 @@ bool napi_pp_put_page(struct page *page, bool napi_sa= fe) > * and page_is_pfmemalloc() is checked in __page_pool_put_page() > * to avoid recycling the pfmemalloc page. > */ > - if (unlikely((page->pp_magic & ~0x3UL) !=3D PP_SIGNATURE)) > + if (unlikely(!is_pp_page(page))) Nit: I think the unlikely here is unnecessary anyway, and can be removed (if without else is already unlikely). > return false; > > pp =3D page->pp; > -- > 2.31.1 > > --=20 Thanks, Mina