From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10CFFC19F2B for ; Thu, 28 Jul 2022 17:44:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 36BBB8E0002; Thu, 28 Jul 2022 13:44:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 31AB38E0001; Thu, 28 Jul 2022 13:44:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E24E8E0002; Thu, 28 Jul 2022 13:44:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0CD8E8E0001 for ; Thu, 28 Jul 2022 13:44:34 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9AFEA16157F for ; Thu, 28 Jul 2022 17:44:33 +0000 (UTC) X-FDA: 79737233226.12.C02E3A3 Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) by imf30.hostedemail.com (Postfix) with ESMTP id D945B800D4 for ; Thu, 28 Jul 2022 17:44:32 +0000 (UTC) Received: by mail-io1-f48.google.com with SMTP id x64so1933834iof.1 for ; Thu, 28 Jul 2022 10:44:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=euGCprHtfgeGD2lqEFLlu8boLeebQ0OwrWscZfMj3tw=; b=CGEsgy3vKfpdFOml8CXiObDyA3GwpotxCUspR08fALLfecVo+Kik7YFCYg6JG7GXhi PsDdbkkkBotpd3/JtocEn7l5WP3tMF6M0c0N6E8tDg6qqmYbme/B5GNAKUnQRgFRaESp jnVi6uUVr7qum/bGpT0hh3IPubgeTh2wsMLH9gM1W1Q+7dvqwDZ+4DnhLphHfiMxdWZR DL35hqWIl4KB91cqIpc6l44yBuradKIApi5uQnjY9cTMx9/NW4TBxT774xdoMsRzUNdX Ezgx3N2l71mHpsgC30sjhjoYfYGcNB0nu5RJvI2DD97/rDrBOuQ4lVzz6VRV61W8PC4K jX7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=euGCprHtfgeGD2lqEFLlu8boLeebQ0OwrWscZfMj3tw=; b=YULHlVok32lB+XqkEzCOeau2LBy8j321AxaqUzR0XEGbmFWqZYkZC0nNdRMq1/g1be qYki6cNHY6rb9HeFBYyPZySobL3HHIWN9KRjIsF3GumvNADYF1cjdbYH5n9kuYWZxjUS jGd5SBshpCBtP2GbvwjJGgQoX7jettgkPIBZrl1SSmJRTgOQdpZc9fXCkeMqbfKwGDeA bm/mtxOE8ZRzr/bsww00kPPGVEDzDRhBlFy4mfiCIr2vMaK90DEL6lDTqk43au0lLvrC g7yhydiNIV6zHIVRBB9eAdaSixa5OcF+tVV8eeo7akVUnsxi5bEGeVnJGVkYhJKgke04 wE1g== X-Gm-Message-State: AJIora8IRbf/sHEsGdnU5tRgwt07ZLvH/Nee8DWxcgDUf5MqpDY1eF1Q rakCNjeOH4FD61f2xcIntesW4EnM1pwMrYYpXdm01Q== X-Google-Smtp-Source: AGRyM1vBKjdqTQANcA4eGkbC4sZ++qu8EIsrbXnKuigxtdN/x9GAVHp9nfatADvkOirreJuOJJq2sCdcDDcdzfaobrs= X-Received: by 2002:a05:6602:29c8:b0:678:7c44:c2fd with SMTP id z8-20020a05660229c800b006787c44c2fdmr9514661ioq.89.1659030271947; Thu, 28 Jul 2022 10:44:31 -0700 (PDT) MIME-Version: 1.0 References: <20220728121949.20985-1-linmiaohe@huawei.com> <20220728121949.20985-2-linmiaohe@huawei.com> In-Reply-To: <20220728121949.20985-2-linmiaohe@huawei.com> From: Mina Almasry Date: Thu, 28 Jul 2022 10:44:20 -0700 Message-ID: Subject: Re: [PATCH 1/6] hugetlb_cgroup: remove unneeded nr_pages > 0 check To: Miaohe Lin Cc: akpm@linux-foundation.org, mike.kravetz@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=CGEsgy3v; spf=pass (imf30.hostedemail.com: domain of almasrymina@google.com designates 209.85.166.48 as permitted sender) smtp.mailfrom=almasrymina@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659030273; a=rsa-sha256; cv=none; b=1XBsUz/v4ncNqYcrVFBX/Q8iCvb8uJlcfMj3HPs02zyKZX2vEHGEgTjVDJaBs4UVPf/2/B b+zDGUZBYEyC/ArBYrQ72/t9Y4xTaSszx7rCW0KEoiD/X4x5i7MsUDE4h5TBIZygLvqjOP BC6cQoTZ1HuTwwkSi1XQQ1bkN3/zjbY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659030273; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=euGCprHtfgeGD2lqEFLlu8boLeebQ0OwrWscZfMj3tw=; b=OmRglyLNPAHCor8YyVBjUeVUltoPYqp8MOeWzqC6lP5/hAdCHkDh/jjq4/wu5R3s0MjUkb H/M8RHQ/xvd8p4nPyTQNFBOPI5LmKjgcZmIKSEGooiiuWPONLqpj0xFsLlVAFU7+UgsuCX pBMlqXOKztb2vJkI4MzNlZDrLPWtxt4= X-Stat-Signature: qay8mu58x8t4c4itbjatmaaakzcxh4oq X-Rspamd-Queue-Id: D945B800D4 X-Rspam-User: Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=CGEsgy3v; spf=pass (imf30.hostedemail.com: domain of almasrymina@google.com designates 209.85.166.48 as permitted sender) smtp.mailfrom=almasrymina@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam02 X-HE-Tag: 1659030272-146168 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 28, 2022 at 5:20 AM Miaohe Lin wrote: > > When code reaches here, nr_pages must be > 0. Remove unneeded nr_pages > 0 > check to simplify the code. > > Signed-off-by: Miaohe Lin Thanks Miaohe, Reviewed-by: Mina Almasry > --- > mm/hugetlb_cgroup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c > index c86691c431fd..d16eb00c947d 100644 > --- a/mm/hugetlb_cgroup.c > +++ b/mm/hugetlb_cgroup.c > @@ -442,7 +442,7 @@ void hugetlb_cgroup_uncharge_file_region(struct resv_map *resv, > if (hugetlb_cgroup_disabled() || !resv || !rg || !nr_pages) > return; > > - if (rg->reservation_counter && resv->pages_per_hpage && nr_pages > 0 && > + if (rg->reservation_counter && resv->pages_per_hpage && > !resv->reservation_counter) { > page_counter_uncharge(rg->reservation_counter, > nr_pages * resv->pages_per_hpage); > -- > 2.23.0 >