From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F01B0C02198 for ; Thu, 6 Feb 2025 16:54:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9167E6B008A; Thu, 6 Feb 2025 11:54:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 89F196B008C; Thu, 6 Feb 2025 11:54:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 716716B0092; Thu, 6 Feb 2025 11:54:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 53D5C6B008A for ; Thu, 6 Feb 2025 11:54:39 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 12640A1323 for ; Thu, 6 Feb 2025 16:54:39 +0000 (UTC) X-FDA: 83090118678.29.C7C080B Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf30.hostedemail.com (Postfix) with ESMTP id 1EB2480003 for ; Thu, 6 Feb 2025 16:54:36 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=BklrQ0Yz; spf=pass (imf30.hostedemail.com: domain of almasrymina@google.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=almasrymina@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738860877; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LTi6XQsJ5RIwztDyjcq4PDuI/5/RV6XdKp/ZtUfpYp0=; b=QTuWRJ2MRTzu0SxPFV2rmFS4gjdNMDeqLEA8UiRTj5w5mMVZTlWDiktfJylMJ7Tz1tgFdj 8HE3zTXATXYPggjsKUvARjNUb4G1c5b0G/CDZGN+ygFFN6t3vU78F7Yg70DM4ifOMsdH51 MbwTu55LxaKwZB+Y6HLJ94lDpkkrWQ4= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=BklrQ0Yz; spf=pass (imf30.hostedemail.com: domain of almasrymina@google.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=almasrymina@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738860877; a=rsa-sha256; cv=none; b=4/H3p/v/OG2bXxtN82guzloM85qPBtPsraDp4yXwys5CILTvAQVM4Vj7An2MgFYpw8PNNU NxGjz32UWcpakKGqWRJ63JUmkl7ww+O01XqlEV5y7XRu0/xsX9Nd1PlBTXuSrCmPvzxANT djqPMZBFCdKuT6T17yICcKYqgwvVGp4= Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-219f6ca9a81so17265ad.1 for ; Thu, 06 Feb 2025 08:54:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1738860876; x=1739465676; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=LTi6XQsJ5RIwztDyjcq4PDuI/5/RV6XdKp/ZtUfpYp0=; b=BklrQ0YzvQ8jfqO/NgLdnBiZ7TBis+H1SQbUCl8g2dBQO/exCVPlhmjbUc9AV6OwXB kRB84vaZCTTSFwXzT6X6QtbZByO8lopmoraOqBkWSoXiyUkVPokQJ7NBPy0Q2txYJUIS ioOW32OQTjc7npj7k/i5kgDGkW+zyy7YCPQxM9X89afT+Phu3F9kyTzYelMXMiB6a7Ys VPhEAldxXkS2NUD9SuHWjfGbAjKKd8resckFalcpZiu+a6R2ElIGvKmhllB25nX1hDaU O9cMxYR4Oiptx6FDeL64sBhorvyaWMFjNpBIWBj/ul5hMbH8eFBwxTRF7v3J0iSSi/5v apnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738860876; x=1739465676; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LTi6XQsJ5RIwztDyjcq4PDuI/5/RV6XdKp/ZtUfpYp0=; b=QmZ/6H02D+jWqWPQrf10CFYEisu2+SIHMlv4vXh/7Q+/JGfJ8+OjFwI3LmW//BaZAP CKJhkW1gp23YZiPMZ/rQSTh1X8c98hOCOqlQeae3jiP9r+rixQQzRwX1WNl0y2MjCSST qZlChkEzee0lmWpeVYNw7BXiK7zSsQfO5dg7njTWTgvGoTEgTtrJ/8HGuxjjbr7HtU63 J5O+YgwTg24EaIA1piiXVE4U02Chg4rtoSWHNHkTshyoM7GnY1pB4XTQKun7Z9v5HPTO AoJtnJ948NNYcs0+zHXjtoOR7SMDSk+t+rnslu+/ZCUM5vy10/ebDMDjRqQlBUhX3AmG 89oQ== X-Forwarded-Encrypted: i=1; AJvYcCWWxQMK0rb96+nd5GWeHpGYNUvcPdgzJrsrhXWwGjGPq863GJ8Q52Pd4+3/VGvngZR5+5gckpiFOg==@kvack.org X-Gm-Message-State: AOJu0YwkGBxfpQua/zRdvVL38TW+AGtLw20MvwsnrmoC+I4ILJ4mKdZ9 5rhH3RSIHnj8DX5jJXHnOBB2NJl5cNjlR7rULpMM/wUJTyOQwJDFPT1ZLk+IVn5wlbqGPkWeo7V uVe/BJpWAJ5BzlEyhpd108mlAgvK0g/UyabM8 X-Gm-Gg: ASbGncsoqVXjH8BhmI2Q6VTFHL4Xu9Wqqd40hwf2o295Cre3QsLYreGpdUdbtxobmjl ZlpqemwsZn360UuYtkFHIMmLxEtd5YrQzKYiRZGTXf2tLIZTlLoYqvaL6iDkOjdNOxx5xmSi2 X-Google-Smtp-Source: AGHT+IHzryBnDyIuG4kua5nqFv0t3CUZetv5VWZDEVSBd2Q6xKHftpMfzmT/4FNKDJh9y7JmfSRCt/+KPeHBMGILBJ4= X-Received: by 2002:a17:902:ef4c:b0:21f:2ded:bfa0 with SMTP id d9443c01a7336-21f4c50aef0mr178385ad.25.1738860875702; Thu, 06 Feb 2025 08:54:35 -0800 (PST) MIME-Version: 1.0 References: <20250127025734.3406167-1-linyunsheng@huawei.com> <20250127025734.3406167-4-linyunsheng@huawei.com> In-Reply-To: From: Mina Almasry Date: Thu, 6 Feb 2025 08:54:23 -0800 X-Gm-Features: AWEUYZkAfsd2D0WA6s0xLr-HWyLjnZliAFrvM7gs-k38rOzilGMV9dLNA263rHA Message-ID: Subject: Re: [RFC v8 3/5] page_pool: fix IOMMU crash when driver has already unbound To: Yunsheng Lin Cc: Christoph Hellwig , Yunsheng Lin , davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, zhangkun09@huawei.com, liuyonglong@huawei.com, fanghaiqing@huawei.com, Robin Murphy , Alexander Duyck , IOMMU , Andrew Morton , Eric Dumazet , Simon Horman , Jesper Dangaard Brouer , Ilias Apalodimas , linux-mm@kvack.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 1EB2480003 X-Stat-Signature: dj9epuyo677nurhfswob513gdarebxyq X-HE-Tag: 1738860876-808171 X-HE-Meta: U2FsdGVkX1/ny8GTY5jhwSnUH9GWvIjqtMbzETiQWl6ldIg6P3XqgZFBOf3CYewvvRuJlkX+Xx20gL78GyfKk5RmFnIz56u3wOHuCwUrL/jP9PZ/HZr0yPkJolELUhQJWP/MUEqy5RO13FYHmyQ7B/bk/rG7fm/fr22oTKYMnPgposmOpLBjk2xXSbSkKWeD+IN9w/gznfjB6zfhm5BOP4zbTexz+35lBtnrzZo1jPPShA2M94gP7z/U5Zx6veaYDjZQf4ptv/UDfwAh7yfTc96DsHeSGBzd6MwWSDMtuDmhfro3XJ+Wl5HFYKgVWxTQZZT9n+8JdnkhyJ69C9HNZstkoRDYFzQXBGVEB57B3UQ6vhcHwuuxTS0fxrZhFoynSErTQf0WnjkZ2550suBSd/l7yDH4VHvMlrTHw+6T5vLltAxAQDrIAcxVa9ykFvpAECfs97ZlUMYJb/8QhlB5Z3/Yla2Na7MU60W1Z/x4dVs+1/ETxQQjMAbLc/4n+6rCrjcV0cInvuU8zKJvYeGC9uWA0rJEZGKeCfjbzKKoT79DQgNzbUZ5IpCZ0+vLou9m6vQOgY5k6xDc0QbXXdeRUFIRjQ7uAWXYhbCq/O/5RdC1vegl09x06bdiQEPOKovI4ff0r7BQkiH9Pyiuch0PkahR8PSUFsUjaBbi7M3ZM+yo5C8yqVXlYwOsaofmXCigG4PmjKbfxBHoE8uDN+lpGVK2JIHQXCdXNtQvJ7TsLA7XNMB2/SFrd9ThGmyW/yY4EWoJ+FFYVGHYc92SoLxQxc8LN2T3AaxOdufMb5RoZ/uQOOFfNSHOrLmO3vPoGcD0Nd81gadIN4slEXOjZD++v2OJ4wlOKFM0IzLpboJWCyIlBkEutZXQOW+plSMAO7kx4hZgmFfhOGpVDMY/7gs6MdG8EdzgL72ShLB6UhU5lOeUgKRJfTdIypCFa6qt+xfVXfPAaMpozPokTbtON2j aAiwOVvf g+SFBCmEnodxoPRonovzw5VrdDlal8L/Qx+sjU5h0a36mPGpyup2vKSj9K5olblq8EpIhjyWbq2ttVxxz+A7D+IyDgvX8kq/ZPsmgw3UQ7TLWL9IiPllmkm/C2P2t9D+dym4pk9me5gijWYYibe4cT9pXl+LA6g8Rv+BMmBGRC4vCVAOrqMNcmChF+G8K4YjWJum5kocPOgGqmrDo6Py6BPWFSxxiI6YT3Ivu93iID9FiNYHSaqODOGGrH0Iz5LqTEWVYBfmmsYrKvqidl7TCLmuEABP/7TDHBIMaYtuTgDqYy3pVIu7TkRqBntgHKNr+4uOD5aUJRLasV2exRYKO/fQDc4gv8fnEd+4K0Z2aq0b9ib4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 4, 2025 at 6:23=E2=80=AFAM Yunsheng Lin wrote: > > On 1/28/2025 2:12 PM, Christoph Hellwig wrote: > > On Mon, Jan 27, 2025 at 10:57:32AM +0800, Yunsheng Lin wrote: > >> Note, the devmem patchset seems to make the bug harder to fix, > >> and may make backporting harder too. As there is no actual user > >> for the devmem and the fixing for devmem is unclear for now, > >> this patch does not consider fixing the case for devmem yet. > > > > Is there another outstanding patchet? Or do you mean the existing > > devmem code already merged? If that isn't actually used it should > > be removed, but otherwise you need to fix it. > > The last time I checked, only the code for networking stack supporting > the devmem had been merged. > > The first driver suppporting seems to be bnxt, which seems to be under > review: > https://lore.kernel.org/all/20241022162359.2713094-1-ap420073@gmail.com/ > > As my understanding, this should work for the devmem too if the devmem >From a quick look at this patch, it looks like you're handling netmem/net_iovs in the implementation, so this implementation is indeed considering netmem. I think the paragraph in the commit message that Christoph is responding to should be deleted, because in recent iterations you're handling netmem. > provide a ops to do the per-netmem dma unmapping > It would be good that devmem people can have a look at it and see if > this fix works for the specific page_pool mp provider. > We set pool->dma_map=3D=3Dfalse for memory providers that do not need mapping/unmapping, which you are checking in __page_pool_release_page_dma. --=20 Thanks, Mina