From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB5DBC63703 for ; Wed, 7 Dec 2022 23:16:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F6578E0003; Wed, 7 Dec 2022 18:16:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 67EAD8E0001; Wed, 7 Dec 2022 18:16:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51FF48E0003; Wed, 7 Dec 2022 18:16:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3F2298E0001 for ; Wed, 7 Dec 2022 18:16:34 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0EF851C67FC for ; Wed, 7 Dec 2022 23:16:34 +0000 (UTC) X-FDA: 80217071508.24.2B1279B Received: from mail-vk1-f175.google.com (mail-vk1-f175.google.com [209.85.221.175]) by imf17.hostedemail.com (Postfix) with ESMTP id B066540003 for ; Wed, 7 Dec 2022 23:16:31 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=RWItdZbE; spf=pass (imf17.hostedemail.com: domain of almasrymina@google.com designates 209.85.221.175 as permitted sender) smtp.mailfrom=almasrymina@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670454992; a=rsa-sha256; cv=none; b=Z299qtRASVVNObKm0qKsNJhCPUk+K88vz7R6ESDFkZ99IoJAE42b7MnGg3a6Myvv07QhMG 8Lm6E33ibZlYune25W37VT2dzxgoMvERFZiy/nkN97jk8ZMEOzuU79XKf3fmHow1SOo/Mx nGzRp3TAtZLrkZSTFBt8+rSuqEkVoEA= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=RWItdZbE; spf=pass (imf17.hostedemail.com: domain of almasrymina@google.com designates 209.85.221.175 as permitted sender) smtp.mailfrom=almasrymina@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670454992; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qKhtWKuWhB3DUJ2H/EHTwp1GzrvWCjjlF4j8bshMOGg=; b=Vr2scqZTsOKiLi+2vYJQHKjPgiEkOzWVSiJU1HtUSk/kvb3J2v92JjsCh7deOmu61VZrXF LTtLj5tRFm+9iQ2VAV+7f9G3aYhipf518MRuTcJqgk5Zz66FhdSVH4Wxbh/f3+hMvQh47t Yj1ocD5BjM1+EYInNmI3qF8tvzB3jo4= Received: by mail-vk1-f175.google.com with SMTP id 6so8984658vkk.6 for ; Wed, 07 Dec 2022 15:16:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qKhtWKuWhB3DUJ2H/EHTwp1GzrvWCjjlF4j8bshMOGg=; b=RWItdZbEx9sodZbYh/mNiehmL8weMOlBg/LJdiWPUbuEkKFHf0IAViiYzIVqNIeDBq JuyepTR4HRBjbUtZXabjpqNAi9B9HoYUaLmxKPshiN6I/EutIHREDQC3wJ1z4nve0Oif d3//qbWsgckqa1nQ/G6uvB3SQ8XCMoe4vmFR2Ce/ukEXK/CHEt4Wm0hvDLqDBZnbQmqH mFdjh7Ez+XvkgML8Z7StJJoaRk9/xj+V8GsFhBkmijvl2L75TsaoTLC6WMLofzSUrp7N sE6bHCajUkKunMMRrzObVAfO68dQPZIf/5XQeW8lA8USYxP9WIpBuACEs4qqS0XVV0GM 5tFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qKhtWKuWhB3DUJ2H/EHTwp1GzrvWCjjlF4j8bshMOGg=; b=eNUKcd97KOnrOTrk4FqHGLniLswHuySmY/THf+0OktVjDfF95fd2P9ljg9OLTfndZX pjl/32m4qQwBcrdq1W4te/Owmv/4kF99YdvMNLCm7T4P+Vaji4H34ZlohWqFMVHl77jc bAy0ZnsTE8jS0Rm/VCsgRaSFMKYdqk/NJ4+y3hZEsnbJBs5M3PvDOn1/Yq41SP46cVaG xLRz8rJUokrpIa3EFMHNU7rM1+fP7C//BLMC8fliD0qv4yJ7vJh8wZTFHk6Ohn5P3q8W kbUNPd7aKmFCShKDVrRpcED7+1kg42Mql/xNZtG/FcFmejPihDJbXT6jRt358NrQbny2 R/qQ== X-Gm-Message-State: ANoB5pm2B9SwtNmrpH6sOWxIC1yCub/apvHDjjKMpHzPnKoe7An6IYrn HHVRQ3gWDZNyVEWuMqTNAkYak2gdTeu2rCkQUfVuzA== X-Google-Smtp-Source: AA0mqf5A5DpDdfJWGB9crw0LgSp4qBZJrveaASusUoBLRh4msF9wZg/3Rjo79pIAegyMmLR1/3R34jfpQmkGjCipZ0s= X-Received: by 2002:a1f:2348:0:b0:3bd:51f6:1f3 with SMTP id j69-20020a1f2348000000b003bd51f601f3mr14369835vkj.35.1670454991528; Wed, 07 Dec 2022 15:16:31 -0800 (PST) MIME-Version: 1.0 References: <20221021163703.3218176-1-jthoughton@google.com> <20221021163703.3218176-4-jthoughton@google.com> In-Reply-To: <20221021163703.3218176-4-jthoughton@google.com> From: Mina Almasry Date: Wed, 7 Dec 2022 15:16:20 -0800 Message-ID: Subject: Re: [RFC PATCH v2 03/47] hugetlb: remove redundant pte_mkhuge in migration path To: James Houghton Cc: Mike Kravetz , Muchun Song , Peter Xu , David Hildenbrand , David Rientjes , Axel Rasmussen , "Zach O'Keefe" , Manish Mishra , Naoya Horiguchi , "Dr . David Alan Gilbert" , "Matthew Wilcox (Oracle)" , Vlastimil Babka , Baolin Wang , Miaohe Lin , Yang Shi , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: B066540003 X-Stat-Signature: fhnui44g6jf71hxykyrotaf9unsne8ig X-HE-Tag: 1670454991-200947 X-HE-Meta: U2FsdGVkX18CAcLU8l4IYTO06VMO9vymgLw92ky+SqOWD6lNUzj8wLxGFj+rK22ycz+l+iQgYytsRB8EMHPtz3uJspDV3ZwUWi0ZVsOn1dZ65aoYcnUUfVoMob+83CYI7DNgMCwG1Aol6HQNCz6Ug1aS6syLJbeLRMAeXIKr4HsJFrzsiDLaykTnhwSTIdyoPKNkjXDEKCzr+gIwY7mchPuHw0W/T15UqnAqeX9NSV78nxh4GX0SvCxKOlLbNCkgKtRGj7W9jW2TO+JLPglt99JBGaWo/38vZXi1ow6MtFSVr53EyTxb1nBPjMTuSEFRSuGr70fGjtEamQYhHF7OQRCHpbqVzWi7SlwSx+3MN5JvCsULo+t7WYKf4kB7cPLTtIJUooqOBPdaS9UFmtnIN1RWXzTfmGk+ltGtjioDaIUTaQ2m7m3H/z3HLbwrFLseIQgF8UlaLApgZYTodLGXh3HuRXjRi+zVTrsy3O9BUSq2UzCzNprWj+lugo9vPFJbvSsunQ7xfJM42v63TPhGtWI7BwwRwE4cLBBdqb8kRaiqSIdQxEreyRiQlMsRkrs48E4C+6amQXlDAr3k4tGqfbW4knzHy65tu1o0BAeuQdCEjZzR7dpU9a3WpaLyLXHmAZdWm4fQJsyTo4zlNn9TJ4C85luEFFxGcKppIJzEpVukiZGFwyQVAKQMNpWBS6AtifUQirYNfNqgXLxvBiYZxBd8YiaG6M2wtG3emaNvFsegaS00qzaeQ2ElMQLdBy0dl1f/uJseO5MpiJoOyUo048MVdJVHPKESoe+6XRsgrgtxuVG1RD2fXucrJs30B+ozbCYxSeuzDeFSMkrRXQbRAqwvwmiGya10rNjfjhzLbvw6EE0qPMTV6keMmrvHTB3g3fVv9gvluBn0Bb1NPlaJbUHw+qaiLILPnf4Xkt7lgFmC22YrP/nK7UneCz1KJg1m/r6zErp/JwEHC2yY+Ir csLA32MP hlX0JSSRQ7cay0ePTWrB7KQ0bKp7jV1btmJq9/LPebf3LvbcABPCZaoj6GA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 21, 2022 at 9:37 AM James Houghton wrote: > > arch_make_huge_pte, which is called immediately following pte_mkhuge, > already makes the necessary changes to the PTE that pte_mkhuge would > have. The generic implementation of arch_make_huge_pte simply calls > pte_mkhuge. > > Signed-off-by: James Houghton Acked-by: Mina Almasry > --- > mm/migrate.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index 8e5eb6ed9da2..1457cdbb7828 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -237,7 +237,6 @@ static bool remove_migration_pte(struct folio *folio, > if (folio_test_hugetlb(folio)) { > unsigned int shift = huge_page_shift(hstate_vma(vma)); > > - pte = pte_mkhuge(pte); > pte = arch_make_huge_pte(pte, shift, vma->vm_flags); > if (folio_test_anon(folio)) > hugepage_add_anon_rmap(new, vma, pvmw.address, > -- > 2.38.0.135.g90850a2211-goog >