From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D30EC3DA4D for ; Thu, 11 Jul 2024 20:57:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BEF386B008C; Thu, 11 Jul 2024 16:57:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B75FF6B0096; Thu, 11 Jul 2024 16:57:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A2036B0099; Thu, 11 Jul 2024 16:57:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7C2436B008C for ; Thu, 11 Jul 2024 16:57:19 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4031E1A07FE for ; Thu, 11 Jul 2024 20:57:19 +0000 (UTC) X-FDA: 82328682198.25.AC993C1 Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) by imf25.hostedemail.com (Postfix) with ESMTP id 72B49A000A for ; Thu, 11 Jul 2024 20:57:17 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=38hpQXw8; spf=pass (imf25.hostedemail.com: domain of almasrymina@google.com designates 209.85.128.169 as permitted sender) smtp.mailfrom=almasrymina@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720731420; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qR1w6TGwRPRKUblfK+cvVsJQzW84NzZB6wHL2Wt2c14=; b=TFZL2w7PLJ5AASyhJOQrMNwBcpiGeG/eLuFxTRB7SOPUyTWESRlMbDbzMdQ6xB4PV9idg7 RQJ020NtlT+kRNkTEDiZEfzhLvmVITI+BHGe2lC7VOpafcSAyrLhp3kc+FbER8rzpmiATe +v0efOUSMgl3FtLF5kVebcczGQ1bEw0= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=38hpQXw8; spf=pass (imf25.hostedemail.com: domain of almasrymina@google.com designates 209.85.128.169 as permitted sender) smtp.mailfrom=almasrymina@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720731420; a=rsa-sha256; cv=none; b=GBSBGkYzCdbYCTsVzmOuqisKPBFZzsitcuQQtEe32TYdl37e8QL3TVpS579sEBV+sBKnt5 9Mt40xfCsbmqz2YXJwuibfj3OSCyFXy5u8hBJmJI2M5azNeSG9B2ej1WS7Sg4LQA+Hepc/ FYRkNXbBeXPDw8ZHFcKcJGco8GFKkM4= Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-6561850a7bcso13470907b3.3 for ; Thu, 11 Jul 2024 13:57:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1720731436; x=1721336236; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qR1w6TGwRPRKUblfK+cvVsJQzW84NzZB6wHL2Wt2c14=; b=38hpQXw8TaAq/ADggdOx5ZrugY45snGwDGBPfIAR2e3iDIXISGc8Ql+UM8RrsgHsiN EpNX//jvN/Mb3FPPPerjJeqzRtWd+UGmxK1erBJZu0mBwJF6aEKUzPh4FJYGrMzVlrhl Tret4laL7iggPUDfYtv/jqT66wNDE7o1eygsaotKFUDTeQKfm30vwfrjaAKaczHoHg9/ dq9rpWus1xIvZDCRHC8L5hHp2nt+briZgw8q0UjxFqsllfUPPHIO3Fa8m72VBpfLdcjc kLy8ZtFbTkn+0lJQNb+zwoivvV+Fiak9xGxmW1GhJYOQ2Y8LcDKiwzl+R3us1NjyjAK4 QGXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720731436; x=1721336236; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qR1w6TGwRPRKUblfK+cvVsJQzW84NzZB6wHL2Wt2c14=; b=MynkXriDtmpCDIYjGFLgRqiQvVDdvEVN90W3gW6sAe+qyctjR9vktmsGUHAek3j8Ht ba7aaJPfCVTQJ5+Nw9pjmVRyxRp+/oanGvmGzHsM5fcvv6qh6W9+aqmUm8eA44IpFkrN CH7lbF61gyjcsSHsmawu83647OP1ojXMMHlLX4xQgfiMO0l2IOzmTHbZPvpKGoGuh6s8 pH0O1HHn6bJaXsRvKNz4whdvZD/z9hjLpu2eH54JT5c8Zw7CSVw3fxGKSUoI1EU5Dl6c fDf0jEyJwHhyGxo41PJmwsCHDcq0HSlOhWbUqgNhh0pyKmMUZUeAwZ5uuwxBz9Tsukad ONRQ== X-Forwarded-Encrypted: i=1; AJvYcCU1reI6xwHkSSpns4loRR2KvaNvy3L8G7u9aOpZdm7T/o7/U5oYngiMmmYlOf1aj9p+BMCn/X6wVu2lhAC8lMScCwA= X-Gm-Message-State: AOJu0YzpUlA6ujob//p1R1bUifXBfjRvcUCEKNQfKSPkiG1wPV0kcyrU bh4HH8WzFwcLf7Puy9stTV2BkiCNiMSGFtOS1nDV2qYszF8424LReYzSEgjxSDwn0+vAjveM9I4 W3pKr3V2zfxab4F7zxjgFuwuxgMEb+CH6NFS1 X-Google-Smtp-Source: AGHT+IEYLltipW2y2jpNMjV5kpiHBN8xdsLzBdnyK43dhH65oHO3BC27aVEWQpPKMVw7hLbmYOjCnlcdqKg1G5wqhvg= X-Received: by 2002:a25:d3cf:0:b0:dfb:c6a:643 with SMTP id 3f1490d57ef6-e041b070a46mr11240607276.7.1720731436062; Thu, 11 Jul 2024 13:57:16 -0700 (PDT) MIME-Version: 1.0 References: <20240710001749.1388631-1-almasrymina@google.com> <20240710001749.1388631-6-almasrymina@google.com> <20240710094900.0f808684@kernel.org> <20240710182322.667f0108@kernel.org> In-Reply-To: <20240710182322.667f0108@kernel.org> From: Mina Almasry Date: Thu, 11 Jul 2024 13:57:01 -0700 Message-ID: Subject: Re: [PATCH net-next v16 05/13] page_pool: devmem support To: Jakub Kicinski Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-alpha@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-kselftest@vger.kernel.org, bpf@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, Donald Hunter , "David S. Miller" , Eric Dumazet , Paolo Abeni , Jonathan Corbet , Richard Henderson , Ivan Kokshaysky , Matt Turner , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Andreas Larsson , Jesper Dangaard Brouer , Ilias Apalodimas , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Arnd Bergmann , Steffen Klassert , Herbert Xu , David Ahern , Willem de Bruijn , Shuah Khan , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , Bagas Sanjaya , Christoph Hellwig , Nikolay Aleksandrov , Taehee Yoo , Pavel Begunkov , David Wei , Jason Gunthorpe , Yunsheng Lin , Shailend Chand , Harshitha Ramamurthy , Shakeel Butt , Jeroen de Borst , Praveen Kaligineedi , linux-mm@kvack.org, Matthew Wilcox Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 72B49A000A X-Stat-Signature: 8weeucmngszp8uciczt69oaojfcm3kag X-Rspam-User: X-HE-Tag: 1720731437-462048 X-HE-Meta: U2FsdGVkX1+tFBAW8AxN4jqbM2jK3xvztrov7mQpXRRE8bYYxYYDPK/xkEroGAUDd3E6E6yGL4SVG3xtHfrLbPnHi+LNBQ4UQWuDy90FAXlxnRMD5i1dL69G/PPdxb9HxVrxyBTo/y/4dROZl7TMwmJ63hIFODtl8tkCu3Xgs8nyA8/L7Sk3M2ithfl3pkzRJD8eMf109Hr+kwxqHXgvocTrfrQZ7EjscHg9A57oZDSoNVHEtrTkJiGUZkuYMRTGzyg7CYQDGEX3/ECav25OTRjKE+mULUI+6R5PF/K1bVQyJQAhP+AdQFpM1fcinwOlhl3sw/yf32zd7a5fuwii/wzs3GFUwRvM7yiEJbuimqHBwExLY7b01v5kpdqJEMhKEaii1R+6jDYi7anrWiWGrtyx56Tcio9BsDijd9POy3xAD0ECHteQ0OccrZ7OKAnkCa4WEFnasxL2WfhDRJIsqGsdpwlTRghNAHhS6R2hbGE1WE32KY5JDoTg3Ym1mBhMKGmftkCFM/cXblg63uVBdxjO4UC3Cy8cVBOOHAIQ8PZUl+Adi4aMpKOov/7kRHemz0ot53/P6Gny40qkhL9vu+DgUPghJYoe+bjOwThaGnB+jUgwGFlwYvydxz/IfwWiuibw9W7nI+YJI1Cp7QCqkAsQXScIudldNednCi0kGImyXTWwcrp80FHRz691aWjqGmHndCXPM9ACLedXuUV09yfsmjaZabqk4FJXF3u143Fbq1hvvs3vfmSmEtIVx2JsifoNvZ+IOam+uir+TfPVKNg9Ym0PLExjlxpGzE8K6wEwmcscUy22VdG1QUeiEuQ5OaELRxGeb/PtEAWEKirKxfIFgmPCzZV7WTotysc44X+3Ol9Q5ZFvVKlGAXyQEMJ55+BFuOU+pbWruVMEUq8UMb5C/PlbGNmkaw3vCJW7LFhzjQvBizlENh+P9zCDwfg1vDSTQtpzsQ3xq9aol2Y MxmgNn0y vfbXE72RQcfDIEEFn471vp5piYdyYYx8MeU1U458MOQnC1GsD1maNwBq7ZYKH3aScu2PGlIhaReIdzmbCDvPWHfCaLsAEVV8m3PIJZLCDSEYgeqtU0bVkNMwCvVMdPDevhgaWxZxK9/1Iu8zVwbU8d8iILIYXiPSmX9uHs6/TT8B3DQ8XrCOOXl63YX1i5THRqh2XdW4jwDWE3Cwhu2pMXMfdx2WedZo3LBthNY02qt7v4IdCuZkkNdPKmPLVxgMbbCIIZwJjV1dbk2DmJ+qWCKuHK14QYC4y9A4/1zC8RzwlLugIM3p0slTIhU1DTX2eI9ZiyolPvuaOm6zi/cI9Dqu1LEBSNQPqkK+h X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 10, 2024 at 6:23=E2=80=AFPM Jakub Kicinski wr= ote: > > On Wed, 10 Jul 2024 16:42:04 -0700 Mina Almasry wrote: > > > > +static inline void netmem_set_pp(netmem_ref netmem, struct page_po= ol *pool) > > > > +{ > > > > + __netmem_clear_lsb(netmem)->pp =3D pool; > > > > +} > > > > > > Why is all this stuff in the main header? It's really low level. > > > Please put helpers which are only used by the core in a header > > > under net/core/, like net/core/dev.h > > > > Sorry none of those are only used by net/core/*. Pretty much all of > > these are used by include/net/page_pool/helpers.h, and some have > > callers in net/core/devmem.c or net/core/skbuff.c > > > > Would you like me to move these pp specific looking ones to > > include/net/page_pool/netmem.h or something similar? > > That's because some things already in helpers have no real business > being there either. Why is page_pool_set_pp_info() in helpers.h? OK, I looked into this a bit. It looks like I can trivially move page_pool_set/clear_pp_info() to page_pool_priv.h, and that lets me move out a few of these netmem helpers to a header under net/core. However, to move more of these netmem helpers to a private header, I think I need to move all the page pool dma helpers and reffing helpers to a private header or the .c file, which I think will uninline them as they're eventually called from drivers. I had guessed the previous authors put those dma and ref helpers in the .h file to inline them as they're used in fast paths. Do you think the refactor and the uninling is desirable? Or should I just do with the trivial moving of the page_pool_set/clear_pp_info() to the private file? --=20 Thanks, Mina