From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AA53C4332F for ; Sun, 4 Dec 2022 10:35:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF9D48E0002; Sun, 4 Dec 2022 05:35:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EA9248E0001; Sun, 4 Dec 2022 05:35:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D71D18E0002; Sun, 4 Dec 2022 05:35:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C94028E0001 for ; Sun, 4 Dec 2022 05:35:24 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9BC871C5C2B for ; Sun, 4 Dec 2022 10:35:24 +0000 (UTC) X-FDA: 80204266968.05.5C5E62F Received: from mail-vk1-f173.google.com (mail-vk1-f173.google.com [209.85.221.173]) by imf09.hostedemail.com (Postfix) with ESMTP id 538C1140009 for ; Sun, 4 Dec 2022 10:35:24 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=CpyJ8vLa; spf=pass (imf09.hostedemail.com: domain of almasrymina@google.com designates 209.85.221.173 as permitted sender) smtp.mailfrom=almasrymina@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670150124; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fwuyG1HCJWJUAjK5O9FsiBCTfvXzIT2aWcUKCXdWWN4=; b=ZsPGJx3AuMlv52X0s04SkCwb0kSpOgFGZDKzfFREWd5DTawHHsh8SjPpQb5v4AgWHYCbzt 2eA7POrlAPqp1EC3fJixlXimJQDTvaIk3GAXX4z3I4J14q6oQHToL1uDqk0pDhgpMOxJ9F 5/oFr+JqqFsy10P5HA9nDrl5fwlt6Is= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=CpyJ8vLa; spf=pass (imf09.hostedemail.com: domain of almasrymina@google.com designates 209.85.221.173 as permitted sender) smtp.mailfrom=almasrymina@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670150124; a=rsa-sha256; cv=none; b=lUTBoLVWGyzlef6UXUjdWo19v5zHL6fZ8IqTG5ilNW6uBj+ysptPp7BAIiq39uLSRLcPtb Es41IIuSy7ZPm0kP41u7ujxbV3MGCRu4GerAcRrM28U9zLM66thJqIGrWZoV+c3iPDVqdk Rvjj9tyrIxAlOYKNGPb0By+xJIIAvTE= Received: by mail-vk1-f173.google.com with SMTP id f24so232536vkl.9 for ; Sun, 04 Dec 2022 02:35:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=fwuyG1HCJWJUAjK5O9FsiBCTfvXzIT2aWcUKCXdWWN4=; b=CpyJ8vLaUSAZg7MijqTf4h8l0yIWc1ZOuPN0pPN9nIcjtaeaWmvUxvn2jSBl9w9Ov7 sibY2yTERj780ey2qljF1gWHZUoIXS3E9dqXR6Y8FD3X0G1h4/AqZEzkfFHSQBZ0w4t3 2hfEzkCE3fJYPaD00/rsiAPMLKZxYb6Orw+zaKeByVz0af3mvsrsx0lH7ai0VNow+xJA yP5cfdjmHDRkuqRuO7o5R1Tmqlqz+lvqvb24lbVc/1Lb3Orty4lUVDCM1bQVpuOcTrxC W8e9a5/Jf1maApFLxsHnX+8Zsp0N+F8exxj6dbponu2nN5yUqn3OTbXqlRQpqmParZT3 Tfxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fwuyG1HCJWJUAjK5O9FsiBCTfvXzIT2aWcUKCXdWWN4=; b=NoF2V4/15kZ7NmrhqyNdMw6nOXuphFJBz2nnh9pINXhjQtpDoo5XLqczPpQctpRaFB PLu7ipi+UTvHaXCSu1xW5n6Zi5gP886dsc72RsQ48sI0/DiCvK7/484Pk8yn61MioKWH P57Th6nWLKLDdKYWX8w4js6DdgenIznpRmqbK6qjrBijTNYt6z0Syqms1gUH7g5hMRqP 6STYCS2jn5ZWTL2dPBJce1nGHIiGPGZVd1CoI9jFq/9o/Jt5lLdwy6HNJXyb8AwWgP0m WpbaS0LpIQHkhvp3GMBaqMwDCT5hYeLWTkx3fAq3bnw64wgTTDACXAcHk3KCxg7KIge6 aUiw== X-Gm-Message-State: ANoB5pm1+77+Egz6L3cv6iidp8+bOarkKUFfBAssuBb7Bh+HpyvZ8yiA YYUUpyqgmIzt4zuXXMkBfJ9ZgRTnHiaotjmyWoP4MA== X-Google-Smtp-Source: AA0mqf4dtADW7mbQ5Zigm+6+B4ZVoLuCxmqE1LTovGR4O/kBxKKU5EgktsStOE3CKlurP+OhDrikoCRrq+VJDY/+2HE= X-Received: by 2002:a1f:2348:0:b0:3bd:51f6:1f3 with SMTP id j69-20020a1f2348000000b003bd51f601f3mr6544287vkj.35.1670150123478; Sun, 04 Dec 2022 02:35:23 -0800 (PST) MIME-Version: 1.0 References: <20221204093008.2620459-1-almasrymina@google.com> <202212041833.kNUaRUeq-lkp@intel.com> In-Reply-To: <202212041833.kNUaRUeq-lkp@intel.com> From: Mina Almasry Date: Sun, 4 Dec 2022 02:35:12 -0800 Message-ID: Subject: Re: [PATCH v2] [mm-unstable] mm: Fix memcg reclaim on memory tiered systems To: kernel test robot Cc: Andrew Morton , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Huang Ying , Yang Shi , Yosry Ahmed , weixugc@google.com, fvdl@google.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spamd-Result: default: False [-0.73 / 9.00]; BAYES_HAM(-3.83)[94.53%]; SORBS_IRL_BL(3.00)[209.85.221.173:from]; BAD_REP_POLICIES(0.10)[]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; DMARC_POLICY_ALLOW(0.00)[google.com,reject]; RCPT_COUNT_TWELVE(0.00)[15]; DKIM_TRACE(0.00)[google.com:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[linux-mm@kvack.org]; R_DKIM_ALLOW(0.00)[google.com:s=20210112]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(0.00)[+ip4:209.85.128.0/17]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[] X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 538C1140009 X-Stat-Signature: om9sdituigtxikp75hr1uuf4tt1juy4a X-HE-Tag: 1670150124-48108 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Dec 4, 2022 at 2:32 AM kernel test robot wrote: > > Hi Mina, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on akpm-mm/mm-everything] > > url: https://github.com/intel-lab-lkp/linux/commits/Mina-Almasry/mm-Fix-memcg-reclaim-on-memory-tiered-systems/20221204-173146 > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > patch link: https://lore.kernel.org/r/20221204093008.2620459-1-almasrymina%40google.com > patch subject: [PATCH v2] [mm-unstable] mm: Fix memcg reclaim on memory tiered systems > config: alpha-buildonly-randconfig-r005-20221204 > compiler: alpha-linux-gcc (GCC) 12.1.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/intel-lab-lkp/linux/commit/332f41fcb1b1d6bc7dafd40e8c1e10a1a0952849 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Mina-Almasry/mm-Fix-memcg-reclaim-on-memory-tiered-systems/20221204-173146 > git checkout 332f41fcb1b1d6bc7dafd40e8c1e10a1a0952849 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=alpha SHELL=/bin/bash > > If you fix the issue, kindly add following tag where applicable > | Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > > mm/vmscan.c: In function 'demote_folio_list': > >> mm/vmscan.c:1618:9: error: too many arguments to function 'node_get_allowed_targets' > 1618 | node_get_allowed_targets(pgdat, &allowed_mask, demote_from_nodemask); > | ^~~~~~~~~~~~~~~~~~~~~~~~ > In file included from mm/vmscan.c:46: > include/linux/memory-tiers.h:94:20: note: declared here > 94 | static inline void node_get_allowed_targets(pg_data_t *pgdat, nodemask_t *targets) > | ^~~~~~~~~~~~~~~~~~~~~~~~ > I missed updating this function signature. Will fix it in v3. > > vim +/node_get_allowed_targets +1618 mm/vmscan.c > > 1587 > 1588 /* > 1589 * Take folios on @demote_folios and attempt to demote them to another node. > 1590 * Folios which are not demoted are left on @demote_folios. > 1591 */ > 1592 static unsigned int demote_folio_list(struct list_head *demote_folios, > 1593 struct pglist_data *pgdat, > 1594 nodemask_t *demote_from_nodemask) > 1595 { > 1596 int target_nid = next_demotion_node(pgdat->node_id); > 1597 unsigned int nr_succeeded; > 1598 nodemask_t allowed_mask; > 1599 > 1600 struct migration_target_control mtc = { > 1601 /* > 1602 * Allocate from 'node', or fail quickly and quietly. > 1603 * When this happens, 'page' will likely just be discarded > 1604 * instead of migrated. > 1605 */ > 1606 .gfp_mask = (GFP_HIGHUSER_MOVABLE & ~__GFP_RECLAIM) | __GFP_NOWARN | > 1607 __GFP_NOMEMALLOC | GFP_NOWAIT, > 1608 .nid = target_nid, > 1609 .nmask = &allowed_mask > 1610 }; > 1611 > 1612 if (list_empty(demote_folios)) > 1613 return 0; > 1614 > 1615 if (target_nid == NUMA_NO_NODE) > 1616 return 0; > 1617 > > 1618 node_get_allowed_targets(pgdat, &allowed_mask, demote_from_nodemask); > 1619 > 1620 /* Demotion ignores all cpuset and mempolicy settings */ > 1621 migrate_pages(demote_folios, alloc_demote_page, NULL, > 1622 (unsigned long)&mtc, MIGRATE_ASYNC, MR_DEMOTION, > 1623 &nr_succeeded); > 1624 > 1625 __count_vm_events(PGDEMOTE_KSWAPD + reclaimer_offset(), nr_succeeded); > 1626 > 1627 return nr_succeeded; > 1628 } > 1629 > > -- > 0-DAY CI Kernel Test Service > https://01.org/lkp