From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5012AC04A68 for ; Thu, 28 Jul 2022 17:48:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE2318E0002; Thu, 28 Jul 2022 13:48:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C93538E0001; Thu, 28 Jul 2022 13:48:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5A1D8E0002; Thu, 28 Jul 2022 13:48:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A6F108E0001 for ; Thu, 28 Jul 2022 13:48:54 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8052FAAAB7 for ; Thu, 28 Jul 2022 17:48:54 +0000 (UTC) X-FDA: 79737244188.09.0A7DB3F Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) by imf29.hostedemail.com (Postfix) with ESMTP id 6F7961200A7 for ; Thu, 28 Jul 2022 17:48:53 +0000 (UTC) Received: by mail-io1-f49.google.com with SMTP id h145so1912536iof.9 for ; Thu, 28 Jul 2022 10:48:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=i7ldDxdnUfldQtfp/5n2EGYevnoqq4v0lSwUh5bbbjc=; b=PF+Ni6CU56dDQlOtp54AWAx9RDfVqoF+E+boOAiFj3dFnctctp1dknHKdpjNYCPQfD RUNJEYA9i23Uo7FReETM/vSHNdkRehwFlBTqPhDJK6+EMb2PKMlh39EAV3hWzgpOZ2tb m56597XHyBSzXe92188/aWt1y7RThhItU60eyhn3ZDC8bwSwUJB0bTFlEPSdpm61fK5T C1lPtN1pLpZ1dIebat9TDVCTBe72i1ER5VaWWAT/T3LzllCf35S26ufE2ArAhT6k7oNp tFXOdE9f10ANw86w/Mm0g5p6Xw1jAMW9C/0RRDd9Lxpa/Xp/NQWZM7e++I/tlyAJP3lX vbxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=i7ldDxdnUfldQtfp/5n2EGYevnoqq4v0lSwUh5bbbjc=; b=D8a/i+sBTNg9MmoaFgSsjZA3ztzpqV1N/Ppw+zsa8aOSkzAnyAIKlnUyWgLA6sAMDn 5U2JF7BvoYZ3lGiU/apgIGKhKLsZB+T/d6ZfZel57l1aMaLaaCLDAEG0FS/R66Ynk0R8 6qmwo7bX7tc7TntZSpJNE8fFwdEQCWd2a4E8iytcmNkt86YpwiwnTJ6b36dTmVj23boz Bz8BGwUdrF2yigNOKk15y3eqLJdvcP764dwU7vUeVLfk9AAkWA6msNYYB1+qpsdsJuAF 9yaWwFVt2Z0TEGwVbst7mIFJkWWo0hR5sWkuzA9N4+kttnCWcrQLvxJP8qjH6s7bC3tj ktIQ== X-Gm-Message-State: AJIora+i8vKjbbTGSYHF3mNtP5kMICg4Nbp7kcxzRC3N1e2mUkJAxMMj 5xVggwoP4cKF+H3k4gbdYlvT6UT/ov2ND5+bC4OcTw== X-Google-Smtp-Source: AGRyM1srcMliEgUreIhv0EqJt3cggMO4YvDZvHruQ80pn7vJrgFRKlIG6ZBAvhYrhfZy3gerPAhiHz4eGmuI4T+CRLE= X-Received: by 2002:a6b:fd15:0:b0:67c:7877:3e4d with SMTP id c21-20020a6bfd15000000b0067c78773e4dmr9308681ioi.65.1659030532741; Thu, 28 Jul 2022 10:48:52 -0700 (PDT) MIME-Version: 1.0 References: <20220728121949.20985-1-linmiaohe@huawei.com> <20220728121949.20985-4-linmiaohe@huawei.com> In-Reply-To: <20220728121949.20985-4-linmiaohe@huawei.com> From: Mina Almasry Date: Thu, 28 Jul 2022 10:48:41 -0700 Message-ID: Subject: Re: [PATCH 3/6] hugetlb_cgroup: hugetlbfs: use helper macro SZ_1{K,M,G} To: Miaohe Lin Cc: akpm@linux-foundation.org, mike.kravetz@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=PF+Ni6CU; spf=pass (imf29.hostedemail.com: domain of almasrymina@google.com designates 209.85.166.49 as permitted sender) smtp.mailfrom=almasrymina@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659030534; a=rsa-sha256; cv=none; b=hhP2fqhCCYMwY1n2IvVgK7MC0LtCDfpPGYRn3zNEdZ+T83EjDLbNd0z6g1u850wAlIzw62 M0ah2PhoMMj4a+CYeaNhyyGtWcCP6AU4eymPKMLhvfrhbMQV0NcRfS23x6syskNkHSVhhY BhEEDsOG4YgHubK0JlXW+kP75zL1qwE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659030534; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i7ldDxdnUfldQtfp/5n2EGYevnoqq4v0lSwUh5bbbjc=; b=0Gu8P2r0HY5p/02IZFuvRhBmkScd1ghf79v2ocCfAaYreuoTnjnl4SBH6GPnkfDhPHiWUh doCdMuMCnmSMIDk7+Fq2/BInqwzQkdCSoi+H4rvTaQJECEURaDqwmZgV8swdsZK4bVlIyk 2jJjQcJuQtUE9DPMCuZhbGv258uy7MM= Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=PF+Ni6CU; spf=pass (imf29.hostedemail.com: domain of almasrymina@google.com designates 209.85.166.49 as permitted sender) smtp.mailfrom=almasrymina@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 6F7961200A7 X-Stat-Signature: aqkii1uzsekx5mhhkhza55td7yoooj1t X-HE-Tag: 1659030533-865578 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 28, 2022 at 5:20 AM Miaohe Lin wrote: > > Use helper macro SZ_1K, SZ_1M and SZ_1G to do the size conversion. Minor > readability improvement. > > Signed-off-by: Miaohe Lin Thanks Miaohe, Reviewed-by: Mina Almasry > --- > mm/hugetlb_cgroup.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c > index 99e9a367e1e5..7e0bca52c40f 100644 > --- a/mm/hugetlb_cgroup.c > +++ b/mm/hugetlb_cgroup.c > @@ -674,12 +674,12 @@ static ssize_t hugetlb_cgroup_reset(struct kernfs_open_file *of, > > static char *mem_fmt(char *buf, int size, unsigned long hsize) > { > - if (hsize >= (1UL << 30)) > - snprintf(buf, size, "%luGB", hsize >> 30); > - else if (hsize >= (1UL << 20)) > - snprintf(buf, size, "%luMB", hsize >> 20); > + if (hsize >= SZ_1G) > + snprintf(buf, size, "%luGB", hsize / SZ_1G); > + else if (hsize >= SZ_1M) > + snprintf(buf, size, "%luMB", hsize / SZ_1M); > else > - snprintf(buf, size, "%luKB", hsize >> 10); > + snprintf(buf, size, "%luKB", hsize / SZ_1K); > return buf; > } > > -- > 2.23.0 >