From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 558D8C33CB3 for ; Fri, 17 Jan 2020 19:34:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1AB4B2082F for ; Fri, 17 Jan 2020 19:34:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="TT8zNjpu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1AB4B2082F Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A1E0D6B04E5; Fri, 17 Jan 2020 14:34:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CF6F6B04E6; Fri, 17 Jan 2020 14:34:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8BC6D6B04E7; Fri, 17 Jan 2020 14:34:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0061.hostedemail.com [216.40.44.61]) by kanga.kvack.org (Postfix) with ESMTP id 755F96B04E5 for ; Fri, 17 Jan 2020 14:34:51 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 18C6E2C0D for ; Fri, 17 Jan 2020 19:34:51 +0000 (UTC) X-FDA: 76388128782.04.help29_6484647e74661 X-HE-Tag: help29_6484647e74661 X-Filterd-Recvd-Size: 4590 Received: from mail-oi1-f196.google.com (mail-oi1-f196.google.com [209.85.167.196]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Fri, 17 Jan 2020 19:34:50 +0000 (UTC) Received: by mail-oi1-f196.google.com with SMTP id z64so23239951oia.4 for ; Fri, 17 Jan 2020 11:34:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wnbjoT0j5ag9BS3W7d99gmYHDerGz9fZIduxI8d9DlM=; b=TT8zNjpuzdDlDWtxUF3ROPfakHa88TVeTCCzR5vCXgxUY7gnjtDdV908bvnyE5y4oV QU36Uh70B8zBcLbEC5WsV9OQuSgknaM4MnZ+6jDRyDTKzq1HngpAdAAs3mElPkgX1Ngs w8RxWNVZZmLjGd/pbBFQ57NF0JHpuxd7a1wSLqAAJwqSwurny5s+HaCNXAxlSd2TrGbE I0HJnlRsjj6jLQu5Cu7qeoUYEz1c4KM83fzEb63Qt4ALXNdDhAqG60fYhmckugqonIpN Q31HLAuMmqxdrdOBjnJmAuE2XH93asNdBTd9rXjxonqLYa1bomCyyydoau0rPmn4pocx 0aNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wnbjoT0j5ag9BS3W7d99gmYHDerGz9fZIduxI8d9DlM=; b=HyMDAJub0uxlf3miGa/q8dlo1qQj2DOGz9ftb9SEvGkToY7K9mDOSw4YWMki5nGxaa Trwgv+iIbL/4HnVNaYjZb4d1Lyo92cx6tNDnNLha0XR5nduXu72T/VlQsr2RQTQJAf13 bRfbfCfLhFu9obPxAjNyOsugZmCPSyhHaZ0z11O/D8KTIBhaHdRp6EQEyp3JIaY7hq4o r0Yq7WTOJMwukQRE1hZcUrCUiuOvv8D+5G85yb4GcgS0NDY8sAcoCthdSg6VDUpsQiy6 z9sVjEnduGh4gj9P0dGhscJHv8hNyUAku/f8pizDM3ugLlCYTKyMMIGsZrvhOJoELASE SbyA== X-Gm-Message-State: APjAAAWMTvW14KHPXputNJHpRXu/8PVYLGnPH+CncPbgEejuuR5Tjxgi SOKYbP1VFUH+XjgXlv9E7p66VcxJG4m4tXm0Mej0mg== X-Google-Smtp-Source: APXvYqxLvi0jqyJq4c6XDMG40T2xm371zP61sFys+Wn5Kv1PErBnDGHtInooR+MBkC+FWhdeiq5hF2mMsauFR8qAt28= X-Received: by 2002:aca:ed57:: with SMTP id l84mr4713560oih.8.1579289689665; Fri, 17 Jan 2020 11:34:49 -0800 (PST) MIME-Version: 1.0 References: <20200115012651.228058-1-almasrymina@google.com> <20200115012651.228058-2-almasrymina@google.com> <7e1d2c5f-3b07-4d16-9e1b-bd89d25e7fb3@oracle.com> In-Reply-To: <7e1d2c5f-3b07-4d16-9e1b-bd89d25e7fb3@oracle.com> From: Mina Almasry Date: Fri, 17 Jan 2020 11:34:38 -0800 Message-ID: Subject: Re: [PATCH v10 2/8] hugetlb_cgroup: add interface for charge/uncharge hugetlb reservations To: Mike Kravetz Cc: David Rientjes , Shakeel Butt , shuah , Greg Thelen , Andrew Morton , open list , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, cgroups@vger.kernel.org, Aneesh Kumar Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 17, 2020 at 11:26 AM Mike Kravetz wrote: > > On 1/14/20 5:26 PM, Mina Almasry wrote: > > Augments hugetlb_cgroup_charge_cgroup to be able to charge hugetlb > > usage or hugetlb reservation counter. > > > > Adds a new interface to uncharge a hugetlb_cgroup counter via > > hugetlb_cgroup_uncharge_counter. > > > > Integrates the counter with hugetlb_cgroup, via hugetlb_cgroup_init, > > hugetlb_cgroup_have_usage, and hugetlb_cgroup_css_offline. > > > > Signed-off-by: Mina Almasry > > > > --- > > > > Changes in v10: > > - Added missing VM_BUG_ON > > Thanks for addressing my comments. > I see that patch 8 was updated to address David's comments. I will also > review patch 8 later. > > I am again requesting that someone with more cgroup experience comment on > this patch. I do not have enough experience to determine if the code to > not reparent/zombie cgroup is correct. > Thank you very much for your continued reviews and I'm sorry I'm having so much trouble getting anyone with cgroup experience to look deeply into this. My guess is that it's not very active feature and the patchseries is long and complex so folks are not interested. Nevertheless I'm continually poking David and Shakeel and they will hopefully continue to look into this. FWIW, I have a test for repartenting/counting zombies and the tests at least don't uncover any problems. > For now, > Acked-by: Mike Kravetz > while waiting for cgroup comments. > > -- > Mike Kravetz