From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3187CC54ED1 for ; Fri, 23 May 2025 17:15:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A83786B00C3; Fri, 23 May 2025 13:15:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A33B96B00C5; Fri, 23 May 2025 13:15:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FBA66B00CD; Fri, 23 May 2025 13:15:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7113A6B00C3 for ; Fri, 23 May 2025 13:15:10 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 20E381CD1C1 for ; Fri, 23 May 2025 17:15:10 +0000 (UTC) X-FDA: 83474823180.10.6CC832F Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf05.hostedemail.com (Postfix) with ESMTP id 3B3DA100010 for ; Fri, 23 May 2025 17:15:08 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=NJ0KcUho; spf=pass (imf05.hostedemail.com: domain of almasrymina@google.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=almasrymina@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748020508; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1L0JjzOjlHgjWZPMHxouS8dOF8m0fP7fyoaNhah9J5s=; b=8H/zEXGAxlZAYNknt7zqO0LxMDuHmF4NY+RWFha41oNR9m9UQR6F2ISdsJ9IFVhtQC4aOT p0Tox/hL/w4d1UOIF+EoOHCyhjAnQ8ugz/vZmr/gPqfJiktHw1gfSo8ywsFixPSE+K142F M502Kc+MfzhbjAExOS6759IF4hki/hc= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=NJ0KcUho; spf=pass (imf05.hostedemail.com: domain of almasrymina@google.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=almasrymina@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748020508; a=rsa-sha256; cv=none; b=L0u5g51AWq6bgzRNrFMg3ZL7V6TGkedN0tab9T7Vhl/AAPrRyqd8UEYdFmS7QV6LzKfaOO MZd0Y5Cn86QmAhyzRkSG7xsShaa5DoT1BY3Clg3HT3lTnTFJIHqUK7Qkn+yZOCeGrd+ulK gKonsPl3VJNkrlBNYEL/3uztY37NNo8= Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-231f6c0b692so11395ad.0 for ; Fri, 23 May 2025 10:15:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1748020507; x=1748625307; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1L0JjzOjlHgjWZPMHxouS8dOF8m0fP7fyoaNhah9J5s=; b=NJ0KcUhoxYKQW17txV3JIIy0ixDSeOQJv1ScWtlZX55zKYr7SNMMdnKrNMjdyGsS0v +QCsROfQk3FGzISzHWgyfSjeCg1nrLyCVIPru4ozZhXpad1WRa6TkjwxAUbrnm95S8pF vdFxqCMEP21cxeUfJAHh3hfwPomuVqTBC0MLc1EqEhhTH6ZC7ck9j5ve50ZlDlmNo4gI jjXjdCVonPyBYz9etexjZdxU42kkD7ZQSp/e/GUYooR+AyLtPKqOTw541IOnP7utZzfo fg0yiBuWmKsfWGb0lrdKHx3bBClrujezJedxHdintYFDkBXCb/m6K6laxmz9snJmArkc /IaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748020507; x=1748625307; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1L0JjzOjlHgjWZPMHxouS8dOF8m0fP7fyoaNhah9J5s=; b=NVZCKpsLIn9GFNgQ/WQsMhtZRkpzvigebZRWq7a4oGpz8xAApSnV17kR9PANgMhzDS Uxj1apdDNhs2s03DlrzQxguOMwxPpQur+pJ36lsd7mHjTbDUtzcuOfeDYC67sHVWRENw qroShksaZH9FxzGrUu7cgDrZwDk/57e278rLTfprg1N5wzm3K1PJPkc9JJTWEnvHrMyQ xm8F9XxaCqoFgQGN65KGtI+kjXBJllyORaQWH5n2XYfYXrKvY6R2j9pMFZjx8YicO9bI 02sZGDSDTY+78bRKUXcbOpsJp074WpSq69nSBlFNQskIg0XAXsd7qQQqaFsbriH5+e2k L4NA== X-Forwarded-Encrypted: i=1; AJvYcCWpc9KuINUif3PeVdYgOvQs5MIN7JLXNIk81yXK4CjDij9TxB7FiyCg2urgA+03UChNHoOJhtSGJg==@kvack.org X-Gm-Message-State: AOJu0YzZNvH7zWdVGJRMKISYMultjWz5ezegCsxNYGkE8nAaLJYyc333 TrMuqA1NLA4ufPRv2UMeUeIR/aFMQBQvgTi4Po2P1vyeDXwkh4Ts3+nz4QaMRaGfMvGB4LGNZKB 3XJE3uXYA6AtTG1LqaYKzCGY1RKRsXiGh8dduG99k X-Gm-Gg: ASbGncvLfkATIb0CFjn3miv6sqpopkisv8BLhTpTGNxogssFLk3XK0uGjArcvd8t2fh ygd9LPes8ioPS2i8pm6riPep37VpuG4ovBbvYwvfh9MAFT8foxRttwxhoAfyb5g2vvd8eRKu5hv ZdTpgT9q0WCh7VZOpPUKqOhVEsxAtQqCqaAAQeWlxvZsZP4+ESfp2xHj3XjCTzD7zCvZrwGhnIh MUVUzg0rHAf X-Google-Smtp-Source: AGHT+IHKY4+eyOTipL+J4QWHEmhi7z98sbn5GuQRI5Ig+KizZC1qpLnfhveOl7CVrrTaKZsQhRy6NnMNBA8jCy7xQ54= X-Received: by 2002:a17:903:2348:b0:216:7aaa:4c5f with SMTP id d9443c01a7336-233f34df516mr2608055ad.3.1748020506755; Fri, 23 May 2025 10:15:06 -0700 (PDT) MIME-Version: 1.0 References: <20250523032609.16334-1-byungchul@sk.com> <20250523032609.16334-15-byungchul@sk.com> In-Reply-To: <20250523032609.16334-15-byungchul@sk.com> From: Mina Almasry Date: Fri, 23 May 2025 10:14:54 -0700 X-Gm-Features: AX0GCFuS-_ZvIZXs7vWDJYGmbnFNShYZqaEghvfevVpzOFymPJ1-gQ7S9gnP9aI Message-ID: Subject: Re: [PATCH 14/18] netmem: use _Generic to cover const casting for page_to_netmem() To: Byungchul Park Cc: willy@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, asml.silence@gmail.com, toke@redhat.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 3B3DA100010 X-Stat-Signature: owjfpawo8k7cmwp9tfu3kcgydjw7cwjx X-Rspam-User: X-HE-Tag: 1748020508-216707 X-HE-Meta: U2FsdGVkX19vtQzccEKGQS9e/0VCI8mmXl2z9NKImniDpgyKGSsF8JA54d5A+/pV4V3YFEIbnnOXbw0mvFTmcA9kbhx1jxwhII3rxz9zgK1Zsb5m91D/JOV5aYEb3hIw39y67bruuymCqOY+16nMybXtVTovQISiJZFp6U7assLEdnGop96fTvMncMjuVhcaVA2eW25bt+7B+dUy6m1rwWnk5QMmg73U30tQEhJgFL/ewOnT+fT3gRL/DzWCg6pg1C86YouOEa4Cy3wuRGAWm7FTFfxu1RNmkWKEPYqBbyIiYIXZ4i4jEKFWrFrf/4jDpCrtvmNv9iOZZF72mNILFq9BuSYHci2P5Qr+g8eC6aGoL+GlMvkWpsWne0455W5+VnJqqanXvAUivWCQf5zbJuuy43X8TeOgh0ptlRYEKiyVKlkIG7SHWVOXEtOB+FzH7vBG6htkwB8WC+rqhX2UiuygobGuaPHZblqccqPW2bHOCY0e9RiXBf2TsrUqHx/jB23eYAQFkszNeRJdMS4DD42HfD55qz4h6S5BxmOM7z7IxDaTndAXYCX7eJCsoO3IBd5ntUVjNPr34MvcxbijQJmO5/6No2EeR+Ak6magaknnAeHI+H3GkLaGd/vKefF+yRjMNhyceY4kum3Vqgm1cLjyFStZJ9MQcnjlQxBFGdDATMx3UcAXkkggpItyHhkDHQLabGK4hdOdLjn9H/6/8cD14+NC5IUNrwiv3fYjcsWPlGvE8u3y0yuQBkkp40BSI+COSHXhKGLaYv1oj/do2d2MnDs5yQBRY721OTYOHhwYR+RoskO1BGoU3aZ8DbDBro78rTzY8c+XEoOBXsF6kNPn7VHlDXoB1qb+dgqEZ+ljdBF+HRDdqm4lLOQVITeCaJKpf6atO9HYG7w6qF9iyRbl+Vv7QSgzlhsIMdsttKouAo+s6A9GEnyeaRC5HiZw8ELpow4vmh7n5/HKXf/ chAvyGDG WFIdZisp/uNjbtshpafXjxoYs2p0RMb/3vuEDaed9WxX/4nqV9yUyLeThbBe2g+gA0+Qe3LYit9L0UntOlrr6XAllSeSy5REHOeeSCoYTMcC0OKDO9JqCkT0W2xXsEBRMN7vsz21VhHk2MhCllQd46x/LKHhV6E4etLkqrsSRpBRgR/NZnJEfdGqwKfXERFgZYDEOyJc5i3q6fvbmRxXmuNhCcZCLWgbjqvX590mZ0iEQMu6AqDCksM1K1CiFNCZWpHrESxHmIUpqLdi3QPfWEDc3vMcI7wgi0aF1a1NYVFx7hlFwzqyp+Pa1tzoUa9JOEYp8nKOR6Fl5mvZvbLcikR1q7TWj3peHJ1HRBijuYQJHbYHiXwb5h38PsbNgDSps/H8cOh+OldPBjWw8RZ+iIMEo1A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 22, 2025 at 8:26=E2=80=AFPM Byungchul Park w= rote: > > The current page_to_netmem() doesn't cover const casting resulting in > trying to cast const struct page * to const netmem_ref fails. > > To cover the case, change page_to_netmem() to use macro and _Generic. > > Signed-off-by: Byungchul Park Reviewed-by: Mina Almasry > --- > include/net/netmem.h | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/include/net/netmem.h b/include/net/netmem.h > index 29c005d70c4f..c2eb121181c2 100644 > --- a/include/net/netmem.h > +++ b/include/net/netmem.h > @@ -172,10 +172,9 @@ static inline netmem_ref net_iov_to_netmem(struct ne= t_iov *niov) > return (__force netmem_ref)((unsigned long)niov | NET_IOV); > } > > -static inline netmem_ref page_to_netmem(struct page *page) > -{ > - return (__force netmem_ref)page; > -} > +#define page_to_netmem(p) (_Generic((p), \ > + const struct page *: (__force const netmem_ref)(p), \ > + struct page *: (__force netmem_ref)(p))) > > static inline netmem_ref alloc_netmems_node(int nid, gfp_t gfp_mask, > unsigned int order) > -- > 2.17.1 > --=20 Thanks, Mina