From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AFC5C04A68 for ; Thu, 28 Jul 2022 18:03:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DAACF8E0002; Thu, 28 Jul 2022 14:03:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D33838E0001; Thu, 28 Jul 2022 14:03:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BAC938E0002; Thu, 28 Jul 2022 14:03:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A71798E0001 for ; Thu, 28 Jul 2022 14:03:02 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6ADCE120AE7 for ; Thu, 28 Jul 2022 18:03:02 +0000 (UTC) X-FDA: 79737279804.20.C371408 Received: from mail-il1-f181.google.com (mail-il1-f181.google.com [209.85.166.181]) by imf05.hostedemail.com (Postfix) with ESMTP id 0F65F10009F for ; Thu, 28 Jul 2022 18:03:01 +0000 (UTC) Received: by mail-il1-f181.google.com with SMTP id d4so1298697ilc.8 for ; Thu, 28 Jul 2022 11:03:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=XQkz3l4blJBLiLTAjl/FZyXziCJMNBNV1rmuyDfw/84=; b=BWliJSmnkQgO1y3ePZSHGzOW819Z/V1OguHLXGggxZWhKNm55DHUsml+ThMzNhzOdh vkr3lk2sS2oz5ngv2VEHI4+/FxQ0PVENUGmTlYd00kOI+6sTX59cPRGArtvNTjBOHE8M 09INeJeAlX/eLh8oElv/6kJRafViJJorq0V8cIUiaG5nedEHIPfigzKGbCjPgnfjdSUf ovj+4IJPGd7CBXRq02R1XJmA07OldnqT7++nToBxEFN0utNb4teZ6yFTaSWIxzEUdeUC NzlQiNAvW88RN5r5eXQkwlecNPzATnJpbU4o+N35A7BQgwY7X3y+SoDniYlpG3WvG5/B ItgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=XQkz3l4blJBLiLTAjl/FZyXziCJMNBNV1rmuyDfw/84=; b=vpOI6sUVjwZceluagNojsrnBSDbAXJOwJu9NBJQsCKtL6FuPWTpRCsGJM9sOFgX7zq D7KA6ryxaHMTVXgilIGHfu0WhdxWFPmrjpG9tNCm6ofZgkU/rmkCsIDFcp7lAcu7XuIT tJDe3UfdlJj0P63DxUYxqfc4Yjr3Y8uu16Ewx3/m6gwrt77HDmBp91a/Z36nvg6WRXVC ARvbqnTDcTqiFXvFHU0q31QhmrA6C0vYjrwNszk9W9qHCJ5RG9Yrp7++iz/jMEpOxfc4 6LBC8m3YBAM9Aj3FJnFafKfVQsaiZuG/X5qdOmBOY2t6fwGC7cGClZucFRRSmAZs2zxQ V2xA== X-Gm-Message-State: AJIora8g2ynmoGOaH2UNyOvC4XUaT4HkMuPpWPyXcwVtLNVZ+fdbK/DJ X7+ePjD+uyVGLCGeLzBLjyk+eCImUso6L7b34clgpQ== X-Google-Smtp-Source: AGRyM1u5vV09nMNJatCWQHOe4HEUu9U9TIZS3YYzjBpgCOgDMpq9ET02MUTl02EsdHfb2aifCksbzWj1BkdeL8Z3cOA= X-Received: by 2002:a05:6e02:1091:b0:2dd:f304:5a50 with SMTP id r17-20020a056e02109100b002ddf3045a50mr1630335ilj.146.1659031381251; Thu, 28 Jul 2022 11:03:01 -0700 (PDT) MIME-Version: 1.0 References: <20220728121949.20985-1-linmiaohe@huawei.com> <20220728121949.20985-3-linmiaohe@huawei.com> In-Reply-To: From: Mina Almasry Date: Thu, 28 Jul 2022 11:02:50 -0700 Message-ID: Subject: Re: [PATCH 2/6] hugetlb_cgroup: remove unneeded header file To: Miaohe Lin Cc: akpm@linux-foundation.org, mike.kravetz@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=BWliJSmn; spf=pass (imf05.hostedemail.com: domain of almasrymina@google.com designates 209.85.166.181 as permitted sender) smtp.mailfrom=almasrymina@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659031382; a=rsa-sha256; cv=none; b=EBzcR/caDAOQDtXK3fwjIzEnZqhm77YMDyb8RtgzWNdB4petbYidtWn1GYoUr4Nz9QoRNZ q7mSasthANNvLBiaml8SlYcRQ0OuGJtUhim5Fn+EkWIXgrcPIvII3qmwWm1Zf+VRCabJaA S3qSz+tNJKkt2r7Z3u4MeQskgO6Tb38= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659031382; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XQkz3l4blJBLiLTAjl/FZyXziCJMNBNV1rmuyDfw/84=; b=MaXD1GYV/hfg+gsFs30GZe2BGt7aPH/gjqzmXUo9ApjJUrW5xUejdCsJWxzOo/6/yzoICy F02q4QUXflVCUqv4pb4tt3OppDXHWMs+4o0Q56P9Y3JpnA2Ojy7nRQCOeq8gePkFTYuPQW 4ZIUL+LzGt2wAJrAZ560eorrvlYsQxg= X-Stat-Signature: cc4urpkkmgg7mmmgpdypgtenm14qwg3h X-Rspamd-Queue-Id: 0F65F10009F X-Rspam-User: Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=BWliJSmn; spf=pass (imf05.hostedemail.com: domain of almasrymina@google.com designates 209.85.166.181 as permitted sender) smtp.mailfrom=almasrymina@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam02 X-HE-Tag: 1659031381-89771 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 28, 2022 at 10:45 AM Mina Almasry wrote: > > On Thu, Jul 28, 2022 at 5:20 AM Miaohe Lin wrote: > > > > The header file slab.h is unneeded now. Remove it. > > > > Signed-off-by: Miaohe Lin > > Acked-by: Mina Almasry > Actually, sorry, but this file calls kzalloc_node() which comes from linux/slab.h, no? Can we keep the include then? slab.h is probably included by other include files but for clarity it's better that hugetlb_cgroup.c to include slab.h if it is calling functions declared there. > > --- > > mm/hugetlb_cgroup.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c > > index d16eb00c947d..99e9a367e1e5 100644 > > --- a/mm/hugetlb_cgroup.c > > +++ b/mm/hugetlb_cgroup.c > > @@ -19,7 +19,6 @@ > > > > #include > > #include > > -#include > > #include > > #include > > > > -- > > 2.23.0 > >