From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DCB0C05027 for ; Sat, 18 Feb 2023 01:40:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 38B776B0078; Fri, 17 Feb 2023 20:40:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 314226B007B; Fri, 17 Feb 2023 20:40:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B4F26B007D; Fri, 17 Feb 2023 20:40:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 08BD46B0078 for ; Fri, 17 Feb 2023 20:40:28 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D65D8120A29 for ; Sat, 18 Feb 2023 01:40:27 +0000 (UTC) X-FDA: 80478707694.11.445480E Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) by imf21.hostedemail.com (Postfix) with ESMTP id 208881C0014 for ; Sat, 18 Feb 2023 01:40:24 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=RHqMFu4f; spf=pass (imf21.hostedemail.com: domain of almasrymina@google.com designates 209.85.166.53 as permitted sender) smtp.mailfrom=almasrymina@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676684425; a=rsa-sha256; cv=none; b=Nc1ReRoMePaYXFPADFanOi/6ffgX0fYJpHjS2MygktcJdUbd/criUyKO2Vaee5KhbsTUOV d0MmdihzjZuldwl3fTwpCTeqd/HeTi9hov2kmU60TsTRSeRRdbNnIqgY1m+/Y22yM+/vEt KEpjFba+JqbZNArz06TL1IevFzw7ZYM= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=RHqMFu4f; spf=pass (imf21.hostedemail.com: domain of almasrymina@google.com designates 209.85.166.53 as permitted sender) smtp.mailfrom=almasrymina@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676684425; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fsxS1CvU3sPwRUQ7h5x+PsiOhYM0cqVzH8hm+Yv9Ypk=; b=E874oApFhBQE/RFkeQsMN1Rg1WsrNhYJEXxZoeEoOqFAl6j8bNPhB1voMNzboch3s41lKU QsJrpjqLf2l3APNSHfKZchE1RPew+5JZqMShz7ZgNEoBXT1OmEL0bTQNE/GoQiMKS6iMVp RYoLamst97cVsjZQSqyw6b1xgTjcCcU= Received: by mail-io1-f53.google.com with SMTP id v8so4537ioh.12 for ; Fri, 17 Feb 2023 17:40:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fsxS1CvU3sPwRUQ7h5x+PsiOhYM0cqVzH8hm+Yv9Ypk=; b=RHqMFu4fMBvsjgHDOqayIgKc17Dfifs0tzNkGNdGY4QFvW1R6niUfBvQMJDRwG2DOZ R+8NuQvda+pKQjQwrGOmkEKc9QkzPz80st/qNPH0wN8mbQ0dnZobvx3nv6BXxzDa0wCg APImNM62nPIOVuemsndgIxFBcfHN/trLXonKQM7cyi/vlR9K3jmexu6P41dUuqipJY4B xwurCDXsgERc0EoiFtO35L45V1WpXMuhvFHUEKK9NtSXGkbGfGTtfieCsJXEmGjvu5zK 7yavbqNxJYGg2zCfeJ9rEh5QA49RsQ68d7JUpU7WuotqvegGxLXr17QWftzPHbofbQ3C Y5fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fsxS1CvU3sPwRUQ7h5x+PsiOhYM0cqVzH8hm+Yv9Ypk=; b=uyWrPwD5RJUb8vdGfO+oZ0WRcPx+tFaQ+JF1HudhjmQRxt5HoC/AFWtbnPIT7JUs4L HXFkM8HhxDlQ/o6uA5KiI37wsTJ0uZBKlj6gY2ikTbEl3hIpdRFXdodh2YH9A5RLyjxY xnL7rMXUk1kLJ/7E9BbwjdPTqGHSo7R7RxNRVFdu6XhHMIpl8XOgaHDflqKAXwKxl6Kb 0izwKzdkWpGKAHZe4wRBwD7fjm/f4yHvyLR9lqzbytImUs/wYJCRVqCKjZeX//WgegGM b49B34W+7Gp5wBw13mQkYn6vaoStyPTV1FmF+DPZo/tZLqKxqoxUX7giNPQ5/JHZecUw tUBw== X-Gm-Message-State: AO0yUKWyBlPcjsi+xeVbqF32WSMBr4t/GTRuOppnzxig9g1g9b74zna/ Q2o+aFItPOnFsNDdUPzfHX9iyU8p6i4o0VQJ5ocrnA== X-Google-Smtp-Source: AK7set81+4+DcnxLnRjD0bGTcfJyYF5UOz/DNXJjQZZRHaJs1AohJ+P/Q1I8zGEmUbew24o0jKFdz2LCuIDv8k69ycU= X-Received: by 2002:a6b:3c09:0:b0:73d:9833:d43 with SMTP id k9-20020a6b3c09000000b0073d98330d43mr347908iob.27.1676684424236; Fri, 17 Feb 2023 17:40:24 -0800 (PST) MIME-Version: 1.0 References: <20230218002819.1486479-1-jthoughton@google.com> <20230218002819.1486479-9-jthoughton@google.com> In-Reply-To: <20230218002819.1486479-9-jthoughton@google.com> From: Mina Almasry Date: Fri, 17 Feb 2023 17:40:13 -0800 Message-ID: Subject: Re: [PATCH v2 08/46] hugetlb: add HugeTLB HGM enablement helpers To: James Houghton Cc: Mike Kravetz , Muchun Song , Peter Xu , Andrew Morton , David Hildenbrand , David Rientjes , Axel Rasmussen , "Zach O'Keefe" , Manish Mishra , Naoya Horiguchi , "Dr . David Alan Gilbert" , "Matthew Wilcox (Oracle)" , Vlastimil Babka , Baolin Wang , Miaohe Lin , Yang Shi , Frank van der Linden , Jiaqi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 208881C0014 X-Rspamd-Server: rspam01 X-Stat-Signature: s3pitcoisng5rad5hc7ai3ukbz6q7wju X-HE-Tag: 1676684424-647233 X-HE-Meta: U2FsdGVkX1+5JS5UEQInDvB1yuCXsgzMvOaK5iQjqvuQpr7ShW0Rop7qOcpGTCm885eBig0v9VH9giuap95gViSUYlGdPK2+ginXNqexsj9FGWfZO1e8/novmBARUP4A1l/ktKkCF8M7nksJBAunwcVdlTJGjj09XhDVJDD+pW3zGV6xS/+9YB9QXjWWFESXKpgvqL1YO5pbT+c3je0WRXIQ5N8ihebXT8u0Ua3e+zo8HW8pbXFv0Qqi/Gom99vXYEzFkxK8Fz1LF9z1K6vgmnp8R0KjWlW0etbJf8NaPxMkKmDeAxJWaVF7/FbFwHVAJAEHFsTOKnu6OAmlvZLVn2G+BNwODCylqJGXOID5Bskg4DDYtV1z4v20MlVpUrs2CsA9lmtLo+HIwh16eW2TH4raxBPpdCyKrd4rHb7jPNb2oTqMXDWES6N+sOS8UkEjGFqXn1fC4N9vS0nGRUsyfb35Vv9r41rxc0ailB6AL86BX6lC0psb82nmE4QYuuf+6aSdIl7gO3pfhHEr0QpyBVq1eYdUyrxj+CJJ5cy1OUfOPxRUV120FsQ40KQcKMPucpH6cVUjQYMb43fxLFCaEakhMV/dmOQgKqTskxgyoO+WAzHvdhUKr9vzhGJHqWJQL+0XZLaUDCIK0xDg7+4UzLXY/ngB9UACHZUhrmlEYB8HcpgS6j9cr8jJz6lE1aQBAy2jtZW70gN+rx64fwLHTijyMcxnIiXY7FoUhn/AF8ssWNPVfirqjQiUVm/khpKDcHS6gre2voLahhz5elZHkIPfE3UZrF2k8RgGQBTS9kL8HdmJX0M2MM2OoiwSNCZH+QlFZS4+1cuD1zseyS7klupLf2PzS7+sDtqtAcowOt40Hgd6xTD9woffJ/FVu4a6tWRTOsBHyeJCZYaJXvfJeg5xC/Q5DXAUPk7w4qTKK98yTfowfOYQiXsFJhpEVKTSjv82Dh+UEWZ50F9Fxwp k7ab6/yI 8OPOuIGAMIketmnzPjeCDIYUYnV59h39ikpnGAEeUhCHF8+H+SD/9oC14HndtgInatwq60mS20CywkhYZCdr1ObYwTdh8sPru5zFZHTiJY+tL6r6KmTXyk7KoXGCcqd1pKlbwhlI82pWsSxfcfE7DZ7sTOBDxDWZNNH/CV+KZbGKtc/O2Ti1oylTQD6XcGYFBJFn6E6LBRUOGPwcMw01rBM3PgIe0lsMPKHtgL+6E1Cs32heJDiYwVZ3SDRh7QzSxzzds5FWWR4wq/D8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 17, 2023 at 4:28=E2=80=AFPM James Houghton wrote: > > hugetlb_hgm_eligible indicates that a VMA is eligible to have HGM > explicitly enabled via MADV_SPLIT, and hugetlb_hgm_enabled indicates > that HGM has been enabled. > > Signed-off-by: James Houghton Only nits: Reviewed-by: Mina Almasry > > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > index 7c977d234aba..efd2635a87f5 100644 > --- a/include/linux/hugetlb.h > +++ b/include/linux/hugetlb.h > @@ -1211,6 +1211,20 @@ static inline void hugetlb_unregister_node(struct = node *node) > } > #endif /* CONFIG_HUGETLB_PAGE */ > > +#ifdef CONFIG_HUGETLB_HIGH_GRANULARITY_MAPPING > +bool hugetlb_hgm_enabled(struct vm_area_struct *vma); > +bool hugetlb_hgm_eligible(struct vm_area_struct *vma); > +#else > +static inline bool hugetlb_hgm_enabled(struct vm_area_struct *vma) > +{ > + return false; > +} > +static inline bool hugetlb_hgm_eligible(struct vm_area_struct *vma) > +{ > + return false; > +} > +#endif > + > static inline spinlock_t *huge_pte_lock(struct hstate *h, > struct mm_struct *mm, pte_t *pte) > { > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 6c008c9de80e..0576dcc98044 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -7004,6 +7004,10 @@ static bool pmd_sharing_possible(struct vm_area_st= ruct *vma) > #ifdef CONFIG_USERFAULTFD > if (uffd_disable_huge_pmd_share(vma)) > return false; > +#endif > +#ifdef CONFIG_HUGETLB_HIGH_GRANULARITY_MAPPING > + if (hugetlb_hgm_enabled(vma)) > + return false; > #endif > /* > * Only shared VMAs can share PMDs. > @@ -7267,6 +7271,18 @@ __weak unsigned long hugetlb_mask_last_page(struct= hstate *h) > > #endif /* CONFIG_ARCH_WANT_GENERAL_HUGETLB */ > > +#ifdef CONFIG_HUGETLB_HIGH_GRANULARITY_MAPPING > +bool hugetlb_hgm_eligible(struct vm_area_struct *vma) I think the other function you named pmd_sharing_possible(), I suggest hugetlb_hgm_possible() for some consistency. > +{ > + /* All shared VMAs may have HGM. */ I think this is a redundant comment. > + return vma && (vma->vm_flags & VM_MAYSHARE); > +} > +bool hugetlb_hgm_enabled(struct vm_area_struct *vma) > +{ > + return vma && (vma->vm_flags & VM_HUGETLB_HGM); > +} > +#endif /* CONFIG_HUGETLB_HIGH_GRANULARITY_MAPPING */ > + > /* > * These functions are overwritable if your architecture needs its own > * behavior. > -- > 2.39.2.637.g21b0678d19-goog >