From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF951CF31B4 for ; Wed, 2 Oct 2024 12:14:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 82B9C6B0093; Wed, 2 Oct 2024 08:14:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7DBBB6B00AB; Wed, 2 Oct 2024 08:14:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A3416B00AD; Wed, 2 Oct 2024 08:14:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 44A5D6B0093 for ; Wed, 2 Oct 2024 08:14:59 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id AAE63C03A4 for ; Wed, 2 Oct 2024 12:14:58 +0000 (UTC) X-FDA: 82628556276.08.7AE52C7 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf28.hostedemail.com (Postfix) with ESMTP id D48D2C0009 for ; Wed, 2 Oct 2024 12:14:56 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Nf4lloEr; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of ebpqwerty472123@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=ebpqwerty472123@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727871202; a=rsa-sha256; cv=none; b=nZNy7iTvG/XNEFSwQuWLwfn5xJL36vPnTBad/JtHyaIkdmZt3mfcPB2lFOGSHqoDu+yjAm BrU3dZ6p3J0TIJFUvg1kBvc4rWlLCDR5kuVFJFJwYBCt1Z62FQoHzA+ogwy66hJ+HF+EtN VEgCMdH0QHm3aOtRTltbuNJ9cCDDjRY= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Nf4lloEr; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of ebpqwerty472123@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=ebpqwerty472123@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727871202; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kn1Dd/px1Ixz2rJpunVYZIZjoaQqQeBetzzxg5CJq7Y=; b=IhBKqK25tWtri4IPE4YV04CnFDUaYxjb5F8gm6YywiR0L6lkU2s648/1gkYIBAHXmZLT6o 1tKwkYdsXw6a172C2vU0pS5SxHCzJhPLZFYflxSdPJ57fON0KXL8hvqA7tsfY7c5gYLl4P bVyYUbQWzCPXVve3FlHaRGKxVvfyma8= Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-5399041167cso5579894e87.0 for ; Wed, 02 Oct 2024 05:14:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727871295; x=1728476095; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=kn1Dd/px1Ixz2rJpunVYZIZjoaQqQeBetzzxg5CJq7Y=; b=Nf4lloErrmdsn3laAZNWAIumjHTK73uxDGWjLEjyCJ4tgJdqO6HEF8mv57A3kPnvND 0EFisv8h2ZKYOe86NbcU8CYpfwXjGyDY0OdLbw2b3e+hD6Dj5qy01xBepJ7qVr8eXQFq OMPg8OcpcQD0nbDs1mg82rE8ki1uM0kWxgaEHKBLl3V0X/zrojzKLxrer69Y9jHTkuxL Y/FVDsrYWdxWY5UtClvWxm9KU9noN2fI1BJByuvcnYkPPMkZjI5BXntppU6gIIl78E54 XAKk2VQtqViuHtnHMIvJltHETO+vPMFCN+wL3on8sAuj+OHCQUwez9e+tihbn8/EBOqj wjFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727871295; x=1728476095; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kn1Dd/px1Ixz2rJpunVYZIZjoaQqQeBetzzxg5CJq7Y=; b=LxR18v9AEIau/XrrC5KZxaMkyZswUMZ9tN3pHNqE+IKTKAEqaH2lUCnY3jFYY6xh5w AemPPMJt7VzMIP+TcVsf4Xf4z3tSgPnX8GJ/36dbmFqaODk4bwKlrztOepkIueLWn/hK tTlW7i4T6eKQYDE2Wz2sJk+YPhk2LDZNJTLyQOnnvVaflD3yZ2g1RfsAo7WoV4Iyorwl e8cEIASYUMJH9U6u42hknIa2eGo6MihCFr2pmi/B5gTfvb6BO3GWOmA95O9IcXVoKj+9 h3RVV0hO9am2rkGqFmFKDicnv/L1vm/6RD86FyADR2Cr7VkbS4dQjGze+drISVwaHPiP QP2w== X-Forwarded-Encrypted: i=1; AJvYcCXYKVBNFJ62qQwMrpyKuVC3iVRrsdradcRzA6iZPL22S57RLIzod9dLnkSYMC+Dby4x0A7BRLWOPw==@kvack.org X-Gm-Message-State: AOJu0YwfY+sf96Tf9+2aI04SRS0FukR3EXxuz/1LWSK1jS3Y04P5c606 TidGbc7BHqg8ZT1ew9SP1mzXJILPNr7L4cD4LA6CPu9pBTg2lublnCal1CSBZltFiFjsKx7/nFm f0JIoX7IF1tJuRMrUxl62obom7zw= X-Google-Smtp-Source: AGHT+IHLZlR5sPbJi6pSFv/Bu4vFdjMUz0c0zKHyOhto8MlpSlYJUJSnjsnyEKOpWeVMTU84J0RJLmTQwxaVDlPHAZQ= X-Received: by 2002:a05:6512:3c8a:b0:535:6a34:b8c3 with SMTP id 2adb3069b0e04-539a0658927mr2649946e87.5.1727871294749; Wed, 02 Oct 2024 05:14:54 -0700 (PDT) MIME-Version: 1.0 References: <66f8846e.050a0220.aab67.000b.GAE@google.com> <66fcd082.050a0220.f28ec.04f1.GAE@google.com> In-Reply-To: <66fcd082.050a0220.f28ec.04f1.GAE@google.com> From: Shu Han Date: Wed, 2 Oct 2024 20:14:41 +0800 Message-ID: Subject: Re: [syzbot] [mm?] possible deadlock in upgrade_mmap_lock_carefully To: syzbot Cc: akpm@linux-foundation.org, hughd@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, paul@paul-moore.com, stephen.smalley.work@gmail.com, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: D48D2C0009 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 8cpyefqjw5bdm34t1ch1a3663qgsw3xj X-HE-Tag: 1727871296-214233 X-HE-Meta: U2FsdGVkX18Hca5yKMw4Fda17VbEci64gGGeqtXp8rOWmo0v7s9v5ESF04AY2jGfEtSAZ87Jvrg4/inzanwcjMOj4kGwRzH/kTbXivA/qCZplzxNSdk/TnK433t+cLI2ghmLOjKLBeUcMrhqei7Q1GJtxseUMtf4kGh8/pEiWc+Uua55U+Y4NNN3aCLJm1zrbDeXL77IzhdeXj31jbOmWQFIbF1iqq7pg3O+Ulc2FT/T8Kh0eRSXrjeclfq14qKo9pANwmKlyNo39wp5aL+1Jzi9pYXs+z+L2eFB7jRdhZqN5lUoKTPBvPlgAgG036naxAefTp91uw3mLH7vhI0KSfDvjrAD/jFU/hW/VGF+7q6b+YtnZNeX1pugYlUY/Y/cHxsAeUtlYYGrD+yyJy4WGvu6dYoBzDRnoXGr2WvUqF67/RrDtQtXUO8i1kbIv3OG+Qq0RrL6Cf8J4lJfqKKx0D9977JG3yOBaycUQfRVp/AwlokiK3UAU9dwvNpFlRyKkqH+wGUmLRJmLKfGAohhWlkrc0rekhB85wP12inMQcXh6+iFgAwHChA2LsHBOsU1oHhHV1TcjKTm6Q99zEHoMROeh3hQS1lElBkgcalqSiCWp4uW9ybgeJIODhlHu5q2YCiv2SsvwCeVYeOD7h4Y2x07Wv4TJltUxX8J7Bs8MZx0jnptH8hpuf4tM1WdiP1nKJe4iG1HRIBTI/fPVqmP0Vmw2r/Yuo5fIJ7MtUTV/rP5E3A0W6Iz2PKjIgV1t/dTUHJqyXjec/EGj4kRmIlhArJm9ueZPcNSVH1Y0b4vgNkiItzWASr6ncKE0kydmgueFJ5aasB9OE223dvhTQ8ptv5cxFmWbcYeD7jJyQUgMdyGEuTVRrU0YxzaR0MBh0ToPAxcUayWP/KhTpctnmdIF3hd5OHmtgFeLSt+14GlnPne+FZzybeEuK4CnA6dVXUv2AUTd1EXDOYuIQ6pG6f ZHZQZ1Nk R4nbzDB8nuv3wuvApcppqrRvCkQ3+wFQMfZi1nptqxTL//m9YOEkvAu7BVB2qpv4BKF1BopfAQRBgWsXHG7idYl60BL65ziT11FwBIU+pYUUYb40OFs/gYfQ8Ro21U6es+SOv3DYwQyVbN8Mh/aYYAGHjJMEZBtOERHYLdtikkNu0Qahhl1OqWPe+huMsPPizN7BB7bKQblyjB9i8/ftpKEaOB+nzGq/oYDJfcMnaiaVUk6g51sDPYezh5+ap+ud6Ckw0c9WEBibgHGm6ZRZMda76xXcl6CedQSmzgm2Fw30f57qi7NqQFmvVT1lyf+xDLJ1qPXahq8q47t2IfR1gy8CCQM6ujJaf1cTFVM9ZUO567stxdYSPZ7APbOynauhyZzCWU8r1nSqMO2tnJKITyEcT1dYyo9HJxmjQLY8G7zh/L7sbbU7w9LSDEypu2zKmmup5+VkMvOKV9EF5oe9kXk01iTCI331KlJiBHydZEwIQmW5VqJ6w2c8ox4Jdle9+WA7gw8IGnXnBSrOgkrFpWNaduj4YTXSRbDMIBL9xCfObyAoU6TKCwTpylwZDRsNlo1n6W+j7PBKmwtQ+RuA38EK8xXIE2rBwx/em2D9Ax47vfDY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.178090, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: It seems to be the same as [1]. New LSM hook position for remap_file_pages + IMA = deadlock. The new LSM hook position is added for a bypass caused by no check in remap_file_pages + READ_IMPLIES_EXEC in do_mmap. I suggest fix it by removing the check and moving READ_IMPLIES_EXEC out of do_mmap[2]. Link: https://lore.kernel.org/lkml/20240928065620.7abadb2d8552f03d785c77c9@linux-foundation.org/ [1] Link: https://lore.kernel.org/all/20240928180044.50-1-ebpqwerty472123@gmail.com/ [2]