From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6551C369B0 for ; Wed, 25 Sep 2024 09:10:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C67D6B007B; Wed, 25 Sep 2024 05:10:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 576B26B0082; Wed, 25 Sep 2024 05:10:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 43E106B0083; Wed, 25 Sep 2024 05:10:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 261816B007B for ; Wed, 25 Sep 2024 05:10:07 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id AC99A120A5D for ; Wed, 25 Sep 2024 09:10:06 +0000 (UTC) X-FDA: 82602688812.04.3F84F0F Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by imf22.hostedemail.com (Postfix) with ESMTP id DD817C000E for ; Wed, 25 Sep 2024 09:10:04 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Q6RMtDnt; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of ebpqwerty472123@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=ebpqwerty472123@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727255369; a=rsa-sha256; cv=none; b=cmC7ns1Q9oz+JZWGBcfgmnoJqN3p17K6r+DaDRNd6ZMTMyVjFA+bvcDXKPPnob1EgX9UXp p0FR8Pu7VpeEwvxzH4pdHV5tRmIgAhBa+26F8dv7DSnkqOMlugLA8eR9eMQ3xZOWzfndC/ Ntmd5lIkpt+xuRB5pdQfh57u8S3dXEM= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Q6RMtDnt; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of ebpqwerty472123@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=ebpqwerty472123@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727255369; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KJNitsyKCNYW8WsaTmTs6kzhn1+MWzOgiBu6LL80W0g=; b=jjTcqJ2zkYpRrhuKqoId5HOhJfLYpneT8lAUfmKDDNWFufeDySFAbTOavFvcROrXBe6OZj U+b7h7htqOOdSS2cUQ9NxfzVD6AolF9raDrcfKyA+n0Sylst9tfpvZZ+JzXd8NfCUYiEBr ao+adyIXOhiRV+C51GDDZx3kcXjs/ao= Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-536a2759f0eso3239559e87.3 for ; Wed, 25 Sep 2024 02:10:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727255403; x=1727860203; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=KJNitsyKCNYW8WsaTmTs6kzhn1+MWzOgiBu6LL80W0g=; b=Q6RMtDntobnHxJ6YIUH3zEwcvQDiEakHhLCOXZI773xJH70NeRUIaZa6rYCW/9BKKN GJRNxqVooz/YuC8WSOj0L6y++UiOPEFPh71HE+VhTNRY/MH+H7FKh1ebf/U4r9P5iHoV LNVyeZYmC+AjDoX+S3wkU+HYO8oSHJSz9jmzxOE7xArQ9eidUG+dZDLpSZehCYplYsP6 HzMIcg5klXJHJ1AzcBEshVEgEm/O3jXwbOqlkn/iYBmOET6Ny1Rz+KZ+it7IcK+0safv F9aAGtouPjfy0NBPLJd8NfbobBI9IZKZwlC+m1HQagcmV3ssnpkUHJcgK90/pj8OZxFX c5OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727255403; x=1727860203; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KJNitsyKCNYW8WsaTmTs6kzhn1+MWzOgiBu6LL80W0g=; b=vBdLtvpPmxxxgKUJt8zMfEzhCbupMEcAtSTOV+21DXUjQDfJ6DD/YglzB1BsxDzsUQ jbOJbBKIOit84+UcH5XbFva7lGvq20ZsmXrdHSHBHxRGakylaVStxn16OjEW9+Eb4hDT mmgp7qvLFWBtfx8bA70NSWJabFMWXOh3E21nnRVFwJ1JzuJO8n4/g8LFpN8LTKjRnUEh 58p5dzS03Q+QcPpWv0ChPbGAh7y8aBpN/EyBiCgMtRT6j14ffZOzErojp0NRHeEBEnNb g5KuvQe3nzptfTeuJfCTnBYkZ4V/0FX6o3sz/5vAyGgzpY76CaR+fra7UcrErj2Snrys zgGw== X-Forwarded-Encrypted: i=1; AJvYcCW8XvmqEB17J1utXl4Ecy33Zrw72xfHwJWlt44dy/clxqGysE0xGWlmabgNBw/OU5hJaw9v5OJAKQ==@kvack.org X-Gm-Message-State: AOJu0YyO40JD6uJWMcJ7wT2VBjm45R5v3lL8eoCxe6uXivxsVH6LmH4r yRB59rdRHknh7VTt8mqZSf04cIUYlZFM7/VpMytJzfQSPjxIY0gXQ6z7NJIbFF/ueUFogqC0etN bP1OA9ljUCJ4lIXBEyYHnReSYKug= X-Google-Smtp-Source: AGHT+IFe0eFSdFHtx4vDmmNqJptlJb98VcDaGToQ02Y9mXP2tAtI/AVgR/sheKHABwSRLmum1zOsjbmvSENKOtB1wzY= X-Received: by 2002:a05:6512:3d23:b0:533:4b07:a8dc with SMTP id 2adb3069b0e04-538775391d9mr1260207e87.35.1727255402704; Wed, 25 Sep 2024 02:10:02 -0700 (PDT) MIME-Version: 1.0 References: <20240925063034.169-1-ebpqwerty472123@gmail.com> <72050879-4546-4bc7-9983-79ad437594d4@lucifer.local> In-Reply-To: <72050879-4546-4bc7-9983-79ad437594d4@lucifer.local> From: Shu Han Date: Wed, 25 Sep 2024 17:09:47 +0800 Message-ID: Subject: Re: [PATCH] mm: move the check of READ_IMPLIES_EXEC out of do_mmap() To: Lorenzo Stoakes Cc: akpm@linux-foundation.org, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, Liam.Howlett@oracle.com, vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, Al Viro Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: DD817C000E X-Rspamd-Server: rspam01 X-Stat-Signature: eu9j6ujixohzdwaad51dpekgn5m5xwj8 X-HE-Tag: 1727255404-949021 X-HE-Meta: U2FsdGVkX1/honMHoXgbWrIA3wAjzf+U6S32QodTyT65ddUpq7s/nH45q6+40j7WFiv9YNznXTywnEXqls4yLJthrnT4ZcXzCqXDOPYX6Cej83kh4Y/o+7n6jtr2rGniTP7mPP1+Ql9SMJ8dzK2on+YMdwV5maK4jQabDx2hKXWX7+xoaLWdlD0R1h2djwtleCv98u1RvE4KReo4G0bNkU2QunEfg+5oAES0VolxqbrYqCKYmD12Ir3+pXxWbGyGxqLzHaDN/70yC11gW0stuL9hwWX5j0ugcVCmdxW4yNxjEV+IMlKz48m8NKjfaWHeY7RUxXRDZRvwzRk7JdfbhdnYOrSHzZEaQ+8W7g+VotNlZ5++SzWWhiJzvdboJc8L7RIZVFKiewhi1nsFdq43vV0eKZq+3f+JiCavx14pgIAg+0awuKE24jnIzxs6cEdi4LbRUAofw0I81+9NhZD0UjnZUfNQtCrbqz4Sj1JdKIzLOO8kNg5DwLyi8RWWemjKEtTq1ye//US4tOPfVUFqjCHmi5QRy2MxpoTs92qKHxaaztcZuAbQS6ZgY+Js4P5ynxtAL1GRfcxS2XKHaB2kllEC50fXoEg5iUBagnzucc7oZ7IoNbRPxabRfJJlFp8DHGP/BdqI/L4v+YAHb6hgmLVxSuwv7zdROutEUhzmJ2sVrRMxBJK2n2jBDeXSm1Yaef4h52lHezMRXoaBZjXXFccBfrqfZENj5PUgx3TB8CDkbS8Fo2+bivHZiDWtBiFcX/iiZ7mnmrPN4BTV3R9Ir50RsYxSmBfD0JMaNK/nKMla0YMI7shfWfQZUFd09sp8CWaKbEP+z0m+LzfdxEmMIh3NIr8P/I5/nIYvLc4qEk0pBNPCnDQq3+TSGvG03CDNj3alRUlVeaOLGL8v5CNBt9RUjoO+Pxp9QFiC0srsdn/z4HDgKHiF8V9dKnuf1NgN15xxhQyjaxzPkWI1vIb OnpFM5Cz 7URzRfUbp8/CWBa7hOm6rwA7DmTnP6qPa/1qSVFjSXoyvsp4/mSc1dVK5UC/ygg8GFUFH7Q8bhqqJiTr+ZLc6rsyA4UBjmVhzx11strq3vsaqWGnRyjwQbUT4CrjJURnrucnY8L6p2suijjJ8SttpqSEj+Xg58Ge3EfGwQ7ZxJx+YD49DgbU3PPn6Vy+YASXg1IJS/Tb/EMGxweQz8B0PwuF23VTy+RcP16cs4zR+9/26QkPS/PjaO82BTc8nFHLWKmfKVzUCKesuXLiIH6KKorabaOc2PCImUJCZ+VQJBNliSEIQUEhseal+iyh5v0/7NwWsMlZ9JZLMAhPbTojN6rF3TZyLQmFwRLw9iW+ESX1lEbM+1kZ1/RQXiCvEpahIUKwOMmj9FmlaRDhv9vA/0yGQuyGemcvvpej+1d4tNH0+tmim4e5e1v9pnAtqfUK9gH5RLpdH+A8IRf4cJCI1hU52tw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.193506, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > You have sent this non-RFC intentionally conflicting with [0] to provide > 'alternatives' that is not what a [PATCH] submission is. > > In any case, speculative changes like this should ABSOLUTELY be sent RFC, > and sending things that are merge conflicts as ordinary patches is actually > bordering on being a little rude! > > I'm sure it's unintentional :) but for the sake of us being able to work > with these properly you should just send one as RFC and ask whether it'd be > appropriate to send an alternative, and just allude to it in the one you do > send. > > [0]:https://lore.kernel.org/all/20240925081628.408-1-ebpqwerty472123@gmail.com/ I am very sorry that I sent the wrong subject which should add "RFC", due to lack of experience. > It's a bit weird to send 'alternatives' - you should by now have a good > sense of which ought to work, if not perhaps more research is required on > your part? I think both solutions can work, and the preliminary discussion is on the mail list for [1] (as this issue is related to security before it was fixed, the discussion is on security@kernel.org). The choice depends only on taste. Link: https://lore.kernel.org/all/20240919080905.4506-2-paul@paul-moore.com/ [1]