linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Shu Han <ebpqwerty472123@gmail.com>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: akpm@linux-foundation.org, paul@paul-moore.com,
	jmorris@namei.org,  serge@hallyn.com, Liam.Howlett@oracle.com,
	vbabka@suse.cz, linux-mm@kvack.org,
	 linux-kernel@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	 Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] mm: move the check of READ_IMPLIES_EXEC out of do_mmap()
Date: Wed, 25 Sep 2024 17:09:47 +0800	[thread overview]
Message-ID: <CAHQche8ijvNfKHBLV8BWWq85rjKQbjO+0w2s6kj4V3OpBANcuA@mail.gmail.com> (raw)
In-Reply-To: <72050879-4546-4bc7-9983-79ad437594d4@lucifer.local>

> You have sent this non-RFC intentionally conflicting with [0] to provide
> 'alternatives' that is not what a [PATCH] submission is.
>
> In any case, speculative changes like this should ABSOLUTELY be sent RFC,
> and sending things that are merge conflicts as ordinary patches is actually
> bordering on being a little rude!
>
> I'm sure it's unintentional :) but for the sake of us being able to work
> with these properly you should just send one as RFC and ask whether it'd be
> appropriate to send an alternative, and just allude to it in the one you do
> send.
>
> [0]:https://lore.kernel.org/all/20240925081628.408-1-ebpqwerty472123@gmail.com/

I am very sorry that I sent the wrong subject which should add "RFC",
due to lack of experience.

> It's a bit weird to send 'alternatives' - you should by now have a good
> sense of which ought to work, if not perhaps more research is required on
> your part?

I think both solutions can work, and the preliminary discussion is on
the mail list for [1]
(as this issue is related to security before it was fixed, the
discussion is on security@kernel.org).
The choice depends only on taste.

Link: https://lore.kernel.org/all/20240919080905.4506-2-paul@paul-moore.com/ [1]


  reply	other threads:[~2024-09-25  9:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-25  6:30 Shu Han
2024-09-25  8:48 ` Lorenzo Stoakes
2024-09-25  9:09   ` Shu Han [this message]
2024-09-25  9:50     ` Lorenzo Stoakes
2024-09-25 11:36       ` Shu Han

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHQche8ijvNfKHBLV8BWWq85rjKQbjO+0w2s6kj4V3OpBANcuA@mail.gmail.com \
    --to=ebpqwerty472123@gmail.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=jmorris@namei.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=paul@paul-moore.com \
    --cc=serge@hallyn.com \
    --cc=vbabka@suse.cz \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox