From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B125CF855A for ; Thu, 3 Oct 2024 07:36:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D27A06B014E; Thu, 3 Oct 2024 03:36:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CD7946B040B; Thu, 3 Oct 2024 03:36:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B519C6B040C; Thu, 3 Oct 2024 03:36:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8AB596B014E for ; Thu, 3 Oct 2024 03:36:07 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C86B2140AE4 for ; Thu, 3 Oct 2024 07:36:06 +0000 (UTC) X-FDA: 82631482332.15.A1D6A5C Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by imf01.hostedemail.com (Postfix) with ESMTP id 02B3F40005 for ; Thu, 3 Oct 2024 07:36:04 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lFzLv3Bz; spf=pass (imf01.hostedemail.com: domain of ebpqwerty472123@gmail.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=ebpqwerty472123@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727940837; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9oR8h0jcD+ASzHqwg5wRJecDB5ThsYQmaCFqLieUUys=; b=Vg86//uVw6h3yBnZ9DVlEupnot3uT8X3iEe1/HxsbnzmcDj30Oo69s1ghXEgqqDjsxA8Pk r/hGRASb0eNqgY6Rh6ubaxO5zZrrBwiiei/ZAuzM7Y/te/6KMCNGj25YoonCke/a8QmI2i z3sLzyY3IuSHqkHrZxgCGtt5z3WIodc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727940837; a=rsa-sha256; cv=none; b=b4NLtmtO3Jicn4DLdMrhp2sXu7VDsVVz0WacTeXOoD0j8EtZiUPWfLGZUKiiqQEJm91UBj tzTUkaVnUdfTQgz1bFnkUs7rrfJziqoox3rwAx202QJtNdCPqS3sdo2Wi+ZLV8Gf/tJfXK v6uGDVnAy/Mt/U6GDCqm6aNdtkqwSDM= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lFzLv3Bz; spf=pass (imf01.hostedemail.com: domain of ebpqwerty472123@gmail.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=ebpqwerty472123@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-5389e24a4d1so621500e87.3 for ; Thu, 03 Oct 2024 00:36:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727940963; x=1728545763; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=9oR8h0jcD+ASzHqwg5wRJecDB5ThsYQmaCFqLieUUys=; b=lFzLv3Bzj+DdMbbUdK06rnlDZ8HA2qos7vjRh3rX7fOqErUbTfA3S0x3IeZ8GOPsYS PTpsVKJrV17jhuViNh4alNvumLUYS0HgJ5f1J0gtWVTESnvsEy5ojQuXSal17uYlqluP hlPgywtFsNsyMA0NdvW4gG4R+5byNor4JbKXKKQWUlQWjSq7SEjTbXF/3sh24vILgz8g XhZsmYqtvtIeTww8v4Q3YiuI80oacz7BtsAbe6V3728cF84IG9eHrKlTsHMRGl9RTZZq xFHUKJTEVMdlim0neRStW//3Aaaux9x4jLWgBAXtbQ6eDDglMbD1Q8XkxeUg3GrSKYxb 7AeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727940963; x=1728545763; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9oR8h0jcD+ASzHqwg5wRJecDB5ThsYQmaCFqLieUUys=; b=Od8t7MYowohM1em0d4kKeuVHK8BAOrNhx2HHwzq5tce/atSStLRP6BkA2xtb+c9Bn6 uOA/5ZCIBrWT53tYxejLMrGrPeqKfwdhKVOLtWhNo5WVX6TdJEJRU87uR4HYt1MAKJU1 RjD6GPoFMtNHEqyhwzC6wj4f69iyaJ09LLIKqpTrtw1zTCbQaij41RVjvvbCrM6p2x85 OQc47ocld/5m9D7SdQbKZnGDqJSQc7tAh+H+HcmrJkEYVqH8gHfHchMQmllLpQCXvfdt 1WEdN4tIBj9SOHWuijcKQYsnb0jLX8sPWuWooSxQFLz/7jNuxYrLhL+7anXS2pl6Dqau 5QXQ== X-Forwarded-Encrypted: i=1; AJvYcCV8UOGa5EK5R42qKoXxYSqjrakiJs7Ef5EMAYVbeWuGxdVRVn5+H5GxLsVyPIp4zaAVJx1daVXRmg==@kvack.org X-Gm-Message-State: AOJu0YyeKQx0Ka3DrQRqzNdjZLtQ/Wk1tmD6LUZWDsDC775pel2T5TW9 a8dq3XZ97/WrjGkj53p8qb/mJREd8u+O+3gkYUOP0whaVwIUpAkYNxBv12gQbH7OzdrAFuRgw6Q q+FQfayw/Pq8fEP8FxCXgfQdlW+4= X-Google-Smtp-Source: AGHT+IFv9AtG9mNjYdrEiVauqIlg0dzgZJCUwjpzJV+xaWeaunneTND2RuGD2CvAsi1FIHppDH85AjSwHwx2Tj0ajdk= X-Received: by 2002:ac2:4c48:0:b0:52c:cc2e:1c45 with SMTP id 2adb3069b0e04-539a0663300mr3041629e87.15.1727940962711; Thu, 03 Oct 2024 00:36:02 -0700 (PDT) MIME-Version: 1.0 References: <66f7b10e.050a0220.46d20.0036.GAE@google.com> In-Reply-To: From: Shu Han Date: Thu, 3 Oct 2024 15:35:51 +0800 Message-ID: Subject: Re: [syzbot] [integrity?] [lsm?] possible deadlock in process_measurement (4) To: Paul Moore Cc: syzbot , akpm@linux-foundation.org, dmitry.kasatkin@gmail.com, eric.snowberg@oracle.com, hughd@google.com, jmorris@namei.org, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, roberto.sassu@huawei.com, serge@hallyn.com, stephen.smalley.work@gmail.com, syzkaller-bugs@googlegroups.com, zohar@linux.ibm.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 02B3F40005 X-Stat-Signature: 6qjbgt43kpuq6qmobd39ftmt1ei73m5h X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1727940964-320127 X-HE-Meta: U2FsdGVkX1+0iSVRGRpbiHMxdMVrxxKgyoLsUeM4RY5PoML/uicxu6vvcMyvrq1lc6C1FLLl85XazOXsukDTjoghUEn8TqXVLSchrLuKjcpOQZM+AyCljnq6sqUcHITspZOSPeIAn7JkcaZRKi13A7p6xjqgFjp7r0VdlR7CmSpGKTFm0jZCiJfWyAX6Nwv67N3HhGnWX3tYpkX9ROdokfdDa6txHFtq1BPzW5i11OPezUrsi0mwhYqCniPq5JZ/wiztaBVSdoJzTlUJfIW7HryYW8kkDDAZ/EPVRERdu5Sm/Ex/GUmwPi7Ug4HNUl5S3uXaan7X4bDjjKLNlelLIASjw7DDk3GuWEgiw/mnZEA6x+fie773oA2IA//eqfHl/hUvZoB9Clk/kaK6XivFRXDaNKN0Xao2YueZ629FjDDsmPHVcy9zV0i/CTf/4Yy4axiNaoc1zg6PgMHKXoQplIb+ftNZudkO1L4RU7u5u/8xMmsV/KBaZPEcWUZ1joO8T2dCZ1X/eWfe4IkhK+8aefRLYbxBdSkEL29lCkux0H/WpnZC+61lLaKXY1IrFq8u5rPKKbZRlZmpGq+WSjghoSZnTgWo7GNJ+nL2djSwt2WRpOdWMc9zXmKgAuVo5XycyNxhu5vNr9NN5v+5t7yEQWZUSfWIB4nodGtUA0F3H0KsaO38vzEMz9PKlMe08okBbsjkL2gsKN7PlTLqKoGEuXNhUusWP6hBBruJ24iNAS4BSdWN9p22yBe9TWAPUQO0aKTm+ULr7Aq2B2RKshlKSHgibh5RjviD7+2uxDihL7KLTq5Sood0MaPZnfZGtJiiwSmtZQVPvXkWqOR4/gCz6ZG8hFUOtogu7/w4YXJPJMr/tvvUDNhIWyRpTuadRCwc0Iz5gqmVo+VOvlgZjwp6lLAaQdngC70wXcMCP9WMp2lT+K/VkZmuIa4zwWB+A8FzwITVrj6uAMojpxkZ0Oo 3ZZREA8c qTa2eiga7xFQiZDWOkOfF2wtOFuH2cP0FVVkdN2XVixMms3dLkMI1Qcr48yy/nIg0AB3L5yI08I6mn3mJ1oGIpdo4IA6HPmHJLEE0MND6cldAXDzaWpb29+XlijlyQlQt+gmFcSqkA0NC+7AUqzm32HHrwA+H5Sipo7cAYg4sfAR7JaIxtraAUAf1aY9IL9Ptplck+iCD45K7ZDmCzDcELcuFJShr0eBhPg5mOv/sLJraWbArO99Aaqhh0gxW7mP28LPUqa3sHy+a1t4crnEF1ct2tQC0tMFlM+f/ZxWTSpIkYYE8i+Q++c5DTU7fO7cPsvcNrK11TsdkAU0adE88oxZjePpheJnvTLyzO5egR2XWL1aPKWlmqFHj9UneX7bUdboEwodWC7xO9y7Zjv5+kr4VpwffDMzeBvufGAy2idd2npnXGde5jEThS5fj5P5UB0H9EGrxGFgv8LnCMNvmfc2nQzF5aA5jgZU5Eqlc6i9dPRr5JJBdp+k6+L1A0nV0Q0T8WPR5qG2b7zacCKXEGuVrCkCgM5WG87jBg7k49OJXmHsD6TSkcMmexw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.022715, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > My apologies for the delay on this, I was traveling for a bit and > missed this issue while away. > > Looking quickly at the report, I don't believe this is a false positive. This is the mistake I made when I first watched the report. It should be a deadlock. > Looking at the IMA code, specifically the process_measurement() > function which is called from the security_mmap_file() LSM hook, I'm > not sure why there is the inode_lock() protected region. Mimi? > Roberto? My best guess is that locking the inode may have been > necessary before we moved the IMA inode state into the inode's LSM > security blob, but I'm not certain. > > Mimi and Roberto, can we safely remove the inode locking in > process_measurement()? It would be better if IMA could avoid acqurie inode_lock(). If not, then we may need to consider solutions I mentioned in my previous reply.